- 22 Nov, 2009 1 commit
-
-
chase@chromium.org authored
Save the CL locally prior to attempting to submit to Rietveld. The CL is saved locally with a dirty-bit before the upload is attempted. If successful, the CL is saved locally again with a clean-bit. On loading a dirty CL for editing, we only load the CL description from Rietveld if the local CL is clean (there are no pending changes to upload). Clean CLs continue to retrieve updated descriptions directly from Rietveld. BUG=none TEST=gcl change <name> saves CL description local prior to uploading. gcl change <name> after a failed Rietveld upload uses local CL description instead of using the associated issue's description from Rietveld. Changes in this state are reset to the 'clean' state after the Rietveld update completes. Review URL: http://codereview.chromium.org/428001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32791 0039d316-1c4b-4281-b951-d872f2087c98
-
- 21 Nov, 2009 2 commits
-
-
maruel@chromium.org authored
TBR=nsylvain Review URL: http://codereview.chromium.org/430004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32748 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TEST=not much BUG=none Review URL: http://codereview.chromium.org/399070 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32720 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Nov, 2009 4 commits
-
-
laforge@chromium.org authored
Review URL: http://codereview.chromium.org/414060 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32713 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Review URL: http://codereview.chromium.org/423002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32637 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TEST=upload always work whatever the case BUG=none Review URL: http://codereview.chromium.org/418010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32617 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TEST=not tested at all. Review URL: http://codereview.chromium.org/414035 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32611 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 Nov, 2009 2 commits
-
-
msb@chromium.org authored
Review URL: http://codereview.chromium.org/402105 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32568 0039d316-1c4b-4281-b951-d872f2087c98
-
msb@chromium.org authored
Review URL: http://codereview.chromium.org/402084 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32521 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Nov, 2009 2 commits
-
-
msb@chromium.org authored
ssh://example.com/git/test.git was not parsed correctly. Review URL: http://codereview.chromium.org/401022 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32377 0039d316-1c4b-4281-b951-d872f2087c98
-
msb@chromium.org authored
Review URL: http://codereview.chromium.org/397029 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32259 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Nov, 2009 3 commits
-
-
msb@chromium.org authored
Review URL: http://codereview.chromium.org/399040 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32200 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Noteworthy change is scm.SVN.GetFileProperty calls Capture instead of Run. TEST=unit tests BUG=none Review URL: http://codereview.chromium.org/399009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32181 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@google.com authored
add this to PRESUBMIT.py in the chromium tree later). - Update cpplint.py to the latest version from the style guide. Review URL: http://codereview.chromium.org/395022 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32180 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Nov, 2009 5 commits
-
-
maruel@chromium.org authored
Revert "Group SCM-specific functions in classes to simplify generalization of the interface." Revert "Fix 2 recently introduced errors." Revert "Fix a variable aliasing error." Revert "Fix typo." TBR=dpranke TEST=none BUG=none Review URL: http://codereview.chromium.org/391075 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32065 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TEST=presubmit check BUG=none Review URL: http://codereview.chromium.org/400002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32062 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TBR=mad TEST=none BUG=none Review URL: http://codereview.chromium.org/395018 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32059 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/391072 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32058 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TEST=none BUG=none Move scm functions into a class to make it simpler to manage. Review URL: http://codereview.chromium.org/391052 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@32057 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Nov, 2009 3 commits
-
-
chase@chromium.org authored
BUG=25824 TEST=gcl change in a read-only checkout is now a warning instead of a hard error Review URL: http://codereview.chromium.org/384128 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31942 0039d316-1c4b-4281-b951-d872f2087c98
-
msb@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31916 0039d316-1c4b-4281-b951-d872f2087c98
-
msb@chromium.org authored
ssh://test@example.com wasn't being parsed correctly for revinfo. Fixed by factoring out all code which splits url into a base_url and revision. Review URL: http://codereview.chromium.org/391048 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31910 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 Nov, 2009 5 commits
-
-
maruel@chromium.org authored
Reapplies r31809 is typo fixed. TEST=unit tests fixed and reclassified BUG=none Review URL: http://codereview.chromium.org/393001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31812 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
This reverts commit 7489404c56dcc725c7c13214f410b2d375a6630a. git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31810 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TEST=unit tests fixed and reclassified BUG=none Review URL: http://codereview.chromium.org/389020 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31809 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Removed lines in the process. TEST=unit tests BUG=none Review URL: http://codereview.chromium.org/387033 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31759 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TEST=unit tests BUG=none Review URL: http://codereview.chromium.org/392006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31754 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Nov, 2009 6 commits
-
-
maruel@chromium.org authored
TEST=unit tests BUG=none Review URL: http://codereview.chromium.org/387007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31593 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Review URL: http://codereview.chromium.org/387005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31592 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TEST=unit tests BUG=none Review URL: http://codereview.chromium.org/385007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31590 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@google.com authored
Fix GetCachedFile() to skip local mods when use_root is True. The files that exist in the root of the tree don't even seem to exist in the normal source checkouts, and we were looking at a different file as a result. BUG=none R=maruel@chromium.org TEST=locally modify a PRESUBMIT.py file and look for duplicate results. If you get duplicates, this didn't fix it Review URL: http://codereview.chromium.org/379021 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31586 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
BUG=27241 TEST=running 'gcl change --force' in a read-only checkout creates random changename. M gcl.py Review URL: http://codereview.chromium.org/387001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31552 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
BUG=27243 TEST=Create change which contains no files and confirm 'gcl diff createdchange' doesn't output anything. M gcl.py Review URL: http://codereview.chromium.org/388001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31551 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Nov, 2009 4 commits
-
-
chase@chromium.org authored
BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31454 0039d316-1c4b-4281-b951-d872f2087c98
-
chase@chromium.org authored
BUG=25824 TEST=running 'gcl change foo' in a read-only checkout shows an error, --force creates a CL anyway, and gcl change in read-write checkouts continues to work. Review URL: http://codereview.chromium.org/378027 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31452 0039d316-1c4b-4281-b951-d872f2087c98
-
msb@chromium.org authored
ssh://test@example.org/test.git was not parsed correctly because we would split at the '@' assuming what followed was a revision. Review URL: http://codereview.chromium.org/372045 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31444 0039d316-1c4b-4281-b951-d872f2087c98
-
finnur@chromium.org authored
for the try servers and fallback on EMAIL_ADDRESS, since WebKit uses that. The reason is that some people have WebKit emails that predate Chromium emails so some separation is warranted so that people don't have to fix up emails all the time. BUG=None TEST=None Original review: http://codereview.chromium.org/372048 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31437 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 Nov, 2009 1 commit
-
-
msb@chromium.org authored
Requirement for build system. Review URL: http://codereview.chromium.org/372036 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31362 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Nov, 2009 2 commits
-
-
msb@chromium.org authored
* Add revinfo as part of SCMWrapper interface. * Implement revinfo for git and svn. * Add unit tests. Review URL: http://codereview.chromium.org/362008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31280 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@google.com authored
If you're not running gclient sync with --verbose and you get a conflict on a file, the conflict message prints *before* the message that you're running update in the appropriate directory. This is happening because we intercept stdout but not stderr, and the conflict prompt goes to stderr. redirecting stderr in the popen() to the pipe fixes this. R=maruel@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/373003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@31276 0039d316-1c4b-4281-b951-d872f2087c98
-