Skip to content

C
Chromium_Depot_tools
Switch branch/tag
  1. 17 Feb, 2015 2 commits
    • primiano@chromium.org's avatar
      [download_from_google_storage] Don't list ALL objects to check for ACLs · e48b81e6
      primiano@chromium.org authored 
      Currently check_bucket_permissions() in download_from_google_storage.py
performs a gsutil ls gs://bucket to determine whether the user has access
to the bucket or not.
This can be an EXTREMELY expensive operation (~minutes) if the bucket in
question has a lot of objects in the root (real case: chrome-telemetry).
It is worth noting that check_bucket_permissions() is not called just for
uploads but also for downloads, hence this is slowing down all invocations
of gclient sync on users and bots machine.
Removing the check_bucket_permissions() and let gsutil fail with an
Unauthorized error message if ACLs are not met.

BUG=458059

Review URL: https://codereview.chromium.org/923473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294083 0039d316-1c4b-4281-b951-d872f2087c98
      e48b81e6
    • primiano@chromium.org's avatar
      Reland "Make gclient ready for the Blink (DEPS to main project)" · 1c127389
      primiano@chromium.org authored 
      Reland crrev.com/743083002, which was reverted in crrev.com/796053002
due to some test flakiness, probably related with an old version of Git on
the bots. Relanding now that the infra has been updated to Trusty (plus
adding some de-flake precautions).

Original CL Description:
Make gclient ready for the Blink (DEPS to main project) transition

This CL makes gclient understand correctly whether a git project is
being moved from DEPS to an upper project and vice-versa.
The driving use case for this is the upcoming Blink merge, where
third_party/Webkit will be removed from DEPS (and .gitignore) and will
become part of the main project.

At present state, gclient leaves the .git folder around when a project
is removed from DEPS, and that causes many problems.

Furthermore this CL solves the performance problem of bisecting across
the merge point. The subproject's (Blink) .git/ folder is moved to a
backup location (in the main checkout root) and is restored when moving
backwards, avoiding a re-fetch when bisecting across the merge point.

BUG=431469

Review URL: https://codereview.chromium.org/910913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294082 0039d316-1c4b-4281-b951-d872f2087c98
      1c127389
  3. 16 Feb, 2015 1 commit
  5. 11 Feb, 2015 1 commit
  7. 05 Feb, 2015 1 commit
  9. 03 Feb, 2015 2 commits
  11. 02 Feb, 2015 3 commits
  13. 30 Jan, 2015 1 commit
  15. 26 Jan, 2015 2 commits
  17. 24 Jan, 2015 1 commit
  19. 23 Jan, 2015 1 commit
  21. 22 Jan, 2015 1 commit
  23. 16 Jan, 2015 1 commit
  25. 15 Jan, 2015 1 commit
  27. 14 Jan, 2015 1 commit
  29. 13 Jan, 2015 2 commits
  31. 10 Jan, 2015 1 commit
  33. 08 Jan, 2015 1 commit
  35. 07 Jan, 2015 2 commits
  37. 06 Jan, 2015 1 commit
  39. 29 Dec, 2014 1 commit
  41. 25 Dec, 2014 2 commits
  43. 23 Dec, 2014 1 commit
  45. 20 Dec, 2014 3 commits
  47. 19 Dec, 2014 1 commit
    • raphael.kubo.da.costa@intel.com's avatar
      presubmit_unittest: Fix pylint errors. · e589f98b
      raphael.kubo.da.costa@intel.com authored 
      The recent pylint 1.3.1 and 1.4.0 upgrades have caused some new errors
to be reported for presubmit_unittest:

* presubmit_support.InputApi.AffectedFiles() expectes a parameter called
  |include_deletes|, not |include_deleted|.

* The mock AffectedFiles() implementation in
  CannedChecksUnittest.testCannedCheckChangeHasNoTabs() had its
  signature updated to match the one in presubmit_support.InputApi,
  otherwise pylint would (erroneously) consider that this mock
  implementation was used in all other AffectedFiles() invocations in
  CannedChecksUnittest and complain that some parameters were missing.
  It makes more sense to do this than disable the check and miss real
  problems in the future.

R=maruel@chromium.org, iannucci@chromium.org, pgervais@chromium.org
BUG=443232

Review URL: https://codereview.chromium.org/802403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293468 0039d316-1c4b-4281-b951-d872f2087c98
      e589f98b
  49. 18 Dec, 2014 3 commits
  51. 17 Dec, 2014 2 commits
  53. 16 Dec, 2014 1 commit