- 08 Apr, 2020 1 commit
-
-
Peter Wen authored
Increase the number of long times by extension to report from 5 to 10 since java build steps produce a number of different extension types. It is difficult to distinguish between android vs non-android builds, so increase this default for all platforms. Prioritize .jar outputs for java targets and allow up to two levels of extensions to be recognized. e.g. file.interface.jar would have .interface.jar as its full extension. file.javac.jar would have .javac.jar as its full extension. Some of these build steps require .jar outputs, which is why these targets use a secondary extension to differentiate. Example output: https://crrev.com/c/2142395 Bug: chromium:1067273 Change-Id: Id5780980f60841c3384d91bf96121c6dec3e8bed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2142163Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org>
-
- 07 Apr, 2020 3 commits
-
-
Edward Lesmes authored
Change-Id: Ib51acc5671c7b60219f64bcb73a70f85a51779a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2140817Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/42f6841b9e7d40b310e52425c71ca77dbe2ac1f2 (olivernewman@google.com) [analyze] Consider recipe resource files More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ieae5583e34dc42c2dde78b2561cfbe62365ec046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2140371Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Jose Lopes authored
At the moment, specifying --dependencies to upload all dependent CLs will always prompt for confirmation if --force was specified. This means that there is no way to run this command in a batch way or from another script, and it's also in contradiction to the --force flag which is meant to answer 'yes' to all prompts. This uses a pattern that is used several times in the script, which is to check 'if not force: prompt()'. Change-Id: I7d85b02b68d958a5b2d3295a04c4ced023d36ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2139700 Auto-Submit: Jose Lopes <jabolopes@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
-
- 06 Apr, 2020 2 commits
-
-
Vadim Shtayura authored
The most notable change is that invalid escape sequences in strings cause errors now. This is due to an underlying starlark-go change. R=tandrii@chromium.org, iannucci@chromium.org Change-Id: I2fc8aa297000e5bcfd9c5f0cca7af205a8e77e80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2137983Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
Edward Lesmes authored
This is a reland of 87661afb Set shell=True on Windows, so that vpython.bat can be executed. Original change's description: > git-cl: Execute clang-format-diff.py using vpython. > > When running git-cl using vpython3, sys.executable is python3. > Execute clang-format-diff.py using vpython instead, since it has > not been migrated already. > > Bug: 1066187 > Change-Id: I31556acb50ff4256706a313c1393eddad9f903f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2130926 > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Bug: 1066187 Change-Id: Ia482f13d0f30d625f2f6db3cb4202b7f3f95707b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2135330Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 02 Apr, 2020 4 commits
-
-
Bruce Dawson authored
The title of command prompt windows indicates what command is running. However it is easy to confuse Windows so that it doesn't clear the status when a program termintes. Apparently a tail from one batch file to another is sufficient to do this. This change uses "call" to run python to avoid this minor glitch, making is so that I can tell when gclient has completed merely by glancing at the command prompt status bar. Change-Id: Ibd310362b8dd78589abc443be1841f0937c791fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2133303Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
Mike Frysinger authored
Bug: None Test: `repo sync` still works Change-Id: I472e5f8753f96f1ad45c9782e4ac30b71a620ab5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2120252Reviewed-by: Michael Mortensen <mmortensen@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org>
-
Peter Kasting authored
This reverts commit 87661afb. Reason for revert: Still get: OSError: Execution failed with error: [Error 2] The system cannot find the file specified. Original change's description: > Reland "git-cl: Execute clang-format-diff.py using vpython." > > This is a reland of beec6607 > > Append the clang-format directory to the front of PATH instead of > overwriting it. > This allows vpython to be invoked. > > Original change's description: > > git-cl: Execute clang-format-diff.py using vpython. > > > > When running git-cl using vpython3, sys.executable is python3. > > Execute clang-format-diff.py using vpython instead, since it has > > not been migrated already. > > > > Bug: 1066187 > > Change-Id: I31556acb50ff4256706a313c1393eddad9f903f3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2130926 > > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > > Bug: 1066187 > Change-Id: I8b65549ef47587cef8492f8f76a037eb85a981fc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2132972 > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> TBR=ehmaldonado@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com Change-Id: I22566c829a83991e3749a039d0bd0ba7d8a56812 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1066187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2133588Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
Josip Sokcevic authored
This reverts commit 4741a127. Reason for revert: % is escaped improperly Bug: 1067065 Original change's description: > Tweak git bat template > > This fixes some issues with escaping, namely carets. For example, > without this patch, when HEAD^^1 is passed to batch script, it will > forward HEAD1 to git. With this patch, it will be forwarded as HEAD^^1 > to git. There is still issue with HEAD^1 which seems not possible to fix > with batch script as batch receives HEAD1. > > R=ehmaldonado@chromium.org > > Change-Id: Ibb48ef06b4f17df374ee983eaa19ca43a706fa22 > Bug: 1065307 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2130635 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Auto-Submit: Josip Sokcevic <sokcevic@google.com> TBR=ehmaldonado@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com Change-Id: Ib46517010fd49621b758fc9594cbd90f7ff4e89a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1065307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2133309Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
- 01 Apr, 2020 7 commits
-
-
Edward Lesmes authored
This is a reland of beec6607 Append the clang-format directory to the front of PATH instead of overwriting it. This allows vpython to be invoked. Original change's description: > git-cl: Execute clang-format-diff.py using vpython. > > When running git-cl using vpython3, sys.executable is python3. > Execute clang-format-diff.py using vpython instead, since it has > not been migrated already. > > Bug: 1066187 > Change-Id: I31556acb50ff4256706a313c1393eddad9f903f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2130926 > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Bug: 1066187 Change-Id: I8b65549ef47587cef8492f8f76a037eb85a981fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2132972Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lesmes authored
Decode the result of reading http.cookiefile from git config Bug: 1066992 Change-Id: I1d4f2c8e54f717ef61ab4e630f3f66206c56047e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2132774Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Josip Sokcevic authored
This fixes some issues with escaping, namely carets. For example, without this patch, when HEAD^^1 is passed to batch script, it will forward HEAD1 to git. With this patch, it will be forwarded as HEAD^^1 to git. There is still issue with HEAD^1 which seems not possible to fix with batch script as batch receives HEAD1. R=ehmaldonado@chromium.org Change-Id: Ibb48ef06b4f17df374ee983eaa19ca43a706fa22 Bug: 1065307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2130635 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Josip Sokcevic <sokcevic@google.com>
-
Allen Bauer authored
Bug: 1066954 Change-Id: Icdf68547f94376616a21997c37cf51cd38659c5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2132954Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org>
-
Josip Sokcevic authored
R=ehmaldonado@chromium.org Bug: 1065582 Change-Id: I434db17d4113cdf623ad733b65aa66b770766fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2131468Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
Edward Lesmes authored
Change-Id: I43d1b9cecee3066c206b2cfdb2fa9d37bc5001e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2132232Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org>
-
Robert Iannucci authored
This is a followup to https://chromium-review.googlesource.com/2124657 TBR=ahaas@chromium.org, ehmaldonado@chromium.org Change-Id: I0cf8a73a645865700dc8ce5c2d17cc1915706ca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2131384Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 31 Mar, 2020 7 commits
-
-
Edward Lesmes authored
This reverts commit beec6607. Reason for revert: OSError: Execution failed with error: [Errno 2] No such file or directory: 'vpython'. Original change's description: > git-cl: Execute clang-format-diff.py using vpython. > > When running git-cl using vpython3, sys.executable is python3. > Execute clang-format-diff.py using vpython instead, since it has > not been migrated already. > > Bug: 1066187 > Change-Id: I31556acb50ff4256706a313c1393eddad9f903f3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2130926 > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> TBR=ehmaldonado@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com Change-Id: I555251d8dbb1582d7f03702b7910d70a11b75855 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1066187 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2130785Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lesmes authored
On Windows, git can be either an executable or batch script, each of which requires carets (^) to be escaped in different ways. This makes it hard to use `git rev-parse --verify REV^{commit}`, so we truncate full hash revisions to achieve the same effect instead. Change-Id: I01578620706a1bab75a2decc55d9b4f1ac3afe28 Bug: 1065307 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2127968Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lesmes authored
When running git-cl using vpython3, sys.executable is python3. Execute clang-format-diff.py using vpython instead, since it has not been migrated already. Bug: 1066187 Change-Id: I31556acb50ff4256706a313c1393eddad9f903f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2130926Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lesmes authored
The old behavior was to set parent from the gerritsquashhash of the parent branch, but now it's trying to set it from the gerritsquashhash of the current branch (which doesn't exist yet). As a result it's always saying `Upload upstream branch ... first` Change-Id: I035ed128f46a49d09d563ea589e9ca9eb7b87db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2128679Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Andreas Haas authored
For development in V8, and I guess also in Chrome, it is important that depot_tools are at the beginning of $PATH. This was explicitly mentioned in the original tutorial. However, it seems like a cleanup CL changed this recently, see https://crrev.com/c/1593820. This CL changes the order in $PATH back to the original order. CC=marja@chromium.org, dmcardle@chromium.org R=iannucci@chromium.org Change-Id: Idaed3ada05cddd666734c03a25503fe5dc481e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2124657 Auto-Submit: Andreas Haas <ahaas@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Print it unconditionally when creating the HTTP connection. The previous check was not capturing all possible failure modes. Change-Id: Ie519f3c3afdbb2e452fbea2385cd75c3d5d1af84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2129148Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lesmes authored
Change-Id: I6ca167e34829cd7694372923917446c3843c879f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2129146Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 30 Mar, 2020 6 commits
-
-
Dale Curtis authored
1) The current behavior feels contrary to the documentation; which says "If true, will cause rebase-update to skip all processing on the branch." 2) The new behavior allows a workflow where 'master' is empty and marked dormant, but kept up to date as the parent for all other branches. Change-Id: Ic7440706a69753f796846dd84ecbf8bcf172ba4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2128675 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lesmes authored
Check `if [[ $(uname -s) = MINGW* ]]` instead of using grepping and an additional variable. Change-Id: I6f2cfbb6743357125e6672b77667ee5e36d3d81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2127674 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
-
Edward Lesmes authored
This is a reland of e3a49aa4 GetRelativeRoot was fixed to use '.' instead of None Original change's description: > git-cl: Remove unused and duplicate functions. > > Remove unused functions, and use scm.GIT where possible to reduce > duplication. > > Change-Id: I24f05e7b3ae04743e97b6665ee668f44d6acc294 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2116938 > Reviewed-by: Anthony Polito <apolito@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Change-Id: I54bd1d34d3501a38bf8af2f9e70059d58fa538a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2125293Reviewed-by: Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lesmes authored
Follow up to crrev.com/c/2125626. This allows depot_tools commands to run successfully when depot_tools is installed in a path containing spaces. Change-Id: I8f99dbdcb3b1acf27d51ce26b6153f643b8d4dcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2127675 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
-
John Stiles authored
This allows git-cl to run successfully when the depot tools are installed to a path with a space in it. Change-Id: I79fa44d13f89fb0ee1baaa90961b4c4284913c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2125626 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://crrev.com/c7bd3cd4eb151ae7a00352e1180ab7ec6933a71e (olivernewman@google.com) [autoroll] Don't gen docs if no_docs is set More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I006885495c8be7ce86d4dd876db656ef96c8d7fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2127239Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 27 Mar, 2020 5 commits
-
-
Josip Sokcevic authored
R=ehmaldonado@chromium.org Change-Id: I5bf1aa21a5ae9b90dbab4cc0439ca19e73de337f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2125221Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
Bruce Dawson authored
Normal weight colored text can be hard to read, especially over Chrome Remote Desktop (video compression treats chroma harshly). Git colors can be made more readable by editing .gitconfig, but git cl colors are hard coded. This hard codes them to all be bold, for greater readability and effective brightness, and changes the still-too-dim-over-CRD blue to red. Magic bold code found here: https://stackoverflow.com/questions/8924173/how-do-i-print-bold-text-in-python Change-Id: If3a8684d1886291ca692d6fdbe7e30095a5acbc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2116941Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
Josip Sokcevic authored
This patch enables more unit tests on Windows. R=ehmaldonado@chromium.org Change-Id: I8667777fc6eef11568aa2aead9850f7e37757e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2123808Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
Josip Sokcevic authored
R=ehmaldonado@chromium.org Change-Id: Ie801df1cef3d36fbfe6ba9fbd922bff4cf03a006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2123867Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
John Budorick authored
logging.warn is deprecated. Change-Id: I047f356b8eeced631edc51e3b846f0995f4ce95e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2124526Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
- 26 Mar, 2020 4 commits
-
-
Edward Lesmes authored
On an initial upload, git-cl upload -t <title> should append <title> before the change description. This broke because options.squash is set to a default value very late into code execution, so its value was not available when computing the initial description. options.squash is now set when parsing the options, early into code execution. Bug: 1064905 Change-Id: I04a18c572dd5b04a3013d39f71bc43d026ea85d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2122324Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Josip Sokcevic authored
This fixes python2 unit tests (py3 works fine) Change-Id: I9b968ba5d5f534166ce6c4fe59c8dfa4beb73021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2121563Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
Edward Lesmes authored
This reverts commit e2ac022f. git-cache issues were solved by https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2120966 Original change's description: > Reland "depot_tools: Run using Python 3 by default." > > This is a reland of 01ed3589 > > * python_runner.sh, gclient, roll-dep and fetch will call vpython > (instead of vpython3) when running on Windows under git-bash. > * vpython3 now detects when running on Windows under git-bash and > executes vpython3.bat instead. > * vpython3.bat calls python3.exe directly instead of calling python3.bat. > > Original change's description: > > depot_tools: Run using Python 3 by default. > > > > Run gclient, roll-dep, fetch and custom git commands (i.e. git-cl, git-rebase-update, git-new-branch, etc.) > > using vpython3 by default. > > > > Change-Id: I4eecddafa6ca4c5f82ec097615c79d2a741613e7 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2113550 > > Reviewed-by: Anthony Polito <apolito@google.com> > > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > > Change-Id: I9829141d7ea26a67e655264430151f493e73a930 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2118418 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Anthony Polito <apolito@google.com> Change-Id: Iff02533f0a11062f335a010c074043c720d5b2ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2121304Reviewed-by: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Josip Sokcevic authored
This fixes default value for Windows platform. Unit tests still don't work for Windows as CTRL+C handling is not working properly. Change-Id: I11fd33279313bfd7a2070e90164da6cf9f63696e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2121555 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
-
- 25 Mar, 2020 1 commit
-
-
Alex Drexler authored
The storage.* links do not work unless an individual object is specified. This isn't the case for recursive upload/copy operations. When uploading multiple objects recursively, we should use the console link instead. Bug: None Test: Updated recipe expectations. Recipe-Nontrivial-Roll: build Change-Id: I511f04f367f6c20c538b3c2093a40807323d7b75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2118421Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Alex Drexler <adrexler@google.com>
-