Commits · e08f491731a674188daf2286232ba6ffba88c5eb · Linshizhi / Chromium_Depot_tools

17 Feb, 2010 1 commit

depot_tools: Make git-cl wrapper not fail when repo is missing. · e08f4917

derat@chromium.org authored Feb 17, 2010

I broke this in my last change.

TBR=msb
Review URL: http://codereview.chromium.org/627004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@39277 0039d316-1c4b-4281-b951-d872f2087c98

e08f4917

16 Feb, 2010 1 commit

Make git-cl wrapper print errors instead of silently deleting repos. · b7ec6aa9

derat@chromium.org authored Feb 16, 2010

It would previously delete and recreate git-cl-repo if it
saw that the remote was different than expected.  This looks
like it was added for the transition from the old SVN repo
to the new git one, but it also has the effect of losing
any local changes that have been made in the repo. :-(

Everyone should be updated by now, so print a helpful error
and exit instead.
Review URL: http://codereview.chromium.org/609002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@39099 0039d316-1c4b-4281-b951-d872f2087c98

b7ec6aa9

12 Feb, 2010 1 commit

Modified default blacklist regexp to match nothing, as empty regexp · 296df660

kbr@google.com authored Feb 12, 2010

was matching everything. See
http://stackoverflow.com/questions/940822/regular-expression-syntax-for-match-nothing/940856 .

Review URL: http://codereview.chromium.org/601064

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@38965 0039d316-1c4b-4281-b951-d872f2087c98

296df660

08 Feb, 2010 3 commits

Fix failure to contain the line entry instead of constant "True" · 8599aa7d

maruel@chromium.org authored Feb 08, 2010

TEST=none
BUG=34793

Review URL: http://codereview.chromium.org/591002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@38382 0039d316-1c4b-4281-b951-d872f2087c98

8599aa7d

Make git-try --webkit work like it used to work. · 81f6eea2

maruel@chromium.org authored Feb 08, 2010

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/570059

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@38337 0039d316-1c4b-4281-b951-d872f2087c98

81f6eea2

Add automatic retry on HTTP 502 for svn and connection drop for git. · 2de10250

maruel@chromium.org authored Feb 08, 2010

TEST=totally untested
BUG=34793

Review URL: http://codereview.chromium.org/574017

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@38336 0039d316-1c4b-4281-b951-d872f2087c98

2de10250

04 Feb, 2010 1 commit

Add progress indicator for sync · 1f7a3d1d

nasser@codeaurora.org authored Feb 04, 2010

Review URL: http://codereview.chromium.org/564051

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@38104 0039d316-1c4b-4281-b951-d872f2087c98

1f7a3d1d

03 Feb, 2010 1 commit

Fix licensing headers and move most third party code to third_party/ · ba551776

maruel@chromium.org authored Feb 03, 2010

Moved tests/pymox to third_party/pymox
Moved upload.py to third_party/upload.py
Fixed tests so they can run standalone
Fixed the executable bit on some scripts

TEST=none
BUG=34376
Review URL: http://codereview.chromium.org/562031

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37987 0039d316-1c4b-4281-b951-d872f2087c98

ba551776

01 Feb, 2010 7 commits

fix git-try broken by CheckCall return type change · d4fd8823

nasser@codeaurora.org authored Feb 01, 2010

Review URL: http://codereview.chromium.org/561001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37750 0039d316-1c4b-4281-b951-d872f2087c98

d4fd8823

Add windows ignores to .gitignore, mostly useful for cygwin users · de707484

maruel@chromium.org authored Feb 01, 2010

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/557082

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37710 0039d316-1c4b-4281-b951-d872f2087c98

de707484

Add codereview.settings to depot_tools. · 99ab6776

maruel@chromium.org authored Feb 01, 2010

I'm doing this while trying to figure out the best way to make git-cl
auto-configure itself on first use, including automatic presubmit scripts hook
setup.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/559002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37709 0039d316-1c4b-4281-b951-d872f2087c98

99ab6776

Fix a FetchUpstreamTuple cwd bug · b65040ab

nasser@codeaurora.org authored Feb 01, 2010

in_directory was not being set to the correct cwd. This caused commands to
always run in the dir from which gclient was executed.

Review URL: http://codereview.chromium.org/554142

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37697 0039d316-1c4b-4281-b951-d872f2087c98

b65040ab

Fix for git-svn rebase bug · e42a1939

nasser@codeaurora.org authored Feb 01, 2010

git-svn rebase will always output 'Current branch <> is up-to-date' when the
branch is up-to-date, even if you pass the --quiet flag(s). This change
specifically squelches that message.

Review URL: http://codereview.chromium.org/555183

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37696 0039d316-1c4b-4281-b951-d872f2087c98

e42a1939

git-try was broken by r37650 · 61148d07

maruel@chromium.org authored Feb 01, 2010

TEST=none
BUG=none
TBR=nasser

Review URL: http://codereview.chromium.org/548223

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37692 0039d316-1c4b-4281-b951-d872f2087c98

61148d07

Always return a tuple from GIT.Capture · cd968c18

nasser@codeaurora.org authored Feb 01, 2010

Review URL: http://codereview.chromium.org/555198

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37685 0039d316-1c4b-4281-b951-d872f2087c98

cd968c18

30 Jan, 2010 4 commits

Change CheckCall behavior when print_error=False · 7be5ef2e

maruel@chromium.org authored Jan 30, 2010

We now return the stderr half of the tuple.
This required a clean up of any usage of CheckCall and GIT.Capture.

Patch contributed by Nasser Grainawi <nasser@codeaurora.org>

Review URL: http://codereview.chromium.org/551215

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37650 0039d316-1c4b-4281-b951-d872f2087c98

7be5ef2e

Using options.email for svn credential is not a good idea. · 519a8dd3

maruel@chromium.org authored Jan 30, 2010

It breaks the use case when a dev outside corp wants to send a job's email to someone else.

Review URL: http://codereview.chromium.org/558062

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37644 0039d316-1c4b-4281-b951-d872f2087c98

519a8dd3

Remove stale revert.py unit test and fix another test I broke in r37487. · 56ca2c24

maruel@chromium.org authored Jan 30, 2010

TEST=unit tests
BUG=none

Review URL: http://codereview.chromium.org/556092

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37618 0039d316-1c4b-4281-b951-d872f2087c98

56ca2c24

Simplify submitting try jobs directly from rietveld. · 5f423140

maruel@chromium.org authored Jan 30, 2010

trychange.py -R <review_url> is sufficient for try jobs when in a checkout directory.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/553166

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37616 0039d316-1c4b-4281-b951-d872f2087c98

5f423140

29 Jan, 2010 1 commit

Delete the revert.py tool. · c19d95a4

maruel@chromium.org authored Jan 29, 2010

It's been replaced by drover a year ago.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/553145

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37487 0039d316-1c4b-4281-b951-d872f2087c98

c19d95a4

28 Jan, 2010 4 commits

Fix the regexp in DEFAULT_WHITE_LIST. · a73d7931

maruel@chromium.org authored Jan 28, 2010

For example, r".*\.c" was triggering for foo.checksum.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/558026

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37461 0039d316-1c4b-4281-b951-d872f2087c98

a73d7931

gclient: Keyboard interrupt should not cause request to send stack · 8912ead3

msb@chromium.org authored Jan 28, 2010

Patch-contributed-by: Alexey Marinichev <amarinichev@chromium.org>

Review URL: http://codereview.chromium.org/553139

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37434 0039d316-1c4b-4281-b951-d872f2087c98

8912ead3

Change the default source lists; · ef77648d

maruel@chromium.org authored Jan 28, 2010

Remove *.txt and *.json, add *.pl and *.pm.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/548172

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37406 0039d316-1c4b-4281-b951-d872f2087c98

ef77648d

Add a trailing \ when printing filenames for presubmit checks. · 593258b9

estade@chromium.org authored Jan 28, 2010

This makes it easier to apply commands to a set of files. For example:

Run the command: svn pset svn:eol-style LF \
  chrome/browser/extensions/extension_accessibility_apitest.cc \
  chrome/browser/extensions/extension_accessibility_api_constants.cc \
  chrome/browser/extensions/extension_accessibility_api.h \
  chrome/browser/extensions/extension_accessibility_api.cc \
  chrome/browser/extensions/extension_accessibility_api_constants.h \
  chrome/browser/gtk/accessible_widget_helper_gtk.h \
  chrome/browser/gtk/accessible_widget_helper_gtk.cc \
  chrome/browser/gtk/accessibility_event_router_gtk.h \
  chrome/browser/gtk/accessibility_event_router_gtk.cc \
  chrome/common/accessibility_events.cc \
  chrome/common/accessibility_events.h

requires just 1 copy-paste.

Review URL: http://codereview.chromium.org/552202

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37350 0039d316-1c4b-4281-b951-d872f2087c98

593258b9

27 Jan, 2010 2 commits

Add presubmit_canned_checks.CheckLicense() · b9e7adaa

maruel@chromium.org authored Jan 27, 2010

It does a regexp search on the file contents to make sure it contains expected license boiler plate.

It is a generalization to implement the equivalent of ubuntu's license check script into the corresponding PRESUBMIT.py files.

TEST=unit tests
BUG=28291

Review URL: http://codereview.chromium.org/558007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37338 0039d316-1c4b-4281-b951-d872f2087c98

b9e7adaa

Fix branching regex to match .*? and not /d+ so that it will match "249s" in · 3529954d

laforge@chromium.org authored Jan 27, 2010

addition to "249"
Review URL: http://codereview.chromium.org/553108

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37203 0039d316-1c4b-4281-b951-d872f2087c98

3529954d

26 Jan, 2010 1 commit

Partial revert of r37053. Put back the gcl default CODEREVIEW_SETTINGS as we... · 172b6e74

thestig@chromium.org authored Jan 26, 2010

Partial revert of r37053. Put back the gcl default CODEREVIEW_SETTINGS as we had it before, except with an updated CC_LIST.

BUG=none
TEST=Using gcl from src/third_party/WebKit sends code reviews to codereview.chromium.org.
Review URL: http://codereview.chromium.org/552144

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37069 0039d316-1c4b-4281-b951-d872f2087c98

172b6e74

25 Jan, 2010 5 commits

gcl.py cleanup · 4aa47816

thestig@chromium.org authored Jan 25, 2010

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/552139

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37053 0039d316-1c4b-4281-b951-d872f2087c98

4aa47816

Fix condition where no author would be retrieved (revert on a branch for · 638044da

laforge@chromium.org authored Jan 25, 2010

something that was on trunk, svn info only knows about it when it's ref by trunk
url).

Also added an author override, useful for webkit merges or double reverts

Review URL: http://codereview.chromium.org/551137

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37024 0039d316-1c4b-4281-b951-d872f2087c98

638044da

Make gclient cleanup a no-op for git · d8a63787

msb@chromium.org authored Jan 25, 2010

Patch-contributed-by: Nasser Grainawi <nasser@codeaurora.org>

Review URL: http://codereview.chromium.org/551023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37021 0039d316-1c4b-4281-b951-d872f2087c98

d8a63787

Use --force to reset a git repo before attempting to rebase during gclient sync/update · eafef3b3

msb@chromium.org authored Jan 25, 2010

Patch Contributed By: Nasser Grainawi <nasser@codeaurora.org>

Review URL: http://codereview.chromium.org/548079

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37020 0039d316-1c4b-4281-b951-d872f2087c98

eafef3b3

Always list the args in the same order · 3904caa9

msb@chromium.org authored Jan 25, 2010

Patch-contributed-by: Nasser Grainawi <nasser@codeaurora.org>

Review URL: http://codereview.chromium.org/546045

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@37016 0039d316-1c4b-4281-b951-d872f2087c98

3904caa9

22 Jan, 2010 2 commits

Adding branch to branch merge support for drover. · 2d6af5fc

laforge@chromium.org authored Jan 22, 2010

Review URL: http://codereview.chromium.org/554054

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@36872 0039d316-1c4b-4281-b951-d872f2087c98

2d6af5fc

Fix svn mv/cp/ren diff for real this time, for try jobs. · 0836c561

maruel@chromium.org authored Jan 22, 2010

TEST=send a try job with a file moved with modified content
BUG=6825

Review URL: http://codereview.chromium.org/554013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@36828 0039d316-1c4b-4281-b951-d872f2087c98

0836c561

19 Jan, 2010 1 commit

First take on zsh-completion functionality for gclient. · 41cdced8

antonm@chromium.org authored Jan 19, 2010

It's very basic, only subcommands.

If this would evolve, generation of _gclient should be automized (like a separate command
or some other tool.)

Review URL: http://codereview.chromium.org/546069

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@36521 0039d316-1c4b-4281-b951-d872f2087c98

41cdced8

13 Jan, 2010 4 commits

gclient: Add better error reporting when path is not a git repo. · e4af1ab4

msb@chromium.org authored Jan 13, 2010

Review URL: http://codereview.chromium.org/505007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@36172 0039d316-1c4b-4281-b951-d872f2087c98

e4af1ab4

Correct the value needed to disable auto-updates · 74f559a7

msb@chromium.org authored Jan 13, 2010

Also remove Windows-style line endings.
Patch-contributed-by: Nasser Grainawi <nasser@codeaurora.org>

Review URL: http://codereview.chromium.org/541034

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@36145 0039d316-1c4b-4281-b951-d872f2087c98

74f559a7

Update docs for git usage · d6504218

msb@chromium.org authored Jan 13, 2010

chromium-os BUG=1189

Review URL: http://codereview.chromium.org/551002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@36129 0039d316-1c4b-4281-b951-d872f2087c98

d6504218

gclient: git relative url implementation · e6f78352

msb@chromium.org authored Jan 13, 2010

Redo relative url implementation per maruel's comments here:
http://codereview.chromium.org/500015

Instead of adding an option, implement relative urls differently for
git urls.

Review URL: http://codereview.chromium.org/546022

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@36126 0039d316-1c4b-4281-b951-d872f2087c98

e6f78352

12 Jan, 2010 1 commit

gclient: fix unittests · 32906d1b

msb@chromium.org authored Jan 12, 2010

Review URL: http://codereview.chromium.org/550013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@36022 0039d316-1c4b-4281-b951-d872f2087c98

32906d1b