Commits · e038545c2bf5781affa39a311d900e68d8cd2749 · Linshizhi / Chromium_Depot_tools

01 Feb, 2022 5 commits

Roll recipe dependencies (trivial). · e038545c

recipe-roller authored Feb 01, 2022

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8823402091761702673

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/1b1ecd03e0b00399784c43add1465f685b6d1ab9
  1b1ecd0 (olivernewman@google.com)
      [recipes.py] Set --quiet on git fetch

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=dpranke@google.com, iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I559774d210c32d2557fade1c406c92e4fdd72469
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3428936
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

e038545c

[lucicfg] Update to v1.30.9. · 5c308b71

Vadim Shtayura authored Feb 01, 2022

The only change is:
https://chromium-review.googlesource.com/c/3428299

R=iannucci@chromium.org
BUG=1182002

Change-Id: I8e7b3a2315eceaa9285a9b4b94fc6e09493f02ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3428355Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

5c308b71

Roll recipe dependencies (trivial). · 8a6d00f1

recipe-roller authored Feb 01, 2022

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8823466894054118465

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/5675f7012878c187ba4d9556be2944fc00744bbf
  5675f70 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 17dd9c65691b to 55b6fea03452

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4e619fe2668390bc3597159428f4da642188d0cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3428920
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

8a6d00f1

ninjalog_uploader: do not redirect stderr · 98cf9328

Takuto Ikuta authored Feb 01, 2022

Fixed: 1292542
Change-Id: Ia312eb7e4e3fd8d4c2b0fdaa10b7cc0290d38b93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3428659
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>

98cf9328

Roll recipe dependencies (trivial). · 9c2e78d2

recipe-roller authored Feb 01, 2022

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8823475697464031329

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/e04c8561dfa35ac7837ddf2a453fc8df5d8014b8
  e04c856 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from d980af3b2cd9 to ce8e2e60bf68

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6826510c075a28f63cf0470f5b40d8c02b244fe5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3428344
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

9c2e78d2

28 Jan, 2022 5 commits

Roll recipe dependencies (trivial). · 8dd74d4f

recipe-roller authored Jan 28, 2022

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8823757559656099905

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/b1529aa30a0989e41082ca1e13b2fdae8be226da
  b1529aa (gbeaty@chromium.org)
      Output the number of potential candidate commits.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iff7cbace9a697064093c0b9594e2389b86fab236
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3425440
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

8dd74d4f

Add rs files to git gs. · 92469157

dan sinclair authored Jan 28, 2022

Rust support is being tested out in Chromium (crbug.com/1292073). This
CL adds support for searching rust (.rs) files when using git gs.

Bug: 1292064
Change-Id: I5e2c5aa16e4dfa5f51a632afda7bdb5ab263b6ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3425617
Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>

92469157

Roll recipe dependencies (trivial). · f698cfce

recipe-roller authored Jan 28, 2022

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8823765738068482353

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/b406be2b7c72b044e73567f8b1d90fb763a81d79
  b406be2 (gbeaty@chromium.org)
      Remove python2 compatibility from buildbucket:run/multi recipe.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie39a54d72f35295a0e57b79a6124a036d1846e78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3423669
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

f698cfce

Add method for setting test data for get_files_affected_by_patch. · dd93ebca

Garrett Beaty authored Jan 28, 2022

The get_files_affected_by_patch method on the test API will return a
TestData object that determines the output of the "git diff" call. a
Test was added specifically for the get_files_affected_by_patch API
method to ensure that the test API operates as expected.

Change-Id: Ia1846700461757a72ed518894a5a38a8ca54fcc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3422006
Auto-Submit: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Garrett Beaty <gbeaty@google.com>

dd93ebca

Replace all rem comments with :: comments in batch files · 0dc69c4e

Darshan Sen authored Jan 28, 2022

Though the Microsoft docs recommend using rem to write comments, it has
a shortcoming - redirection characters (< or >) or pipes (|) aren't
allowed. However, :: though undocumented, is a better alternative as it
allows such characters.
Signed-off-by: Darshan Sen <raisinten@gmail.com>
Change-Id: I95a0445168527ab5087246238f0216d5f6177046
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3400399Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>

0dc69c4e

27 Jan, 2022 4 commits

Remove unused arguments from bot_update recipe · 289dedd3

Josip Sokcevic authored Jan 27, 2022

gclient removed syntax validation flag in 2020:
https://crrev.com/c/2083589, so this can safely be removed.

R=aravindvasudev@google.com, gavinmak@google.com

Recipe-Nontrivial-Roll: chrome_release
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: build
Change-Id: I2aced6cdb01d571ca361cc57e7c8715c9ca40552
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3419278Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

289dedd3

[lucicfg] Update to v1.30.8. · 925f2fa4

Vadim Shtayura authored Jan 27, 2022

To pick up conditional bindings support in LUCI Scheduler.

R=iannucci@chromium.org

Change-Id: I16fd0329db9b4a62cdb067b9e9b1e94ceb48f086
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3419176Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

925f2fa4

Roll recipe dependencies (trivial). · 3bf97661

recipe-roller authored Jan 27, 2022

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8823855706329430113

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/503f1c16a4ff279d5cf94bb1e68b4720482bc218
  503f1c1 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 371a3309b190 to 9c88febc5ab6

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8ea4a8f2a7b978d67ef0476716d6febe138c5c4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3421572
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

3bf97661

Roll recipe dependencies (trivial). · 82a23989

recipe-roller authored Jan 27, 2022

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8823860733982438289

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/f40ed1ad369619a76a0103e8831acf4860e06e5f
  f40ed1a (bpastene@chromium.org)
      Make the 'critical' field be configurable for trybuilds in reci...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3fbe5b14db84892396eb672839e6e8b4acb62e30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3421566
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

82a23989

26 Jan, 2022 3 commits

Roll recipe dependencies (trivial). · d5862557

recipe-roller authored Jan 26, 2022

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8823943154243442865

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/ca3ecae8e85d2408682007a2d5638563ee05d231
  ca3ecae (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from b232340b0fe0 to 7528d700b89d

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id617dd9cdb95807c459f670ba7217b86fe566c2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3416568
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

d5862557

Remove deprecated arguments in bot_update recipe · e1b48631

Josip Sokcevic authored Jan 26, 2022

R=gavinmak@google.com

Change-Id: I37bbdf02bfd32577224224a3114171810a7318fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3416677
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>

e1b48631

Reland "Use py3 in bot_update and gclient recipe_modules" · ed6aa2b0

Josip Sokcevic authored Jan 26, 2022

This is a reland of bb88492f

Original change's description:
> Use py3 in bot_update and gclient recipe_modules
>
> Recipe-Nontrivial-Roll: build
> Recipe-Nontrivial-Roll: build_limited
> Recipe-Nontrivial-Roll: chrome_release
> Recipe-Nontrivial-Roll: chromiumos
> Recipe-Nontrivial-Roll: infra
> Bug: 1289280
> Change-Id: Id61bacf4acef319f7ea22161081b632677ca363c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3402082
> Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: chrome_release
Recipe-Nontrivial-Roll: chromiumos
Recipe-Nontrivial-Roll: infra
Bug: 1289280, 1289504
Change-Id: I2f2f7244568b1fdfb960d5cdfa3937175ac1ed2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3414742Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

ed6aa2b0

25 Jan, 2022 2 commits

Add aravindvasudev to owners · d05a2e03

Josip Sokcevic authored Jan 25, 2022

R=aravindvasudev@google.com, gavinmak@google.com

Change-Id: Ic00cc4a6b0ca9aa7d8109f0d8c611044a4a1da47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3414741
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>

d05a2e03

Roll recipe dependencies (trivial). · 403558f6

recipe-roller authored Jan 25, 2022

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8824037529371800769

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/619324050cd76c770cce159952b9625814a57ff0
  6193240 (bpastene@chromium.org)
      Add 'resultdb_info' fields to default swarming JSON in recipe t...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I550ee7f49c6ab711ba065a3d6a9f2ca8ca78ded2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3415790
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

403558f6

24 Jan, 2022 9 commits

Use pylint 2.7 for depot_tools · c5f0cbb8

Aravind Vasudevan authored Jan 24, 2022

This includes a few fixes for specific errors, and disables several new
warnings introduced in this version, in order to allow for an incremental migration.

Bug:1262286
Change-Id: I4b8f8fc521386419a3121bbb07edc8ac83170a94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3413679Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>

c5f0cbb8

Add a method for enforcing a tryjob. · d94f9a6d

Garrett Beaty authored Jan 24, 2022

The tryserver.require_is_tryserver method will create an infra-failing
step that raises an exception if there is no CL associated with the
build. In the case of an LED task, it will only fail so as not to cause
the removal of the builder cache in the case of a minor user error.

Change-Id: I05d3a86cc727577f067fb3eae49e46398345f672
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3413971
Auto-Submit: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>

d94f9a6d

Revert "Use pylint 2.7 for depot_tools" · 42c5bbbc

Josip Sokcevic authored Jan 24, 2022

This reverts commit 22bf605b.

Reason for revert: breaks gclient sync

Original change's description:
> Use pylint 2.7 for depot_tools
>
> This includes a few fixes for specific errors, and disables several new
> warnings introduced in this version, in order to allow for an incremental migration.
>
> Bug:1262286
> Change-Id: Ie97d686748c9c952e87718a65f401c5f6f80a5c9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3400616
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>

Bug: 1262286
Change-Id: Ieb946073c7886c7bf056ce843a5a48e82becf7a5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3413672
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

42c5bbbc

Use pylint 2.7 for depot_tools · 22bf605b

Aravind Vasudevan authored Jan 24, 2022

This includes a few fixes for specific errors, and disables several new
warnings introduced in this version, in order to allow for an incremental migration.

Bug:1262286
Change-Id: Ie97d686748c9c952e87718a65f401c5f6f80a5c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3400616Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>

22bf605b

Remove deprecated parameters · 9a4db25b

Josip Sokcevic authored Jan 24, 2022

Those paremeters are deprected for over 4 years now. I found no usages
while searching for output_manifest in source.chromium.org.

R=machenbach@google.com

Bug: 1289274
Change-Id: I7d8f8ee29fdb046b255c96ad26f8dc7129b1f83a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3402741
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

9a4db25b

Fix depot_tools tests when running without py2 · e9ea0d5c

Gavin Mak authored Jan 24, 2022

Currently, running git cl presubmit fails without python 2 installed.
This CL replaces instances of 'python' in fetch_test.py with the generic
sys.executable and fixes a small error testRebaseUpdate due to an extra
period.

Bug: 1289839
Change-Id: Ib5802545af70fe0886448397fa76058bd2036527
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3407864Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>

e9ea0d5c

Update dirmd to newest depot_tools commit. · 19c4cef8

Andrew Lamb authored Jan 24, 2022

- Needed to get newer proto schemas from messages that are
included in the Metadata message. Currently, `dirmd validate`
is failing with errors like
"unknown field: test_plan_starlark_files" which passes with
newer versions of `dirmd`.

Bug:b/182898188
Change-Id: Ib59e160ea22518f7fdf2c0f2e830c65481c116a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3368325Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Andrew Lamb <andrewlamb@chromium.org>

19c4cef8

ninjalog_uploader: do not use capture_output and text · 18a2844b

Takuto Ikuta authored Jan 24, 2022

capture_output and text args are not available in Python3.6.

Bug: 1290210
Change-Id: Id3c70ad456c5ca56df9935d64229f599d7aae4b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3406721
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: David Munro <davidmunro@google.com>
Commit-Queue: David Munro <davidmunro@google.com>

18a2844b

ninjalog_uploader: fix command for Windows · 653d7e6c

Takuto Ikuta authored Jan 24, 2022

Windows doesn't work with shebang.

Fixed: 1289707
Change-Id: I9db5f550d7ab5d2f92ccac392c3a5ee9595a9bf6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3406711
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>

653d7e6c

21 Jan, 2022 5 commits

Roll recipe dependencies (trivial). · 4068ef45

recipe-roller authored Jan 21, 2022

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8824394040072813425

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/a476355d81d68d946bb2ab2b9431d648e7ad2167
  a476355 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from a169f70aa54e to 09f8b3edbbf1

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I633e94d81e46e852cd6ecdb3ec53d9b466303dda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3407861
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

4068ef45

Revert "Use py3 in bot_update and gclient recipe_modules" · 6bfbe35c

Brian Ryner authored Jan 21, 2022

This reverts commit bb88492f.

Reason for revert: Broke bot_update: https://logs.chromium.org/logs/infra/buildbucket/cr-buildbucket/8824463357494497185/+/u/bot_update/stdout

Original change's description:
> Use py3 in bot_update and gclient recipe_modules
>
> Recipe-Nontrivial-Roll: build
> Recipe-Nontrivial-Roll: build_limited
> Recipe-Nontrivial-Roll: chrome_release
> Recipe-Nontrivial-Roll: chromiumos
> Recipe-Nontrivial-Roll: infra
> Bug: 1289280
> Change-Id: Id61bacf4acef319f7ea22161081b632677ca363c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3402082
> Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: chrome_release
Recipe-Nontrivial-Roll: chromiumos
Recipe-Nontrivial-Roll: infra
Bug: 1289280
Change-Id: I371d599b17b42edd7b1aae581695e75a80ebae83
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3403476
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

6bfbe35c

Roll recipe dependencies (trivial). · b8f1ca30

recipe-roller authored Jan 21, 2022

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8824471710524633281

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/312823d273286a0cf42514f5d00633262ee92f65
  312823d (bryner@google.com)
      Convert git stdin/stdout to and from bytes.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1aa21fb634156878fb361c0a637e4c38c73e5890
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3405077
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

b8f1ca30

Use py3 in bot_update and gclient recipe_modules · bb88492f

Josip Sokcevic authored Jan 21, 2022

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: chrome_release
Recipe-Nontrivial-Roll: chromiumos
Recipe-Nontrivial-Roll: infra
Bug: 1289280
Change-Id: Id61bacf4acef319f7ea22161081b632677ca363c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3402082Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

bb88492f

fix ninjalog_uploader.py · 3dc0172a

Takuto Ikuta authored Jan 21, 2022

This is to fix https://crbug.com/1288639#c5

Bug: 1288639
Change-Id: Ife224fb5d5fe4faa4a78785828d4fa488fda3c6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3403475
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>

3dc0172a

20 Jan, 2022 2 commits

Add support for c++17 tuple destructuring (#487) · ac54b8de

Alex Light authored Jan 20, 2022

C++17 adds support for tuple destructuring. This allow one to write
code such as:

```
std::pair<int, int> span = getSpan();
auto [start, end] = span;

// Use start as span.first and end as span.second
```

This makes cpplint recognize and allow a space before the '[' in this
situation.

This is a purposeful divergence from the internal version where the
entire whitespace/braces category was removed. It was decided to leave
the checks in since this is sometimes used without other formatting
tools.

Test: manual

(cherry picked from commit 26470f9ccb354ff2f6d098f831271a1833701b28
 from https://github.com/google/styleguide)

Bug: 1287491
Change-Id: Ib61a75853e19316b1bacf8dc56528f94c17e30a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3389431Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Victor Boivie <boivie@google.com>

ac54b8de

ninjalog_uploader: use goma_auth to detect googler · a657331e

Takuto Ikuta authored Jan 20, 2022

Bug: 1288639
Change-Id: I447e2f66603ffb8d68599dcf22023fd7857dc4fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3400398Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

a657331e

19 Jan, 2022 2 commits

Always fetch main in update_depot_tools · b674278c

Josip Sokcevic authored Jan 19, 2022

If main is not fetchable, report the error to end user.

R=gavinmak@google.com

Bug: 1277136
Change-Id: I8c061719f9aadc42786045b3c5331bab3d0caae7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3389824Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>

b674278c

switch autoninja shebang to python3 · 237cc469

Takuto Ikuta authored Jan 19, 2022

We don't want to use python2 and this doesn't use third party library
too so no need to be vpython which has a small overhead.

Change-Id: Iff924a87f0562069e29195a5693e2260e4a6684e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3400397
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>

237cc469

18 Jan, 2022 1 commit

Fix git_common_test.py: git checkout -tb -> git checkout -t -b · cb340f5b

Andrew Grieve authored Jan 18, 2022

git now takes an optional parameter for -t

Bug: 1288010
Change-Id: I0b7b212229f8df846a2d80a1632387982fd7358e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3395441
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>

cb340f5b

14 Jan, 2022 2 commits

Roll recipe dependencies (trivial). · fd7427cc

recipe-roller authored Jan 14, 2022

This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8825030197048673041

recipe_engine:
https://chromium.googlesource.com/infra/luci/recipes-py.git/+/96ed3069ae18ba2ced6ff8955702cc23acd1a197
  96ed306 (rubensf@google.com)
      Allow extract.py to extract to non-empty dir

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2904892628241d8b27ee50034d58bcd19e8028ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3389819
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

fd7427cc

Roll out goma client VERSION=240 · 56dedaeb

Fumitoshi Ukai authored Jan 14, 2022

Bug: b/207719456
Change-Id: I7fdc401b92bbea866ad7dc4079342fd910b64dea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3388375Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>

56dedaeb