Commits · de281aee41f5fae08e9274341b7995d26af32a66 · Linshizhi / Chromium_Depot_tools

12 Oct, 2016 1 commit

git cl try: make code less Rietveld-specific. · de281aee

tandrii authored Oct 12, 2016

This also adds first test to cover case of custom properties.

R=machenbach@chromium.org,sergiyb@chromium.org
BUG=599931

Review-Url: https://codereview.chromium.org/2409223002

de281aee

11 Oct, 2016 12 commits

Remove git lockfile flakiness on win (bot_update) · df66a34f

katthomas authored Oct 11, 2016

Hypothesis: Sometimes bot update fails because windows fails to delete
a lockfile associated with a git process.

Test: If this happens, let's delete that lockfile and try again.

BUG=651602

Review-Url: https://codereview.chromium.org/2382653005

df66a34f

Add .mojom to git-gs · bda914b8

scottmg authored Oct 11, 2016

R=maruel@chromium.org

Review-Url: https://codereview.chromium.org/2410393002

bda914b8

Revert of Remove SVN and File support from gclient (patchset #4 id:60001 of... · 398a46ee

lpique authored Oct 11, 2016

Revert of Remove SVN and File support from gclient (patchset #4 id:60001 of https://codereview.chromium.org/2398493004/ )

Reason for revert:
The Chrome buildbots pass "--transitive" still. Removing the option causes them to fail to build.

Example:

https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/x86-alex-tot-chrome-pfq-informational/builds/21555

Original issue's description:
> Remove SVN and File support from gclient
>
> FileImpl was only usable with SVN.
>
> R=maruel@chromium.org
> BUG=641588
>
> Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/b3a24c3fd5159972f58063967a9c07ef724ff97b

TBR=maruel@chromium.org,agable@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=641588

Review-Url: https://codereview.chromium.org/2405173003

398a46ee

Roll recipe dependencies (trivial). · 7e269f0d

recipe-roller authored Oct 11, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/e129c96c485b33149256838d912c5f324bf59dd7 Add LogDog / annotation protobuf support. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=None

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2410173003

7e269f0d

Remove SVN and File support from gclient · b3a24c3f

agable authored Oct 11, 2016

FileImpl was only usable with SVN.

R=maruel@chromium.org
BUG=641588

Review-Url: https://codereview.chromium.org/2398493004

b3a24c3f

git cl try: refactor to add Gerrit support in the future. · e113dfd7

tandrii authored Oct 11, 2016

R=nodir@chromium.org,sergiyb@chromium.org
BUG=599931

Review-Url: https://codereview.chromium.org/2400713003

e113dfd7

git cl try: remove --use-rietveld and related code. · 568043bd

tandrii authored Oct 11, 2016

R=nodir@chromium.org,sergiyb@chromium.org
BUG=599931

Review-Url: https://codereview.chromium.org/2401943002

568043bd

Revert of gclient: kill git fetch operation that hangs. (patchset #12... · 64103db7

tandrii authored Oct 11, 2016

Revert of gclient: kill git fetch operation that hangs. (patchset #12 id:220001 of https://codereview.chromium.org/2241843002/ )

Reason for revert:
Didn't help.

Original issue's description:
> gclient: kill git fetch operation that hangs.
>
> This provides env variable GCLIENT_KILL_GIT_FETCH_AFTER
> that kills git fetch if it produces no output for that
> many seconds.
>
> Note that this is not final patch, but an experiment.
> See http://crbug.com/635641#c24 for the deployment plan.
>
> BUG=635641
> R=hinoka@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/f8757b7e02226594655230ccbeae3543c7dc49c6

TBR=hinoka@chromium.org,hinoka@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=635641

Review-Url: https://codereview.chromium.org/2410853002

64103db7

Revert of bot_update/gclient: kill git fetch after timeout regardless of... · 30d95627

tandrii authored Oct 11, 2016

Revert of bot_update/gclient: kill git fetch after timeout regardless of output. (patchset #2 id:20001 of https://codereview.chromium.org/2293013002/ )

Reason for revert:
didn't work.

Original issue's description:
> bot_update/gclient: kill git fetch after timeout regardless of output.
>
> Also spits out whatever output was produced by git fetch for debugging.
>
> BUG=635641
> R=machenbach@chromium.org,hinoka@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/db8b839320168ab4f5156399ecb275478c0aa2cd

TBR=hinoka@chromium.org,machenbach@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=635641

Review-Url: https://codereview.chromium.org/2410053002

30d95627

git cl try-results regression tests for Gerrit. · 45b2a589

tandrii authored Oct 11, 2016

The flow looks like this:

  $ git cl status
  Branches associated with reviews:
    gerrit-4483 : https://chromium-review.googlesource.com/381231 (waiting)

  $ git cl try-results
  Warning: Codereview server has newer patchsets (2) than most recent
  upload from local checkout (None). Did a previous upload fail?
  By default, git cl try uses latest patchset from codereview,
  continuing using such patchset 2.

  Warning: Some results might be missing because You are not logged in.
  Please login first by running:
    depot-tools-auth login chromium-review.googlesource.com
  Started:
    Infra Linux Precise 32 Tester https://luci-milo.appspot.com/swarming/...
    Infra Linux Trusty 64 Tester  https://luci-milo.appspot.com/swarming/...
  Total: 2 try jobs

  $ depot-tools-auth login chromium-review.googlesource.com
   <<<auth in my browser>>>

  Logged in to chromium-review.googlesource.com as <some@email.com>

	To login with a different email run:
		depot-tools-auth login chromium-review.googlesource.com
	To logout and purge the authentication token run:
		depot-tools-auth logout chromium-review.googlesource.com

  $ git config branch.gerrit-4483.gerritpatchset 2
  $ git cl try-results
  Started:
    Infra Linux Precise 32 Tester https://luci-milo.appspot.com/swarming/...
    Infra Linux Trusty 64 Tester  https://luci-milo.appspot.com/swarming/...
    Infra Mac Tester              https://luci-milo.appspot.com/swarming/...
  Total: 3 try jobs

R=sergiyb@chromium.org,emso@chromium.org
BUG=599931
TEST=new unittests + end-to-end local.

Review-Url: https://codereview.chromium.org/2392463009

45b2a589

repo: update to v1.12.34-cr2 · ae39f566

vapier authored Oct 11, 2016

We've synced our fork of repo to upstream. This change copies the new
version into depot_tools.

BUG=chromium:632203
TEST=`repo sync` still works

Review-Url: https://codereview.chromium.org/2402193002

ae39f566

Roll recipe dependencies (trivial). · fa2ea243

recipe-roller authored Oct 11, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/eace5bb2ef1323ca39ffda4644278569d54acd60 Print information when user doesn't have coverage available. (martiniss@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2403783004

fa2ea243

10 Oct, 2016 2 commits

git cl patch: handle missing/wrong Gerrit issue better. · c2405f55

tandrii authored Oct 10, 2016

No stacktrace is printed, instead just a user-friendly string is shown.
Add test + some tests refactoring.

This CL also improve missing Gerrit issue exception elsewhere by raising
user-friendly exception.

BUG=654360
R=sergiyb@chromium.org
TEST=manual

Review-Url: https://codereview.chromium.org/2403793002

c2405f55

git cl try: --use-rietveld no longer supported. · 8e229546
tandrii authored Oct 10, 2016
```
R=nodir@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2399993004
```
8e229546

07 Oct, 2016 1 commit

Refactor git cl try. · f7b29d4a

tandrii authored Oct 07, 2016

R=phajdan.jr@chromium.org,sergiyb@chromium.org
BUG=599931

Review-Url: https://codereview.chromium.org/2400793004

f7b29d4a

06 Oct, 2016 3 commits

Roll recipe dependencies (trivial). · a3f10315

recipe-roller authored Oct 06, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/825386b5d616ed1e5fca94ec76eb6de9335b86d2 Add astunparse and update_vendoring. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2399153003

a3f10315

git cl try-results: refactor Rietveld + add tests. · 221ab25f

tandrii authored Oct 06, 2016

R=emso@chromium.org,phajdan.jr@chromium.org
BUG=599931
TEST=new teste + local end-to-end

Review-Url: https://codereview.chromium.org/2395113002

221ab25f

git cl: style cleanup. · 1838bade

tandrii authored Oct 06, 2016

R=emso@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2393253002

1838bade

01 Oct, 2016 1 commit

Make merge driver complain about older gits · 9bd40a63

thakis authored Oct 01, 2016

The git coming with Xcode 7.0 is too old to know about %P. Most
people will be on newer Xcodes (and Trusty's git and depot_tools's
Windows git are new enough), so this doesn't affect most folks -- so
just complaining loudly is good enough.

BUG=574611
TBR=dpranke

Review-Url: https://codereview.chromium.org/2388483004

9bd40a63

30 Sep, 2016 1 commit

Roll recipe dependencies (trivial). · bdb5c1ff

recipe-roller authored Sep 30, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/36a1da1369c83f0754989e6f5a24b1b49f6898c9 Allow tests for complicated property names (martiniss@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2380393002

bdb5c1ff

29 Sep, 2016 4 commits

Remove straggler auto-svn doc file. · c6fbe605

agable authored Sep 29, 2016

R=brucedawson@chromium.org

Review-Url: https://codereview.chromium.org/2383493003

c6fbe605

Modify depot_tools instructions regarding %PATH% · dd55dc6d

brucedawson authored Sep 29, 2016

The old depot_tools instructions insisted that depot_tools be the last
entry in the PATH environment variable, for reasons that are unclear and
may only have applied to Linux. Meanwhile, there is a gn issue that can
cause unnecessary building if depot_tools is not near the front of the
path - ahead of other Python installs. This change alters the
instructions for Windows.

This also removes some obsolete instructions regarding building Chrome
on Windows XP - Chrome doesn't even *run* on Windows XP anymore.

BUG=611087

Review-Url: https://codereview.chromium.org/2371333002

dd55dc6d

Reland of Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld · 88189774

tandrii authored Sep 29, 2016

Originally landed as issue 2378703002 at patchset 60001
(http://crrev.com/2378703002#ps60001).

BUG=chromium:649660
TBR=rmistry@chromium.org

Review-Url: https://codereview.chromium.org/2376323002

88189774

Revert of Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs... · 31d165a5

tandrii authored Sep 29, 2016

Revert of Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld (patchset #4 id:60001 of https://codereview.chromium.org/2378703002/ )

Reason for revert:
Actually, it doesn't break uploads, add cc-ed emails post-upload fails with exception and confuses users, and I couldn't find workaround.

Original issue's description:
> Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld
>
> BUG=chromium:649660
>
> Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/3574740929abd37c45db1d2f8a2c3799bdfe77c5

TBR=rmistry@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:649660

Review-Url: https://codereview.chromium.org/2375393002

31d165a5

28 Sep, 2016 3 commits

Add CC_LIST and --cc to Gerrit issues via API to be similar to CCs in Rietveld · 35747409
rmistry authored Sep 28, 2016
```
BUG=chromium:649660

Review-Url: https://codereview.chromium.org/2378703002
```
35747409

Roll recipe dependencies (trivial). · 3e1cde7a

recipe-roller authored Sep 28, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/69af4e53c1be1b0fbbc9e57edd70926b8d4f9370 Fix whitelist feature to preserve step order. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=459361

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2380433002

3e1cde7a

Roll recipe dependencies (trivial). · 2ca16919

recipe-roller authored Sep 28, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/01049d305bfe49d91aab3207372b5b0a0791ba63 Force printing of exception message. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:650831

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2375813002

2ca16919

27 Sep, 2016 1 commit

Roll recipe dependencies (trivial). · a8d76db7

recipe-roller authored Sep 27, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/79cf78db1a3c32c7730f3e9006825a95261abe06 Cleanup fetch, fix missing network flake instances (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:650355

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2376543002

a8d76db7

26 Sep, 2016 4 commits

Roll recipe dependencies (trivial). · 6b2cc381

recipe-roller authored Sep 26, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/970fe6881473f82045801dff8c317a372c51d052 Update vendoring (martiniss@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2370123002

6b2cc381

Remove git-svn support from fetch · 72762286

agable authored Sep 26, 2016

R=iannucci@chromium.org
BUG=475320

Review-Url: https://codereview.chromium.org/2360873002

72762286

git recipe_module: git new-branch. · bef52ff0

tandrii authored Sep 26, 2016

R=iannucci@chromium.org,qyearsley@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2369073002

bef52ff0

Use a whitelist for depot_tools pylint instead · f39c3338
agable authored Sep 26, 2016
```
R=maruel@chromium.org
BUG=644995

Review-Url: https://codereview.chromium.org/2353393004
```
f39c3338

23 Sep, 2016 4 commits

Introduce git merge driver for the blink reformatting · ff84560e

dcheng authored Sep 23, 2016

Based on CL from primiano@: https://codereview.chromium.org/2348793003/

This is a simple tool that can help automatically resolve conflicts
from clang-format reformatting patches.

BUG=574611

Review-Url: https://codereview.chromium.org/2356933002

ff84560e

Roll recipe dependencies (trivial). · 15ab0822

recipe-roller authored Sep 23, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/044dba0634a396fd78f97f0f633136420780fc37 More strategic retries in fetch. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:649466,chromium:649529

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2360143005

15ab0822

Delete unneeded test. · f3cc160f

stip authored Sep 23, 2016

Follow-up to https://codereview.chromium.org/2352393003. Note that a lot of these tests seem svn related, and can probably be deleted. I defer to to agable@ on what we can carve out here.

BUG=
R=agable@chromium.org

Review-Url: https://codereview.chromium.org/2360113002

f3cc160f

Change usage of deprecated flag. · 7a3dd357

stip authored Sep 23, 2016

BUG=Every time I run 'git cl upstream' I get "The --set-upstream flag is deprecated and will be removed. Consider using --track or --set-upstream-to."

Review-Url: https://codereview.chromium.org/2352393003

7a3dd357

22 Sep, 2016 2 commits

Roll recipe dependencies (trivial). · 32d8737b

recipe-roller authored Sep 22, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/5b64ce6370b70afd63e463ae72f02e69ecc034ec Require recipes to emit at least one full test case. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=459361

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2364463003

32d8737b

Delete git-auto-svn and its docs · 3b9a5bb8

agable authored Sep 22, 2016

We no longer support git-svn as a workflow.

R=iannucci@chromium.org
BUG=475320

Review-Url: https://codereview.chromium.org/2360143002

3b9a5bb8

21 Sep, 2016 1 commit

Reland bot_update: add --auth-refresh-token-json passthrough for apply_issue · b61b9b75

hinoka authored Sep 21, 2016

Reland of https://codereview.chromium.org/2294413002/ after a rebase fix.

BUG=642150

Review-Url: https://codereview.chromium.org/2353833002

b61b9b75