- 23 Jun, 2015 2 commits
-
-
rmistry@google.com authored
Here is an explanation of the changes in each module: * git_cl.py - IF a local branch is being tracked AND a CL has been uploaded there THEN use the CL's issue number and latest patchset as a dependency. * upload.py - Uploads the patchset dependency, if it exists, to Rietveld (Rietveld will be able to parse this when https://codereview.chromium.org/1155513002/ lands). * rietveld.py - Adds utility methods to get patchset dependencies from the new Rietveld endpoint (the endpoint will exist when https://codereview.chromium.org/1155513002/ lands). * apply_issue.py - If CL3 depends on CL2 which in turn depends on CL1 then apply_issue will gather a list of all issues and patchsets to apply (Eg: [CL1:PS1, CL2:PS1, CL3:PS2]). apply_issue will then loop over the list applying each dependency. Note: The apply_issue.py diff looks much worse than it is. Please see my comment in https://codereview.chromium.org/1149653002/diff/260001/apply_issue.py#oldcode169 Tested end-to-end using a test Git repository (https://skia.googlesource.com/skiabot-test/) and the following CLs created in my test Rietveld instance: * https://skia-codereview-staging.appspot.com/931002 ('Branch1 CL') * https://skia-codereview-staging.appspot.com/5001001 ('Branch2 CL') * https://skia-codereview-staging.appspot.com/9881001 ('Branch3 CL') * https://skia-codereview-staging.appspot.com/3951001 ('Branch3.1 CL') Opt into the new UI and observe the new 'Depends on Patchset' and 'Dependent Patchsets' sections in the above CLs. Design doc is here: https://docs.google.com/document/d/1KZGFKZpOPvco81sYVRCzwlnjGctup71RAzY0MSb0ntc/edit#heading=h.6r6lt4tsvssw BUG=502255 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295778 Review URL: https://codereview.chromium.org/1149653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295799 0039d316-1c4b-4281-b951-d872f2087c98
-
iannucci@chromium.org authored
R=thakis@chromium.org BUG=503462 Review URL: https://codereview.chromium.org/1193333012 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295795 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Jun, 2015 4 commits
-
-
smut@google.com authored
This flag allows the user to specify a file which contains a JSON list of dicts to set for the "changes" property when scheduling the build. BUG=493885 Review URL: https://codereview.chromium.org/1199963004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295788 0039d316-1c4b-4281-b951-d872f2087c98
-
rmistry@google.com authored
Revert of [depot_tools] Find, upload and apply patchset dependencies (patchset #17 id:360001 of https://codereview.chromium.org/1149653002/) Reason for revert: Ran into a crash during the bot_update step here: https://uberchromegw.corp.google.com/i/internal.infra.try/builders/infra-internal-presubmit/builds/62 Original issue's description: > Find, upload and apply patchset dependencies. > > Here is an explanation of the changes in each module: > > * git_cl.py - > IF a local branch is being tracked AND a CL has been uploaded there THEN use the CL's issue number and latest patchset as a dependency. > > * upload.py - > Uploads the patchset dependency, if it exists, to Rietveld (Rietveld will be able to parse this when https://codereview.chromium.org/1155513002/ lands). > > * rietveld.py - > Adds utility methods to get patchset dependencies from the new Rietveld endpoint (the endpoint will exist when https://codereview.chromium.org/1155513002/ lands). > > * apply_issue.py - > If CL3 depends on CL2 which in turn depends on CL1 then apply_issue will gather a list of all issues and patchsets to apply (Eg: [CL1:PS1, CL2:PS1, CL3:PS2]). > apply_issue will then loop over the list applying each dependency. > Note: The apply_issue.py diff looks much worse than it is. Please see my comment in > https://codereview.chromium.org/1149653002/diff/260001/apply_issue.py#oldcode169 > > > Tested end-to-end using a test Git repository (https://skia.googlesource.com/skiabot-test/) and the following CLs created in my test Rietveld instance: > * https://skia-codereview-staging.appspot.com/931002 ('Branch1 CL') > * https://skia-codereview-staging.appspot.com/5001001 ('Branch2 CL') > * https://skia-codereview-staging.appspot.com/9881001 ('Branch3 CL') > * https://skia-codereview-staging.appspot.com/3951001 ('Branch3.1 CL') > Opt into the new UI and observe the new 'Depends on Patchset' and 'Dependent Patchsets' sections in the above CLs. > > > Design doc is here: https://docs.google.com/document/d/1KZGFKZpOPvco81sYVRCzwlnjGctup71RAzY0MSb0ntc/edit#heading=h.6r6lt4tsvssw > > BUG=502255 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295778 TBR=agable@chromium.org,jrobbins@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=502255 Review URL: https://codereview.chromium.org/1200773003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295782 0039d316-1c4b-4281-b951-d872f2087c98
-
rmistry@google.com authored
Motivation: The conversation in https://docs.google.com/document/d/1KZGFKZpOPvco81sYVRCzwlnjGctup71RAzY0MSb0ntc/edit?disco=AAAAAXU60E8 BUG=502257 Review URL: https://codereview.chromium.org/1191473002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295779 0039d316-1c4b-4281-b951-d872f2087c98
-
rmistry@google.com authored
Here is an explanation of the changes in each module: * git_cl.py - IF a local branch is being tracked AND a CL has been uploaded there THEN use the CL's issue number and latest patchset as a dependency. * upload.py - Uploads the patchset dependency, if it exists, to Rietveld (Rietveld will be able to parse this when https://codereview.chromium.org/1155513002/ lands). * rietveld.py - Adds utility methods to get patchset dependencies from the new Rietveld endpoint (the endpoint will exist when https://codereview.chromium.org/1155513002/ lands). * apply_issue.py - If CL3 depends on CL2 which in turn depends on CL1 then apply_issue will gather a list of all issues and patchsets to apply (Eg: [CL1:PS1, CL2:PS1, CL3:PS2]). apply_issue will then loop over the list applying each dependency. Note: The apply_issue.py diff looks much worse than it is. Please see my comment in https://codereview.chromium.org/1149653002/diff/260001/apply_issue.py#oldcode169 Tested end-to-end using a test Git repository (https://skia.googlesource.com/skiabot-test/) and the following CLs created in my test Rietveld instance: * https://skia-codereview-staging.appspot.com/931002 ('Branch1 CL') * https://skia-codereview-staging.appspot.com/5001001 ('Branch2 CL') * https://skia-codereview-staging.appspot.com/9881001 ('Branch3 CL') * https://skia-codereview-staging.appspot.com/3951001 ('Branch3.1 CL') Opt into the new UI and observe the new 'Depends on Patchset' and 'Dependent Patchsets' sections in the above CLs. Design doc is here: https://docs.google.com/document/d/1KZGFKZpOPvco81sYVRCzwlnjGctup71RAzY0MSb0ntc/edit#heading=h.6r6lt4tsvssw BUG=502255 Review URL: https://codereview.chromium.org/1149653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295778 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Jun, 2015 3 commits
-
-
maruel@chromium.org authored
Otherwise this creates a mess for WIP branches that do not pass the git pre-commit hook. R=iannucci@chromium.org BUG= Review URL: https://codereview.chromium.org/1179273003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295742 0039d316-1c4b-4281-b951-d872f2087c98
-
ricow@google.com authored
This does not seem to be run by the bots, otherwise they should be red R=hinoka@google.com, iannucci@google.com BUG= Review URL: https://codereview.chromium.org/1188643008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295741 0039d316-1c4b-4281-b951-d872f2087c98
-
sergiyb@chromium.org authored
R=akuegel@chromium.org BUG=497243 Review URL: https://codereview.chromium.org/1183513004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295739 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Jun, 2015 4 commits
-
-
hinoka@chromium.org authored
This does two noticable things: * Prints a message when "download_from_google_storage --config" is run to tell the user to enter "0" for the project ID prompt * Removes the ".boto.depot_tools" boto file and defaults the boto file to grant fullcontrol scopes. Context: We restricted the depot_tools specific scopes to be readonly out of concern that we would be forcing every developer to hold a set of non-expiring write access credentials on their workstation. But this distinction has caused a great deal of pain and anguish with confusing credentials (who would've thought ~/.boto.depot_tools would exist and might be broken?), and not for huge security gains. Most people don't have write access to buckets, and the ones that do definitely has a fullcontrol boto file already. BUG= Review URL: https://codereview.chromium.org/1182583003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295728 0039d316-1c4b-4281-b951-d872f2087c98
-
mmoss@chromium.org authored
BUG=501173 R=dpranke@chromium.org, scottmg@chromium.org Review URL: https://codereview.chromium.org/1183703003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295725 0039d316-1c4b-4281-b951-d872f2087c98
-
tandrii@google.com authored
R=pgervais@chromium.org, hinoka@chromium.org BUG=489569 Review URL: https://codereview.chromium.org/1145313002. git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295723 0039d316-1c4b-4281-b951-d872f2087c98
-
sergiyb@chromium.org authored
TBR=pgervais@chromium.org R=akuegel@chromium.org, tandrii@chromium.org, phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/1183363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295718 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 Jun, 2015 4 commits
-
-
sheyang@google.com authored
The properties are removed by this CL: https://codereview.chromium.org/1178923007 and https://codereview.chromium.org/1177953005/ https://codereview.chromium.org/1182053004/ BUG=500735 R=dnj@chromium.org, sergiyb@chromium.org Review URL: https://codereview.chromium.org/1184143006. git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295690 0039d316-1c4b-4281-b951-d872f2087c98
-
agable@chromium.org authored
This reverts commit 78624b68. The reason is that install-build-deps.sh isn't meant to be run on mac or windows, and this implementation ran it everywhere. TBR=dpranke@chromium.org BUG=229270 Review URL: https://codereview.chromium.org/1186893003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295686 0039d316-1c4b-4281-b951-d872f2087c98
-
sheyang@chromium.org authored
BUG=457428 Review URL: https://codereview.chromium.org/1177953005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295680 0039d316-1c4b-4281-b951-d872f2087c98
-
agable@chromium.org authored
R=mmoss@chromium.org BUG=229270 Review URL: https://codereview.chromium.org/1187913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295679 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 Jun, 2015 2 commits
-
-
iannucci@chromium.org authored
R=maruel@chromium.org BUG=479837,499650 Review URL: https://codereview.chromium.org/1181103002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295664 0039d316-1c4b-4281-b951-d872f2087c98
-
iannucci@chromium.org authored
TBR=agable@chromium.org BUG=499031 Review URL: https://codereview.chromium.org/1182713002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295642 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Jun, 2015 5 commits
-
-
iannucci@chromium.org authored
* When aborting a failed rebase, don't cascade errors if the abort itself fails. * When starting a rebase-update cycle, cd to the root of the repo. This avoids an issue when you run rebase-update from inside of a branch which adds a new folder. R=agable@chromium.org BUG=499031 Review URL: https://codereview.chromium.org/1180673003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295637 0039d316-1c4b-4281-b951-d872f2087c98
-
pgervais@chromium.org authored
BUG=496892 Review URL: https://codereview.chromium.org/1156223008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295634 0039d316-1c4b-4281-b951-d872f2087c98
-
tandrii@chromium.org authored
R=agable@chromium.org BUG=437397 Review URL: https://codereview.chromium.org/1150353003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295630 0039d316-1c4b-4281-b951-d872f2087c98
-
seanmccullough@chromium.org authored
BUG=491889 Review URL: https://codereview.chromium.org/1176243002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295626 0039d316-1c4b-4281-b951-d872f2087c98
-
sdefresne@chromium.org authored
CL https://codereview.chromium.org/1172223002 changed the meaning of the third value in the tuple returned by get_cl_statuses from a color to the status of the branch and broke the formatting of output. Convert the status to the color using color_for_status helper function. BUG=499189 Review URL: https://codereview.chromium.org/1175103004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295618 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Jun, 2015 4 commits
-
-
mmoss@chromium.org authored
BUG=230693 R=agable@chromium.org Review URL: https://codereview.chromium.org/1169403002. git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295611 0039d316-1c4b-4281-b951-d872f2087c98
-
mmoss@chromium.org authored
R=agable@chromium.org, iannucci@chromium.org Review URL: https://codereview.chromium.org/1135563005. git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295609 0039d316-1c4b-4281-b951-d872f2087c98
-
hinoka@chromium.org authored
Revert of Specify GIT_DIR when running git-config in a mirror. (patchset #4 id:60001 of https://codereview.chromium.org/1167193002/) Reason for revert: Potentially broke the NaCl toolchain builders: crbug.com/498942 Speculative revert. Original issue's description: > Specify GIT_DIR when running git-config in a mirror. > > BUG=497894 > R=hinoka@chromium.org,agable@chromium.org > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295587 TBR=agable@chromium.org,szager@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=497894 Review URL: https://codereview.chromium.org/1179593002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295607 0039d316-1c4b-4281-b951-d872f2087c98
-
nodir@chromium.org authored
Example of output: $ git cl status Branches associated with reviews: git-cl-status : None master : None owner : https://codereview.chromium.org/983843003 (closed) testfilter : None Current branch: no issue assigned. R=vadimsh@chromium.org BUG=362198 Review URL: https://codereview.chromium.org/1172223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295596 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Jun, 2015 6 commits
-
-
szager@chromium.org authored
BUG=497894 R=hinoka@chromium.org,agable@chromium.org Review URL: https://codereview.chromium.org/1167193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295587 0039d316-1c4b-4281-b951-d872f2087c98
-
akuegel@chromium.org authored
In git version 2.4 the git branch command prints "* (HEAD detached at" or "* (HEAD detached from" instead of "* (detached from". Adjust the parsing to make our tests still work with git 2.4. BUG=487172 Review URL: https://codereview.chromium.org/1162763003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295578 0039d316-1c4b-4281-b951-d872f2087c98
-
ricow@google.com authored
BUG= Review URL: https://codereview.chromium.org/1157543005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295572 0039d316-1c4b-4281-b951-d872f2087c98
-
agable@chromium.org authored
This cl ensures that gclient enforces sane revision overrides and onfiguration when running a revert, just like it does on a normal sync/update. R=iannucci@chromium.org BUG=420919 Review URL: https://codereview.chromium.org/1160113003. git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295571 0039d316-1c4b-4281-b951-d872f2087c98
-
smut@google.com authored
BUG=493885 TESTED=See https://paste.googleplex.com/5622248052359168 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295569 R=nodir@chromium.org Review URL: https://codereview.chromium.org/1164363003. git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295570 0039d316-1c4b-4281-b951-d872f2087c98
-
smut@google.com authored
BUG=493885 TESTED=See https://paste.googleplex.com/5622248052359168 Review URL: https://codereview.chromium.org/1164363003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295569 0039d316-1c4b-4281-b951-d872f2087c98
-
- 08 Jun, 2015 2 commits
-
-
szager@chromium.org authored
BUG=497943 R=hinoka@chromium.org,agable@chromium.org Review URL: https://codereview.chromium.org/1163403003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295568 0039d316-1c4b-4281-b951-d872f2087c98
-
smut@google.com authored
Because some interfaces aren't linkifying the URL when the commit message ends with it. BUG=480922 TESTED=tests/git_cl_test.py; presubmit ok Review URL: https://codereview.chromium.org/1165293002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295566 0039d316-1c4b-4281-b951-d872f2087c98
-
- 05 Jun, 2015 4 commits
-
-
sbc@chromium.org authored
Based on yapf (https://github.com/google/yapf) this formatter currently only works with --full. It defaults to pep8 style and projects that use a different style can add .style.yapf to the top level. Review URL: https://codereview.chromium.org/1156743008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295547 0039d316-1c4b-4281-b951-d872f2087c98
-
akuegel@chromium.org authored
The last remaining failing test is fixed now, so we should be fine with enabling this trybot for CQ. BUG=420910 Review URL: https://codereview.chromium.org/1149943010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295540 0039d316-1c4b-4281-b951-d872f2087c98
-
akuegel@chromium.org authored
After changing this to '%f%' instead of just '%' this doesn't work anymore. It should be '%f%%' instead. BUG= TBR=iannucci@chromium.org Review URL: https://codereview.chromium.org/1156023008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295539 0039d316-1c4b-4281-b951-d872f2087c98
-
akuegel@chromium.org authored
This CL changes the check for base URL to a query to the json endpoint. This makes the test pass on the trybot. BUG=353718 Review URL: https://codereview.chromium.org/1160273005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295538 0039d316-1c4b-4281-b951-d872f2087c98
-