Goal is to ensure that unreviewed and untrusted code isn't sent through
CQ to try bots, by accident or through malicious intent.

R=agable@chromium.org
BUG=692613

Change-Id: I3f202685dff1ba0d609fadfd5725f98be833d325
Reviewed-on: https://chromium-review.googlesource.com/443351Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

Depends on: https://codereview.chromium.org/2674283002/

BUG=679514

Change-Id: I61611fc19724028bb8cdefefc50b4d5d3bb77a46
Reviewed-on: https://chromium-review.googlesource.com/437919
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

Follow up on https://chromium-review.googlesource.com/#/c/439877/
which fixed a bug.

R=kbr@chromium.org
BUG=688765

Change-Id: I8cfc5feb2d8060182572b2d4ecb6a038bf1e0abf
Reviewed-on: https://chromium-review.googlesource.com/443350Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

This makes them accessible to presubmit scripts' PostUploadHook.

Fixed bugs where caching needed to be bypassed in order for
sequential PostUploadHooks to see each others' results.

BUG=688765

Change-Id: I56c0c6b6419e2474f4b7f701be036fb2a524f8e3
Reviewed-on: https://chromium-review.googlesource.com/439877Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>

This reverts commit 2074a4b7.

Reason for revert: this is a reland, because it didn't actually break Angle.

Original change's description:
> Revert "bot_update: speculative fix for gerrit patch application failure."
> 
> This reverts commit 2b4da122.
> 
> Reason for revert: likely broke Angle http://crbug.com/692140
> 
> Original change's description:
> > bot_update: speculative fix for gerrit patch application failure.
> > 
> > bot_update doesn't properly cleanup git index state from unmerged paths,
> > which are likely if Rietveld patches were failed to be applied in prior
> > runs in the same checkout dir.
> > 
> > R=​machenbach@chromium.org
> > BUG=692067
> > 
> > Change-Id: I8fd326caefce8623731697a368cbad3159405257
> > Reviewed-on: https://chromium-review.googlesource.com/442426
> > Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
> > Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> > 
> 
> TBR=machenbach@chromium.org,tandrii@chromium.org,chromium-reviews@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=692067,692140
> 
> Change-Id: Iec808f28f3a0af99914a279536bb20a8975e02ba
> Reviewed-on: https://chromium-review.googlesource.com/442485
> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> 

TBR=machenbach@chromium.org,tandrii@chromium.org,chromium-reviews@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=692067,692140

Change-Id: I4b4b66fa74f11e73e066602a9e7efabd5a29a974
Reviewed-on: https://chromium-review.googlesource.com/443345
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

See https://groups.google.com/a/chromium.org/d/msg/infra-dev/p8Iq9v9Y4k0/w__b1zTWAQAJ
for more context.

BUG=685746

Change-Id: Iab46d78e92d67e9a2523cce8b22d9798a6121dd8
Reviewed-on: https://chromium-review.googlesource.com/439328
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

BUG=692140,664880

Change-Id: I3ddd899f1841930e601a906d658c5c78e2d76673
Reviewed-on: https://chromium-review.googlesource.com/442707Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

This reverts commit 2b4da122.

Reason for revert: likely broke Angle http://crbug.com/692140

Original change's description:
> bot_update: speculative fix for gerrit patch application failure.
> 
> bot_update doesn't properly cleanup git index state from unmerged paths,
> which are likely if Rietveld patches were failed to be applied in prior
> runs in the same checkout dir.
> 
> R=​machenbach@chromium.org
> BUG=692067
> 
> Change-Id: I8fd326caefce8623731697a368cbad3159405257
> Reviewed-on: https://chromium-review.googlesource.com/442426
> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> 

TBR=machenbach@chromium.org,tandrii@chromium.org,chromium-reviews@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=692067,692140

Change-Id: Iec808f28f3a0af99914a279536bb20a8975e02ba
Reviewed-on: https://chromium-review.googlesource.com/442485
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

bot_update doesn't properly cleanup git index state from unmerged paths,
which are likely if Rietveld patches were failed to be applied in prior
runs in the same checkout dir.

R=machenbach@chromium.org
BUG=692067

Change-Id: I8fd326caefce8623731697a368cbad3159405257
Reviewed-on: https://chromium-review.googlesource.com/442426
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

This ensures coverage is installed, rather than depending on it being
installed in your system.

BUG=671189

Change-Id: Id9d7c514b4db53963381c5269bee06c706b23751
Reviewed-on: https://chromium-review.googlesource.com/442050
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

BUG=664880

Change-Id: Ic3d4da4595acb509c9dae682dbd696900f435436
Reviewed-on: https://chromium-review.googlesource.com/442025Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/32e585682faac9148b8760742148d8222ef68a94 [json] Fix more unicode weirdness (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2689713009

BUG=

Change-Id: I793990a18a32a795f7bca24939eaff56c0abdcdc
Reviewed-on: https://chromium-review.googlesource.com/441148Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

This reverts commit 81246202.

Reason for revert: This doesn't work for deps_os

Original change's description:
> Make an error on wrong recursedeps entry.
> 
> BUG=685433
> 
> Change-Id: I5eb68c4a3bfd1c93edecf33127a459822f5a23ed
> Reviewed-on: https://chromium-review.googlesource.com/440945
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Dirk Pranke <dpranke@chromium.org>
> 

TBR=dpranke@chromium.org,caseq@chromium.org,chromium-reviews@chromium.org,alex-ac@yandex-team.ru
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=685433

Change-Id: If10b57d77dbff36d140f842d375682a20d69db06
Reviewed-on: https://chromium-review.googlesource.com/440491Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>

This reverts commit e0635650.

Reason for revert: This doesn't work for deps_os.

Original change's description:
> Fix an exception when trying to report a non-referenced recursedeps entry
> 
> Problem originally introduced in https://chromium-review.googlesource.com/c/440945/
> 
> BUG=685443
> 
> Change-Id: I16313bc7c09b0dd68c6ad118004f9d5cdfec0ddd
> Reviewed-on: https://chromium-review.googlesource.com/440394
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Dirk Pranke <dpranke@chromium.org>
> 

TBR=dpranke@chromium.org,caseq@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=685443

Change-Id: I69b59e91b4019af112bd676c125119eee1edddda
Reviewed-on: https://chromium-review.googlesource.com/440490Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>

Problem originally introduced in https://chromium-review.googlesource.com/c/440945/

BUG=685443

Change-Id: I16313bc7c09b0dd68c6ad118004f9d5cdfec0ddd
Reviewed-on: https://chromium-review.googlesource.com/440394Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>

BUG=685433

Change-Id: I5eb68c4a3bfd1c93edecf33127a459822f5a23ed
Reviewed-on: https://chromium-review.googlesource.com/440945Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>

Adds the ability to only trigger the APK download hooks on bots we care
about instead of having them in the main Chromium DEPS file.

Hashes for the APKs are added in https://codereview.chromium.org/2666213002/

BUG=

Change-Id: I9fc3cadf621a954e0c2485ec16bf9d4f72c10f2f
Reviewed-on: https://chromium-review.googlesource.com/437710Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@google.com>

Again, utf-8 encoded strings are the good thing to do in python2 :D

BUG=

Change-Id: I693a726f8407ea2ea135994ce6f49df76976e559
Reviewed-on: https://chromium-review.googlesource.com/440474Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

BUG=689359

Change-Id: I6d76a5ac1c51db903bcfd00d91215981e9608bc8
Reviewed-on: https://chromium-review.googlesource.com/439783Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

(edited, so that next next line gets u200 char 
between R= and reviewer email)

R=​​mstarzinger@chromium.org
TBR=agable@chromium.org
BUG=b/34702620 (internal)

Change-Id: I58f2528dd28e3a43d8eb2d7d4f5c046460d8a9ee
Reviewed-on: https://chromium-review.googlesource.com/440085
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/bab22ae9b2fb5541bee4cb60136a3c562f7a7fe9 Short-circut if result is None. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2682913005

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/0aa2b6364faf52b0536c37534efc4574708cecd6 [raw_io] prevent output_text from returning `unicode` object. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2681133003

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/699e274630d839a4d49ac48744ad71216b9553c6 split human reason (nodir@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2688473003

R=kbr@chromium.org
BUG=633572,688765

Change-Id: I05130cfd05f89a4605c34b15cadf13a33e3565d9
Reviewed-on: https://chromium-review.googlesource.com/439445
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

R=kbr@chromium.org
BUG=633572,688765

Change-Id: I2ce6530148bc2f00fe9f6a80aaccc520c69a2f83
Reviewed-on: https://chromium-review.googlesource.com/439186
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>

That's marketing 101. :)

R=sergeyberezin@chromium.org
BUG=

Change-Id: Ibbc1cd18650b7b601c27662fcb40ea7b15b40fc7
Reviewed-on: https://chromium-review.googlesource.com/439006Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>

BUG=686280,664352
TBR=iannucci

Change-Id: Ibd1feadffc440ea01790abe2bc73fc6a69092f54
Reviewed-on: https://chromium-review.googlesource.com/437821Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

The PostUploadHooks in the Chromium repository which add
CQ_INCLUDE_TRYBOTS entries to the issue description will be rewritten
in terms of this primitive, which will compose properly if multiple
sub-directories attempt to modify it.

BUG=688765

Change-Id: Icf72edb872f29af1e082038e96bc547504edfd07
Reviewed-on: https://chromium-review.googlesource.com/438925Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>

Change-Id: Ic6109dff73f6726c1b50d107dc0996d1a0d0fcf4
Reviewed-on: https://chromium-review.googlesource.com/437637
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

R=​agable@chromium.org
BUG=

Change-Id: I744627d99454ddc71184b9251cf8a4a309f31b71
Reviewed-on: https://chromium-review.googlesource.com/437663Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

R=machenbach@chromium.org
BUG=689035

Change-Id: Ib7a56c52501a5d0dd6638a99bde3d376bd27bfb6
Reviewed-on: https://chromium-review.googlesource.com/438347Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

Roll CIPD client in CIPD recipe module to version
git_revision:0f49ce7d793b80877633ed640c89547ece130abb

BUG=688918

Change-Id: Id4dbdc89a5b6b7d151996acb5ac6be4df7f4a5f0
Reviewed-on: https://chromium-review.googlesource.com/437993
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Emma Söderberg <emso@chromium.org>

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/5d4666c5340082e7bfad85ee01d47ebbc48aeab6 [path] Improve abs_to_path to include resource paths. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2677753002

Also bumps cipd client version to ac753ee37abd753a9a511210d3df362d003211f0.

BUG=

Change-Id: I5bb005eb603fd7106d8cf6125dc2cda3c6e1ac94
Reviewed-on: https://chromium-review.googlesource.com/436904
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/1c4786ae10b3b4f17c2893cea345725c4a8cd135 [step|docs] Improve the nest docstring a bit. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2673583004

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/77da9cfa8ca5cdf3d01c1ef30425d17af1f99592 [recipe_engine] Fix unnecessary plurality (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2672843004

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/37a1da981d744246d14a2c2e6fac554703ea4b1b [recipe_engine] Fix a couple path-related bugs. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2675613003

BUG=688099

Change-Id: Ic505ab6553b1a9f1e6ab51377bb6519d805a847e
Reviewed-on: https://chromium-review.googlesource.com/436406Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrew Bonventre <andybons@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/a7a17ae6545a9ff04b71b3655ff4d08a0de32926 [recipe_modules/path] add abs_to_path. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2674593002