Commits · d79d41954e45ae40436a48e67b5c16249f1a2fb4 · Linshizhi / Chromium_Depot_tools

19 Dec, 2011 2 commits

Fix gcl path handling to be more consistent. · d79d4195

maruel@chromium.org authored Dec 19, 2011

gcl change will look for unmodified files from the current directory and below
only.
Add shell out are cwd=checkout's root.
Fix try/finally handlers.
Remove extraneous os.chdir() calls since cwd is now correctly set.

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8994004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@115027 0039d316-1c4b-4281-b951-d872f2087c98

d79d4195

[depot_tools] Adding safesync_url for git and git-svn checkouts. · e5d1e61d

dbeam@chromium.org authored Dec 19, 2011

R=maruel@chromium.org
TEST=Configure a checkout using the NewGitWorkflow with a safesync_url and everything works (though possibly with a really long git svn fetch time).
BUG=106015

Review URL: http://codereview.chromium.org/8382030

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@115011 0039d316-1c4b-4281-b951-d872f2087c98

e5d1e61d

15 Dec, 2011 1 commit

Add setuptools egg to third_party. · 93ee568c

chrisha@chromium.org authored Dec 15, 2011

This CL adds the egg distribution of setuptools to third_party. A follow-up CL will use this to install various required third-party eggs in a depot_tools/site-packages directory.

TBR=maruel@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/8953018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@114635 0039d316-1c4b-4281-b951-d872f2087c98

93ee568c

13 Dec, 2011 3 commits

Fix a regression introduced in r114262, cwd must be a named argument to subprocess2.Popen(). · f94e3f1d

maruel@chromium.org authored Dec 13, 2011

Not sure why pylint didn't catch it. :/

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8937010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@114270 0039d316-1c4b-4281-b951-d872f2087c98

f94e3f1d

Enforce cwd for GIT functions · 80a9ef1e

maruel@chromium.org authored Dec 13, 2011

GIT.CaptureStatus was assuming os.getcwd() was using all the time, which isn't
true when using trychange.py --sub_rep XXX.

R=dpranke@chromium.org
TEST=
BUG=


Review URL: http://codereview.chromium.org/8930002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@114264 0039d316-1c4b-4281-b951-d872f2087c98

80a9ef1e

Enforces using cwd in all svn calls. · d579fcf9

maruel@chromium.org authored Dec 13, 2011

That helps weed out some issues faces with svn plus helped me figure out some
misuses.

Most of the commands have been implicitly depending on os.getcwd(). This change
makes it always consistent and clear when dependence on the current directory is
needed.

Remove default arguments to scm.SVN.GenerateDiff and a few other calls to be
sure the refactoring was done right.

R=dpranke@chromium.org
BUG=
TEST=make sure most commands aren't broke


Review URL: http://codereview.chromium.org/8771042

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@114262 0039d316-1c4b-4281-b951-d872f2087c98

d579fcf9

10 Dec, 2011 1 commit

Still send try job status even if test filter is used · 4159b736

maruel@chromium.org authored Dec 10, 2011

This caused all CQ job to not show up on rietveld. Now that rietvelt supports
multiple try job per builder per patchset, this check is not useful anymore.

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8895022

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@113952 0039d316-1c4b-4281-b951-d872f2087c98

4159b736

09 Dec, 2011 1 commit

drover: Use Python style for accessing last item in array. · 2887b7d6

jhawkins@chromium.org authored Dec 09, 2011

Review URL: http://codereview.chromium.org/8883034

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@113720 0039d316-1c4b-4281-b951-d872f2087c98

2887b7d6

08 Dec, 2011 1 commit

drover: Fix --milestone to take the highest-valued branch. · 758417e3

jhawkins@chromium.org authored Dec 08, 2011

The previous code erroneously took the lowest-valued branch.
Review URL: http://codereview.chromium.org/8888028

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@113681 0039d316-1c4b-4281-b951-d872f2087c98

758417e3

05 Dec, 2011 2 commits

Using lists is faster than cStringIO. · 740a6c0b

maruel@chromium.org authored Dec 05, 2011

Clean up stdin management.
Remove stale comments.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8808002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@113065 0039d316-1c4b-4281-b951-d872f2087c98

740a6c0b

Improve subprocess2 stdin tests. · bc3a53cb

maruel@chromium.org authored Dec 05, 2011

No significant code change.

R=dpranke@chromium.org
TEST=
BUG=


Review URL: http://codereview.chromium.org/8801019

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@113062 0039d316-1c4b-4281-b951-d872f2087c98

bc3a53cb

02 Dec, 2011 2 commits

Reverted accidental commit · 56f4c474

supersat@chromium.org authored Dec 02, 2011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112766 0039d316-1c4b-4281-b951-d872f2087c98

56f4c474

Fix pulling in patches from git subrepos · e8043d11

supersat@chromium.org authored Dec 02, 2011



git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112765 0039d316-1c4b-4281-b951-d872f2087c98

e8043d11

01 Dec, 2011 3 commits

Reimplement r109239 but using Popen.communicate() instead. · 94c712fa

maruel@chromium.org authored Dec 01, 2011

Enables threaded callback handler for subprocess.communicate().

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8749015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112465 0039d316-1c4b-4281-b951-d872f2087c98

94c712fa

Handle exceptions thrown when shelling out svn commit · 5d0fc9a7

maruel@chromium.org authored Dec 01, 2011

So temporary files aren't left around.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8758004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112358 0039d316-1c4b-4281-b951-d872f2087c98

5d0fc9a7

Add Popen.shell, add more subprocess2 tests and make it more compact. · a8e8163a

maruel@chromium.org authored Dec 01, 2011

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8750003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112351 0039d316-1c4b-4281-b951-d872f2087c98

a8e8163a

30 Nov, 2011 7 commits

Silence pylint on Mac OSX 10.6 · 14e37ad7

maruel@chromium.org authored Nov 30, 2011

Also, increase the wait for socket binding to 0.2 seconds because OSX10.6 is
broken _and_ slow.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8749005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112277 0039d316-1c4b-4281-b951-d872f2087c98

14e37ad7

Fix git try. git_try.py imports git_cl.py without calling its main. · 379d07a4

maruel@chromium.org authored Nov 30, 2011

Make sure settings is correctly initialized.

TBR=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/8745014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112222 0039d316-1c4b-4281-b951-d872f2087c98

379d07a4

Make --send-mail more useful by not requiring -r · a335365d

maruel@chromium.org authored Nov 30, 2011

Previously, --send-mail required -r to pass. Now it uses the R=|TBR= lines from
the description, which is much more useful.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8735018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112221 0039d316-1c4b-4281-b951-d872f2087c98

a335365d

Fix case where TBR=foo would remove the -r flag in git-cl · ddd59417

maruel@chromium.org authored Nov 30, 2011

Add unit test!

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8715007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112220 0039d316-1c4b-4281-b951-d872f2087c98

ddd59417

Improve testing by comparing behavior of subprocess to subprocess2 · db59bfc1

maruel@chromium.org authored Nov 30, 2011

This makes sure no regression relative to subprocess is introduced in
subprocess2.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8722001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112217 0039d316-1c4b-4281-b951-d872f2087c98

db59bfc1

Add Popen.start property. · dd9837f9

maruel@chromium.org authored Nov 30, 2011

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8694006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112102 0039d316-1c4b-4281-b951-d872f2087c98

dd9837f9

Commit cpplint.py r77 to depot_tools. · 7956a87b

erg@chromium.org authored Nov 30, 2011

Committing on behalf of Reid Kleckner <rnk@google.com>.

BUG=102890

Review URL: http://codereview.chromium.org/8676053

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112099 0039d316-1c4b-4281-b951-d872f2087c98

7956a87b

29 Nov, 2011 2 commits

Fix error message when using "gcl try nonexistentcl". · 53790118

asvitkine@chromium.org authored Nov 29, 2011

Call ChangeInfo.Load() with fail_on_not_found=True to get a good error message in this case.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/8692007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@112018 0039d316-1c4b-4281-b951-d872f2087c98

53790118

Move auto_stub.py from commit-queue · 7bb06bba

maruel@chromium.org authored Nov 29, 2011

Use it in subprocess2 and trial_dir to remove manually bookeeping.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8688011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@111941 0039d316-1c4b-4281-b951-d872f2087c98

7bb06bba

24 Nov, 2011 2 commits

Add more subprocess2 tests with stderr=subproces2.STDOUT. · 93e2137d

maruel@chromium.org authored Nov 24, 2011

No code change beside tests. This is mainly a regression test to make sure I
don't regress that code path.

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8695003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@111535 0039d316-1c4b-4281-b951-d872f2087c98

93e2137d

Make subprocess2.Popen a class instead of a function. · ef77f9e6

maruel@google.com authored Nov 24, 2011

This will be necessary to override member functions eventually. It also better
replicates what subprocess.Popen is.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8570005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@111530 0039d316-1c4b-4281-b951-d872f2087c98

ef77f9e6

21 Nov, 2011 1 commit

Introduced git+http(s) fake URL schema to support git urls which don't have... · 4e07567f

igorgatis@gmail.com authored Nov 21, 2011

Introduced git+http(s) fake URL schema to support git urls which don't have "filename.git" portion (http://foo/bar vs http://foo/bar/filename.git).

Review URL: http://codereview.chromium.org/8590024

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@110937 0039d316-1c4b-4281-b951-d872f2087c98

4e07567f

15 Nov, 2011 1 commit

Add most of testing improvements without the tee-specific tests · 4942e4a5

maruel@chromium.org authored Nov 15, 2011

Change return value from list to tuple for communicate(timeout != None).

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8539015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@110094 0039d316-1c4b-4281-b951-d872f2087c98

4942e4a5

12 Nov, 2011 2 commits

Swap in cmp for chase. · 5357fa66

cmp@chromium.org authored Nov 12, 2011

Review URL: http://codereview.chromium.org/8536043

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109750 0039d316-1c4b-4281-b951-d872f2087c98

5357fa66

Update version of repo. Most importantly this takes repo from · ad39056f

jeffbailey@chromium.org authored Nov 12, 2011

the current canonical upstream. The Chromium mirror is out of date.
Review URL: http://codereview.chromium.org/8540026

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109742 0039d316-1c4b-4281-b951-d872f2087c98

ad39056f

11 Nov, 2011 5 commits

Drover: Add --milestone option to merge to a specific milestone. · b63a5c5a

jhawkins@chromium.org authored Nov 11, 2011

Queries omahaproxy.appspot.com for related branch number.

Review URL: http://codereview.chromium.org/8498038

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109718 0039d316-1c4b-4281-b951-d872f2087c98

b63a5c5a

Delete tests/__init__.py. It should have been deleted in r109636 but the CQ failed. · 840af3d7

maruel@chromium.org authored Nov 11, 2011

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8536018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109697 0039d316-1c4b-4281-b951-d872f2087c98

840af3d7

Fix deleted empty files. · 4005225a

maruel@chromium.org authored Nov 11, 2011

Add relevant new tests.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8539016

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109692 0039d316-1c4b-4281-b951-d872f2087c98

4005225a

Create a new testing_support module to move utility modules there · 0927b7ee

maruel@chromium.org authored Nov 11, 2011

It will simplify importing utility modules from other projects. Otherwise I was getting name conflicts with 'test'.

Reenable W0403 that was disabled in the previous CL.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8508015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109636 0039d316-1c4b-4281-b951-d872f2087c98

0927b7ee

Remove _rietveld from svn:ignore in depot_tools/tests. · a9c7d6f3

maruel@chromium.org authored Nov 11, 2011


git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109635 0039d316-1c4b-4281-b951-d872f2087c98

a9c7d6f3

10 Nov, 2011 3 commits

Standardize the sys.path fix up and fix a few pylint warnings. · 428342a0

maruel@chromium.org authored Nov 10, 2011

Disable temporarily W0403, will be reenabled on the next CL

R=dpranke@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/8508017

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109435 0039d316-1c4b-4281-b951-d872f2087c98

428342a0

Update upload.py to ba420db469ba. · 8e2bb16a

maruel@chromium.org authored Nov 10, 2011

The main fix is 'Accept new empty files, like __init__.py'

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8519005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109431 0039d316-1c4b-4281-b951-d872f2087c98

8e2bb16a

Revert r109283, r109282 and r109239. · 7eda862b

maruel@chromium.org authored Nov 10, 2011

"Add callback support for stdout and stderr."
"Add tests for both universal_newlines=True and False."
"Implement accelerated tee support for POSIX."

The reason is that the semantic of
subprocess2.check_call(cmd, timeout=60, stderr=subprocess2.STDOUT) changed,
stderr wasn't redirected to VOID anymore and for an unknown reason, it was
hanging until the timeout happened. Will reapply r109239 with a new regression
test to detect that bug.

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8505046

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109369 0039d316-1c4b-4281-b951-d872f2087c98

7eda862b

09 Nov, 2011 1 commit

Fix automatic detection when git is not installed · 67ec5fae

maruel@chromium.org authored Nov 09, 2011

subprocess2.check_output() raises an OSError instead of a CalledProcessError
when the executable is not found.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/8511025

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@109325 0039d316-1c4b-4281-b951-d872f2087c98

67ec5fae