- 21 Nov, 2018 5 commits
-
-
Robert Iannucci authored
Now with correct error handling. R=nodir@chromium.org, vadimsh@chromium.org Bug: 869227 Change-Id: I961fd80209c9d9988e9d03016b7c0bd253c6cdfb Reviewed-on: https://chromium-review.googlesource.com/c/1347249 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
-
John Budorick authored
Bug: 856278 Change-Id: I949cefd102ecc80b161d082ec40b7e059f596781 Reviewed-on: https://chromium-review.googlesource.com/c/1345050Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
Andrii Shyshkalov authored
R=ajp, ehmaldonado Change-Id: I59859048d64902669479e666c6c3d37c1fb1394c Reviewed-on: https://chromium-review.googlesource.com/c/1344642 Auto-Submit: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
On my machine, saves 0.16s of time while loading git cl: from 0.32s to 0.16s. R=ajp, ehmaldonado Change-Id: I0febca43f11514da3e3f7be7e2c0184fb9e17409 Reviewed-on: https://chromium-review.googlesource.com/c/1344641Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
R=ajp, ehmaldonado Change-Id: I9c9f5e0f8ef41c0f6a00faa67acf0cf516290f09 Reviewed-on: https://chromium-review.googlesource.com/c/1345272Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 20 Nov, 2018 6 commits
-
-
Vadim Shtayura authored
This reverts commit f4913068. Reason for revert: panics, see b/119830955 Original change's description: > [vpython] Roll to pick up user differentiation of cached envs. > > R=vadimsh@chromium.org > > Bug: 869227 > Change-Id: I7e529c7c4d63e35a66ef93623982afc7d254d72f > Reviewed-on: https://chromium-review.googlesource.com/c/1344638 > Commit-Queue: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> > Auto-Submit: Robbie Iannucci <iannucci@chromium.org> > Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> TBR=iannucci@chromium.org,vadimsh@chromium.org Change-Id: Ie77d559dc1787ec1b8a19076238b7018d39dd0b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 869227 Reviewed-on: https://chromium-review.googlesource.com/c/1344639Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
Robert Iannucci authored
R=vadimsh@chromium.org Bug: 869227 Change-Id: I7e529c7c4d63e35a66ef93623982afc7d254d72f Reviewed-on: https://chromium-review.googlesource.com/c/1344638 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
-
John Budorick authored
This reverts commit 3f40c42b. Reason for revert: ast.literal_eval(False) doesn't work? Original change's description: > Don't fetch flash when fetching android_internal. > > Bug: 856278 > Change-Id: I89eccc7581daedda69dee4f99d174e8cb49c6ba1 > Reviewed-on: https://chromium-review.googlesource.com/c/1342730 > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> TBR=ehmaldonado@chromium.org,jbudorick@chromium.org Change-Id: Iffb655701830984e47a2b8e7629f0ed87886a401 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 856278 Reviewed-on: https://chromium-review.googlesource.com/c/1344637Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
Aiden Benner authored
Enables python formatting in git cl format by default for all files that have a .style.yapf file in a parent directory up to the repository root. If no .style.yapf file is found the --python flag still needs to be set explicitly for python formatting to be enabled. Also adds a --no-python to explicitly disable python formatting on any file even if a .style.yapf file is found. This allows default formatting to be enabled on a per project/directory basis by adding a .style.yapf file. Bug:846432 Change-Id: I40d899ec1a3e0dfca445e04b91befab113416175 Reviewed-on: https://chromium-review.googlesource.com/c/1316415 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by: Nodir Turakulov <nodir@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org>
-
John Budorick authored
Bug: 856278 Change-Id: I89eccc7581daedda69dee4f99d174e8cb49c6ba1 Reviewed-on: https://chromium-review.googlesource.com/c/1342730Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
Aiden Benner authored
git cl format --python currently breaks on windows because FindExecutable('yapf') returns .../depot_tools/yapf (a py file) instead of .../depot_tools/yapf.bat. Also yapf.bat tries to run the yapf py file without vpython which breaks the yapf dependency. This CL fixes these two issues. Bug:846432 Change-Id: I551a4c1e6367074fa76767851bd34feb2dcfb6a2 Reviewed-on: https://chromium-review.googlesource.com/c/1341236Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Aiden Benner <abenner@google.com>
-
- 19 Nov, 2018 3 commits
-
-
Eric Foo authored
Bug:868202 Change-Id: Ic480356aa4b385e97eb3e47a6f1a439aeb82720a Reviewed-on: https://chromium-review.googlesource.com/c/1341227 Commit-Queue: Eric Foo <efoo@chromium.org> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
-
Edward Lesmes authored
Bug: 906114 Change-Id: Ib8614086f7c456c04d27f33c73809671ed073bf4 Reviewed-on: https://chromium-review.googlesource.com/c/1341862Reviewed-by: Eric Boren <borenet@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
This is a reland of 5705acab If a gclient config is not found, then built-in variables wont be supported. Original change's description: > [gclient] Make getdep and setdep to provide builtin vars > > Bug: 906114 > Change-Id: I069cc21343911f7fdb3c91ecbd8fcba53fc8099f > Reviewed-on: https://chromium-review.googlesource.com/c/1340461 > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Commit-Queue: Eric Boren <borenet@chromium.org> Bug: 906114 Change-Id: I72f30d10b5f0180fd5c616a42393f5b12055ce8e Reviewed-on: https://chromium-review.googlesource.com/c/1341039Reviewed-by: Eric Boren <borenet@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 16 Nov, 2018 5 commits
-
-
Bruce Dawson authored
These changes ensure that the packaged Windows SDK bits support targeting ARM64 Windows. This change must not land until crrev.com/c/1339101 lands, since it is needed to the varying number of vs_runtime_dll_dirs. Bug: 893460 Change-Id: Ie32563067c6fb6078acfaccd6d3d572d1dd44888 Reviewed-on: https://chromium-review.googlesource.com/c/1330185 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
-
Sergiy Byelozyorov authored
This reverts commit 5705acab. Reason for revert: breaks internal bots, e.g. see http://shortn/_KDb4blyDVz Original change's description: > [gclient] Make getdep and setdep to provide builtin vars > > Bug: 906114 > Change-Id: I069cc21343911f7fdb3c91ecbd8fcba53fc8099f > Reviewed-on: https://chromium-review.googlesource.com/c/1340461 > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Commit-Queue: Eric Boren <borenet@chromium.org> TBR=borenet@chromium.org,ehmaldonado@chromium.org Change-Id: I233ae7feae296fb4cd04b9b36d7f53d1114df5ff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 906114 Reviewed-on: https://chromium-review.googlesource.com/c/1340506Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
-
Johannes Henkel authored
This will facilitate a more standalone development process. We don't have a DEPS file there yet, but I'm planning to add a simple one, which for starters will have gunit. I'll model this mostly after breakpad. I've tested this fetch config and it appears to work great: $ mkdir testfetch $ cd testfetch $ fetch inspector_protocol After this there's an src directory in testfetch which has our sources. Change-Id: I482d65b3d8e50e9e5a98c4affc7b487a5bd6df53 Reviewed-on: https://chromium-review.googlesource.com/c/1340502 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
-
Robert Iannucci authored
Fixes issue with bogus secret bytes being included when running `led get-build`. The server would return "<REDACTED>".encode("base64"), and led would pass this along to the task, which would fail to decode it as a proto. R=nodir@chromium.org, vadimsh@chromium.org Change-Id: Ie8b33a2dc1f05ddb163465d72ea461f9e6833363 Reviewed-on: https://chromium-review.googlesource.com/c/1340504 Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
Eric Boren authored
Bug: 906114 Change-Id: I069cc21343911f7fdb3c91ecbd8fcba53fc8099f Reviewed-on: https://chromium-review.googlesource.com/c/1340461Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Eric Boren <borenet@chromium.org>
-
- 15 Nov, 2018 5 commits
-
-
Robert Iannucci authored
R=vadimsh@chromium.org Change-Id: Ibd55035fe62ae710cdce448ec489bf7af06925fd Reviewed-on: https://chromium-review.googlesource.com/c/1337522 Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
Edward Lemur authored
Use "personally identifiable information" instead of "PII" on metrics.README.md. Tbr: tandrii@chromium.org Bug: None Change-Id: I5294ab3ddfbc9e6705085a68751a477073cea052 Reviewed-on: https://chromium-review.googlesource.com/c/1337515Reviewed-by: Alan Bram <flyboy@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Yoshisato Yanagisawa authored
Change-Id: Ic7ca117435de34400fdd117741d0b321339f8cfd Reviewed-on: https://chromium-review.googlesource.com/c/1325250 Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
-
Yoshisato Yanagisawa authored
On Windows, without quote, whole return value would be treated as a command, and the execution would fail. On Linux and Mac, without quote, if depot_tools is settled under directories with ' ', command execution would fail because paths are separated in a wrong way. To make such a return value work on Linux and Mac, the shell script started to use eval. Bug: 902930 Change-Id: I9bb74585294af565988c0b844b6b113a5c685530 Reviewed-on: https://chromium-review.googlesource.com/c/1325249Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
-
Yoshisato Yanagisawa authored
Since ninja uses getopt_long to parse the argument, we need to suppose -j100 and -tclean. Please see ReadFlags function in: https://github.com/ninja-build/ninja/blob/master/src/ninja.cc Change-Id: If61f05e66be546a591549f6f153cce994c972309 Reviewed-on: https://chromium-review.googlesource.com/c/1335428Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
- 12 Nov, 2018 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/3ec591502d7760fb3d2d64b63d51e6993b5beca6 [doc/user_guide] Add a bit more about recipes.py (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ibf90ca4157cbe0eee09bdc54eef09855b05b2557 Reviewed-on: https://chromium-review.googlesource.com/c/1332567Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Robert Iannucci authored
R=bpastene@chromium.org, nodir@chromium.org Bug: 904478 Change-Id: I087c4e5a3a88339869573f214e6f415dd54f82aa Reviewed-on: https://chromium-review.googlesource.com/c/1332027 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org>
-
- 10 Nov, 2018 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/8bda99d5e0cd3e2cf8b863d1c77152dbbd0fc23e [doc/user_guide.md] Initial structure for rewrite of user_guide.md. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I338d530089d2b5e90ccdbec2a423ac398c8b1fd7 Reviewed-on: https://chromium-review.googlesource.com/c/1330187 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
-
Robert Iannucci authored
R=nodir@chromium.org Change-Id: I37a0647ad9358a9e9b88f25b737385556428ebcd Reviewed-on: https://chromium-review.googlesource.com/c/1329997 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
-
- 09 Nov, 2018 5 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/519790719eb481c3c7282d76da6010dc0f5418c7 Add ability to mock git ref (sergiyb@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I200ce62c30b96523912701c723ab88d3f772d61d Reviewed-on: https://chromium-review.googlesource.com/c/1330183Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Mohamed Heikal authored
Currently git cl owners tries to fetch the current reviewers of a CL from gerrit. However, this fails with a KeyError when there are no reviewers currently. This cl fixes that bug. Bug: 895722 Change-Id: I78a998ee234d207523aa2cef4b5058ba7cfecbc2 Reviewed-on: https://chromium-review.googlesource.com/c/1330122 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
-
Peter Boström authored
Mentioning these commands make it easier for folks to get rid of the large notice. Bug: None Change-Id: I85dd0e1ec0d33999af46f9e20b95bea05bd40a1e Reviewed-on: https://chromium-review.googlesource.com/c/1330181 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
-
Vadim Shtayura authored
The most notable change is in how the integrity of the tag cache file is checked. Once deployed, existing tag cache files will be considered invalid and wiped. The only observable side effect is the following line in the log: "can't deserialize tag cache - no sha256 is recorded in the file" R=tandrii@chromium.org, iannucci@chromium.org Change-Id: I7ea300a4e7ad8be0c1d42ae561c5202420d2db62 Reviewed-on: https://chromium-review.googlesource.com/c/1327823Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
Yoshisato Yanagisawa authored
Bug: b/77176746 Change-Id: I8f027daa6f867d61f0a9124a6d22c512bf91f219 Reviewed-on: https://chromium-review.googlesource.com/c/1325267Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
-
- 08 Nov, 2018 6 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/a5a5b1ee65266762db9839ed8ac32eb325c53dca Remove old run code (martiniss@google.com) https://crrev.com/0c993cb828b335e2fc0528c149f8060c35ebf0ac Revert "Remove old run code" (martiniss@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I7fbab5d8255120016278cde25eefcbe6bb6f2f67 Reviewed-on: https://chromium-review.googlesource.com/c/1327627Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Ben Pastene authored
I'm writing a recipe that makes heavy use of gsutil's ls and cat, and some of the calls are expected to fail. So this allows the user to make those that fail do so as normal steps. R=iannucci, tandrii Bug: 866062 Change-Id: I4c9cdcb77c00afd4ab8fefd146f22fa94fcc37d7 Reviewed-on: https://chromium-review.googlesource.com/c/1325332Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org>
-
Stephen Martinis authored
This reverts commit fc810ab2. Reason for revert: Broke everything Original change's description: > Roll recipe dependencies (trivial). > > This is an automated CL created by the recipe roller. This CL rolls recipe > changes from upstream projects (e.g. depot_tools) into downstream projects > (e.g. tools/build). > > > More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. > recipe_engine: > https://crrev.com/a5a5b1ee65266762db9839ed8ac32eb325c53dca Remove old run code (martiniss@google.com) > > > TBR=iannucci@chromium.org > > Recipe-Tryjob-Bypass-Reason: Autoroller > Bugdroid-Send-Email: False > Change-Id: Ieac443303891c032ddec11b24004774595cd954a > Reviewed-on: https://chromium-review.googlesource.com/c/1327623 > Reviewed-by: Recipe Roller <recipe-roller@chromium.org> > Commit-Queue: Recipe Roller <recipe-roller@chromium.org> TBR=iannucci@chromium.org,recipe-roller@chromium.org Change-Id: Iad38bee7bc5dcb0d342f5a3b1a072c458a8257d6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1327505Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/a5a5b1ee65266762db9839ed8ac32eb325c53dca Remove old run code (martiniss@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ieac443303891c032ddec11b24004774595cd954a Reviewed-on: https://chromium-review.googlesource.com/c/1327623Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Edward Lemur authored
Tbr: tandrii@chromium.org Bug: 881860 Change-Id: I17dd5c3b6e3fc6da126487b03ea4fc5aa06c2898 Reviewed-on: https://chromium-review.googlesource.com/c/1326561Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Dan Beam authored
Example error: https://gist.github.com/danbeam/3c6b1f98b5d4a921a583a6f070ed0bf0 R=dpranke@chromium.org BUG=none Change-Id: Ib3406ce04782b08b1761506b494b96a827fa4a84 Reviewed-on: https://chromium-review.googlesource.com/c/1299615 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
-
- 07 Nov, 2018 1 commit
-
-
Allen Bauer authored
Bug: 902930 Change-Id: I5f160cd2ff7a9da603b029c894c84db1c5ed8374 Reviewed-on: https://chromium-review.googlesource.com/c/1324650Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org>
-