Commits · d504dd79629644dcd2143a1bdddb69dee20f724f · Linshizhi / Chromium_Depot_tools

15 Aug, 2019 7 commits

Roll recipe dependencies (trivial). · d504dd79

recipe-roller authored Aug 15, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/54c9a286d41d9f711837dd4c002fc7fbc9bfde83 [buildbucket] Fix timeout in collect_builds (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9bd486fed5d6b5492a34cec20a1f04f55101de05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1757116Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

d504dd79

depot_tools: Don't use mox on presubmit_unittest. · f32a0e8d

Edward Lemur authored Aug 15, 2019

Bug: 984182
Change-Id: I9fd81f758c16099b3cb021035a57c35fe363c8ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1755302Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

f32a0e8d

depot_tools: Separate TestCaseUtils into its own file. · 9cafbf4b

Edward Lemur authored Aug 15, 2019

This will make it easier to get rid of super_mox.py

Bug: 984182
Change-Id: Ic6c9646b8a96ef05ac59293a62f68ad7db7dc2d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1754977
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

9cafbf4b

depot_tools: Stop using mox on gclient_utils_test.py. · 614050ef

Edward Lemur authored Aug 15, 2019

Bug: 984182
Change-Id: Ie29f06c817824c009656cf81d93a605abebe948a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1754976Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

614050ef

depot_tools: Make gclient Python3 compatible. · 26a8b9f3

Edward Lemur authored Aug 15, 2019

Bug: 984182
Change-Id: Idc38678acbfca9cc6b89d77db28fdc24784f2b7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1753742
Commit-Queue: Edward Lemur <ehmaldonado@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

26a8b9f3

Roll recipe dependencies (trivial). · c45acb9c

recipe-roller authored Aug 15, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/5ad4574eb507b14945b29450e6aa378fac0ea120 [analyze] Improve module path detection logic. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I67993ee25f91a007dc64f4f13653ddaab20090ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1756293Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

c45acb9c

Make it possible to build a Windows SDK package without arm libs · f411acf5

Daniel Bratell authored Aug 15, 2019

Not everyone builds Chromium for arm so then it's practical to be
able to use a smaller SDK package without arm support included.

This also removes some samples that should not be needed.

Recipe-Nontrivial-Roll: chromiumos
Change-Id: I10f64d8907600fe79d3051083d100a7562d3a797
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1752202
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>

f411acf5

14 Aug, 2019 7 commits

Roll recipe dependencies (trivial). · 08233ee4

recipe-roller authored Aug 14, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/9739dd145b64ef8a9e33d0a4a5e25e8c516d83d4 Make set_worse_status not crash on None status (engeg@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5731702cbe41cde465da4411e99405d4abdc25a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1754637Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

08233ee4

Roll recipe dependencies (trivial). · 6a940b6d

recipe-roller authored Aug 14, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/dbc1acf1456ba2041808ab5ac96d2bbe5ebdbf49 Improve the exception for missing config. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6403bd33f203a49d29aa39504aaf7fd17e73288c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1754635Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

6a940b6d

git-cl: simplify squash commandline parsing · a989d559

Mike Frysinger authored Aug 14, 2019

We can have --no-squash update the --squash state directly so we don't
have to constantly check two different knobs.  This means opts.squash
is now a tristate: None means load config settings while True/False
means the user has specified a command line option.  This also means
we don't have to detect multiple --squash/--no-squash flags as the
argparse module will take care of coalescing.

Bug: 993518
Test: `git cl upload` uses my ~/.gitconfig
Test: `git cl upload --squash` squashes
Test: `git cl upload --no-squash` doesn't squash
Change-Id: Ib2577db11d3af03c93cb47d8b78b341213720a92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1754234Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

a989d559

Add 'stat' to gsutil module. · 30f9664b

George Engelbrecht authored Aug 14, 2019

In support of the signing rework we're going to want to have
the signers keep track of the calculated hash to ensure that
we don't have a TOCTOU type issue. This commit adds the stat
command to the gsutil module so that we can ask gs a files hash.

Change-Id: Ib35d1541292a18fbfc26fab50f594c682ba4109d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1754262Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: George Engelbrecht <engeg@google.com>

30f9664b

Remove nodir from recipe OWNERS · 089282a9

Nodir Turakulov authored Aug 14, 2019

R=iannucci@chromium.org

Bug: iannucci@chromium.org
Change-Id: I54feea6646d7f983795cc67e79008587ce3a74f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1754235
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

089282a9

presubmit: add a one hour timeout to bot_update. · 1069d421

John Budorick authored Aug 14, 2019

Mirroring crrev.com/c/1717663. bot_update runs that take more than an
hour are typically hung in irrecoverable ways.

Recipe-Nontrivial-Roll: build
Change-Id: Ic0afc48db7e0ac3464888e7715621a04f55443ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1754263Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Haiyang Pan <hypan@google.com>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Auto-Submit: John Budorick <jbudorick@chromium.org>

1069d421

Make presubmit emit a warning when it can't find the desired luci config set. · a151265d

John Budorick authored Aug 14, 2019

Useful in cases like the green presubmit runs on crrev.com/i/1434617/2

Bug: 925774
Change-Id: I37ce2be843d76ace0615cd3313e5c8421504a1ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1687122Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

a151265d

13 Aug, 2019 6 commits

depot_tools: Make scm Python 3 compatible. · 9185e449

Edward Lemur authored Aug 13, 2019

Bug: 984182
Change-Id: I6165cf889ebd4e074f1f72b29e8d1216337fb04f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1752480
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

9185e449

depot_tools: Make gclient_scm Python 3 compatible. · 979fa780

Edward Lemur authored Aug 13, 2019

Bug: 984182
Change-Id: Ib9c5d2762546f29eaca5eae89b0428431067da4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1753029
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

979fa780

Roll recipe dependencies (trivial). · 4ec0fe31

recipe-roller authored Aug 13, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/83800d1aff85a6bfa6b5202485c8a26b44701ff5 Regenerate README from 3fd5281 (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I924af5959cae02f189dcc34b99b166a18739eda1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1752690Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

4ec0fe31

Roll recipe dependencies (nontrivial). · 6bb29da8

recipe-roller authored Aug 13, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


Please review the expectation changes, and LGTM+CQ.


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/e7fec5ccb9e70bf17b7878e63052a874afa06856 Change is_luci default to True. (mmoss@google.com)


R=recipe-roller@chromium.org, tandrii@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9eb8913a8f65b8f107e5856c46aceda10e14c00c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1752476
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

6bb29da8

[depot_tools] Set "is_luci=False" for buildbot tests. · e765f652

Michael Moss authored Aug 13, 2019

This is needed to change the api.runtime default to is_luci=True in
https://crrev.com/c/1750109.

R=iannucci@google.com, tandrii@google.com

Bug: 993137
Change-Id: Id52e0a12b9121d590fcb61e275eda8ca903372d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1751815Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Michael Moss <mmoss@chromium.org>

e765f652

Roll recipe dependencies (trivial). · a9bf96fb

recipe-roller authored Aug 13, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/6043003d0d744b4c03c880d3d260a4b5c52430b1 Rename run_build references to luciexe. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5883f5aed52d1314bc3dacdc5feaad51005d87ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1751808Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

a9bf96fb

12 Aug, 2019 7 commits

Roll recipe dependencies (trivial). · 9fc459b6

recipe-roller authored Aug 12, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/3fd5281a1aa2b954fad2303857e8abf9a037c9e2 [led] Accept and expose isolate/cipd info (olivernewman@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1323814b2e10b606d163689bc0b695750971fc03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1749214Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

9fc459b6

Revert "depot_tools: Run Python scripts using vpython (Part 1)" · 98eda3f3

Edward Lesmes authored Aug 12, 2019

This reverts commit d6186f99.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> depot_tools: Run Python scripts using vpython (Part 1)
> 
> Tbr: iannucci@chromium.org
> Bug: 984182
> Change-Id: If36722e190d305f89d63dce91d0a600ddc34ebe3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1748589
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=iannucci@chromium.org,ehmaldonado@chromium.org

Change-Id: I7686985852608d0703bcbbab137df1ce82b29723
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 984182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1749853Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

98eda3f3

Revert "depot_tools: Run Python scripts using vpython (Part 2)" · 7149d236

Edward Lesmes authored Aug 12, 2019

This reverts commit 3c814957.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> depot_tools: Run Python scripts using vpython (Part 2)
> 
> Tbr: iannucci@chromium.org
> Bug: 984182
> Change-Id: I2e8469f8ee0acd6a54109697d5a6b76faf24fa42
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1748590
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=iannucci@chromium.org,ehmaldonado@chromium.org

Change-Id: Ic683543a04b45f733b48d6c43453fc8dff511d09
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 984182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1749852Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

7149d236

Revert "depot_tools: Include vpython in cipd bundle." · b22aabe4

Edward Lesmes authored Aug 12, 2019

This reverts commit 1222ecd5.

Reason for revert:
recipes should never run any of the shims which fetch cipd packages in depot_tools

Original change's description:
> depot_tools: Include vpython in cipd bundle.
> 
> Tbr: iannucci@chromium.org
> Bug: 984182
> Change-Id: I01b0e12179d2314c48c00d74550ceea1e32b355d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1749844
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=iannucci@chromium.org,ehmaldonado@chromium.org

Change-Id: Iadf11b480c03e0bd57ba2c4210d39bdc6cb27b3d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 984182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1749851Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

b22aabe4

depot_tools: Include vpython in cipd bundle. · 1222ecd5

Edward Lemur authored Aug 12, 2019

Tbr: iannucci@chromium.org
Bug: 984182
Change-Id: I01b0e12179d2314c48c00d74550ceea1e32b355d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1749844Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

1222ecd5

depot_tools: Run Python scripts using vpython (Part 2) · 3c814957

Edward Lemur authored Aug 12, 2019

Tbr: iannucci@chromium.org
Bug: 984182
Change-Id: I2e8469f8ee0acd6a54109697d5a6b76faf24fa42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1748590Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

3c814957

depot_tools: Run Python scripts using vpython (Part 1) · d6186f99

Edward Lemur authored Aug 12, 2019

Tbr: iannucci@chromium.org
Bug: 984182
Change-Id: If36722e190d305f89d63dce91d0a600ddc34ebe3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1748589Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

d6186f99

09 Aug, 2019 5 commits

subprocess2: Rewrite tests to be Python 3 compatible. · 192e8a67

Edward Lemur authored Aug 09, 2019

Also replace mox with mock and move the test script to a different file.

Bug: 984182
Change-Id: I9005a523c2abd82c38a7c61501c7cbfd4201a5b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1745412Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

192e8a67

Add crosjobs shim script · b4fc338b

Yaakov Shaul authored Aug 09, 2019

BUG=chromium:973247

Change-Id: Ibbc10cbefb85b5c9ab7a8092d1ac8d4a16af9e32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1745892Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Yaakov Shaul <yshaul@chromium.org>

b4fc338b

Add crosjobs to cipd_manifest · 0bc68e93

Yaakov Shaul authored Aug 09, 2019

BUG=chromium:973247

Change-Id: Ia0c0625446845ff1c590e0ae455b099ecab958ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1746747
Commit-Queue: Yaakov Shaul <yshaul@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

0bc68e93

Add crosjobs to cipd_manifest · 6d98232f

Yaakov Shaul authored Aug 09, 2019

BUG=chromium:973247

Change-Id: I8be6386fc3ab9ce6e8d9558862dfd0a7c74a5e6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1743018
Commit-Queue: Yaakov Shaul <yshaul@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

6d98232f

depot_tools: Simplify subprocess2. · 1556fbc3

Edward Lemur authored Aug 09, 2019

Remove support for unused features:
- timeout
- nag_timer and nag_max
- Popen start property
- callback functions for stdout and stderr

Bug: 984182
Change-Id: Ib2327119508a89d1e60f4a42c64b78d050f48092
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1745406Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

1556fbc3

08 Aug, 2019 1 commit

Make gclient_utils work with Python 3 · 1b4c7e9f

Christian Biesinger authored Aug 08, 2019

It seems like line is always a string, not bytes; this change
seems to make it work with both Python 2 and 3 (at least,
"gclient sync" looks correct and doesn't throw exceptions)

Bug: 984182
Change-Id: Iaa09e08d4eda0ccb54afa5598bac6231319d6c3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1744766
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

1b4c7e9f

07 Aug, 2019 1 commit

CROS_OWNERS: update · a110bf60

Mike Frysinger authored Aug 07, 2019

Change-Id: Ibad08744af2d28f332b2c0459187f3ab0d3a6ef9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1737469Reviewed-by: Alex Klein <saklein@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

a110bf60

06 Aug, 2019 5 commits

Roll recipe dependencies (trivial). · aa2db565

recipe-roller authored Aug 06, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/3250825222c4ad1b804b18c20fff693e7da55b4f [file] Add recursive=... option to file.listdir(...). (vadimsh@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I42c0cc31084540578f8ec1f9572af95a63c635a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1739752Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

aa2db565

Revert "Reland "depot_tools: Move six to depot_tools' .vpython"" · f994d87e

James Darpinian authored Aug 06, 2019

This reverts commit d52b306f.

Reason for revert: Broke ANGLE CQ with "ImportError: No module named six"
Example: https://ci.chromium.org/p/angle/builders/try/mac-dbg/6758

Original change's description:
> Reland "depot_tools: Move six to depot_tools' .vpython"
> 
> This is a reland of 3a98df0b
> 
> Original change's description:
> > depot_tools: Move six to depot_tools' .vpython
> > 
> > Bug: 984182
> > Change-Id: I34a242c8607624beb0f06a27c563e413dec99790
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1717492
> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> > Reviewed-by: Michael Moss <mmoss@chromium.org>
> 
> Bug: 984182
> Change-Id: Ibf7034201e65a18f833cf1e7432f81a903a99aae
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1732880
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=iannucci@chromium.org,mmoss@chromium.org,tandrii@chromium.org,ehmaldonado@chromium.org

Change-Id: Id4488249b607441df9f00aa51f4a1f2bc4ad5cfd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 984182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1739582Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>

f994d87e

Roll recipe dependencies (trivial). · 3ff0e5df

recipe-roller authored Aug 06, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/001b2e2cd58a5ecd31f1ae49bf6227fe0706d59c Add update script for buildbucket protos. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I56ee66d82208ff9f01259dacdded950ff5baba74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1739577Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

3ff0e5df

Reland "depot_tools: Move six to depot_tools' .vpython" · d52b306f

Edward Lemur authored Aug 06, 2019

This is a reland of 3a98df0b

Original change's description:
> depot_tools: Move six to depot_tools' .vpython
> 
> Bug: 984182
> Change-Id: I34a242c8607624beb0f06a27c563e413dec99790
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1717492
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Reviewed-by: Michael Moss <mmoss@chromium.org>

Bug: 984182
Change-Id: Ibf7034201e65a18f833cf1e7432f81a903a99aae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1732880Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

d52b306f

Roll recipe dependencies (trivial). · c5f95c03

recipe-roller authored Aug 06, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/5d464559eb518abe977bcccf2c5d95b6c76b0cc8 Output the command one argument per line in execution details. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I08a98f6d15eeae0ae063039b0651f21d12f43c03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1739570Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

c5f95c03

05 Aug, 2019 1 commit

Roll recipe dependencies (trivial). · 36756e45

recipe-roller authored Aug 05, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/d4f1140c8ec95a5fd04ada8bb8a87aa2e9b6e98e Account for raw_io output backing file not existing when reading it. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I58f0d9387b1c9a2e49d97ae0819d85e11260d6d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1737467Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

36756e45