R=iannucci@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1426683006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297425 0039d316-1c4b-4281-b951-d872f2087c98

Retrying the change in https://codereview.chromium.org/1415993003/, with
fixes to properly handle being called with either Windows- or
POSIX-style paths (the previous attempt assumed it was always called
with POSIX-style paths under MSYS, which itself was attempting to fix
the assumption that it was always called with Windows-style paths, but
neither assumption was right).

This change doesn't actually use the wrapper in any new places, but
subsequent changes will be made to use it in places where
'exec python' is called directly, like gclient and fetch.

BUG=411518
R=iannucci@google.com, sky@google.com

Review URL: https://codereview.chromium.org/1411793006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297401 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Generalize python_git_runner for use in non-git scripts. (patchset #1 id:1 of https://codereview.chromium.org/1415993003/ )

Reason for revert:
Speculative revert in case this caused the bots to fail bot_update.

Original issue's description:
> Generalize python_git_runner for use in non-git scripts.
> 
> Also fixes an msys (git-bash) incompatibility, similar to the one
> fixed in crrev.com/4845f0ed.
> 
> This change doesn't actually use the wrapper in any new places, but
> subsequent changes will be made to use it in places where
> 'exec python' is called directly, like gclient and fetch.
> 
> BUG=411518
> R=iannucci@google.com
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297357

TBR=iannucci@google.com,iannucci@chromium.org,mmoss@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=411518

Review URL: https://codereview.chromium.org/1414923008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297358 0039d316-1c4b-4281-b951-d872f2087c98

Also fixes an msys (git-bash) incompatibility, similar to the one
fixed in crrev.com/4845f0ed.

This change doesn't actually use the wrapper in any new places, but
subsequent changes will be made to use it in places where
'exec python' is called directly, like gclient and fetch.

BUG=411518
R=iannucci@google.com

Review URL: https://codereview.chromium.org/1415993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297357 0039d316-1c4b-4281-b951-d872f2087c98

This helps prevent behavior such as setting '--name .' so that the .gclient
file contains '.' as the name of the solution, and the .gclient file ends
up a sibling of the .git file, rather than a sibling of the git checkout's
containing directory.

R=iannucci@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/1406053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297343 0039d316-1c4b-4281-b951-d872f2087c98

With this, `fetch pdfium` is all that's needed to get a pdfium checkout.

Review URL: https://codereview.chromium.org/1415243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297340 0039d316-1c4b-4281-b951-d872f2087c98

TBR=hinoka@chromium.org
BUG=None
TEST=local
  - Ran with different branches, seems to work.

R=hinoka@chromium.org

Review URL: https://codereview.chromium.org/1414223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297284 0039d316-1c4b-4281-b951-d872f2087c98

To fix this flake:
https://uberchromegw.corp.google.com/i/internal.infra.try/builders/infra-internal-presubmit/builds/1216/steps/bot_update/logs/stdio

BUG=

Review URL: https://codereview.chromium.org/1417963005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297234 0039d316-1c4b-4281-b951-d872f2087c98

See discussion in https://codereview.chromium.org/1213363002/

BUG=503847

Review URL: https://codereview.chromium.org/1404363004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297230 0039d316-1c4b-4281-b951-d872f2087c98

This removes default testfilter value ['defaulttests'] from polluting properties
everywhere.

This also implies that default testfilter is no testfilter or empty list, which
should have equivalent meening in try recipes.

R=phajdan.jr@chromium.org,nodir@chromium.org
BUG=487822

Review URL: https://codereview.chromium.org/1423483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297228 0039d316-1c4b-4281-b951-d872f2087c98

R=akuegel@chromium.org

Review URL: https://codereview.chromium.org/1412393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297201 0039d316-1c4b-4281-b951-d872f2087c98

R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/1416663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297180 0039d316-1c4b-4281-b951-d872f2087c98

It's basically like C++'s #include but in JS.

Why write 1 language when you can write 2?!

R=maruel@chromium.org
BUG=540977

Review URL: https://codereview.chromium.org/1394563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297065 0039d316-1c4b-4281-b951-d872f2087c98

BUG=404755
R=sammc@chromium.org

Review URL: https://codereview.chromium.org/1387223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297055 0039d316-1c4b-4281-b951-d872f2087c98

Print only the most interesting commit messages.

R=maruel@chromium.org

Review URL: https://codereview.chromium.org/1390073005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297050 0039d316-1c4b-4281-b951-d872f2087c98

The current DEFAULT_BLACKLIST in presubmit_support blacklists by
default third_party/.* in every repo. This requires an adjustement
after the blink merge, as it causing all the blink presubmits to
become noops.

BUG=539768

Review URL: https://codereview.chromium.org/1382993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297030 0039d316-1c4b-4281-b951-d872f2087c98

TBR=pgervais@chromium.org,sergeyberezin@chromium.org
BUG=537417

Review URL: https://codereview.chromium.org/1383723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297020 0039d316-1c4b-4281-b951-d872f2087c98

R=brucedawson@chromium.org
BUG=491424

Review URL: https://codereview.chromium.org/1382873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297019 0039d316-1c4b-4281-b951-d872f2087c98

R=pgervais@chromium.org
BUG=537417

Review URL: https://codereview.chromium.org/1372133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297015 0039d316-1c4b-4281-b951-d872f2087c98

BUG=537417
R=sergiyb@chromium.org,phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/1373363006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297012 0039d316-1c4b-4281-b951-d872f2087c98

This will make explanation provided by Rietveld visible to the user, e.g.
"Request to https://codereview.chromium.org/1386443003/edit_flags failed: Cannot
set commit on an issue that does not have a commit queue".

R=phajdan.jr@chromium.org
BUG=529339

Review URL: https://codereview.chromium.org/1387833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297009 0039d316-1c4b-4281-b951-d872f2087c98

R=sergeyberezin@chromium.org
BUG=537417

Review URL: https://codereview.chromium.org/1388463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296995 0039d316-1c4b-4281-b951-d872f2087c98

R=iannucci@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1375343005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296990 0039d316-1c4b-4281-b951-d872f2087c98

R=sergiyb@chromium.org,phajdan.jr@chromium.org
BUG=537417

Review URL: https://codereview.chromium.org/1385653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296986 0039d316-1c4b-4281-b951-d872f2087c98

R=jochen@chromium.org

Review URL: https://codereview.chromium.org/1384693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296985 0039d316-1c4b-4281-b951-d872f2087c98

This would allow bot_update to differentiate between patch download and
aplication failures.

R=phajdan.jr@chromium.org,sergiyb@chromium.org
BUG=537417

Review URL: https://codereview.chromium.org/1380093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296983 0039d316-1c4b-4281-b951-d872f2087c98

R=erikcorry@google.com, iannucci@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1317833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296978 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Temporary fix for codereview cert issue. (patchset #3 id:2 of https://codereview.chromium.org/1376333002/ )

Reason for revert:
Outage is now over

Original issue's description:
> Temporary fix for codereview cert issue.
> 
> BUG=537763
> R=stip@chromium.org
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296959

TBR=tandrii@google.com,tandrii@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=537763

Review URL: https://codereview.chromium.org/1374223004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296964 0039d316-1c4b-4281-b951-d872f2087c98

BUG=537763
R=stip@chromium.org

Review URL: https://codereview.chromium.org/1376333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296959 0039d316-1c4b-4281-b951-d872f2087c98

It's incorrect - the checkout it creates is unusable for pdfium
development.

Correct instructions are here:
https://code.google.com/p/pdfium/wiki/Build

BUG=510419
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/1382543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296946 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:532318
TEST=None

Review URL: https://codereview.chromium.org/1350673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296930 0039d316-1c4b-4281-b951-d872f2087c98

- Create logs URL for both gitiles and github.
- Include the number of commits being rolled in in the commit subject, which is
  always useful.
- Make the log inclusion conditional on the repository being rolled in and the
  number of commits.
- Checkout the new commit when using this script, otherwise this is surprising
  to users.
- Add flags to support more use cases.
- Use --quiet when calling git to reduce noise in the output.

R=spang@chromium.org,jochen@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1366493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296924 0039d316-1c4b-4281-b951-d872f2087c98

This uses the same trick as git-new-workdir to reuse an existing git
checkout without interfering with it. However, this makes it only usable
on platforms where os.symlink exists.

BUG=404755

Review URL: https://codereview.chromium.org/1342383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296920 0039d316-1c4b-4281-b951-d872f2087c98

This CL allows passing the Rietveld URL to git cl patch along with the
CL number or patch URL.

Review URL: https://codereview.chromium.org/1363043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296889 0039d316-1c4b-4281-b951-d872f2087c98

BUG=532220

Review URL: https://codereview.chromium.org/1344183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296885 0039d316-1c4b-4281-b951-d872f2087c98

BUG=504452

Review URL: https://codereview.chromium.org/1223793008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296882 0039d316-1c4b-4281-b951-d872f2087c98

Devs should use fetch chromium instead

R=phajdan.jr@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1367473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296860 0039d316-1c4b-4281-b951-d872f2087c98

Revert of roll_dep: Avoid large commit messages by providing the log as a link (patchset #1 id:1 of https://codereview.chromium.org/1257233006/ )

Reason for revert:
Blink merge is done, blink people won't have to use it anymore.

Original issue's description:
> roll_dep: Avoid large commit messages by providing the log as a link
> 
> The majority of chromium projects are on googlesource.com, which can
> display a range of commits on the web. Use this feature instead of
> dumping logs into the commit message.
> 
> Particularly, this avoids creating large commit messages as these logs
> sometimes contain upwards of 50 commits.
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296184

TBR=jochen@chromium.org,spang@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1364763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296840 0039d316-1c4b-4281-b951-d872f2087c98

With this change, 'git cache fetch' will automatically re-bootstrap
a repo from google storage if the local cache has too many pack
files.  The behavior can be disabled with the --no-bootstrap flag.

BUG=

Review URL: https://codereview.chromium.org/1320383004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296829 0039d316-1c4b-4281-b951-d872f2087c98

For example:

[5165c48...]d:\src\crashpad\crashpad>git cl checkout https://codereview.chromium.org/1355503005
Previous HEAD position was 5165c48... Use argument escaping function in util/win/process_info_test.cc
Switched to branch 'crashpad-info-cross-bitness'

[crashpad-info-cross-bitness]d:\src\crashpad\crashpad>git cl checkout 818433002
Multiple branches match issue 818433002:
0: file_io_open
1: file_io_open-2
2: file_io_open-3
Choose by index: 1
Switched to branch 'file_io_open-2'


R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1357213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296823 0039d316-1c4b-4281-b951-d872f2087c98