Commits · c3a15a238139bed048d9ca5feca94fe0578f2cb6 · Linshizhi / Chromium_Depot_tools

20 Nov, 2010 3 commits

Add an alert for python < 2.5. · c3a15a23

maruel@chromium.org authored Nov 20, 2010

Don't block execution.

Python 2.4 has been untested for a while and may break unexpectedly.

TEST=manual testing
BUG=none

Review URL: http://codereview.chromium.org/5110009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@66870 0039d316-1c4b-4281-b951-d872f2087c98

c3a15a23

Revert r66865 "revert upload.py changes from previous commit since its throwing exceptions" · ea4d91e0

maruel@chromium.org authored Nov 20, 2010

This issue is only on python 2.4.

BUG=
TEST=

Review URL: http://codereview.chromium.org/5216004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@66867 0039d316-1c4b-4281-b951-d872f2087c98

ea4d91e0

revert upload.py changes from previous commit since its throwing exceptions · c04db91d
jam@chromium.org authored Nov 20, 2010
```
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@66865 0039d316-1c4b-4281-b951-d872f2087c98
```
c04db91d

19 Nov, 2010 2 commits

Apply directly http://codereview.appspot.com/3227041 to add support for HTTP 301 · f6d0de19

maruel@chromium.org authored Nov 19, 2010

We need this now for an imminent rietveld instance move.

TEST=worked with manual testing
BUG=none

Review URL: http://codereview.chromium.org/5138007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@66810 0039d316-1c4b-4281-b951-d872f2087c98

f6d0de19

Update upload.py to r590. · 9ad0cf62

maruel@chromium.org authored Nov 19, 2010

TBR=jam
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5172007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@66776 0039d316-1c4b-4281-b951-d872f2087c98

9ad0cf62

17 Nov, 2010 2 commits

Fix XSRF token in gcl so we don't need to hack rietveld anymore. · 41db6ef3

maruel@chromium.org authored Nov 17, 2010

Improve SendToRietveld to hardcode less function arguments.

TEST=manually tested that gcl works on both chromium and non-chromium rietveld instances
BUG=none

Review URL: http://codereview.chromium.org/5015005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@66499 0039d316-1c4b-4281-b951-d872f2087c98

41db6ef3

Update cpplint.py to r62. · 35589e67

erg@google.com authored Nov 17, 2010

Review URL: http://codereview.chromium.org/5186001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@66483 0039d316-1c4b-4281-b951-d872f2087c98

35589e67

15 Nov, 2010 1 commit

Change shebangs to allow the tools to be used out of the box without modification · 3bb0d6fa

maruel@chromium.org authored Nov 15, 2010

on system that don't hard code bash's path.

For example, BSD's bash lives in /usr/local/bin on freebsd & openbsd.

Patch contributed by Sevan Janiyan (venture37 at gmail)

TEST=didn't break ubuntu users
BUG=none

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@66124 0039d316-1c4b-4281-b951-d872f2087c98

3bb0d6fa

11 Nov, 2010 1 commit

Improve help to be clearer about what --delete_unversioned_trees does. · 28d14bd1

maruel@chromium.org authored Nov 11, 2010

Make -D -f combination more effective by deleting directories even if there is
modified files.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/4803001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@65845 0039d316-1c4b-4281-b951-d872f2087c98

28d14bd1

10 Nov, 2010 1 commit

Do not check the safesync_url at all if one or more --revision flags are · 792ea881

joi@chromium.org authored Nov 10, 2010

specified.

BUG=49625
TEST=tests\gclient_smoketest.py runs successfully


Review URL: http://codereview.chromium.org/4698006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@65620 0039d316-1c4b-4281-b951-d872f2087c98

792ea881

04 Nov, 2010 1 commit

Reduce the chances for gclient to throw an exception in subprocess module. · 0661727b

maruel@chromium.org authored Nov 04, 2010

Python standard library is not thread safe. Work around it by leaking a bit.
The problem is particularly visible on python 2.4.

TEST=none
BUG=60623

Review URL: http://codereview.chromium.org/4465001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@65048 0039d316-1c4b-4281-b951-d872f2087c98

0661727b

03 Nov, 2010 4 commits

Disable the remaining pylint warnings locally and enable pylint warnings in PRESUBMIT. · b17b55be

maruel@chromium.org authored Nov 03, 2010

This causes some code clutter.

TEST=Increased pylint warning level
BUG=none

Review URL: http://codereview.chromium.org/4321006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64913 0039d316-1c4b-4281-b951-d872f2087c98

b17b55be

Largely reduce the number of pylint warnings and fix one typo. · cb2985fb

maruel@chromium.org authored Nov 03, 2010

Most of them are style issues or variable aliasing.

TEST=Can almost enable pylint warnings
BUG=none

Review URL: http://codereview.chromium.org/4360002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64908 0039d316-1c4b-4281-b951-d872f2087c98

cb2985fb

Make CheckLicense() to not trigger on empty files. · 71626858

maruel@chromium.org authored Nov 03, 2010

This is especially annoying on empty __init__.py files.

TEST=new unit test
BUG=none

Review URL: http://codereview.chromium.org/4310001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64904 0039d316-1c4b-4281-b951-d872f2087c98

71626858

Improve PRESUBMIT.py error messages. · 488d0431

maruel@chromium.org authored Nov 03, 2010

TEST=presubmit.py
BUG=none

Review URL: http://codereview.chromium.org/4279002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64903 0039d316-1c4b-4281-b951-d872f2087c98

488d0431

02 Nov, 2010 3 commits

Blacklist more characters when sending a try job. · ed68d975

maruel@chromium.org authored Nov 02, 2010

Otherwise files containing these characters can be created on the file system,
making it harder to get rid of those files.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/4127014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64782 0039d316-1c4b-4281-b951-d872f2087c98

ed68d975

Change gcl presubmit to only run commit hooks by default. · 8e13a094

maruel@chromium.org authored Nov 02, 2010

Upload hook are only run with the --upload flag.

Most of the time the same hook is run in both case so gcl presubmit is simply 2x
slower than it could be otherwise.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/4277003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64779 0039d316-1c4b-4281-b951-d872f2087c98

8e13a094

Disregard any global 'ignore' settings that the user may have when submitting try jobs via SVN. · 22605389

erikwright@chromium.org authored Nov 02, 2010

BUG=None
TEST=Add '*.diff' to 'global-ignores' in your local SVN configuration. Submit a try job using 'gcl try'.
Review URL: http://codereview.chromium.org/4240003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64768 0039d316-1c4b-4281-b951-d872f2087c98

22605389

01 Nov, 2010 5 commits

Add rietveld member to ChangeInfo and use this value to contact rietveld. · bf1fdca7

maruel@chromium.org authored Nov 01, 2010

This makes gcl to use a specific rietveld instance per change list. This is
useful when moving from one rietveld instance to another, so in-flight reviews
are sent to the right instance.

Also clear gcl.CODEREVIEW_SETTINGS between gcl_unittest tests to remove tests interference.

TEST=updated unit tests
BUG=none

Review URL: http://codereview.chromium.org/4218006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64631 0039d316-1c4b-4281-b951-d872f2087c98

bf1fdca7

Refactor ChangeInfo.Load() to make it easier to support mulitple format. · fa3843e6

maruel@chromium.org authored Nov 01, 2010

TEST=updated unit tests and tested manually
BUG=none

Review URL: http://codereview.chromium.org/4127013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64601 0039d316-1c4b-4281-b951-d872f2087c98

fa3843e6

Refactor ChangeInfo.Load() to make it possible to switch to a new format more easily. · 8a8ea02a

maruel@chromium.org authored Nov 01, 2010

The new format will be introduced in the next change.

TEST=not much, mostly manually tested.
BUG=none

Review URL: http://codereview.chromium.org/4106011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64600 0039d316-1c4b-4281-b951-d872f2087c98

8a8ea02a

Make gcl delete foo more useful by being able to delete corrupted change. · 79b7ef05

maruel@chromium.org authored Nov 01, 2010

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/4135011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64599 0039d316-1c4b-4281-b951-d872f2087c98

79b7ef05

Fix decoding to work more often with various encodings found on platforms. · 310b3555

maruel@chromium.org authored Nov 01, 2010

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/4108011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64598 0039d316-1c4b-4281-b951-d872f2087c98

310b3555

29 Oct, 2010 2 commits

Clarified some help topics in trychange.py. · 406a6cad

scheib@chromium.org authored Oct 29, 2010

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/4112010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64443 0039d316-1c4b-4281-b951-d872f2087c98

406a6cad

Reduce the number of pylint warnings in gcl.py to make refactoring simpler. · 3a174252

maruel@chromium.org authored Oct 29, 2010

Doing static analysis on the script greatly easy refactoring since it reduces
the chances of leaving a typo in rarely executed & untested & untested code.

This is in preparation to refactor changelist on-disk format to use json.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/4184008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64427 0039d316-1c4b-4281-b951-d872f2087c98

3a174252

28 Oct, 2010 2 commits

Fix custom_deps, hooks and custom_vars to be evaluated even if no DEPS file. · 46304294

maruel@chromium.org authored Oct 28, 2010

Previously, solution's properties would be ignored if there was no DEPS file in
source control. Change the behavior to evaluate the properties anyway.

TEST=new smoke test
BUG=none

Review URL: http://codereview.chromium.org/4154004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64232 0039d316-1c4b-4281-b951-d872f2087c98

46304294

Add a new regression test for custom_deps in .gclient files. · d5766bb0

maruel@chromium.org authored Oct 28, 2010

To make sure to regression is added while looking into the code more deeply.

BUG=none
TEST=new smoke test

Review URL: http://codereview.chromium.org/4215001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64230 0039d316-1c4b-4281-b951-d872f2087c98

d5766bb0

27 Oct, 2010 1 commit

Reenable breakpad in the DC by enabling .chromium.org suffix. · 322fa22f

maruel@chromium.org authored Oct 27, 2010

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/4176004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64049 0039d316-1c4b-4281-b951-d872f2087c98

322fa22f

26 Oct, 2010 4 commits

Address review comments in r63832. · bec588d9

maruel@chromium.org authored Oct 26, 2010

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/4157002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@63886 0039d316-1c4b-4281-b951-d872f2087c98

bec588d9

Lower logging level for http connection failure when falling back to svn access. · 0974862b

maruel@chromium.org authored Oct 26, 2010

Lowers the noise

TBR=jochen
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/4151001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@63885 0039d316-1c4b-4281-b951-d872f2087c98

0974862b

gclient can now handle git URLs containing "-" in usernames and "~" in paths. · 78b8cd14

maruel@chromium.org authored Oct 26, 2010

Contributed by Torsten Becker <torsten.becker@gmail.com>

BUG=
TEST=gclient config 'ssh://user-name@asd.com/~/asd.git' && gclient sync # fails in SplitUrlRevision

Review URL: http://codereview.chromium.org/4144002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@63877 0039d316-1c4b-4281-b951-d872f2087c98

78b8cd14

Fix retry mechanism to raise when it fails to checkout. · 0350706c

maruel@chromium.org authored Oct 26, 2010

TBR=jochen
BUG=
TEST=

Review URL: http://codereview.chromium.org/4132002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@63832 0039d316-1c4b-4281-b951-d872f2087c98

0350706c

20 Oct, 2010 1 commit

A refactoring left cygwin busted. · 7526fe3b

scottbyer@chromium.org authored Oct 20, 2010

Create an update_depot_tools.bat file to use for updated when on cygwin, and
properly call it from the update_depot_tools shell script and gclient batch
files.

BUG=none
TEST=gclient sync and git cl work again on cygwin. Can also turn echo on in update_depot_tools.bat to verify updating working correctly.

Review URL: http://codereview.chromium.org/3856006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@63234 0039d316-1c4b-4281-b951-d872f2087c98

7526fe3b

19 Oct, 2010 1 commit

Handle gclient_utils.Error exceptions in trychange.py · b153d873

maruel@chromium.org authored Oct 19, 2010

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3853003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@63047 0039d316-1c4b-4281-b951-d872f2087c98

b153d873

18 Oct, 2010 5 commits

Isolate depot_tools update into a separate script. · 2a949047

msb@chromium.org authored Oct 18, 2010

Also, modify git-cl to also update depot_tools. Otherwise, the git-cl
script never gets updated for folks that only use git-cl but
not gclient. This fixes a bug ChromiumOS developers are currently seeing
where there git-cl checkout is still pointing to src.chromium.org
and not git.chromium.org.

BUG=none
TEST=Verified that git-cl help and gclient help work.

Review URL: http://codereview.chromium.org/3817011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@62948 0039d316-1c4b-4281-b951-d872f2087c98

2a949047

Change git-cl wrapper script to automatically fix the git_cl_repo remote url. · 37801da3

maruel@chromium.org authored Oct 18, 2010

This is nicer than an error message.

TEST=manually tested the url was overwritten
BUG=none

Review URL: http://codereview.chromium.org/3796010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@62923 0039d316-1c4b-4281-b951-d872f2087c98

37801da3

Return a meaningful error message when no arg is given to gclient recurse. · 45e9f2d2

maruel@chromium.org authored Oct 18, 2010

It's better than throwing an exception.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3779010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@62921 0039d316-1c4b-4281-b951-d872f2087c98

45e9f2d2

gclient recurse fails if .gclient_entries doesn't exist. · 78cba525

maruel@chromium.org authored Oct 18, 2010

Prints a meaningful message instead of throwing an exception.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3828010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@62920 0039d316-1c4b-4281-b951-d872f2087c98

78cba525

Update git-cl to use git.chromium.org. · 733bc0fa

chase@chromium.org authored Oct 18, 2010

BUG=none
TEST=git-cl works
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/3757006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@62916 0039d316-1c4b-4281-b951-d872f2087c98

733bc0fa

14 Oct, 2010 1 commit

Fix a None reference exception when searching for presubmit scripts. · 09c0dba9

maruel@chromium.org authored Oct 14, 2010

It happens when a user uses --diff foo.diff so the list of file is not defined.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3763004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@62547 0039d316-1c4b-4281-b951-d872f2087c98

09c0dba9