Commits · c2f74c1698a8e75f9474b92dcd69c73178d240b8 · Linshizhi / Chromium_Depot_tools

19 Mar, 2019 1 commit

Make fetch compatible with Python 3 · c2f74c16

Raul Tambre authored Mar 19, 2019

The scripts still work with Python 2.
There are no intended behaviour changes.

Bug: 939847
Change-Id: Icada60c5b2cf351d62aead26b7364fcef2c2a3e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1524486Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>

c2f74c16

18 Mar, 2019 6 commits

Roll recipe dependencies (trivial). · d2b0c2ae

recipe-roller authored Mar 18, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/99e0eb1d865bde251635d46fa5d8982e59937002 Enable displaying code and varmap information for if/while conditions. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4a103d16c04e05a58c64930b74c5e23f62abda62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1529145Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

d2b0c2ae

Roll recipe dependencies (trivial). · 931df5dd

recipe-roller authored Mar 18, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/cdddd19f1b197fc56cb2219eb46663d979056bc8 Move magic_check_fn module to recipe_engine.internal.test. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1d3b4d747452663ca0c7042083cedfe2d1308680
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1529607Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

931df5dd

windows_sdk module: yield paths to provided SDK directories · 2f797295

Veranika Liaukevich authored Mar 18, 2019

Needed by modules using DIA SDK, which is located in "[windows_sdk]/DIA SDK",
not under "[windows_sdk]/win_sdk".

Change-Id: I1ca42a38ef8d9d1cbfde5e63e786b7d792504f3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1526453
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Veranika Liaukevich <veranika@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

2f797295

Roll recipe dependencies (trivial). · 28ac5189

recipe-roller authored Mar 18, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c5f4654c010e356e4a9c21311f44ffa8589aa00a Add read/write_json methods to file module. (adrexler@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id15da3a008da6c4e2ba9277f4b0443639a10e644
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1529310Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

28ac5189

git_test_utils: Copy os.environ in get_git_commit_env() · b542cca2

Raphael Kubo da Costa authored Mar 18, 2019

Instead of creating an empty dict and setting all the required git variables
there, add those variables to os.environ so that we do not drop other
required variables -- in my case, git was not in /usr/bin so invoking 'git
commit' in _add_schema_commit fails with "no such file or directory".

Change-Id: I8c9b14e1f534efc8f40d21b312a5396b2f65f4a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1528290
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

b542cca2

Deploy git 2.21.0 to prod win depot_tools users · efe902b2

Takuto Ikuta authored Mar 18, 2019

Bug: 887141
Change-Id: I95cb990511f7879bd9d644fa2817444092222b9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1524810Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

efe902b2

15 Mar, 2019 3 commits

Metrics: stop trying to print the notice in color and unicode · 24b5f908

Hans Wennborg authored Mar 15, 2019

It breaks gclient for some users depending on locale settings (see bug).
The feature just doesn't seem worth the complexity.

Bug: 934279
Change-Id: I2c6e2b77ab764381db9f2c4e63ff8a84526769bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1520646Reviewed-by: Elliott Friedman <friedman@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Auto-Submit: Hans Wennborg <hans@chromium.org>

24b5f908

Deploy git 2.21.0 to depot_tools on a bleeding edge · e5c289fd

Takuto Ikuta authored Mar 15, 2019

Bug: 887141
Change-Id: If396291e07ceb74093f4da516fd17c9e102eb5f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1524809
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

e5c289fd

Expose gclient_paths via InputAPI. · 04600b4f

Yoshisato Yanagisawa authored Mar 15, 2019

The function we use with gclient_utils has moved to gclient_paths.
However, I am not sure gclient_utils is used by others or not.

Additional change:
- sorted testMembersChanged members for ease of understanding what is
  different.

Bug: 939959
Change-Id: I8b822e26afc73b39d2a33c5e07779c9c14cbd394
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1521850
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>

04600b4f

14 Mar, 2019 7 commits

Roll recipe dependencies (trivial). · 18412ab7

recipe-roller authored Mar 14, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/b2fd216f19285779af34b1d2df68b5ca9899ec1d Add encoding voodoo magic hack. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I950c58b7a55dda8363b3063ec3a1ec26044aa3b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1525324Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

18412ab7

Roll recipe dependencies (trivial). · 575238d6

recipe-roller authored Mar 14, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/d174af20fe2383140d7b604b96034ecaaeba1721 Split up stream.py. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic7b76bac62e59b4aea808610c1dfd1d94eaac701
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1525322Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

575238d6

Roll recipe dependencies (trivial). · 26b4a649

recipe-roller authored Mar 14, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/3ecff337380d856508f5f46a352021aed6ea4178 Add an an implicit check() that the step exists when getting an item from the steps dictionary. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5ff173a722657fd93f74794c3653038231f4f362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1524449Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

26b4a649

Roll recipe dependencies (trivial). · 11f160de

recipe-roller authored Mar 14, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/938a60eec6df492beac392b9d093a56830c7f893 Move RecipeEnigne and run_steps to their own file. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3dcfd7230ee971f341e7382396b484ffba632088
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1524154Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

11f160de

Roll recipe dependencies (trivial). · 8b3add4a

recipe-roller authored Mar 14, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/8368e1a93fc04fed0bae0b4a84ff11e5d6fd8ecf Split step_runner into parts. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8874a08c37a9fb9993ef9d99c499b934207492a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1524445Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

8b3add4a

Roll recipe dependencies (trivial). · 1c2fa0fd

recipe-roller authored Mar 14, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/d5630bebfc7a1c79dfe49e76ff9a1131f4807811 Remove Quiet stream engine/step runner. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I82ab11abff24df08626c2b9266c1124640ee2e73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1524562Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

1c2fa0fd

Roll recipe dependencies (trivial). · 2d4316f0

recipe-roller authored Mar 14, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/5efaa3a69b50fa7f8240d39d79de9c0530327663 [run_build] Implement a StreamEngine for streaming build.proto to logdog. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5b5c01034c7d7709fb084c759ec222fb9151f8a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1524149Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

2d4316f0

13 Mar, 2019 3 commits

Disabling bypass CQ warning message for refs/branch-heads/* of chromium/src. · 40c19421

Karen Qian authored Mar 13, 2019

Warning message appears when trying to cherry-pick into a Chromium branch,
but doesn't actually mean anything right now.
"""
About to land on 3163. Continue (y/n)? y

It seems this repository has a Commit Queue, which can test and land changes for you.
Are you sure you wish to bypass it?
Press Enter to bypass CQ, or Ctrl+C to abort
"""

We want to disable until CQ for branches is fully developed.

Bug: 753213
Change-Id: I1cdfa084a6bad1be56b85a56e94e2dd27a099b2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1518291
Commit-Queue: Karen Qian <karenqian@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

40c19421

Roll recipe dependencies (trivial). · 950df072

recipe-roller authored Mar 13, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/3035f7c165e19a7425d53f3e41b60b9a5ce6dc4e Refactor step names. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I473932a2d0eb7808b9242cc6d8ceb8e4f5dc3412
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1521152Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

950df072

[lucicfg] Bump lucicfg version 1.5.3 -> v1.5.4. · deb384f9

Vadim Shtayura authored Mar 13, 2019

Changes:
2019-03-12 seanabraham@chromium.org chromiumos-protos: Use new builder proto location
2019-03-12 vadimsh@chromium.org [lucicfg] Implement 'equivalent_to' support in CQ config generator.
2019-03-12 dburger@chromium.org Add Id and General configs to BuilderConfig.
2019-03-12 seanabraham@chromium.org testplans: Use protos in chromiumos/infra/proto rather than in lucicfg/external
2019-03-12 hinoka@google.com [milo] Add default_commit_limit and default_expand to console definitions
2019-03-11 vadimsh@chromium.org [lucicfg] Recognize e.g. 'builder = lucicfg.rule(impl = _builder)' in docgen.

R=tandrii@chromium.org, nodir@chromium.org
CC=dburger@chromium.org

Change-Id: I73a54bfe19a86e59e22bd320df6b4d414f654a7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1521149Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>

deb384f9

12 Mar, 2019 7 commits

cipd: link directly to created package on chrome-infra-packages. · 8b94108e

John Budorick authored Mar 12, 2019

I've been using this recipe module for a new internal builder
(http://shortn/_wvjqgrpIGb) and it seems odd to have the package
name and instance ID in the step text rather than a link directly
to the site. (Perhaps the module predates the CIPD UI rewrite?)

Recipe-Nontrivial-Roll: infra
Change-Id: Iab6080c3c6110ac2205cb3de397055b30d881d62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1496953Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

8b94108e

Add sdk_root property to windows_sdk module · 920bada9

Veranika Liaukevich authored Mar 12, 2019

Bug: 926631
Change-Id: Ie2ce79dd5f2cb75ef5160dda5ff5d8dd497beead
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1518793Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

920bada9

Roll recipe dependencies (trivial). · 77e5d48a

recipe-roller authored Mar 12, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/aef5bb3df38a8c316b2af0301be808e34c749583 Trivial doc change to test new recipe roller setup. (tandrii@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I998e054a24c5960acc4bf84e9fd7743ad315e6b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1517203Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

77e5d48a

Make sys a top-level import in gclient_paths. · 112a77f4

Dirk Pranke authored Mar 12, 2019

sys takes essentially no time to import (I think possibly because
it's a built-in?), and importing it as-needed is fragile. Make
it a top-level import to gclient_paths to prevent future breakages.

BUG=939959

Change-Id: I1ebe1260afd927355d668acf3cab5067ff0a2e03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1515669Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>

112a77f4

Roll recipe dependencies (trivial). · 8195bd9e

recipe-roller authored Mar 12, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/be611800cb1d17d3eeb7b3ab53e1acb056f8d50f [run_build] Improve fake_kitchen to actually run butler service. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic90a9f7ecd9d0add27d63e93d2acd23e1b474405
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1516446Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

8195bd9e

my_activity.py: Add date to format · 860378ee

Lutz Justen authored Mar 12, 2019

Allows adding the created and modified dates to the output. Doesn't
change the default behavior.

Example:
$ my_activity.py --begin=01/01/19 -f "{created} {modified} {url} {title}"
2018-12-19 2019-01-09 https://crbug.com/916521 Tests do not resolve libbrillo-libchrome dependency properly
2018-12-05 2019-01-14 https://crbug.com/912312 authpolicy: Cache authentication data

BUG=None

Change-Id: Idfe8aa9553dfb8f9774ee4915e85b6167e6fb75b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1511252
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

860378ee

Roll recipe dependencies (trivial). · 18bfe479

recipe-roller authored Mar 12, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/f270edd89315dd13dbeddd19ccb73ed7038dcc2b Improve fake_kitchen, add LUCI_CONTEXT support, add nonfunctional run_steps. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0da492a71345edb55d86ee4a6b0c74a571b761c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1516864Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

18bfe479

11 Mar, 2019 7 commits

Roll recipe dependencies (trivial). · a1488d4d

recipe-roller authored Mar 11, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/a9e17d2bfaefc76e7355cb5123f1fe6ebcf4af9b Fix the assertions.assertRaises{,Regexp} to act as context managers. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3be3012b9264c1d16dd8fbf4a4a449c9db2a96fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1516443
Reviewed-by: <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

a1488d4d

Roll recipe dependencies (trivial). · 8220b123

recipe-roller authored Mar 11, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/d21dc6a81bce49816df20745cb36daa73ca28f8c Fix the assertions whitelist. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1c8a563f9dca9d73ab5a1d0d83b3d06312ee5275
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1516441
Reviewed-by: <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>

8220b123

Roll recipe dependencies (trivial). · ab83aac1

recipe-roller authored Mar 11, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/5ffb2e26442a8cd2d109686ef16f8ae9f7ea8979 Add support for longMessage and maxDiff to assertions api. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1b4a6392a6b25051741e612893b1422b895e92d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1516438Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

ab83aac1

Fixing getting machine arch on AIX running in an LPAR environment · 973788f8

Milad Farazmand authored Mar 11, 2019

Trying to get "host_cpu" in DEPS file may fail on AIX.
Getting the "machine ID number" using "uname -m" on an AIX box, in an LPAR
environment will not generate a unique machine identifier and instead might
return a string such as "00f9445f4c00". "platform.processor()" will be used
as a fall back on AIX.

Change-Id: I7fada10059e29066f5a13d6135b01eaeaccb769d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1504554Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>

973788f8

Roll recipe dependencies (trivial). · 53aa75c9

recipe-roller authored Mar 11, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/515401ea01ef01bfe17a84de228d9ff467fac4e5 [isolated] Roll isolated client (joshuaseaton@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3c3c18bcc46db7af74c23030fe1a69092d6ccc91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1516172Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

53aa75c9

Unbreak clang-format / GetBuildtoolsPlatformBinaryPath() after depot_tools/+/1512058 · ad116ba9

Nico Weber authored Mar 11, 2019

TBR=tandrii
Bug: 939959
Change-Id: Ia200eb38fda3d2572c4f1c3dc0d9f8f8fbd34362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1515874
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>

ad116ba9

Move gclient path access to separate module. · 09e0b38f

Nico Weber authored Mar 11, 2019

gclient_utils.py is a kitchen sink and is for that reason expensive
to import. Move the comparatively cheap and simple path routines
to a new gclient_paths module and use that in gn.py, clang_format.py,
dart_format.py.

(To be able to move FindGclientRoot() to gclient_paths.py,
make it use io.open() instead of FileRead(). FileRead() tries
to paper over invalid utf-8, but that was added for presubmits,
not for .gclient files, so this is hopefully fine.)

Cuts gn.py overhead in half (on my Windows laptop from 0.6s to 0.25s,
still high; on my Mac laptop from 0.1s to 0.05s), and probably helps
the other two too.

Completely remove PathDifference() since it's unused.

Bug: 939959
Change-Id: I6a70f6e4c16062b622fb2df8778e8a598d4cc956
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1512058
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

09e0b38f

08 Mar, 2019 3 commits

Roll recipe dependencies (trivial). · 3485a263

recipe-roller authored Mar 08, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/1c1a6b6cb1387f9791ff31497301333def7306b3 post_process: move logs extraction to its own function for reuse. (jbudorick@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I97c87ab6722fe84c907e84c04407888edd9485dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1512055Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

3485a263

Avoid unnecessary invocations of "git fetch" (reland) · 73fac91f

Michael Spang authored Mar 08, 2019

If we already have the correct commit, it is not necessary to fetch.  Any
fetches can takes minutes due to gerrit problems, and often fail
completely, so it is helpful to avoid them completely whenever we can.

Reland now that skia autoroller does its own fetch.

Bug: 938627

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1504102
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

Change-Id: I5a6877125c682ff0d98bd6d2ffe495245f74c513
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1512024
Auto-Submit: Michael Spang <spang@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

73fac91f

Roll recipe dependencies (trivial). · cc43111e

recipe-roller authored Mar 08, 2019

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/5b1889d51455dafc76ddd22dd58b2e90aedc129a Move more internal files to the internal package. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ida69d2c114e0f7865cc1fd80c11e505e8dbedc88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1509916Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

cc43111e

07 Mar, 2019 3 commits

Simplify GIT.IsValidRevision · 2f3c820a

Michael Spang authored Mar 07, 2019

We should pass --verify to tell rev-parse that we're just testing,
and use the ^{commit} dereference operator to avoid the hack of
removing a character from the commit hash to see if it's really
in the object database.

Bug: 938627

Change-Id: Ic6ea898b0a5a6a1a5d706c7586c7208ec8ca2ce2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1504104
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

2f3c820a

[lucicfg] Bump lucicfg version 1.3.2 -> 1.5.3. · b139178f

Vadim Shtayura authored Mar 07, 2019

Changes:
2019-03-07 dburger@chromium.org Add dummy BuilderConfig proto to lucicfg external protos.
2019-03-06 vadimsh@chromium.org [lucicfg] Forbid "luci.*" bucket names in luci.bucket(...).
2019-03-06 vadimsh@chromium.org [lucicfg] Use 'flatten_buildbucket_cfg' tool to normalize cr-buildbucket.cfg.
2019-03-06 vadimsh@chromium.org [lucicfg] Add 'triggered_by' support to CQ config generator.
2019-03-06 vadimsh@chromium.org [lucicfg] Add "lucicfg semantic-diff" subcommand to aid in the migration.
2019-03-05 vadimsh@chromium.org [lucicfg] Add luci.cq_tryjob_verifier(...).
2019-03-05 vadimsh@chromium.org [lucicfg] Add retry_config support.
2019-03-04 vadimsh@chromium.org [lucicfg] Initial implementation of luci.cq_group(...).
2019-03-02 vadimsh@chromium.org [lucicfg] Make '#!/usr/bin/env lucicfg' work.
2019-02-28 vadimsh@chromium.org [lucicfg] Add luci.cq(...) rule.
2019-02-27 vadimsh@chromium.org [lucicfg] Get rid of `refs_regexps`, always accept regexps via `refs`.
2019-02-27 seanabraham@chromium.org crostesting: Change "BuildCritera" to "TargetCriteria"

R=tandrii@chromium.org

Change-Id: I8477088c50764ba847424eb1e59be34d03d86eb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1509016
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

b139178f

Revert "Avoid unnecessary invocations of "git fetch"" · 0cec542e

Edward Lesmes authored Mar 07, 2019

This reverts commit 61a1b5f3.

Reason for revert:
It's blocking skia autoroller
https://skia-review.googlesource.com/c/buildbot/+/198700

Original change's description:
> Avoid unnecessary invocations of "git fetch"
> 
> If we already have the correct commit, it is not necessary to fetch.  Any
> fetches can takes minutes due to gerrit problems, and often fail
> completely, so it is helpful to avoid them completely whenever we can.
> 
> Bug: 938627
> 
> Change-Id: I54494cad9b9aa0090f51674b6b9f56bb3e842f12
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1504102
> Commit-Queue: Michael Spang <spang@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

TBR=spang@chromium.org,agable@chromium.org,ehmaldonado@chromium.org

Change-Id: If8bd26d74bf84ff0ca69378dbfe6b9369b9988d3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 938627
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1508980Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

0cec542e