- 29 May, 2013 3 commits
-
-
tyoshino@chromium.org authored
TEST=tests/git_cl_test.py Review URL: https://chromiumcodereview.appspot.com/15650014 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@202865 0039d316-1c4b-4281-b951-d872f2087c98
-
rogerta@chromium.org authored
git_cl.py script. See http://goo.gl/JGg0Z for details. BUG=None Review URL: https://chromiumcodereview.appspot.com/14793006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@202864 0039d316-1c4b-4281-b951-d872f2087c98
-
tyoshino@chromium.org authored
Also adds msg to assertions to print current size of data written to stdout. Review URL: https://chromiumcodereview.appspot.com/16058007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@202863 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 May, 2013 1 commit
-
-
szager@chromium.org authored
BUG=235289 R=maruel@chromium.org Review URL: https://codereview.chromium.org/15792004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@202236 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 May, 2013 1 commit
-
-
szager@chromium.org authored
BUG=242220 Review URL: https://codereview.chromium.org/15367008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@201859 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 May, 2013 2 commits
-
-
dpranke@chromium.org authored
TBR=cmp@chromium.org BUG=239665 Review URL: https://chromiumcodereview.appspot.com/15665002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@201438 0039d316-1c4b-4281-b951-d872f2087c98
-
ilevy@chromium.org authored
._Capture throws exception on non-zero status, switch to subprocess2 capture method. Switch magic value to dontswitchurl. BUG=241907 R=dpranke@chromium.org, maruel@chromium.org Review URL: https://chromiumcodereview.appspot.com/15325003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@201397 0039d316-1c4b-4281-b951-d872f2087c98
-
- 21 May, 2013 1 commit
-
-
bratell@opera.com authored
As noticed in the TODO, raw_input (used by ask_for_data) works badly on background threads. On my Windows it doesn't even print the prompt which makes it hard to interact with it. Better to just abort and tell the user of gclient how to proceed. BUG= Review URL: https://chromiumcodereview.appspot.com/15421005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@201295 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 May, 2013 3 commits
-
-
thakis@chromium.org authored
cflags and ldflags. git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@201145 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
On mac, I ran: git checkout v1.3.3 ./bootstrap.py CXX=path/to/chromiums/clang++ ./configure --with-gtest=path/to/gtest ./ninja ninja_test ./ninja_test # all passed strip ninja Empty build perf is ~7% slower (https://github.com/martine/ninja/issues/544), but this allows us to enable deps mode by default which will make empty builds twice as fast. Mac binary size grew by ~16kB. The linux binaries were built by thestig@chromium.org. The windows binary was built by scottmg@chromium.org. New stuff since 1.1: - NINJA_STATUS now allows %e, for elapsed time. - "pool" feature - "compdb" tool for writing clang compilation databases - faster deps mode (needs to be explicitly enabled in gyp, not done yet) BUG=241628 Review URL: https://codereview.chromium.org/15490003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@201143 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
R=maruel@chromium.org Review URL: https://codereview.chromium.org/15302014 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@201094 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 May, 2013 2 commits
-
-
ilevy@chromium.org authored
Regular map is preferred when parallization does not speed presubmit tests. It makes stacktraces more understandable and facilitates debugging. Only use parallel pool when tests > 1. R=maruel@chromium.org Review URL: https://chromiumcodereview.appspot.com/15385002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@200940 0039d316-1c4b-4281-b951-d872f2087c98
-
hinoka@google.com authored
Windows bots are having trouble calling download_from_google_storage.py from the DEPS hooks. This should allow it to be called as just "download_from_google_storage". BUG= R=maruel@chromium.org Review URL: https://codereview.chromium.org/15395002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@200939 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 May, 2013 3 commits
-
-
digit@chromium.org authored
This patch fixes the implementation as follows: 1/ Fix '--full' option to check for all changes in the current branch relative to upstream. The old code only considered currently modified files, which made little sense. 2/ Fix '--full' option to apply Chromium style too. 3/ Use a proper source file filter. The original code used ".*.cc .*.cpp .*.h" as the filter, which didn't catch anything !? 4/ Add --no-ext-diff to make it work with custom "git diff" handlers. R=agable@chromium.org, maruel@chromium.org, pliard@chromium.org BUG=NONE Review URL: https://chromiumcodereview.appspot.com/14942012 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@200832 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Until r200514 is merged into every active branches on Windows, python can't be upgraded to 2.7.x. TBR=iannucci@chromium.org,joi@chromium.org BUG=241769 Review URL: https://codereview.chromium.org/15294005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@200800 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TBR=joi@chromium.org BUG= Review URL: https://codereview.chromium.org/14972010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@200799 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 May, 2013 1 commit
-
-
ilevy@chromium.org authored
Some PRESUBMIT files dynamically generate test list and so may pass an empty list to RunTests. There appears to be a bug in multiprocessing.Pool that causes a stall in map_async with an empty list. TBR=maruel Review URL: https://chromiumcodereview.appspot.com/14962011 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@200613 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 May, 2013 1 commit
-
-
dpranke@chromium.org authored
R=maruel@chromium.org, iannucci@chromium.org BUG=239665 Review URL: https://chromiumcodereview.appspot.com/14876024 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@200358 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 May, 2013 2 commits
-
-
ilevy@chromium.org authored
Allow users to set a git config entry which stops gclient from messing with remote.origin.url. Useful for using experimental repos. Review URL: https://chromiumcodereview.appspot.com/14731015 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@199532 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
assertEquals is deprecated. R=iannucci@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/14602008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@199316 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 May, 2013 1 commit
-
-
maruel@chromium.org authored
This makes the commit description cleaner. R=iannucci@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/14061008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@199275 0039d316-1c4b-4281-b951-d872f2087c98
-
- 08 May, 2013 2 commits
-
-
maruel@chromium.org authored
[1] *scm_test.py are deeply broken, svnadmin is missing for svn_bin\. And the git test are failing at shutdown. Also Fix SvnCheckout.testMove flakiness. TBR=ilevy@chromium.org,szager@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/14729012 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@198900 0039d316-1c4b-4281-b951-d872f2087c98
-
jparent@chromium.org authored
Make upload.py treat images as binaries, so they upload correctly and display in Reitveld. BUG=227346 Review URL: https://chromiumcodereview.appspot.com/14820015 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@198833 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 May, 2013 2 commits
-
-
maruel@chromium.org authored
Helps scanning faster. colorma is already slightly used by gclient but wasn't by git-cl yet. Update a unit test to be stricter, it was caught in the cross fire as colorma hooks sys.stdout and stderr. R=iannucci@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/15025003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@198689 0039d316-1c4b-4281-b951-d872f2087c98
-
mmoss@chromium.org authored
BUG=238390 Review URL: https://chromiumcodereview.appspot.com/15018003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@198572 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 May, 2013 1 commit
-
-
agable@chromium.org authored
As per the discussion in https://groups.google.com/a/chromium.org/forum/?fromgroups=#!topic/chromium-dev/Hl2QPNQ9E5o, this CL adds a 'git cl format' command. Users may use it at their own discretion. By default, it generates a diff against the local tracking (upstream) branch and runs clang-format-diff on that diff. When given the '--full' flag, it instead identifies all .cc, .cpp, and .h files in the diff and runs clang-format on the entirety of each of those files. Review URL: https://chromiumcodereview.appspot.com/14629012 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@198477 0039d316-1c4b-4281-b951-d872f2087c98
-
- 04 May, 2013 2 commits
-
-
dbeam@chromium.org authored
Chanot branch[0].isdigit()nging --milestone to use JSON source and adding prompt for branch mismatch. Sample output: $ drover --merge 196360 --milestone 27 Not all platforms have same branch number for M27. Here's a list of platforms on each branch: -(1453): win, ios, cf, mac, linux, android -(1460): cros Which branch? ('q' to cancel) 1453 Review URL: https://chromiumcodereview.appspot.com/14544004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@198282 0039d316-1c4b-4281-b951-d872f2087c98
-
rcui@google.com authored
BUG=None TEST=Manual Review URL: https://chromiumcodereview.appspot.com/14746006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@198266 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 May, 2013 6 commits
-
-
xusydoc@chromium.org authored
Follow-up to ilevy's comments in https://chromiumcodereview.appspot.com/14759006/ Review URL: https://chromiumcodereview.appspot.com/14874005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@198236 0039d316-1c4b-4281-b951-d872f2087c98
-
szager@chromium.org authored
Add default 30 second nag timer to gclient subprocesses. BUG=227537 Review URL: https://chromiumcodereview.appspot.com/14826003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@198207 0039d316-1c4b-4281-b951-d872f2087c98
-
xusydoc@chromium.org authored
SVN traps SIGINT and attempts to clean itself up, but this results in hangs waiting for TCP. This patch does two things: daemonizes worker threads so they are culled when the main thread dies (is ctrl-C'd) and keeps track of spawned subprocesses to kill any remaining ones when the main program is ctrl-C'd. A user ctrl-C'ing gclient has to manually terminate hung SVN processes, so this introduces no extra data loss or hazard. stracing a hung SVN process shows that it is indeed hanging on TCP reads after receiving a SIGINT, implying there is an underlying but in the SVN binary. Review URL: https://chromiumcodereview.appspot.com/14759006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@198205 0039d316-1c4b-4281-b951-d872f2087c98
-
rcui@google.com authored
BUG=None TEST=Ran locally Review URL: https://chromiumcodereview.appspot.com/14585006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@198184 0039d316-1c4b-4281-b951-d872f2087c98
-
jbroman@chromium.org authored
It is somewhat surprising when git-cl, which acts as a git subcommand, launches a different editor. In particular, git has a config option (core.editor) which specifies the editor that should be used. Since we already respect $GIT_EDITOR, it makes sense for git-cl to respect core.editor and $VISUAL as well. R=maruel@chromium.org BUG=237504 Review URL: https://chromiumcodereview.appspot.com/14854003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@198101 0039d316-1c4b-4281-b951-d872f2087c98
-
iannucci@chromium.org authored
R=maruel@chromium.org BUG=166901 Review URL: https://chromiumcodereview.appspot.com/14878007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@198031 0039d316-1c4b-4281-b951-d872f2087c98
-
- 02 May, 2013 3 commits
-
-
bratell@opera.com authored
BUG=236148 Review URL: https://chromiumcodereview.appspot.com/14104005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@197872 0039d316-1c4b-4281-b951-d872f2087c98
-
szager@chromium.org authored
BUG=227537 R=maruel@chromium.org,cmp@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/14798003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@197790 0039d316-1c4b-4281-b951-d872f2087c98
-
groby@chromium.org authored
Clean up formatting a bit. Review URL: https://chromiumcodereview.appspot.com/14602017 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@197773 0039d316-1c4b-4281-b951-d872f2087c98
-
- 30 Apr, 2013 2 commits
-
-
szager@chromium.org authored
R=maruel@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/14643009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@197419 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
It is called by logging.foo() so it breaks this use case. TBR=iannucci@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/14569002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@197190 0039d316-1c4b-4281-b951-d872f2087c98
-
- 29 Apr, 2013 1 commit
-
-
maruel@chromium.org authored
Without this change, if an entry is removed from a DEPS file, it won't be effectively deleted. Specify --delete_unversioned_trees so the dependency is properly deleted. TBR=szager@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/14531006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@197081 0039d316-1c4b-4281-b951-d872f2087c98
-