- 19 Nov, 2013 2 commits
-
-
iannucci@chromium.org authored
Compatible with any git topology (multiple roots, weird branching/merging, etc.) I can't get it to be any faster (in python). Suggestions welcome :). On z600/linux, this takes 5.1s to calculate the initial count for 2e3de954ef0a (HEAD on src.git at the time of writing). Subsequent lookups take ~0.06s. For reference, this machine takes 3s to just list the revisions in sorted order without any additional processing (using rev-list). All calculations are stored in a git-notes-style ref with the exception that the leaf 'tree' object which would normally be stored in a git-notes world is replaced with a packed binary file which consists of records [hash int]. Each run of this script will create only 1 commit object on this internal ref which will have as its parents: * The previous git number commit * All of the target commits we calculated numbers for. This ref is then excluded on subsequent invocations of rev-list, which means that git-number will only ever process commit objects which it hasn't already calculated a value for. It also prevents you from attempting to number this special ref :). This implementation only has a 1-byte fanout which seems to be the best performance for the repos we're dealing with (i.e. on the order of 500k commit objects). Bumping this up to a 2-byte fanout became extremely slow (I suspect the internal caching structures I'm using are not efficient in this mode and could be improved). Using no fanout is slower than the 1 byte fanout for lookups by about 30%. R=agable@chromium.org, stip@chromium.org, szager@chromium.org BUG=280154,309692,skia:1639 Review URL: https://codereview.chromium.org/26109002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@236035 0039d316-1c4b-4281-b951-d872f2087c98
-
pgervais@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/65933005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@235857 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Nov, 2013 1 commit
-
-
hinoka@chromium.org authored
boto config does the right thing by using the http_proxy env var to set the proxy, and gsutil removes that var which isn't the behavior we want. This should allow gsutil to respect the http_proxy env var. BUG=318478 Review URL: https://codereview.chromium.org/68763013 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@235818 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Nov, 2013 1 commit
-
-
maruel@chromium.org authored
Some people just don't want to read chromium-dev@. Wake them up. R=iannucci@chromium.org BUG= Review URL: https://codereview.chromium.org/74273002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@235548 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 Nov, 2013 2 commits
-
-
pgervais@chromium.org authored
This modification make gclient-new-workdir.py display explicit error messages instead of cryptic Python backtraces. BUG= Review URL: https://codereview.chromium.org/68213010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@235408 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
2.7.5 has bug http://bugs.python.org/issue17998 in re package that is affecting the chromium team so it can't be used. The bug is fixed in 2.7.6. This update still respects DEPOT_TOOLS_PYTHON_275=0. Since the name doesn't represent what is being installed, it also respects DEPOT_TOOLS_PYTHON_27=0. R=iannucci@chromium.org BUG=241769 Review URL: https://codereview.chromium.org/73013003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@235384 0039d316-1c4b-4281-b951-d872f2087c98
-
- 14 Nov, 2013 3 commits
-
-
maruel@chromium.org authored
It may help when the directory is created at high integrity level. This hypothesis is unconfirmed. TBR=iannucci@chromium.org BUG=241769,314257 Review URL: https://codereview.chromium.org/72803002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@235149 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Clean up stray spaces. TBR=iannucci@chromium.org BUG=241769 Review URL: https://codereview.chromium.org/72783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@235145 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
This will automatically upgrade python to 2.7.5 unless set DEPOT_TOOLS_PYTHON_275=0 is used. R=iannucci@chromium.org BUG=241769 Review URL: https://codereview.chromium.org/53313002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@235140 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Nov, 2013 1 commit
-
-
deymo@chromium.org authored
ChromiumOS only developers don't always have a Chromium checkout and a Rietveld cookie file (~/.codereview_upload_cookies) with the auth keys. This patch proceeds with the activity lookup from other services such as Gerrit and GoB if there's no Rietveld cookie present, displaying an error message when this happens. BUG=chromium:316961 TEST=Remove ~/.codereview_upload_cookies and ran my_activity. ChromeOS activity listed. Review URL: https://codereview.chromium.org/68763004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@234874 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Nov, 2013 1 commit
-
-
brettw@chromium.org authored
R=maruel@chromium.org Review URL: https://codereview.chromium.org/69693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@234321 0039d316-1c4b-4281-b951-d872f2087c98
-
- 08 Nov, 2013 1 commit
-
-
brettw@chromium.org authored
This automatically searches the path for a source root (or takes one from the command line), and then executes the current platform's GN binary inside that source tree. This will allow the user to have a "gn" command on their path, and allow our scripts to run GN without having to bake-in the logic for finding the correct platform's GN binary. Review URL: https://codereview.chromium.org/66013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@233983 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 Nov, 2013 2 commits
-
-
iannucci@chromium.org authored
Previously this relied on being able to track branches which didn't have a remote refspec. Now we add a fake origin for the git-svn test repo, and use --prefix so that git has a remote to track and the refs are correctly namespaced. Should also be backwards compatible with older versions of git. R=maruel@chromium.org BUG= Review URL: https://codereview.chromium.org/61893006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@233649 0039d316-1c4b-4281-b951-d872f2087c98
-
iannucci@chromium.org authored
R=maruel@chromium.org BUG= Review URL: https://codereview.chromium.org/63813002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@233566 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Nov, 2013 1 commit
-
-
deymo@chromium.org authored
This patch adds a new function QueryAllChanges to gerrit_util.py allowing the caller to iterate the list of changes regardless the maximum limit of changes per request that the server supports (by default 500 according to gerrit's documentation). my_activity.py is ported to use this function instead of urllib2 to manually make the request. This also adds support for authentication since gerrit_util.py already supports it, and the internal gerrit instance is now re-enabled. Finally, two minor bugs are fixed on the hanlding of returned results: The DETAILED_ACCOUNTS option is passed to gerrit to request the email addresses of the referenced users and users without an email address, such as the "Gerrit Code Review" user on the internal gerrit, are now supported. BUG=chromium:311649,chromium:281695 TEST=Manual run "my_activity.py -u USER" for some users. Review URL: https://codereview.chromium.org/50283002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@233166 0039d316-1c4b-4281-b951-d872f2087c98
-
- 05 Nov, 2013 1 commit
-
-
adam.treat@samsung.com authored
Add a new gclient-new-workdir script which clones an existing gclient working directory much like git-new-workdir, but takes into account all sub projects as well. BUG=none Review URL: https://codereview.chromium.org/52663008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@232992 0039d316-1c4b-4281-b951-d872f2087c98
-
- 04 Nov, 2013 1 commit
-
-
stip@chromium.org authored
This is needed for a further CL to unify TS and CQ using PRESUBMIT.py. BUG=278554 Review URL: https://codereview.chromium.org/54373011 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@232813 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Nov, 2013 1 commit
-
-
maruel@chromium.org authored
Using "%@" will correctly requote quoted arguments. Tested with repro case. The fix in r232184 missed the necessary argument quoting. R=iannucci@chromium.org BUG=314192 BUG=241769 Review URL: https://codereview.chromium.org/47873010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@232501 0039d316-1c4b-4281-b951-d872f2087c98
-
- 31 Oct, 2013 3 commits
-
-
maruel@chromium.org authored
Tested to work now with the repro case of bug 313552. "/c" was interpreted by cygwin's bash as a path and was replaced with c:/. :( Using //c seems to be passed through properly. There is probably other escaping problem but this should be good enough at this stage. Ref: http://www.mingw.org/wiki/Posix_path_conversion R=iannucci@chromium.org BUG=241769 BUG=313552 Review URL: https://codereview.chromium.org/50143013 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@232184 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
This fixes license headers. Interestingly, the pylint workaround at r133705 doesn't seem to be necessary anymore. R=stip@chromium.org BUG= Review URL: https://codereview.chromium.org/54603003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@232152 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
This broke git cl patch due to escaping. I tried removing the double quotes but it didn't work out. Reverting in the meantime to unblock people until I figure out a permanent way. BUG=313552,241769 TBR=iannucci Review URL: https://codereview.chromium.org/50293009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@232112 0039d316-1c4b-4281-b951-d872f2087c98
-
- 30 Oct, 2013 1 commit
-
-
maruel@chromium.org authored
Fix the git-* wrapper scripts, PRESUBMIT.py and .gitignore. The previous python wrapping scripts assumed python_bin\python.exe. This CL modifies the wrapping scripts to use python.bat. This requires some quoting magic and explicitly defer to cmd.exe. This may break some cases where double quotes are used as arguments. We can't do miracles on Windows. R=iannucci@chromium.org BUG= Review URL: https://codereview.chromium.org/50563008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@231888 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 Oct, 2013 1 commit
-
-
brettw@chromium.org authored
Adds a command line flag --platform to control which platforms the given download occurs on. Automatically marks downloads executable on non-Windows if the header x-goog-meta-executable is set. Automatically set this flag on upload when the executable bit is set. BUG=233100 Review URL: https://codereview.chromium.org/42273002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@231387 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Oct, 2013 2 commits
-
-
agable@chromium.org authored
This helps prevent timeout when checking out large repositories (like blink) using the git cache_dir. R=iannucci@chromium.org, maruel@chromium.org BUG=295119 Review URL: https://codereview.chromium.org/43273005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@231111 0039d316-1c4b-4281-b951-d872f2087c98
-
digit@chromium.org authored
Newer versions of clang-format-diff.py now require a -i flag to explicitely apply edits, otherwise they just print a diff, which make "git cl format" a no-op. This patch fixes the issue by probing the script's help text to see if the flag is needed. If it is, it is added automatically. BUG=NONE R=maruel@chromium.org Review URL: https://codereview.chromium.org/44263004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@231020 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Oct, 2013 1 commit
-
-
teravest@chromium.org authored
Currently, running "git cl issue 0" in a client prints a confusing error message if there's no issue assigned. This changes the code so that the issue number isn't "unset" if it's not currently set. BUG= Review URL: https://codereview.chromium.org/32193016 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@230499 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Oct, 2013 1 commit
-
-
raphael.kubo.da.costa@intel.com authored
sleep() is in time, not sys. BUG= R=maruel@chromium.org,szager@chromium.org,cmp@chromium.org Review URL: https://codereview.chromium.org/34483004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@230108 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Oct, 2013 4 commits
-
-
szager@chromium.org authored
This prevents jgit from parsing the user's existing ~/.gitconfig, which can skew test results. BUG= Review URL: https://codereview.chromium.org/27752003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@229245 0039d316-1c4b-4281-b951-d872f2087c98
-
szager@chromium.org authored
Add retry for all git operations that speak to a remote. This should smooth out issues with the git/gerrit-on-borg service. Review URL: https://codereview.chromium.org/26234004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@229219 0039d316-1c4b-4281-b951-d872f2087c98
-
szager@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/27756002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@229216 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TBR=stip@chromium.org BUG= Review URL: https://codereview.chromium.org/26937003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@229012 0039d316-1c4b-4281-b951-d872f2087c98
-
- 16 Oct, 2013 4 commits
-
-
maruel@chromium.org authored
R=szager@chromium.org BUG= Review URL: https://codereview.chromium.org/27537004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@228989 0039d316-1c4b-4281-b951-d872f2087c98
-
szager@chromium.org authored
gob_util.py is a general-purpose library for communicating with the gerrit-on-borg service. testing_support/gerrit_test_case.py is a unittest framework for testing code that interacts with gerrit. R=vadimsh@chromium.org, cmp@chromium.org BUG= Review URL: https://codereview.chromium.org/26399002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@228965 0039d316-1c4b-4281-b951-d872f2087c98
-
kangil.han@samsung.com authored
For example, my id is 'kangil.han', but it fails during parsing. So this patch fixes it. Review URL: https://codereview.chromium.org/27484002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@228937 0039d316-1c4b-4281-b951-d872f2087c98
-
qsr@chromium.org authored
Review URL: https://codereview.chromium.org/27316002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@228926 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 Oct, 2013 2 commits
-
-
phajdan.jr@chromium.org authored
This makes exception catching code which compares the code with numeric values work as expected. pythonis not PHP and 500 != '500'. BUG=none Review URL: https://codereview.chromium.org/27260007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@228788 0039d316-1c4b-4281-b951-d872f2087c98
-
borenet@google.com authored
These are run for a given dependency after it has been synced but before its DEPS have been synced. This will help to switch Chromium to depend on Skia's git repository (skia:1638). Review URL: https://codereview.chromium.org/25322002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@228651 0039d316-1c4b-4281-b951-d872f2087c98
-
- 14 Oct, 2013 1 commit
-
-
scheib@chromium.org authored
Review URL: https://codereview.chromium.org/27269002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@228565 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Oct, 2013 1 commit
-
-
maruel@chromium.org authored
This way, DEPOT_TOOLS_PYTHON_275=1 will properly upgrade an installation still running 2.6. Otherwise the user had to "del python.bat" to force the upgrade. Stop calling python to verify it works, this is slow. Upgrade url to https. R=iannucci@chromium.org BUG=241769 Review URL: https://codereview.chromium.org/26901003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@228179 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Oct, 2013 1 commit
-
-
phajdan.jr@chromium.org authored
BUG=none Review URL: https://codereview.chromium.org/26913003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@227982 0039d316-1c4b-4281-b951-d872f2087c98
-