- 28 Dec, 2012 1 commit
-
-
szager@chromium.org authored
To be used in conjunction with the --template argument to git-clone. The hooks all redirect to build/git-hooks, which are files under revision control. This allows us to version the hooks along with the source code. TBR=mmoss@chromium.org,cmp@chromium.org Review URL: https://codereview.chromium.org/11689005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@174738 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Dec, 2012 1 commit
-
-
ferringb@google.com authored
BUG=chromium-os:37471 TEST=manual invocations, tracking upstream code, running these versions on builders for validation in addition. Review URL: https://chromiumcodereview.appspot.com/11660027 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@174609 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Dec, 2012 3 commits
-
-
szager@chromium.org authored
If the working copy isn't on a named branch, don't try to pull; just fetch. Use --quiet flag to git-submodule, to prevent interleaving of terminal output. Check target os before updating a submodule. TBR'ing, since no one really has a stake in this, and maruel doesn't do bash :). TBR=maruel@chromium.org Review URL: https://codereview.chromium.org/11645056 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@174280 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@chromium.org authored
This version handles the case where we need to suggest two reviewers who have overlapping sets of directories they can review. R=maruel@chromium.org BUG=76727 Review URL: https://chromiumcodereview.appspot.com/11639028 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@174216 0039d316-1c4b-4281-b951-d872f2087c98
-
nyquist@chromium.org authored
This adds the possibility to specify the format for your activity through: -f <format>, --output-format=<format> <format> is specified as in strings.format(...). It is also possible to specify the output format for specific activity types. This enables users to use other formats such as Markdown: [%(title)s](%(url)s) This CL also adds support for new variables such as author, and adds a generic framework for adding more variables. BUG=166519 Review URL: https://chromiumcodereview.appspot.com/11607007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@174203 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 Dec, 2012 5 commits
-
-
dpranke@chromium.org authored
TBR=maruel@chromium.org Review URL: https://codereview.chromium.org/11638019 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@173990 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@chromium.org authored
Initially landed in r173784, reverted in r173808 R=maruel@chromium.org BUG=76727 Review URL: https://chromiumcodereview.appspot.com/11645009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@173979 0039d316-1c4b-4281-b951-d872f2087c98
-
kjellander@chromium.org authored
In https://codereview.chromium.org/11574007/ I attempted to make it possible to use the TRYSERVER_ROOT setting in codereview.settings. It seems like some checkouts ran into errors with it not finding the codereview.settings file when it was parsed. This is probably due to the fact that the following call chain reads the self.toplevel_root variable: _GclStyleSettings -> GetCodeReviewSetting -> ReadRootFile By moving _GclStyleSettings up before self.toplevel_root is set probably causes this. This CL attempts to correct this. BUG=none, but try job upload fails for some users. TEST=submitting try job to locally running try server. Review URL: https://chromiumcodereview.appspot.com/11571052 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@173928 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
This would cause a few exceptions on the CQ until it realizes the checkout is not present anymore. R=petermayo@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/11649011 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@173916 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@chromium.org authored
TBR=maruel@chromium.org BUG= Review URL: https://codereview.chromium.org/11645008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@173808 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Dec, 2012 2 commits
-
-
dpranke@chromium.org authored
It turns out that we were weighting all possible owners equally, and picking the last one out of the list. Given the way we traversed owners files, and given that we got rid of the "set noparent"s, this meant that we were always suggesting Ben for just about everything. This change implements a much smarter algorithm that attempts to balance number of reviewers and closeness to the files under review. The unit tests added show specific examples and explanations for why things are chosen the way they are. R=maruel@chromium.org BUG=76727 Review URL: https://chromiumcodereview.appspot.com/11567052 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@173784 0039d316-1c4b-4281-b951-d872f2087c98
-
kjellander@chromium.org authored
Since the helper function for the parsing of the TRYSERVER_* variables relies on them being unset (i.e. value is None) in order to apply the settings from codereview.settings, this parsing must take place before the code that figures out the root path (since that sets the options.root value if it's not set). Otherwise the TRYSERVER_ROOT setting will never be set, even if configured in codereview.settings, essentially making it useless. This has probably not been discovered previously since almost all Chrome projects use src as the root dir. In WebRTC and some other projects we use 'trunk' usually, which is giving us trouble in our own try server setups (where we have to use 'src' because many other scripts have that root dir hardcoded). I am not sure if there is a case for another project where this change may have any negative effect. Please let me know if theres's any investigation needed that I can assist with. BUG=none TEST=submitting try job to local try master with a codereview.settings file with TRYSERVER_ROOT set. Review URL: https://chromiumcodereview.appspot.com/11574007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@173694 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Dec, 2012 1 commit
-
-
davidjames@chromium.org authored
The cros wrapper in depot_tools is a centralized wrapper for all cros commands. Adding this to depot_tools allows developers to run the 'cros' tool from anywhere inside a Chrome OS checkout. BUG=none TEST=Verify the cros wrapper works. Review URL: https://chromiumcodereview.appspot.com/11600002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@173491 0039d316-1c4b-4281-b951-d872f2087c98
-
- 14 Dec, 2012 1 commit
-
-
jam@chromium.org authored
BUG=161702 Review URL: https://chromiumcodereview.appspot.com/11566014 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@173104 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Dec, 2012 1 commit
-
-
dpranke@chromium.org authored
If you were creating a new OWNERS file that only had per-file owners in it (and no catch-all owners for the whole directory), then we would not look for suggested owners in parent directories, and end up suggesting nothing. See https://chromiumcodereview.appspot.com/11555036/ for the CL that revealed this. Also, the unit tests were incorrectly using absolute paths in some cases, making the code less predictable; I've fixed the unit tests and added a check for this into owners.py (real changes never used absolute paths, just paths relative to the checkout root). R=maruel@chromium.org Review URL: https://chromiumcodereview.appspot.com/11569018 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@173000 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Dec, 2012 3 commits
-
-
thakis@chromium.org authored
See https://bugs.webkit.org/show_bug.cgi?id=104523 Review URL: https://chromiumcodereview.appspot.com/11485007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@172427 0039d316-1c4b-4281-b951-d872f2087c98
-
iannucci@chromium.org authored
R=cmp@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/11532010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@172363 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
Use case rather than inconsistently using [ and [[. Review URL: https://chromiumcodereview.appspot.com/11522008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@172343 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Dec, 2012 2 commits
-
-
tony@chromium.org authored
I compiled this on the WebKit Linux 32 bot and verified that it runs. Review URL: https://codereview.chromium.org/11511007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@172191 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
He no longer works on this project. Review URL: https://chromiumcodereview.appspot.com/11506010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@172123 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Dec, 2012 1 commit
-
-
iannucci@chromium.org authored
Because it's generated :) R=maruel@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/11439022 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@171518 0039d316-1c4b-4281-b951-d872f2087c98
-
- 05 Dec, 2012 3 commits
-
-
ilevy@chromium.org authored
BUG=161702 R=maruel@chromium.org Review URL: https://chromiumcodereview.appspot.com/11438024 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@171277 0039d316-1c4b-4281-b951-d872f2087c98
-
ilevy@chromium.org authored
We use the fact the dcommit adds a "Committed:" link to the description. If we wanted to be more strict, we could make git cl dcommit post a comment on the CL (which would be nice since it would notify reviewers that the CL was committed). Note that this is untested as written, because it doesn't appear that we have either git-cl integration tests, nor a test for git cl dcommit adding the word "Committed:" so as written, this presubmit check is prone to failure. Would like suggestions to improve. Also adding DoNotSubmit checks and a couple others to PanPresubmitChecks. R=maruel@chromium.org,dpranke@chromium.org BUG=161702 Review URL: https://chromiumcodereview.appspot.com/11421050 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@171158 0039d316-1c4b-4281-b951-d872f2087c98
-
ilevy@chromium.org authored
This can come up when CQ closed an issue but the user's local branch is still tied to the issue. BUG=161702 Review URL: https://chromiumcodereview.appspot.com/11348122 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@171153 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Dec, 2012 1 commit
-
-
dpranke@chromium.org authored
R=maruel@chromium.org BUG=163030 Review URL: https://chromiumcodereview.appspot.com/11434048 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@170819 0039d316-1c4b-4281-b951-d872f2087c98
-
- 30 Nov, 2012 1 commit
-
-
hinoka@google.com authored
BUG=161704,161840 Review URL: https://chromiumcodereview.appspot.com/11414098 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@170588 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 Nov, 2012 5 commits
-
-
ilevy@chromium.org authored
Support 'git grep <match> <branch>' type searches in gclient grep. These searches had a slightly different output so needed more tweeking to the regex. I cleaned it up a bit too. R=maruel@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/11316213 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@170039 0039d316-1c4b-4281-b951-d872f2087c98
-
ilevy@chromium.org authored
Reduce calling SendProfile to long running commands. There's lots of low hanging fruit (slow commands) to optimize before we need perf stats from fast commands. R=maruel@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/11416230 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@170009 0039d316-1c4b-4281-b951-d872f2087c98
-
ukai@chromium.org authored
settings.GetIsGerrit() would invoke logging.basicConfig() and preemtps the basicConfig for verbose option in parser.parse_args. R=maruel@chromium.org,ilevy@chromium.org BUG=162600 Review URL: https://chromiumcodereview.appspot.com/11418171 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@169843 0039d316-1c4b-4281-b951-d872f2087c98
-
ilevy@chromium.org authored
- Many chrome-internal viewvc links do not support https. UpgradeToHttps was added 10 months ago and continues to generate broken viewvc links. Reverts part of crrev.com/9214004 BUG=107838 Review URL: https://chromiumcodereview.appspot.com/11412161 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@169815 0039d316-1c4b-4281-b951-d872f2087c98
-
ilevy@chromium.org authored
- This will be used by navabi to have his gclient recurse command print the current repo. R=maruel@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/11308115 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@169812 0039d316-1c4b-4281-b951-d872f2087c98
-
- 27 Nov, 2012 1 commit
-
-
maruel@chromium.org authored
Multiple presubmit checks may call the same function multiple times, so it's worth caching the results to speed up the presubmit check run. Convert presubmit_support, git-cl and gcl to use it. R=dpranke@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/11280143 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@169726 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Nov, 2012 3 commits
-
-
enne@chromium.org authored
BUG=none Review URL: https://chromiumcodereview.appspot.com/11414163 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@169447 0039d316-1c4b-4281-b951-d872f2087c98
-
newt@chromium.org authored
The bash command "local myvar=$(mycommand)" has the exit status of the bash builtin "local" rather than the exit status of mycommand. To get the exit status of mycommand, "local myvar" should be run separately on a previous line. Review URL: https://chromiumcodereview.appspot.com/11308129 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@169446 0039d316-1c4b-4281-b951-d872f2087c98
-
ilevy@chromium.org authored
Add some logging when CMDupload is passed a verbosity option. R=maruel@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/11418148 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@169434 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 Nov, 2012 1 commit
-
-
bauerb@chromium.org authored
This avoids build errors like at http://build.chromium.org/p/tryserver.chromium/builders/linux_clang/builds/64851/steps/update/logs/stdio (search for mtpd). BUG=none Review URL: https://chromiumcodereview.appspot.com/11417059 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@168521 0039d316-1c4b-4281-b951-d872f2087c98
-
- 15 Nov, 2012 1 commit
-
-
davidjames@chromium.org authored
Currently, if an unversioned directory is present where we would expect a versioned repository to be, the following error is printed: Can't update/checkout %s if an unversioned directory is present. Delete the directory and try again. If --reset and --delete_unversioned_trees are used, gclient should delete the unversioned directory in this case. This problem can be reproduced using the following recipe: $ rm -rf src/third_party/webrtc/.svn $ gclient sync -nRftD BUG=none TEST=Verify that above error is fixed. Run all smoke tests. Review URL: https://chromiumcodereview.appspot.com/11366239 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@167942 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Nov, 2012 2 commits
-
-
scheib@chromium.org authored
Turning off could be interpreted as having a lasting impact instead of just being a notice for the current run. Review URL: https://chromiumcodereview.appspot.com/11359168 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@167476 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TBR=iannucci@chromium.org BUG=155511 Review URL: https://chromiumcodereview.appspot.com/11377139 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@167443 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Nov, 2012 1 commit
-
-
ilevy@chromium.org authored
- Adds a gclient grep command to search through git repos. BUG=157950 Review URL: https://chromiumcodereview.appspot.com/11312116 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@167007 0039d316-1c4b-4281-b951-d872f2087c98
-