Commits · 99e2cdf47a3f1083bde35d7553fda218fd7f37d6 · Linshizhi / Chromium_Depot_tools

23 Oct, 2016 2 commits

Print failure reason when git cl try can't trigger jobs on a CL. · 99e2cdf4
qyearsley authored Oct 23, 2016
```
This is a very little fix.

Review-Url: https://codereview.chromium.org/2441213002
```
99e2cdf4

Automatically CC folks listed in CC= lines. · d975b30c

bradnelson authored Oct 23, 2016

Detect CC=<users> lines the way we detect R= and TBR=.
Add these as CC'ed users for rietveld and gerrit.

R=iannucci@chromium.org,hinoka@chromium.org,dnj@chromium.org

Review-Url: https://codereview.chromium.org/2433323004

d975b30c

20 Oct, 2016 1 commit

Remove SVN support from gclient_utils and gclient_scm · 41e3a6c5

agable authored Oct 20, 2016

This removes SVN support (most notably the SVNWrapper class, and the git-svn
logic in GitWrapper.GetUsableRev) from gclient_scm. It also removes some
references to SVN from comments in gclient_utils.

R=maruel@chromium.org
BUG=641588

Review-Url: https://chromiumcodereview.appspot.com/2393773003

41e3a6c5

19 Oct, 2016 6 commits

Change path to internal-try rietveld credentials · bc0b4c6e

hinoka authored Oct 19, 2016

To match where it ended up being located.

BUG=642150

Review-Url: https://chromiumcodereview.appspot.com/2436853002

bc0b4c6e

Roll recipe dependencies (trivial). · d501e8ac

recipe-roller authored Oct 19, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/6e11fcc25f244f962bf750349a805bb3261977ff Remove debugging print. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://chromiumcodereview.appspot.com/2433213002

d501e8ac

Roll recipe dependencies (trivial). · 16b03c73

recipe-roller authored Oct 19, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/9d854c6e7ce9ed004ef0854d0d2c3c5aabcca66f Add Swarming magic environment variables to ENV_WHITELIST (borenet@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://chromiumcodereview.appspot.com/2436773002

16b03c73

Add -B/--bucket flag to git-cl try · 6c0efe60
borenet authored Oct 19, 2016
```
BUG=

Review-Url: https://chromiumcodereview.appspot.com/2419113002
```
6c0efe60
git cl: refactor direct usage of time.sleep and time.time. · 2a16b95e
tandrii authored Oct 19, 2016
```
R=machenbach@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2433813004
```
2a16b95e
Automatically map urls to their raw appengine forms · 6ff1fc0e
Aaron Gable authored Oct 19, 2016
```
BUG=657216
R=dnj@chromium.org

Review URL: https://codereview.chromium.org/2431893002 .
```
6ff1fc0e

18 Oct, 2016 3 commits

Revert "git_cl: Allow server overriding." · 78de30e1
Dan Jacques authored Oct 18, 2016
```
This reverts commit a8fb3a28.
```
78de30e1

git_cl: Allow server overriding. · a8fb3a28

Dan Jacques authored Oct 18, 2016

BUG=chromium:657064
TEST=local
  - Ran "git cl status" during outage with override, works.

R=tandrii@chromium.org

Review URL: https://chromiumcodereview-hr.appspot.com/2425673005 .

a8fb3a28

Fix typo in --manually_grab_svn_rev deprecated flag. · 69b1be10

sdefresne authored Oct 18, 2016

Chrome on iOS downstream bot still use that flag and they cannot
recover as the flag has been misspelt when resurrected.

TBR=agable@chromium.org
TBR=dnj@chromium.org
BUG=656865

Review-Url: https://codereview.chromium.org/2428893002

69b1be10

17 Oct, 2016 4 commits

Roll recipe dependencies (trivial). · 1c822ade

recipe-roller authored Oct 17, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/bb6caf8060139fd4bcefee43f54ae00150e7ce3a Remove 'use_mirror' and 'root' properties. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:656731

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2425083002

1c822ade

Roll recipe dependencies (trivial). · aa9e16ac

recipe-roller authored Oct 17, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/7076377b62701f77783d2d5e002fe2708ffab273 Fix VerifySubset when comparing empty lists (martiniss@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2422313002

aa9e16ac

Reland "Remove SVN and File support from gclient" · d437d76b

agable authored Oct 17, 2016

This is a revert of 398a46ee
Which was itself a revert of b3a24c3f

BUG=641588

Review-Url: https://codereview.chromium.org/2404413002

d437d76b

Gerrit git cl: make it work with minimal file. · 48df5813

tandrii authored Oct 17, 2016

BUG=656555
R=emso@chromium.org,andybons@chromium.org

Review-Url: https://codereview.chromium.org/2421253002

48df5813

14 Oct, 2016 5 commits

Roll recipe dependencies (trivial). · 1dbb595d

recipe-roller authored Oct 14, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/a15c8474d308784e94fe4e15deb7c7860d717059 Reland: Add post_process hooks to recipe testing facilities. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2424483002

1dbb595d

Fix logic to detect Gerrit CL in CQ · c9ebbd24
rmistry authored Oct 14, 2016
```
BUG=chromium:656042

Review-Url: https://codereview.chromium.org/2419123002
```
c9ebbd24

Roll recipe dependencies (trivial). · 49ea106b

recipe-roller authored Oct 14, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/9de4473f1587a0ba103ecaf8ce6b6e882ac40093 Revert post_process hooks for now. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=459361

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2415303002

49ea106b

Roll recipe dependencies (trivial). · 99366c49

recipe-roller authored Oct 14, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/61e9e2a3a9d074748850aa1b46dd170a51649aab Use deepcopy to avoid coupling between test cases. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=459361

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2415963003

99366c49

Roll recipe dependencies (trivial). · 284076e8

recipe-roller authored Oct 14, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/d97fe4474b8ebefb906e594aba840fff58720dae Add post_process hooks to recipe testing facilities. (iannucci@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=459361

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2418613005

284076e8

12 Oct, 2016 4 commits

Roll recipe dependencies (trivial). · d05b9b15

recipe-roller authored Oct 12, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/2e9ed981d6e2f75889aef93cb2b6a5e50a8aac37 Annotation protobuf code can now dump final. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2415803002

d05b9b15

Roll recipe dependencies (trivial). · 20fc95cc

recipe-roller authored Oct 12, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/4608377873373f343214b23d06a912fecfd31bbe Add clients, requirement injection. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:628770

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2414793003

20fc95cc

Roll recipe dependencies (trivial). · 0884b021

recipe-roller authored Oct 12, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/e7c7c99cb0445fa97b7bf27f330fe58449f3d6b6 Add "regenerate protobufs" fast vendoring path. (dnj@chromium.org)
  https://crrev.com/2aab92c00dddf99d117e5846f327f85e8a3ce96a RecipeScript no longer copies recipe global attrs. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=None

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2413883002

0884b021

git cl try: make code less Rietveld-specific. · de281aee

tandrii authored Oct 12, 2016

This also adds first test to cover case of custom properties.

R=machenbach@chromium.org,sergiyb@chromium.org
BUG=599931

Review-Url: https://codereview.chromium.org/2409223002

de281aee

11 Oct, 2016 12 commits

Remove git lockfile flakiness on win (bot_update) · df66a34f

katthomas authored Oct 11, 2016

Hypothesis: Sometimes bot update fails because windows fails to delete
a lockfile associated with a git process.

Test: If this happens, let's delete that lockfile and try again.

BUG=651602

Review-Url: https://codereview.chromium.org/2382653005

df66a34f

Add .mojom to git-gs · bda914b8

scottmg authored Oct 11, 2016

R=maruel@chromium.org

Review-Url: https://codereview.chromium.org/2410393002

bda914b8

Revert of Remove SVN and File support from gclient (patchset #4 id:60001 of... · 398a46ee

lpique authored Oct 11, 2016

Revert of Remove SVN and File support from gclient (patchset #4 id:60001 of https://codereview.chromium.org/2398493004/ )

Reason for revert:
The Chrome buildbots pass "--transitive" still. Removing the option causes them to fail to build.

Example:

https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/x86-alex-tot-chrome-pfq-informational/builds/21555

Original issue's description:
> Remove SVN and File support from gclient
>
> FileImpl was only usable with SVN.
>
> R=maruel@chromium.org
> BUG=641588
>
> Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/b3a24c3fd5159972f58063967a9c07ef724ff97b

TBR=maruel@chromium.org,agable@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=641588

Review-Url: https://codereview.chromium.org/2405173003

398a46ee

Roll recipe dependencies (trivial). · 7e269f0d

recipe-roller authored Oct 11, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/e129c96c485b33149256838d912c5f324bf59dd7 Add LogDog / annotation protobuf support. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=None

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2410173003

7e269f0d

Remove SVN and File support from gclient · b3a24c3f

agable authored Oct 11, 2016

FileImpl was only usable with SVN.

R=maruel@chromium.org
BUG=641588

Review-Url: https://codereview.chromium.org/2398493004

b3a24c3f

git cl try: refactor to add Gerrit support in the future. · e113dfd7

tandrii authored Oct 11, 2016

R=nodir@chromium.org,sergiyb@chromium.org
BUG=599931

Review-Url: https://codereview.chromium.org/2400713003

e113dfd7

git cl try: remove --use-rietveld and related code. · 568043bd

tandrii authored Oct 11, 2016

R=nodir@chromium.org,sergiyb@chromium.org
BUG=599931

Review-Url: https://codereview.chromium.org/2401943002

568043bd

Revert of gclient: kill git fetch operation that hangs. (patchset #12... · 64103db7

tandrii authored Oct 11, 2016

Revert of gclient: kill git fetch operation that hangs. (patchset #12 id:220001 of https://codereview.chromium.org/2241843002/ )

Reason for revert:
Didn't help.

Original issue's description:
> gclient: kill git fetch operation that hangs.
>
> This provides env variable GCLIENT_KILL_GIT_FETCH_AFTER
> that kills git fetch if it produces no output for that
> many seconds.
>
> Note that this is not final patch, but an experiment.
> See http://crbug.com/635641#c24 for the deployment plan.
>
> BUG=635641
> R=hinoka@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/f8757b7e02226594655230ccbeae3543c7dc49c6

TBR=hinoka@chromium.org,hinoka@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=635641

Review-Url: https://codereview.chromium.org/2410853002

64103db7

Revert of bot_update/gclient: kill git fetch after timeout regardless of... · 30d95627

tandrii authored Oct 11, 2016

Revert of bot_update/gclient: kill git fetch after timeout regardless of output. (patchset #2 id:20001 of https://codereview.chromium.org/2293013002/ )

Reason for revert:
didn't work.

Original issue's description:
> bot_update/gclient: kill git fetch after timeout regardless of output.
>
> Also spits out whatever output was produced by git fetch for debugging.
>
> BUG=635641
> R=machenbach@chromium.org,hinoka@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/db8b839320168ab4f5156399ecb275478c0aa2cd

TBR=hinoka@chromium.org,machenbach@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=635641

Review-Url: https://codereview.chromium.org/2410053002

30d95627

git cl try-results regression tests for Gerrit. · 45b2a589

tandrii authored Oct 11, 2016

The flow looks like this:

  $ git cl status
  Branches associated with reviews:
    gerrit-4483 : https://chromium-review.googlesource.com/381231 (waiting)

  $ git cl try-results
  Warning: Codereview server has newer patchsets (2) than most recent
  upload from local checkout (None). Did a previous upload fail?
  By default, git cl try uses latest patchset from codereview,
  continuing using such patchset 2.

  Warning: Some results might be missing because You are not logged in.
  Please login first by running:
    depot-tools-auth login chromium-review.googlesource.com
  Started:
    Infra Linux Precise 32 Tester https://luci-milo.appspot.com/swarming/...
    Infra Linux Trusty 64 Tester  https://luci-milo.appspot.com/swarming/...
  Total: 2 try jobs

  $ depot-tools-auth login chromium-review.googlesource.com
   <<<auth in my browser>>>

  Logged in to chromium-review.googlesource.com as <some@email.com>

	To login with a different email run:
		depot-tools-auth login chromium-review.googlesource.com
	To logout and purge the authentication token run:
		depot-tools-auth logout chromium-review.googlesource.com

  $ git config branch.gerrit-4483.gerritpatchset 2
  $ git cl try-results
  Started:
    Infra Linux Precise 32 Tester https://luci-milo.appspot.com/swarming/...
    Infra Linux Trusty 64 Tester  https://luci-milo.appspot.com/swarming/...
    Infra Mac Tester              https://luci-milo.appspot.com/swarming/...
  Total: 3 try jobs

R=sergiyb@chromium.org,emso@chromium.org
BUG=599931
TEST=new unittests + end-to-end local.

Review-Url: https://codereview.chromium.org/2392463009

45b2a589

repo: update to v1.12.34-cr2 · ae39f566

vapier authored Oct 11, 2016

We've synced our fork of repo to upstream. This change copies the new
version into depot_tools.

BUG=chromium:632203
TEST=`repo sync` still works

Review-Url: https://codereview.chromium.org/2402193002

ae39f566

Roll recipe dependencies (trivial). · fa2ea243

recipe-roller authored Oct 11, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/eace5bb2ef1323ca39ffda4644278569d54acd60 Print information when user doesn't have coverage available. (martiniss@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2403783004

fa2ea243

10 Oct, 2016 2 commits

git cl patch: handle missing/wrong Gerrit issue better. · c2405f55

tandrii authored Oct 10, 2016

No stacktrace is printed, instead just a user-friendly string is shown.
Add test + some tests refactoring.

This CL also improve missing Gerrit issue exception elsewhere by raising
user-friendly exception.

BUG=654360
R=sergiyb@chromium.org
TEST=manual

Review-Url: https://codereview.chromium.org/2403793002

c2405f55

git cl try: --use-rietveld no longer supported. · 8e229546
tandrii authored Oct 10, 2016
```
R=nodir@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2399993004
```
8e229546

07 Oct, 2016 1 commit

Refactor git cl try. · f7b29d4a

tandrii authored Oct 07, 2016

R=phajdan.jr@chromium.org,sergiyb@chromium.org
BUG=599931

Review-Url: https://codereview.chromium.org/2400793004

f7b29d4a