- 29 Aug, 2017 2 commits
-
-
Michael Anthony Knyszek authored
Bug: Change-Id: Iefa3a7bd449dfbe29450597d4ead73626c5315b1 Reviewed-on: https://chromium-review.googlesource.com/636167 Commit-Queue: Michael Knyszek <mknyszek@google.com> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
Ilya Sherman authored
I introduced an indentation error in [1] which caused "git cl format" to typically do nothing for histograms.xml and other metrics XML files. Oops. [1] https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/569105 R=dpranke@chromium.org Bug: 757939 Change-Id: Iab9975588156fca29e119e889ae634c5f77cb704 Reviewed-on: https://chromium-review.googlesource.com/627590Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org>
-
- 28 Aug, 2017 5 commits
-
-
Aaron Gable authored
R=lgarron@chromium.org Bug: 758435 Change-Id: I557cf5027636e8cf30d3971071723bf2b9333f9e Reviewed-on: https://chromium-review.googlesource.com/639036Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
Aaron Gable authored
If one of the "branches" being shown by 'git map-branches' is the pseudo-branch "{NO_UPSTREAM}", and the user has asked the command to print the subject line of each branch, it would crash. This change causes it to gracefully handle that case. R=lgarron@chromium.org Bug: 758428 Change-Id: Id0ff1c6fd90b5efbb07e118ae088e3999c234b67 Reviewed-on: https://chromium-review.googlesource.com/639190Reviewed-by: -
Alexander Thomas authored
Upgrade led to make it work with the new luci-system-account Kitchen cook flag introduced in cl 622079. Includes: 2a2d3d036 Rename github.com/luci/{luci-go,gae} to go.chromium.org/{luci,gae} R=dnj@chromium.org, iannucci@chromium.org Bug:759495 Change-Id: Ic8f2c189cdc2c4cd0d0eecc9bb5ed2e0b770ede9 Reviewed-on: https://chromium-review.googlesource.com/638970Reviewed-by: -
Eric Boren authored
This is hampering Skia's ability to easily diagnose failures introduced by ANGLE rolls. Bug:skia:6998 Change-Id: I646200b691be0a07051e9ae1f7feaf2cd1c0671a Reviewed-on: https://chromium-review.googlesource.com/638070Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Eric Boren <borenet@chromium.org>
-
Paweł Hajdan, Jr authored
See https://goto.google.com/kinhy (Google-internal) for more context. Bug: none Change-Id: I1d255543d99b2d466dbad9f15ca606d663c1f946 Reviewed-on: https://chromium-review.googlesource.com/637311Reviewed-by:
William Hesse <whesse@google.com> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 25 Aug, 2017 3 commits
-
-
Dan Jacques authored
Print the Python version during "bot_update". This is useful for visually auditing the environment in which things are running. BUG=None TEST=None R=iannucci@chromium.org Change-Id: I92be8a888e6f1e5c17205665dff36378e641cd81 Reviewed-on: https://chromium-review.googlesource.com/636450Reviewed-by:
-
Aaron Gable authored
This adds support for the new urls (which contain the project) to git-cl [description|checkout|issue|patch] and others. Bug: 757602 Change-Id: I6e854a85e655e14daa7e4172ca938953778bf514 Reviewed-on: https://chromium-review.googlesource.com/634518 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/9d5ee6b5096f870449f1fc4b6c4ae418cf70d8e3 recipes.py test: print traceback on recipe crashes (phajdan.jr@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I5ddaa2ba228785eeaeb8613aaed106df7b464b56 Reviewed-on: https://chromium-review.googlesource.com/634704Reviewed-by:
Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
- 23 Aug, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
Bug: 756474, 570091 Change-Id: I8777b611f2b77b71cf75ec64ec1f0afca2104235 Reviewed-on: https://chromium-review.googlesource.com/629082Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 22 Aug, 2017 2 commits
-
-
Paweł Hajdan, Jr authored
This should fix some config hangs such as "fetch android", which otherwise prompt to accept a Play Services license. Bug: none Change-Id: I4e3f59f9541a8e80f04b5b0a48d86e48a19e19bc Reviewed-on: https://chromium-review.googlesource.com/625876Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/d0acc08657c0d71e8388c6e2903e2b7aa205f0d6 Distinguish user recipe code crashes from internal failures (phajdan.jr@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ibb7172b550db2d6d0e776de0eed1b9dde381dc5a Reviewed-on: https://chromium-review.googlesource.com/625321Reviewed-by:
-
- 18 Aug, 2017 4 commits
-
-
Scott Graham authored
This was used back in the VS2010/VS2013 Express era, when we used it to automatically extract bits and pieces from the publically available isos for non-Pro users. Now we just require a Community Edition install so this is unnecessary and unused. Change-Id: I35bbb0ef29c940db128bd1fd4862d3d26e4cc002 Reviewed-on: https://chromium-review.googlesource.com/621783Reviewed-by:
-
Paweł Hajdan, Jr authored
This CL includes this as comments in flattened DEPS, as requested on the bug. For automated processes using this, we should export the data in machine-readable form outside of the DEPS file. Bug: 756474, 570091 Change-Id: I78cd2105113f41d599e293e772e1f1ca42679f3c Reviewed-on: https://chromium-review.googlesource.com/621726Reviewed-by:
-
Paweł Hajdan, Jr authored
We need to pass OS info to recursively called _flatten_dep. Regular deps entries in OS-specific DEPS file recursed into need to be marked as OS-specific in the flattened file. Bug: 570091 Change-Id: If3055b84143d8a52d10d8753113893b5054b4d07 Reviewed-on: https://chromium-review.googlesource.com/621046Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/1068819795fd6c8a84a39d67e8328e5714844f92 Fix spelling in source_manifest.proto. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I070b9aba1f113d13a9b0b9ea9f86c7ba08e01c89 Reviewed-on: https://chromium-review.googlesource.com/621526Reviewed-by:
-
- 17 Aug, 2017 4 commits
-
-
Robert Iannucci authored
e130567e [cipd] Add spacers to help text to make it more readable. 91b1bda5 [cipd] Enable package name templates for all CLI functions a10ef48a [cipd] Move template expansion code to common. 4c613c75 cipd: Support template expansion in @subdir 3847616b Rename github.com/luci/{luci-go,gae} to go.chromium.org/{luci,gae}. R=vadimsh@chromium.org Bug: 756288 Change-Id: Ie40daf2d80ea715fb303eb199b6c5abf8b4870ef Reviewed-on: https://chromium-review.googlesource.com/619966Reviewed-by:Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
Scott Graham authored
Git Credential Manager for Windows (as of git 2.14.1) really wants to pop up a modal dialog. Setting this environment variable avoids this so that the check for src-internal access can quietly fail. Ref: https://github.com/Microsoft/Git-Credential-Manager-for-Windows/issues/482 Bug: 755694 Change-Id: I38aec008662fa0a6bccb0a6220d376063ee790e7 Reviewed-on: https://chromium-review.googlesource.com/617502Reviewed-by:
-
Michael Moss authored
This fixes an issue where "--deps=all" syncs everything but ios. R=dpranke@chromium.org, phajdan.jr@chromium.org Change-Id: I413269c5026b2c04f0d34d9ca874057eb35e1076 Reviewed-on: https://chromium-review.googlesource.com/618802Reviewed-by:
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I773b74b042233efa2a525f5f47e920468b7fea4a Reviewed-on: https://chromium-review.googlesource.com/618930Reviewed-by:
-
- 16 Aug, 2017 3 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/b5c35344f0cb93d02d1a94812925d2a734607877 Rename tracking_ref to fetch_ref. (iannucci@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ifb546af066d1ccd678e8edda49f61c8f7e090ffd Reviewed-on: https://chromium-review.googlesource.com/618141Reviewed-by:
-
Paweł Hajdan, Jr authored
Consistently pin all dependencies - including deps_os and ones with shortened shas. We add --process-all-deps switch so that users can easily tell gclient to check out all affected dependencies locally. Bug: 570091 Change-Id: If68db98000c569ae35dd7d0a4b695eb80a589213 Reviewed-on: https://chromium-review.googlesource.com/617224Reviewed-by:
-
Ilya Sherman authored
This allows us to skip 'git cl format' for histograms.xml, which in turn allows us to issue a presubmit error rather than a warning when that file is malformatted, without running the formatting code twice. The formatter is somewhat slow for this file, so it's helpful to avoid duplicating that work. BUG=none TEST=none R=iannucci@chromium.org Change-Id: Ia86d45c7c56a9f89db34ca7175ef686589084f85 Reviewed-on: https://chromium-review.googlesource.com/569105 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
- 15 Aug, 2017 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/67b097fac8a43135691b529e581ad2c7e5f0ca74 Switch revision fields to strings. (iannucci@google.com) https://crrev.com/da5c50e930c48067d1ffecf7a47c3065da5e0fe5 Exclude "$" properties from properties.legacy. (iannucci@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I92b27eb801eacbb6647390b7f311a59bd28c7333 Reviewed-on: https://chromium-review.googlesource.com/616015Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/b1ef35bcab44676a3159ab6c2be00e7c5a9a88ce Add source manifest recipe module. (iannucci@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I898995bf22e16214b2a51fd4dae83f9b183e923b Reviewed-on: https://chromium-review.googlesource.com/615525Reviewed-by:
-
- 12 Aug, 2017 1 commit
-
-
Aleksandr Derbenev authored
There are some usecases where it is simpler to pass path to the cache by an environment variable or command-line argument than to modify the gclient config file. With this change: * GCLIENT_CACHE_DIR environment variable overrides cache_dir variable from .gclient file. * --cache-dir argument moved from gclient config to all gclient commands and overrides values from .gclient file and environment variable. R=dpranke@chromium.org Bug: Change-Id: Iae107f1d5f02a2eee1896d0d3108dc20a83d597f Reviewed-on: https://chromium-review.googlesource.com/596089Reviewed-by:
Daniel Jacques <dnj@chromium.org> Commit-Queue: Aleksandr Derbenev <alex-ac@yandex-team.ru>
-
- 11 Aug, 2017 4 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/7d60012b4e854314e4960e1cde6354533057ffe8 Remove unused Properties from operational args. (iannucci@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I4d830346cc2637f0d3ccfa63e3f7e44d0e7cf4e5 Reviewed-on: https://chromium-review.googlesource.com/612462Reviewed-by:
-
Paweł Hajdan, Jr authored
For example: # buildspec -> tools_internal_DEPS -> build/third_party/python-rsa "build/third_party/python-rsa": { "url": "{git_url}/external/github.com/sybrenstuvel/python-rsa.git@version-3.1.4", }, Bug: 570091 Change-Id: I5fd444908c06fbd03bdaf0715401c1dbd9fbe89f Reviewed-on: https://chromium-review.googlesource.com/611988Reviewed-by: -
Robert Iannucci authored
R=dnj@chromium.org Bug: 754427 Change-Id: Ieea8b3e46b9bb799bd42a29e4c0c791f7d846b22 Reviewed-on: https://chromium-review.googlesource.com/611482Reviewed-by:
-
Robert Iannucci authored
R=dnj@chromium.org Bug: 754427 Change-Id: I46f3c757457a07e4639af6605c45cd907299e8b5 Reviewed-on: https://chromium-review.googlesource.com/611394Reviewed-by:
-
- 10 Aug, 2017 7 commits
-
-
smut authored
The http://metadata shortcut only works on Linux, Windows requires https://metadata.google.internal. Bug: 738255 Change-Id: I06b6c34761bbee9912a8cd2a65ab43b3ae230f07 Reviewed-on: https://chromium-review.googlesource.com/611245Reviewed-by:
-
Andrii Shyshkalov authored
R=phajdan.jr@chromium.org Change-Id: Ia1380bc0cfff50e82f9a26d3c54e9dc34a38c7b5 Reviewed-on: https://chromium-review.googlesource.com/574528 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Paweł Hajdan, Jr authored
Otherwise it'd get stringified to "None" and make resulting DEPS invalid. In theory we could properly serialize them to None, but it's simpler to just skip them, since they do not affect resulting checkout. Bug: 570091 Change-Id: Ica301e2d7e40ba4ed04527355d8f75a43456391c Reviewed-on: https://chromium-review.googlesource.com/610150Reviewed-by:
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I8c450da68fd36d166f8f838c645672fce7c03891 Reviewed-on: https://chromium-review.googlesource.com/610004Reviewed-by:
-
John Budorick authored
Reland of https://chromium-review.googlesource.com/c/580327/ TBR=iannucci@chromium.org Bug: 746763 Change-Id: Icc3be87faa6c614a09b7406ce6e748abb2ad82da Reviewed-on: https://chromium-review.googlesource.com/581268 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org>
-
Paweł Hajdan, Jr authored
This is the same change as in https://chromium-review.googlesource.com/c/586594 applied to _DepsOsToLines. Bug: 570091 Change-Id: I06a4dc3a9b6dbb001a15b1d7b88fef12cf6c6aaa Reviewed-on: https://chromium-review.googlesource.com/609980Reviewed-by:
Emma Söderberg <emso@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I8e67d617c2738459634aabbffd22135ee5d27cc4 Reviewed-on: https://chromium-review.googlesource.com/609065Reviewed-by:
-
- 09 Aug, 2017 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/2b836809932a4cc79defe28352c9772aa1f042a2 Update vendored client-py/libs to get updated logdog client. (iannucci@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I3b57bec944438211ee2937a42dbf716b9931c292 Reviewed-on: https://chromium-review.googlesource.com/609024Reviewed-by:
-
Paweł Hajdan, Jr authored
This finally makes the code structure seem right as well: there's just one method (_flatten_dep), with a simpler control flow. Also added a regression test. Bug: 570091 Change-Id: I22ac7a3af0429a7ffd874b4b1715c0f6c72e0006 Reviewed-on: https://chromium-review.googlesource.com/608241Reviewed-by:
-
