- 21 Jun, 2017 5 commits
-
-
Aaron Gable authored
BUG=735230 Change-Id: Ia75170b3ea13c4c14eb7e8066ecb533f69adbc8d Reviewed-on: https://chromium-review.googlesource.com/542038Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
Paweł Hajdan, Jr authored
This is a reland of https://chromium-review.googlesource.com/c/541280/ with a fix for https://bugs.chromium.org/p/chromium/issues/detail?id=735418 (patchset 1 is original patch, patchset 2 has the fix). Keep deps_os entries in dependencies, just with should_process set to False for entries not applicable to target OS list. This way gclient flatten has proper access to dependencies e.g. to evaluate recursedeps referring to deps_os entries other than active OS. Allow but ignore deps_os overriding a value with None, since that does not fit the new model. There's no correctness harm in not checking out a repo. Allow "overrides" setting given dependency to the same value. This seems fairly common, especially for mac/ios and unix/android, even in chromium/src. Bug: 570091, 735418 Change-Id: I6eba0e4be202212eb86cb959c18f2b2f0c1452b9 Reviewed-on: https://chromium-review.googlesource.com/543076 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
Andrii Shyshkalov authored
This reverts commit 529d6a4e. Reason for revert: broke developers and CI/Try checkouts. Bug: 735418 Original change's description: > gclient: include deps_os entries in dependencies > > Keep deps_os entries in dependencies, just with should_process set to False > for entries not applicable to target OS list. > > This way gclient flatten has proper access to dependencies e.g. to evaluate > recursedeps referring to deps_os entries other than active OS. > > Allow but ignore deps_os overriding a value with None, since that does not > fit the new model. There's no correctness harm in not checking out a repo. > > Allow "overrides" setting given dependency to the same value. This seems > fairly common, especially for mac/ios and unix/android, even in chromium/src. > > Bug: 570091 > Change-Id: I2037a1ecc5fd2da6b5f73061548b81fc79ba2e72 > Reviewed-on: https://chromium-review.googlesource.com/541280 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> TBR=phajdan.jr@chromium.org,dpranke@chromium.org Change-Id: Iaa0c39865908a5b25c15dda54ba61c0e76abcbea No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 570091 Reviewed-on: https://chromium-review.googlesource.com/543138Reviewed-by:
-
Paweł Hajdan, Jr authored
Bug: none Change-Id: Ia858832e120eec59b12d8e97a61fc01fd70a3837 Reviewed-on: https://chromium-review.googlesource.com/541309Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Paweł Hajdan, Jr authored
Keep deps_os entries in dependencies, just with should_process set to False for entries not applicable to target OS list. This way gclient flatten has proper access to dependencies e.g. to evaluate recursedeps referring to deps_os entries other than active OS. Allow but ignore deps_os overriding a value with None, since that does not fit the new model. There's no correctness harm in not checking out a repo. Allow "overrides" setting given dependency to the same value. This seems fairly common, especially for mac/ios and unix/android, even in chromium/src. Bug: 570091 Change-Id: I2037a1ecc5fd2da6b5f73061548b81fc79ba2e72 Reviewed-on: https://chromium-review.googlesource.com/541280Reviewed-by:
-
- 20 Jun, 2017 2 commits
-
-
Jeremy Roman authored
Bug: 735158 Change-Id: I1444f34c84862f542909d0b70c5cdfd02394526c Reviewed-on: https://chromium-review.googlesource.com/541638Reviewed-by:
-
Paweł Hajdan, Jr authored
Bug: none Change-Id: I85724e97c923b4e1651ebf435692018b4629f312 Reviewed-on: https://chromium-review.googlesource.com/541376Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 19 Jun, 2017 1 commit
-
-
Paweł Hajdan, Jr authored
With 'flatten' work and in general, we assume deps_os only add to deps, without attempting to override entries there. This removes significant edge cases from flatten code, and ensures DEPS are easier to reason about. This reverses some past patches and decisions: a0ad8ad9 https://codereview.chromium.org/11368067 https://bugs.chromium.org/p/chromium/issues/detail?id=157979 ed2b4fe5 https://codereview.chromium.org/23875029 https://bugs.chromium.org/p/chromium/issues/detail?id=248168 These are rather old though (2012-2013), and not expected to be used. Bug: 570091 Change-Id: I143e95bdaef9d10c937a5f678e6be7e26899ad4d Reviewed-on: https://chromium-review.googlesource.com/531029Reviewed-by:
-
- 16 Jun, 2017 3 commits
-
-
Rico Wind authored
R=hinoka@chromium.org Bug: Change-Id: I027ac560beeea2ebf38fe6ddcb4e707efd3f615a Reviewed-on: https://chromium-review.googlesource.com/538612Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Rico Wind <ricow@chromium.org>
-
Aaron Gable authored
This is a partial revert of https://chromium-review.googlesource.com/c/527345/ Turns out more people were confused by the new behavior than expected, so we're returning to "cherry-pick" being the default, but supporting the collaboration workflow is important, so we're adding a warning message and support for "reset --hard" behind a pre-existing flag. Bug: 723787 Change-Id: Ib6038a42e3bdcc0db93c1f32d759e9ff0e91a065 Reviewed-on: https://chromium-review.googlesource.com/538137 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
-
Gabriel Charette authored
I've hit this assert a few times, seeing the output of the set usually helps highlight quickly how my command-line arguments are broken. Bug: Change-Id: I8b80b635df91f2707a599a33ab9b4959b3c76614 Reviewed-on: https://chromium-review.googlesource.com/535834Reviewed-by:
-
- 15 Jun, 2017 3 commits
-
-
Dan Jacques authored
Bump "vpython" verison to: d147cd8b9062f3699759612ef96c4fe4bd49f87d TBR=iannucci@chromium.org BUG=None TEST=canary - Version successfully runs on Chromium canary builders. Change-Id: I23750860261378157db72aaa59cb19c2911e6dd1 Reviewed-on: https://chromium-review.googlesource.com/537896Reviewed-by:
Daniel Jacques <dnj@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org>
-
Robert Iannucci authored
72dd7271e [led] minor improvements. R=dnj@chromium.org, nodir@chromium.org Bug: 662654 Change-Id: I680709209a172c13115b96117f1708cdb15304ae Reviewed-on: https://chromium-review.googlesource.com/537156 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by:
-
Aaron Gable authored
There's no reason not to, since it is pretty easy, and other commands like "git cl patch" already do so. Bug: 733715 Change-Id: I3396153ef11bfdbbf09b8a7f54f9a5b1047e290f Reviewed-on: https://chromium-review.googlesource.com/537113Reviewed-by:
-
- 14 Jun, 2017 7 commits
-
-
Robert Iannucci authored
bb62539e3 [led] add hack to set luci_project. 4f33697c5 [led] fix property typo TBR=dnj@chromium.org, nodir@chromium.org Bug: 662654 Change-Id: I42c2742bee5cf30fe529e91f7ec522745a76bac9 Reviewed-on: https://chromium-review.googlesource.com/535893Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
Bruce Dawson authored
While setting up a Chromium repo on a new machine I ended up with a missing .gclient_entries file. This triggered a warning message but it led me in the wrong direction. I think that the new message - saying exactly what problem was detected - will be slightly more helpful. Change-Id: I8c91861f843e3d30881b1b4933a02ad966c114ef Reviewed-on: https://chromium-review.googlesource.com/533314Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
Paweł Hajdan, Jr authored
Looks like it was added in https://codereview.chromium.org/503563002 and later became dead code. Bug: none Change-Id: Ic348e84fcbb0770b8a2dfca592c02d0dbf7e4750 Reviewed-on: https://chromium-review.googlesource.com/535647Reviewed-by:
-
Paweł Hajdan, Jr authored
This makes it possible to run hooks properly in flattened DEPS. Bug: 570091 Change-Id: If8175a57ebe8f607bd4ac83d4a26dcc4cc18165c Reviewed-on: https://chromium-review.googlesource.com/535476Reviewed-by:
-
Paweł Hajdan, Jr authored
This will be useful e.g. to add cwd support for flatten. No intended behavior change. Bug: 570091 Change-Id: I014f97739676d55f6d5b37c10afd9221b1d0978d Reviewed-on: https://chromium-review.googlesource.com/534193 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
-
Paweł Hajdan, Jr authored
It's unused, and not covered by tests. See https://codereview.chromium.org/9232068/ where it was added ~5 years ago for an abandoned project to convert to repo. Bug: 570091 Change-Id: Ica59cd3b28f92e05607203218cbeb92a377ec99a Reviewed-on: https://chromium-review.googlesource.com/534313Reviewed-by:
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I3b9fc0560bf744efed9e7f6d9a6595477cffbf8d Reviewed-on: https://chromium-review.googlesource.com/534393Reviewed-by:
-
- 13 Jun, 2017 9 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/d732be8c982f015796f0e620b7b46cff161b137f [context] Split "env" values and prefixes. (dnj@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Iaabc5692dc1e9c1281865564e30cced44cd4322e Reviewed-on: https://chromium-review.googlesource.com/534753Reviewed-by:
Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/a8816c7cb46f98d0becd31d3338b97088fc10c17 [path] Add "base_path" to __contains__, add get. (dnj@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I5cf34319656f9f6c40009b92b924ebdfc5dc35b7 Reviewed-on: https://chromium-review.googlesource.com/534733Reviewed-by:
-
Bruce Dawson authored
The second preview of VS 2017 Update 3 removed the MFC DLLs from the redist directory. Luckily it appears that we don't actually need them. The directories were also renamed from VC150 to VC141. This change switches to VC* to make it more robust, enabled by the use of glob added a few changes ago. crrev.com/2938453003, which tests a package that was created with this updated script, passed. BUG=683729 R=scottmg@chromium.org Change-Id: I4ae5dec949d16a83e1751e3d2ff7bd10a78b680f Reviewed-on: https://chromium-review.googlesource.com/534353Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
Robert Iannucci authored
823e17daf [led] add edit-cr-cl subcommand. 076fbac3c [led] refactor job.go 19c9d154e [led] refactor command-specific functions into their commands. 4e734e2f1 [led] fix broken help messages 9b90d51e6 [led] set buildbucket host instead of url. 42bb05cc3 [led] support symlinks. 3345e64e2 [led] fix some bugs. TBR=dnj@chromium.org, nodir@chromium.org Bug: 662654 Change-Id: Ifb68bb490fe4c8c535b5342e4163057d07844685 Reviewed-on: https://chromium-review.googlesource.com/533819Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/e089e513602ea7f98d0c6478686c0919b97497fc [url] Update vpython spec protobuf. (dnj@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I2069d0cae69530b9219d9eacd944142aa2e64bca Reviewed-on: https://chromium-review.googlesource.com/534254Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/264e3cab40de2ee04e33850810188e20d249f9d2 [step] Remove config indirection. (dnj@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Id9828090b889c09d1672b969c51d57cdcbff3bd6 Reviewed-on: https://chromium-review.googlesource.com/534135Reviewed-by:
-
Paweł Hajdan, Jr authored
TBR=dpranke Bug: 570091 Change-Id: I1b8cc8156c83c72b2fc599d90059bc7f2674ca17 Reviewed-on: https://chromium-review.googlesource.com/532995Reviewed-by:
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I2b68e8e8a0e28b28b9aab79833578cdf59392b98 Reviewed-on: https://chromium-review.googlesource.com/531185Reviewed-by:
-
Bruce Dawson authored
When no files are found where there should be on the VS packaging script throw an exception - using a non-existent variable. Resolving the missing files is a separate problem that I have filed a VS bug for: https://developercommunity.visualstudio.com/content/problem/67864/vs-2017-update-3-preview-2-is-missing-mfc-redist-f.html Bug: 683729 Change-Id: I1a3ba2a342ce7f8fa826300bb808e87c36969b52 Reviewed-on: https://chromium-review.googlesource.com/532114Reviewed-by:
-
- 12 Jun, 2017 5 commits
-
-
Bruce Dawson authored
Using goma requires the developer to remember which build directories use goma and which don't so that they can pass an appropriate -j number. Getting this wrong makes builds slower, either by under utilizing resources or by causing a self-inflicted DOS attack. Usage: autoninja -C out/debug autoninja looks at the settings for the specified build directory and then selects either -j num_cores*20 or no -j flag based on the use_goma setting. You can set the NINJA_CORE_MULTIPLIER variable to change from the default 20* multiplier. You can also use NINJA_CORE_ADDITION if you want non-goma builds to specify -j with an offset to the number of cores, such as this Linux command: NINJA_CORE_ADDITION=-2 autoninja -C out/release base This will tell autoninja to pass -j to ninja with num_cores-2 as the parameter. On Windows you can have a ninja.bat file (ahead of ninja on the path) such that autoninja will automatically be used. It should contain this: @call autoninja.bat %* Change-Id: I4003e3fc323d1cbab612999c945b5a8dc5bc6655 Reviewed-on: https://chromium-review.googlesource.com/517662Reviewed-by:Fumitoshi Ukai <ukai@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM+CQ. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/060325b14d5a63ce65e65d93052b265ee310a828 [path] Cleanup and use "C:\" for test Windows base (dnj@chromium.org) https://crrev.com/96221bce29d908b951812550036f42520f085dec [generator_script] Make allowed keys strict and improve error handling. (iannucci@chromium.org) https://crrev.com/cfff93afa16e61285e295d49f6aa2ba64642f330 [path] bring PLATFORM back to config. (iannucci@chromium.org) R=martiniss@chromium.org, phajdan.jr@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I214f2a5a0f39b09d7c401da8f997545336335bbb Reviewed-on: https://chromium-review.googlesource.com/531974 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/6d2596f2b4183b3abc59b92d0298e781e02d1687 [generator_script] constrain generator_script to have a stricter API. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: If0c38cc948b5ed998ff40df5aeb26aefe1d7b69b Reviewed-on: https://chromium-review.googlesource.com/531526Reviewed-by:
-
Paweł Hajdan, Jr authored
This will also be useful for other values (deps_os, hooks_os) we may want to store and keep constant. Freeze code copied from luci/recipes-py @ 944125e6d1e8c831d09517bde658a38d8f81db37 Bug: 570091 Change-Id: I3365cf2b267c478316870bbb3fd41e9955aa4ddf Reviewed-on: https://chromium-review.googlesource.com/531166 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/c7595ad0dd704f72e4765e2645501c553bef3af1 [file] fix "rmtree" on non-dir path (dnj@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ib07ee1b4327305d2fc59f199dcac22d7bb6c7034 Reviewed-on: https://chromium-review.googlesource.com/531224Reviewed-by:
-
- 10 Jun, 2017 2 commits
-
-
Robert Iannucci authored
R=dnj@chromium.org Bug: 662654 Change-Id: Ic5a59eeb67c435d54878ef5f060399f6b2963cd4 Reviewed-on: https://chromium-review.googlesource.com/523015 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
-
Robert Iannucci authored
R=dnj@chromium.org Bug: 720603 Change-Id: Iec447a7e32a4221009172f600ced7a9c19125266 Reviewed-on: https://chromium-review.googlesource.com/530099Reviewed-by:
-
- 09 Jun, 2017 3 commits
-
-
Aaron Gable authored
Bug: skia:6744 Change-Id: I0f84bd685bfacf692190f8636208122cf88d0b82 Reviewed-on: https://chromium-review.googlesource.com/529016Reviewed-by:
-
Andrii Shyshkalov authored
R=agable@chromium.org Bug: 728150 Change-Id: I3b2a843ac44bf447ce27a6d901d72a1c8035f496 Reviewed-on: https://chromium-review.googlesource.com/529112Reviewed-by:
-
Aaron Gable authored
TBR=tandrii@chromium.org Bug: 723787 Change-Id: Ie5017747f2070116774cd12ba0dd2ea531b2d0aa Reviewed-on: https://chromium-review.googlesource.com/529547Reviewed-by:
-
