Commits · 972ac5040176acd90c8a1ce412f75d19f77cc4e8 · Linshizhi / Chromium_Depot_tools

16 Sep, 2016 1 commit

bot_update: ensure correct depot_tools checkout is used. · 972ac504

tandrii authored Sep 16, 2016

R=vadimsh@chromium.org,martiniss@chromium.org
BUG=635641,647446

Review-Url: https://codereview.chromium.org/2346973003

972ac504

15 Sep, 2016 2 commits

Teach bot_update to remove partially deleted git repos. · 18ca30ca

vadimsh authored Sep 15, 2016

Also add logging to 'remove', helps to debug issues with 'build.dead' filling
up with crap.

R=iannucci@chromium.org, hinoka@chromium.org
BUG=647046

Review-Url: https://codereview.chromium.org/2342973002

18ca30ca

presubmit_support: Remove a noisy logging.debug() · adcd4b78

thakis authored Sep 15, 2016

On a CL with a single file, presubmit writes all this noise:

Running /b/build/slave/linux/build/src/PRESUBMIT.py
DEBUG:root:Running CheckChangeOnCommit in /b/build/slave/linux/build/src/PRESUBMIT.py
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.(cc|cpp|cxx|mm)$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:git diff -p --no-color --no-prefix --no-ext-diff 691e0c7d46341465de7a605b5f2aee941ccfedc0...HEAD --no-renames; cwd=/b/build/slave/linux/build/src
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:/usr/bin/python /b/build/slave/linux/build/src/tools/checkperms/checkperms.py --root /b/build/slave/linux/build/src --file content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:^(android_webview|base|content|net)[\\\/].* matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.(cc|cpp|cxx|mm)$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:LocalPaths: ['content/browser/gpu/gpu_data_manager_impl_private.cc']
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.(cc|cpp|cxx|mm)$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:.+\.cc$ matched content/browser/gpu/gpu_data_manager_impl_private.cc
DEBUG:root:Running CheckChangeOnCommit done.

The "a matched b" lines are boring and numerous, so remove this log line.
If we ever need it to debug something, we can add it back then (temporarily).

(From https://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/260304/steps/presubmit/logs/stdio)

BUG=none

Review-Url: https://codereview.chromium.org/2341103002

adcd4b78

14 Sep, 2016 7 commits

repo: update to v1.12.17-cr1 · 7475196d

vapier authored Sep 14, 2016

We've synced our fork of repo to upstream. This change copies the new
version into depot_tools.

BUG=chromium:632203
TEST=`repo sync` still works
TEST=`repo sync` with a tag signed by me works
TEST=`repo init` with my tag is accepted

Review-Url: https://codereview.chromium.org/2340073002

7475196d

git cl land to refs/pending: remove unused arg. · bf429405
tandrii authored Sep 14, 2016
```
R=iannucci@chromium.org
BUG=642493

Review-Url: https://codereview.chromium.org/2322783002
```
bf429405

Gerrit git cl land: abort if not uploaded. · 73449b0b

tandrii authored Sep 14, 2016

R=agable@chromium.org
BUG=642759,609225

Review-Url: https://codereview.chromium.org/2317253003

73449b0b

git_cl: update outdated TODOs. · 5d0a0421

tandrii authored Sep 14, 2016

R=machenbach@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2339903002

5d0a0421

codereview.settings: add GIT_NUMBER_FOOTER setting. · f46c20fc

tandrii authored Sep 14, 2016

This will be used in repositories that use Cr-Commit-Position footers
to generate them at the time of git cl land instead of gnumbd.

R=iannucci@chromium.org
BUG=642493

Review-Url: https://codereview.chromium.org/2324583002

f46c20fc

Roll recipe dependencies (nontrivial). · 34aa4d98

recipe-roller authored Sep 14, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must CQ the change manually.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/82c60d376b779c86f78ce98884fd4f887382e9ec Add better documentation, trigger namedtuple. (dnj@chromium.org)

R=dnj@chromium.org
BUG=None

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2335163004

34aa4d98

Add recipe-roller as an OWNER of recipe modules. · 33061f78

martiniss authored Sep 14, 2016

See https://codereview.chromium.org/2335163004 for why this is needed. The
roller can't land a non-trivial CL with the upstream author's LGTM, because
it's not an OWNER of the recipes in the repo it's rolling into.

Review-Url: https://codereview.chromium.org/2337263002

33061f78

13 Sep, 2016 4 commits

Roll recipe dependencies (trivial). · 65cc5b19

recipe-roller authored Sep 13, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/ca75ca80dcfcc2a2dc38096ba0522065ebd347ec Revert of Require recipe tryjob for CQ. (patchset #1 id:1 of https://codereview.chromium.org/2153303002/ ) (martiniss@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=644609,628801

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2338723003

65cc5b19

Roll recipe dependencies (nontrivial). · 1ce79108

recipe-roller authored Sep 13, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must CQ the change manually.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/dbdcd3b5c9096b3a770bdb61e15039115b6a8dd3 Revert of Add better documentation, trigger namedtuple. (patchset #3 id:40001 of https://codereview.chromium.org/2332833003/ ) (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=None

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2336313002

1ce79108

Skip apply_gerrit rebase when there is a rebase failure. · ea9e93f2

rmistry authored Sep 13, 2016

Not doing so causes a failure in the 'git checkout $base_rev' step as visible here: https://build.chromium.org/p/client.skia.fyi/builders/Infra-PerCommit-Trybot/builds/4995
This causes the checkout to remain in the "rebase in progress" state.

BUG=chromium:645955
BUG=skia:5749

Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/9736fe8938e67337bb45dccf79ae8699b9625fa6
Review-Url: https://codereview.chromium.org/2328313002

ea9e93f2

Roll recipe dependencies (trivial). · 53323d73

recipe-roller authored Sep 13, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/be22c9a16dd89f9780e193a24edd98346870271d Formally define step config, pass to stream. (dnj@chromium.org)
  https://crrev.com/8ad49e0698f1e74e3f500fda6ca5b65a2af29fd0 Add better documentation, trigger namedtuple. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=None,chromium:628770

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2338573002

53323d73

12 Sep, 2016 2 commits

Revert of Skip apply_gerrit rebase when there is a rebase failure (patchset #2... · b9403858

rmistry authored Sep 12, 2016

Revert of Skip apply_gerrit rebase when there is a rebase failure (patchset #2 id:20001 of https://codereview.chromium.org/2328313002/ )

Reason for revert:
The "git rebase --abort" should only happen when there is a failure during rebase not when it succeeds.

Original issue's description:
> Skip apply_gerrit rebase when there is a rebase failure.
>
> Not doing so causes a failure in the 'git checkout $base_rev' step as visible here: https://build.chromium.org/p/client.skia.fyi/builders/Infra-PerCommit-Trybot/builds/4995
> This causes the checkout to remain in the "rebase in progress" state.
>
>
> BUG=chromium:645955
> BUG=skia:5749
>
> Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/9736fe8938e67337bb45dccf79ae8699b9625fa6

TBR=agable@chromium.org,andybons@chromium.org,tandrii@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:645955

Review-Url: https://codereview.chromium.org/2331103002

b9403858

Skip apply_gerrit rebase when there is a rebase failure. · 9736fe89

rmistry authored Sep 12, 2016

BUG=chromium:645955
BUG=skia:5749

Review-Url: https://codereview.chromium.org/2328313002

9736fe89

09 Sep, 2016 7 commits

Use 'draft' status to restrict access to private Gerrit reviews · c6787971
agable authored Sep 09, 2016
```
R=andybons@chromium.org, tandrii@chromium.org

Review-Url: https://codereview.chromium.org/2324283002
```
c6787971

A bunch more little cleanups in bot_update. · d1d31d5d

iannucci authored Sep 09, 2016

R=agable@chromium.org, estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org
BUG=643885

Review-Url: https://codereview.chromium.org/2321203003

d1d31d5d

Don't try svn.chromium.org for src-internal check · 9fc45897

scottmg authored Sep 09, 2016

svn://svn.chromium.org/chrome-internal/trunk/src-internal/ doesn't seem
to exist any more.

d:\src>"d:\src\depot_tools\svn_bin\svn.exe" ls --non-interactive svn://svn.chromium.org/chrome-internal/trunk/src-internal/
svn: Can't connect to host 'svn.chromium.org': A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

R=brucedawson@chromium.org

Review-Url: https://codereview.chromium.org/2327213002

9fc45897

WebRTC: Remove references to src/third_party/libjingle/source/talk · 9abf453c

kjellander authored Sep 09, 2016

A while back, we removed the last pieces of code in
src/third_party/libjingle/source/talk and it is no longer synced
in Chromium's DEPS file. Clean this up to avoid confusion in the
buildbot recipes.

BUG=webrtc:4256

Review-Url: https://codereview.chromium.org/2325043002

9abf453c

Switch bot_update to use exponential backoff on clone · c958da49
agable authored Sep 09, 2016
```
R=iannucci@chromium.org
BUG=472386

Review-Url: https://codereview.chromium.org/2324073002
```
c958da49

Remove unused PATCH_TOOL and resulting dead code from bot_update. · 3dd74368

iannucci authored Sep 09, 2016

R=agable@chromium.org, estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org
BUG=643885

Review-Url: https://codereview.chromium.org/2328883002

3dd74368

Reland "Delete lots of svn logic from bot_update" · 3454ae85

agable authored Sep 09, 2016

This is a reland of 082267a6
which was reverted in 4dcad385

BUG=472386

Review-Url: https://codereview.chromium.org/2325513002

3454ae85

08 Sep, 2016 10 commits

Roll recipe dependencies (trivial). · 0c2dfcb7

recipe-roller authored Sep 08, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/227f56ba6353986a7fe6d56fb283ad73c84e94d9 Track step nesting in StreamEngine (Reland). (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:628770

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2325773004

0c2dfcb7

Fix typobug in bot_update.py. · 0abcd264

iannucci authored Sep 08, 2016

Extra comma changes type from dict to tuple :(

TBR=agable@chromium.org, estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org
BUG=643885
NOPRESUBMIT=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2325763002

0abcd264

Roll recipe dependencies (trivial). · 92ded3f2

recipe-roller authored Sep 08, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/339eace18cba35868b8bbb039100448fbfc58d15 Revert of Track step nesting in StreamEngine. (patchset #5 id:80001 of https://codereview.chromium.org/2245113002/ ) (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:628770

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2328713002

92ded3f2

Remove bogus master/builder/slave parameters from bot_update. · 16e7f097

iannucci authored Sep 08, 2016

Bot update now always runs regardless of environmental context.

R=estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org, tandrii@chromium.org
BUG=643885

Review-Url: https://codereview.chromium.org/2308193002

16e7f097

Remove force parameter from bot_update.ensure_checkout. · 990ab1b4

iannucci authored Sep 08, 2016

This is the simplest change I can make here. The bot_update.py script already
ignores the value of force (and sets it to True in all cases). This is an
expectations-only change.

I'll refactor the content of the bot_update.py script to account for this
removed option in a followup CL as well.

R=agable@chromium.org, estaab@chromium.org, hinoka@chromium.org, martiniss@chromium.org
BUG=643885

Review-Url: https://codereview.chromium.org/2316323002

990ab1b4

Roll recipe dependencies (trivial). · 1332f33d

recipe-roller authored Sep 08, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/4b3ff6014bcb018aff9ae2755faf47cc304f47af Track step nesting in StreamEngine. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:628770

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2321813004

1332f33d

Propagate use_relative_paths into recursedeps · dce6ddcd

agable authored Sep 08, 2016

Currently, if a DEPS file sets use_relative_paths, but *also* sets
recursedeps, then the recursed-upon DEPS files still get checked
out relative to the .gclient root. This change makes it so that
recursed-upon DEPS files check their dependencies out relative to
where their parent wants them to be, if that parent sets
use_relative_paths=True.

R=maruel@chromium.org

Review-Url: https://codereview.chromium.org/2324513003

dce6ddcd

Update gclient test to assert both dir and url · 73baf853

agable authored Sep 08, 2016

This makes it easier to reason about tests which care about
both the url being fetched and the directory to which it is
being fetched, like those concerning relative paths and
recursion.

R=maruel@chromium.org

Review-Url: https://codereview.chromium.org/2316963004

73baf853

Prompt to delete pending edits before changing the Gerrit CL description. · e2d6fd98
dsansome authored Sep 08, 2016
```
BUG=641838

Review-Url: https://codereview.chromium.org/2318903002
```
e2d6fd98
Copy over bot_update_coverage_test.py · eb20eaec
hinoka authored Sep 08, 2016
```
BUG=

Review-Url: https://codereview.chromium.org/2316393002
```
eb20eaec

07 Sep, 2016 7 commits

Revert of Delete lots of svn logic from bot_update (patchset #5 id:80001 of... · 4dcad385

bpastene authored Sep 07, 2016

Revert of Delete lots of svn logic from bot_update (patchset #5 id:80001 of https://codereview.chromium.org/2280213002/ )

Reason for revert:
Everything's purple :(

Original issue's description:
> Delete lots of svn logic from bot_update
>
> R=hinoka@chromium.org
> BUG=472386
>
> Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/082267a659f94bf7bca5cb144e203ca0913abb3a

TBR=hinoka@chromium.org,hinoka@google.com,iannucci@chromium.org,agable@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=472386

Review-Url: https://codereview.chromium.org/2320653003

4dcad385

gclient: Prune dangling remote tracking refs when fetching with --force · 2a3e9913
bpastene authored Sep 07, 2016
```
BUG=644722

Review-Url: https://codereview.chromium.org/2320573005
```
2a3e9913

Delete lots of svn logic from bot_update · 082267a6

agable authored Sep 07, 2016

R=hinoka@chromium.org
BUG=472386

Review-Url: https://codereview.chromium.org/2280213002

082267a6

Remove redundant output in git_cl.py tests. · 8da412cf
tandrii authored Sep 07, 2016
```
R=agable@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2319903002
```
8da412cf

Revert of Require recipe tryjob in CQ (patchset #1 id:1 of... · 925b910a

martiniss authored Sep 07, 2016

Revert of Require recipe tryjob in CQ (patchset #1 id:1 of https://codereview.chromium.org/2157503003/ )

Reason for revert:
Downstream tester messed up now, see https://crbug.com/644609

Original issue's description:
> Require recipe tryjob in CQ
>
> BUG=628801
>
> Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/ac74456f1e697f38598cda9b1c1acedb80702c7a

TBR=phajdan.jr@chromium.org,estaab@chromium.org,iannucci@chromium.org
NOTRY=true
(no try because the tester itself is broken)
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=628801, 644609

Review-Url: https://codereview.chromium.org/2322763002

925b910a

Remove gerrit_rebase_patch_ref flag from bot_update API · f0b03783
andybons authored Sep 07, 2016
```
BUG=612417

Review-Url: https://codereview.chromium.org/2317213002
```
f0b03783

Remove svn from gclient recipe module example · fbfa601e

agable authored Sep 07, 2016

R=martiniss@chromium.org
BUG=640251

Review-Url: https://codereview.chromium.org/2318843002

fbfa601e