Commits · 96e179bba0f81a12ed57c9840f1ad4b060bc20cd · Linshizhi / Chromium_Depot_tools

24 Jun, 2016 2 commits

Better error checking in git freeze · 96e179bb

agable authored Jun 24, 2016

R=iannucci@chromium.org
BUG=567157

Review-Url: https://codereview.chromium.org/1527403002

96e179bb

gclient: fix patch_project handling for the recipe engine · cd0b7abe

phajdan.jr authored Jun 24, 2016

This is needed after https://github.com/luci/recipes-py/commit/d88f0c8311fdf2fe2d258d1032f84a251ceba83f

BUG=none

Review-Url: https://codereview.chromium.org/2091313003

cd0b7abe

23 Jun, 2016 5 commits

git cl upload: add --message-file to provide arbitrary messages. · b80458a7
tandrii authored Jun 23, 2016
```
R=martiniss@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2087393004
```
b80458a7

Limit the number of extra/missing files that get printed. · a0e66ea6

sebmarchand authored Jun 23, 2016

The message now look like this:

2 files missing from the 9ff97version of the toolchain:
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\assert.h
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\complex.h
22 extra files in the 9ff97version of the toolchain:
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\assert_.h
        vs2013_files\9ff97\win_sdk\Include\10.0.10240.0\ucrt\complex_.h
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\string\wmemmove_s.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\asctime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\clock.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\ctime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\days.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\difftime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\ftime.cpp
        vs2013_files\9ff97\win_sdk\Source\10.0.10240.0\ucrt\time\gmtime.cpp
        ...

R=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2092753003

a0e66ea6

Roll recipe dependencies (trivial). · 37b270d7

recipe-roller authored Jun 23, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/467c65451222b2d425497477338930b4a7898f83 fix mismatched quote in cq.cfg (martiniss@google.com)

R=martiniss@google.com
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2091863002

37b270d7

Roll recipe dependencies (trivial). · 5d16deeb

recipe-roller authored Jun 23, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/d88f0c8311fdf2fe2d258d1032f84a251ceba83f change id to recipe_engine (martiniss@google.com)

R=martiniss@google.com
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2098563002

5d16deeb

Roll recipe dependencies (trivial). · 7a4861dd

recipe-roller authored Jun 23, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/b9e897ad16ef22c054cf5fd525124fa66711fa6e Remove 'remote_run' command (replaced with 'remote') (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=chromium:459840

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2095623002

7a4861dd

22 Jun, 2016 7 commits

Roll recipe dependencies (trivial). · 828e8a87

recipe-roller authored Jun 22, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/98030a88041df67bae71e0bdb0d0f8248c8dd910 do not print <br> in step text (nodir@chromium.org)

R=nodir@chromium.org,martiniss@chromium.org,hinoka@chromium.org
BUG=622503

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2091593002

828e8a87

Make git-freeze bail out if the user has too much untracked data. · 02b3c98b
agable authored Jun 22, 2016
```
R=iannucci@chromium.org
BUG=376099

Review-Url: https://codereview.chromium.org/2052113002
```
02b3c98b

handle configparser rename in python3 · 9f343717

vapier authored Jun 22, 2016

The ConfigParser module was renamed to configparser, so update the
two modules using it to try both (and default to the new name).

Review-Url: https://codereview.chromium.org/2076653002

9f343717

Gerrit git cl land: add warning if Commit-Queue label exists. · d60367ba
tandrii authored Jun 22, 2016
```
BUG=612727
R=agable@chromium.org

Review-Url: https://codereview.chromium.org/2089683002
```
d60367ba

Roll recipe dependencies (trivial). · 27ed22e6

recipe-roller authored Jun 22, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/2514f69431aba26d302fbc38b344a36864a94d9b Add 'remote' command to replace 'remote_run' (phajdan.jr@chromium.org)
  https://crrev.com/9540897c91022bfca86cac689bd52823f61b357f Add support for fetching repo updates from Gitiles (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=chromium:459840

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2083333002

27ed22e6

Rietveld git cl status: ignore CQ dry run and generated messages. · 9d2c7a3d
tandrii authored Jun 22, 2016
```
R=sergiyb@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2083063002
```
9d2c7a3d

Add warning for non-https remotes in Gerrit git cl upload. · e32e3eae

tandrii authored Jun 22, 2016

R=shinyak@chromium.org,sergiyb@chromium.org
BUG=614312

Review-Url: https://codereview.chromium.org/2085013002

e32e3eae

21 Jun, 2016 3 commits

Bump git-cl version to 2.0, since we now support Gerrit. · 7400cf0f
tandrii authored Jun 21, 2016
```
R=andybons@chromium.org
BUG=618017

Review-Url: https://codereview.chromium.org/2077773003
```
7400cf0f

Refactor git_common config and die · 7aa2ddd8

agable authored Jun 21, 2016

R=iannucci@chromium.org
BUG=376099

Review-Url: https://codereview.chromium.org/2075603002

7aa2ddd8

Remove SVN code from update_depot_tools · a0e5cc40

Aaron Gable authored Jun 21, 2016

R=maruel@chromium.org
BUG=600446

Review URL: https://codereview.chromium.org/2088653003 .

a0e5cc40

20 Jun, 2016 4 commits

Roll recipe dependencies (trivial). · f0834e44

recipe-roller authored Jun 20, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/d6668158ac17d845f016c191258b733947169ad1 Add per step timeout (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2081783002

f0834e44

git cl test framework: improve debuggability of expected calls. · 9d206759
tandrii authored Jun 20, 2016
```
R=phajdan.jr@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2074233002
```
9d206759
Default to y(es) when asking user about archiving committed branches · 4a5ecbe6
sergiyb authored Jun 20, 2016
```
R=tandrii@chromium.org

Review-Url: https://codereview.chromium.org/2074723002
```
4a5ecbe6

Gerrit git cl upload: --squash is now default. · a60502f2

tandrii authored Jun 20, 2016

You can override it for all devs of repo by adding line to codereview.settings:
  GERRIT_SQUASH_UPLOADS: (True|False)

And even with that, individual devs can overide it for themselves with:
  git config [--global] --bool gerrit.override-squash-uploads (true|false)

BUG=611892

Review-Url: https://codereview.chromium.org/2072363002

a60502f2

17 Jun, 2016 7 commits

Roll recipe dependencies (trivial). · 95369051

recipe-roller authored Jun 17, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/3495f24ac7834058a1490b6253e413f78d6adb93 remove whitespace (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2073253002

95369051

cit: print to stderr to allow piping from cit log cat. · 56396af3

tandrii authored Jun 17, 2016

R=hinoka@chromium.org,stip@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2062053002

56396af3

Add SVN->Git migration warning to git cl dcommit users. · 3bb82ff1

tandrii authored Jun 17, 2016

R=mmoss@chromium.org,benhenry@chromium.org
BUG=600451,161849

Review-Url: https://codereview.chromium.org/2074883002

3bb82ff1

Remove git-tree-prune. · 461a222a

tandrii authored Jun 17, 2016

PSA [1] has been sent 3 weeks ago. Alternative git cl archive landed 1 week ago.
No comments have been received since then. Also, this tool is not even in
top-level depot_tools, hence outside of $PATH for most people, user impact
should be very limited.

[1] PSA link:
https://groups.google.com/a/chromium.org/d/msg/infra-dev/K2qwUQ-mRUM/nnYcTDD8AQAJ

BUG=616404
R=machenbach@chromium.org

Review-Url: https://codereview.chromium.org/2077943003

461a222a

Enforce GN formatting for *.typemap files. · 58edce2b

kylechar authored Jun 17, 2016

Ensure consistent formatting for Mojo typemap files that define the
build rules to generate StructTraits.

BUG=620799
TEST=Tested locally, both presubmit and git cl format work as expected.

Review-Url: https://codereview.chromium.org/2074793002

58edce2b

Roll recipe dependencies (trivial). · 7d44639e

recipe-roller authored Jun 17, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/d6f0e607c1bca05178f248b9f06619749a8c42d8 Introduce different repo types (git and gitiles) (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=chromium:459840

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2074073002

7d44639e

Simplify octal constants in Python code (e.g. 0o0700 -> 0o700). · 1dfe43ca
mgiuca authored Jun 17, 2016
```
Review-Url: https://codereview.chromium.org/2075923003
```
1dfe43ca

16 Jun, 2016 12 commits

Gerrit git cl upload: Remove --no-squash warning message. · edbf9a3e

tandrii authored Jun 16, 2016

First, it's wrong because of instruction in it is ineffective.
Second, it was also shown during --squash upload, which is completely wrong.

TBR=sergiyb@chromium.org
BUG=611892

Review-Url: https://codereview.chromium.org/2072923002

edbf9a3e

Revert of Gerrit git cl: allow overriding GERRIT_SQUASH_UPLOADS in git config.... · 8dd81ea2

tandrii authored Jun 16, 2016

Revert of Gerrit git cl: allow overriding GERRIT_SQUASH_UPLOADS in git config. (patchset #2 id:20001 of https://codereview.chromium.org/2070013002/ )

Reason for revert:
I suspect this broke squash setting setup.

Original issue's description:
> Gerrit git cl: allow overriding GERRIT_SQUASH_UPLOADS in git config.
>
> Previously, if GERRIT_SQUASH_UPLOADS was found in codereview.settings,
> a local repository value of gerrit.squash-uploads would be set.
>
> This CL changes that, so that gerrit.squash-uploads property is written
> with GERRIT_SQUASH_UPLOADS value ONLY IF the property wasn't set before.
>
> This allows individual users to choose their own way with
>   git config [--global] -bool gerrit.squash-uploads (true|false)
>
> BUG=611892
> R=andybons@chromium.org,sergiyb@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/768ec9a75560b5e5903d86654d4c1ab2afe17361

TBR=andybons@chromium.org,sergiyb@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=611892

Review-Url: https://codereview.chromium.org/2071963002

8dd81ea2

git cl upload: stop using deprecated except syntax · 2cc483c1

vapier authored Jun 16, 2016

The newer form works with python2 and python3.

Review-Url: https://codereview.chromium.org/2076643002

2cc483c1

Cleanup CQ config post SVN->Git migration. · 62d045ce
tandrii authored Jun 16, 2016
```
R=sergiyb@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2074823002
```
62d045ce

git cl upload: convert to print_function · c0943768

vapier authored Jun 16, 2016

This makes the code work both in python2 and python3.

Review-Url: https://codereview.chromium.org/2078553002

c0943768

use py3 compatible octal constants · 8057ac88
vapier authored Jun 16, 2016
```
Review-Url: https://codereview.chromium.org/2076613002
```
8057ac88
Add project-infra-tryjob-access to dry-runners of CQ. · 214df955
tandrii authored Jun 16, 2016
```
TBR=sergiyb@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2071703003
```
214df955

httplib2: update to 0.9.2 release · 45c2edf7

vapier authored Jun 16, 2016

This is in preparation for adding py3 support.

Review-Url: https://codereview.chromium.org/2073823002

45c2edf7

git_cl: convert to print_function · a7fbd5a9

vapier authored Jun 16, 2016

This makes the code work both in python2 and python3.

Review-Url: https://codereview.chromium.org/2066003002

a7fbd5a9

git_cl: stop using deprecated except syntax · fd77ac7c

vapier authored Jun 16, 2016

The newer form works with python2 and python3.

Review-Url: https://codereview.chromium.org/2061023003

fd77ac7c

Gerrit git cl: allow overriding GERRIT_SQUASH_UPLOADS in git config. · 768ec9a7

tandrii authored Jun 16, 2016

Previously, if GERRIT_SQUASH_UPLOADS was found in codereview.settings,
a local repository value of gerrit.squash-uploads would be set.

This CL changes that, so that gerrit.squash-uploads property is written
with GERRIT_SQUASH_UPLOADS value ONLY IF the property wasn't set before.

This allows individual users to choose their own way with
  git config [--global] -bool gerrit.squash-uploads (true|false)

BUG=611892
R=andybons@chromium.org,sergiyb@chromium.org

Review-Url: https://codereview.chromium.org/2070013002

768ec9a7

Expose fnmatch in presubmit's input_api. · 091b7db6
dcheng authored Jun 16, 2016
```
BUG=611905

Review-Url: https://codereview.chromium.org/2070493002
```
091b7db6