- 12 Nov, 2019 2 commits
-
-
Edward Lemur authored
pythond and python3 are still downloaded from cipd, but python3 is no longer shim'd into depot_tools on Linux, so is not available on PATH. Modify PATH in vpython and vpython3 on Linux to point to the python3 download directory, so that the version downloaded from cipd is used. Bug: 1017812 Change-Id: I70bc8e7d460f60dcbfa5e141127edecfc2b44744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1893982 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org>
-
Yang Guo authored
Change-Id: Ib416a8a00c57c21d31d16d928932fcd16f39426f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1903486 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org>
-
- 11 Nov, 2019 4 commits
-
-
Edward Lemur authored
This is a reland of c87ed606 Fix on the reland: Encode change description before writing to temporary file. Original change's description: > git-cl: Fix some python3 compatibility errors. > > Also, fix bug in git cl status where the 'updated' field was used to compare messages, even though > it doesn't exist (see [1]). This CL modifies it to use 'date', which does exist. > > [1] https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#change-message-info > > Bug: 1002209 > Change-Id: I5a5e1193b8502c3ad35d94808ea178cad7f44ac6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1891259 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Anthony Polito <apolito@google.com> Bug: 1002209 Change-Id: I2f0fc779ea3e361e6d32ee7ce1e53cbddb5cfdea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1898702 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com>
-
Edward Lemur authored
Change-Id: I086ebb327ca9ad3021c50bbc159867ea150daabd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1898695Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lesmes authored
Bug: 939847 Change-Id: Ic5f87c7423ab72086ca928fecc15ed60408fbedd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1900165Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Bug: 1018293 Change-Id: I9b915c3b4a1218e6318efde005c4f38243a35055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1900309Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 08 Nov, 2019 5 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/2102e819b3d68cf17a7dc72bc2b45b7431292215 Reland "Add swarming.TaskRequest.from_jsonish()" (garymm@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I4785ca6804bbd9e660e3d208d898dab398cc753f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1907457Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Bruce Dawson authored
The "CPU time" values printed by post_build_ninja_summary.py are not actually measure of CPU time, they are measures of wall-clock time or elapsed time. This just changes the labeling of the numbers - the actual numbers printed are unchanged. The "weighted time" number continues to be the more important number since it is an approximation of how much the build step(s) are affecting build time. See the comments in the script for details. Change-Id: Ibdb4efdd327ece34492ab10337c234a826514197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1900019 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/8eb3985beff2b4d0cf0bae61a7a3dab29271849f [recipe_modules/cipd] Expose default test data input for cipd.search. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Icc009c79b72f02eac992b2c415903d68a0106056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1906737Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
danakj authored
This changes the behaviour when applying a patch to not fetch tags along with the patch being applied. The fetch to apply a patch only needs the commits that will be cherry picked, it does not need tags. Fetching tags creates slow bottlenecks if a repo such as chromium has 10k+ tags. Using --no-tags prevents the server from sending the list of all tags and the client from processing them. Bug: 1019824 Change-Id: I756beb8c2b0c7ec3c0fc48b7431d0cf8c0bbbbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1894393Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: danakj <danakj@chromium.org>
-
Stephen Martinis authored
This reverts commit 72a245e4. Reason for revert: crbug.com/1022617 Original change's description: > Fetch the input commit ref when both ref and id are specified. > > This causes --refs refs/head/master to be added to bot_update calls when > the input build message contains a commit id and the refs/head/master > ref. This is an effective no-op. > > When bot_update clones a git repository, it results in HEAD referring to > master in contrast to the non-clone case which results in a detached > HEAD. This prevents fetching refs/heads/master, so detach the HEAD after > cloning. > > Bug: 922150 > Change-Id: I357a78305020218e9f5d350832a706b8f2b27967 > Recipe-Nontrivial-Roll: build > Recipe-Nontrivial-Roll: build_limited_scripts_slave > Recipe-Nontrivial-Roll: infra > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1900735 > Commit-Queue: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> TBR=ehmaldonado@chromium.org,gbeaty@chromium.org Change-Id: Ibd6c6ed272b0c98f82be50cefa521aaee0444f11 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 922150, 1022617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1904099Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
-
- 07 Nov, 2019 3 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/71729a14269530e56e9a74c0335e7d4385969153 Allow StepPresentation logs to be a single string (mheikal@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I8217341fadf2da2394bbdd2bf5060e006faaf874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1904729Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Garrett Beaty authored
This causes --refs refs/head/master to be added to bot_update calls when the input build message contains a commit id and the refs/head/master ref. This is an effective no-op. When bot_update clones a git repository, it results in HEAD referring to master in contrast to the non-clone case which results in a detached HEAD. This prevents fetching refs/heads/master, so detach the HEAD after cloning. Bug: 922150 Change-Id: I357a78305020218e9f5d350832a706b8f2b27967 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: infra Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1900735 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
Jasper Chapman-Black authored
Recipe-Nontrivial-Roll: build Change-Id: I76c2db161677852b005f2b934ff96f7369844fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1900486 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
- 06 Nov, 2019 4 commits
-
-
danakj authored
Bug: 1019824 Change-Id: Ibec0b47067345150dbd2083265c49fb9b6769a3a Recipe-Nontrivial-Roll: build Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1894408 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/9aeddce5ce569741c849c155d94b4966832356eb Add swarming.TaskRequest.from_jsonish() (garymm@google.com) https://crrev.com/ce6248afeab2c85d8e9eebc934339c26d048d0fb Revert "Add swarming.TaskRequest.from_jsonish()" (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I87a944c18c3cf2af24d3f8617c9b04d9978b07e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1900365Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/97ead225e3da23cbd18605e0f4cec0417412da64 isolated: roll isolated (tikuta@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Icf7453d63b380f64d03fec04e43a81eeceb5094b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1900598Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Vadim Shtayura authored
Contains a fix for crbug.com/1021520. R=nodir@chromium.org, tandrii@chromium.org BUG=1021520 Change-Id: I7f0ac984f9740613b34adf45a2f3d8013923c7ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1900490 Auto-Submit: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
-
- 05 Nov, 2019 3 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/482cd39e373ee9af9c4726064a1a62efcc8bfb2a [buildbucket] Don't accept project=None in schedule_request (olivernewman@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ie312133f20be523ac0b6f463348ad21a8256d87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1900323Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Vadim Shtayura authored
Adds `strutil.template(...)` function. R=nodir@chromium.org, tandrii@chromium.org Change-Id: Id1a160c02bb63647cbc5215347d6024bc5d14ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1899569 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> Auto-Submit: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org>
-
danakj authored
There are 3 layers modified, starting from the bottom up: 1. git_cache.py populate Now takes a --no-fetch-tags option. If specified, the cache will not fetch updated tags from the server by passing --no-tags to git fetch. This prevents the server from sending all the tag refs. In chromium this prevents significant time bottlenecks dealing with 10k+ tags. 2. bot_update.py bot_update has to deal with multiple git repos, it has the root repo that is checked out through git-cache, as well as repos synched via DEPS and gclient. The script now takes a --no_fetch_tags option. If specified, the git-cache populate call will include --no-fetch-tags. Otherwise, it won't. So this controls (for chromium) if fetches to the src.git server are passed --no-tags. 3. bot_update/api.py This is the entry point for recipes and also has to deal with multiple git repos. The behaviour at this point is not changed from the default. A |no_fetch_tags| parameter is added to ensure_checkout() that defaults to False. This CL is a refactor with no intended behavior change. The next step will be to change the chromium build repo to pass True for ensure_checkout(no_fetch_tags) on chromium trybots. This represents solution #2 in https://docs.google.com/document/d/1hDIunJjjfpmr50y3YnZ4o3aq1NZF4gJa1TS0p7AIL64/edit# Bug: 1019824 Change-Id: I935430603299daa9e301a95a5184c0ce486fd912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1894352Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org>
-
- 04 Nov, 2019 3 commits
-
-
Edward Lesmes authored
This reverts commit c87ed606. Reason for revert: Causes a regressions for CL descriptions on Windows Original change's description: > git-cl: Fix some python3 compatibility errors. > > Also, fix bug in git cl status where the 'updated' field was used to compare messages, even though > it doesn't exist (see [1]). This CL modifies it to use 'date', which does exist. > > [1] https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#change-message-info > > Bug: 1002209 > Change-Id: I5a5e1193b8502c3ad35d94808ea178cad7f44ac6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1891259 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Anthony Polito <apolito@google.com> TBR=ehmaldonado@chromium.org,apolito@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1002209 Change-Id: I004f202b12c6b99cb6b24cb12a14fba7898569e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1898547Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Sorting owners by score is non-deterministic, so sort by name too. Bug: 1009814 Change-Id: I93a9370a5852634b4bbb2768b9ebbb5b866348e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1891665 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com>
-
Edward Lesmes authored
Bug: 1007872, 1009819 Change-Id: Icb24badc0429012dc66912d7d35e03a456512787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1894354Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 01 Nov, 2019 3 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/e9ca19a0946a226ba6011bfadcc19a13340268dd Improve docstrings for step module. (gbeaty@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I09a43f8540b9e545a38203ea497ff2e24387bb65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1895977Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Robert Iannucci authored
This makes no-rebase-patch-ref correctly populate `file_list` and work with `git diff --cached` (i.e. they will show only the files affected by the patchset). Previously gclient would `reset --soft` to master. Because we didn't rebase on top of master with `no-rebase-patch-ref`, it has roughly nothing to do with the patchref we just checked out. R=gbeaty@chromium.org, ltina@google.com, tandrii@chromium.org Context: Tricium recipes sometimes need to use no-rebase-patch-ref in order to get accurate linenumbers in the diff (i.e. so that the tricium comments will actually line up correctly with the patchset the user uploaded); Tricium recipes also need to accurately get the diff file list in this mode. Change-Id: I5f3c95cd4958cf407a83b96c238b8c55c452ac81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1895041 Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
-
danakj authored
The finder.owners_queue contains a set of owners but they appear in an arbitrary order on each invocation of the test. The current method of assertEqual() with a list fails randomly because of the ordering being different. Example: https://ci.chromium.org/p/infra/builders/try/Depot%20Tools%20Presubmit%20(win)/b8897976148721436512 This changes comparisons of owners_queue to use an assertEqualSets() which does a comparison that is order-independent. Change-Id: Ia827795af283dadeb56f76ae0cf14fa4ad7e9eeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1895699Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: danakj <danakj@chromium.org>
-
- 31 Oct, 2019 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/afc73d4e075d241d52b01b744e73111ee3f0c47c [buildbucket] Support custom field masks (smut@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I10e814d8debb98801cd2b62f77f698da903b165f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1894402Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 30 Oct, 2019 11 commits
-
-
Edward Lemur authored
Also, fix bug in git cl status where the 'updated' field was used to compare messages, even though it doesn't exist (see [1]). This CL modifies it to use 'date', which does exist. [1] https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#change-message-info Bug: 1002209 Change-Id: I5a5e1193b8502c3ad35d94808ea178cad7f44ac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1891259 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Anthony Polito <apolito@google.com>
-
Edward Lemur authored
The problems on crbug.com/1017367 should have been fixed by crrev.com/c/1880013 Bug: 1009814 Change-Id: Ia98304ca983b4e7e293fedb9df1fee589de58ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1887714Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Bug: 1009814 Change-Id: Ifb073dc0b54a3291f1f874866da3c0fbbeab2db9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1888443Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Bug: 1009809 Change-Id: I47c9a468b2922248b823ebae5e71863a698c30f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1889166Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
It's not used and uses basestring, which is not supported in Python 3. Bug: 1002209 Change-Id: I9df900076978636c4a5c75e84432a8cc02d46909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1891654Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
basestring doesn't exist in Python 3. scm.Capture status doesn't need to support strings either. Bug: 1002209 Change-Id: Ie9edfdfd09b789bfaace038a6ad8f3a7da344bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1890925Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/5f5aea33b7cac05bfc7f7b68332de60ddd143be3 Roll swarming go client (dcheng@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I7ba97dd288a975b9eba69b7b66137a9e221fbe60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1891548Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Haiyang Pan authored
This reverts commit 512f92b7. Reason for revert: bot_update is having infra failure on ci bots. For example https://ci.chromium.org/p/chromium/builders/ci/Closure%20Compilation%20Linux/249684. Original change's description: > Fetch the input commit ref when both ref and id are specified. > > This causes --refs refs/head/master to be added to bot_update > calls when the input build message contains a commit id and the > refs/head/master ref. This is an effective no-op. > > Bug: 922150 > Change-Id: I119d9b3cede727713a0b66bff83b5ee4e1848790 > Recipe-Nontrivial-Roll: build > Recipe-Nontrivial-Roll: infra > Recipe-Nontrivial-Roll: build_limited_scripts_slave > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1884457 > Commit-Queue: Garrett Beaty <gbeaty@chromium.org> > Auto-Submit: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Andrii Shyshkalov <tandrii@google.com> TBR=tandrii@google.com,gbeaty@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 922150 Change-Id: Ie9275c21827688f59449f052c768452a8652e139 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1891000 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Haiyang Pan <hypan@google.com>
-
John Budorick authored
This reverts commit 1e4dbf3f. Reason for revert: unlikely but possible cause of http://shortn/_sgL4PqICVB Original change's description: > Add more git tracing. > > This CL adds more perf tracing to `git fetch` from bot_update.py and > git_cache.py > > Change-Id: I9b69c60b6c81fc0c5f23f82fcc889b4d45a27556 > Recipe-Nontrivial-Roll: build_limited_scripts_slave > Recipe-Nontrivial-Roll: build > Recipe-Nontrivial-Roll: infra > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1888433 > Reviewed-by: Andrii Shyshkalov <tandrii@google.com> > Commit-Queue: Erik Chen <erikchen@chromium.org> > Auto-Submit: Erik Chen <erikchen@chromium.org> TBR=danakj@chromium.org,tandrii@google.com,erikchen@chromium.org Change-Id: I03b33bf1532212f83a6b89b1de32fafb6b8aafc4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1891001Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
Edward Lemur authored
Checking for LUCI_CONTEXT is not enough. To use local auth, the stored config must be valid and have a default account id. Bug: 1018069 Change-Id: I5bbe880cc217a06ae0e1ae8d7e00ef09502af6a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1888211Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Fumitoshi Ukai authored
This reverts commit a0aed87f. Reason for revert: install goma client without update_hook update_hook would disrupt current users, so start without update_hook, which means goma cient in depot_tools user might need to restart compiler_proxy manually when updated. https://docs.google.com/document/d/1pnwfkU6Rd9dRtQC0sg2vATmyRbkYWhnNUTD5k1PddC0/edit# Original change's description: > Revert "put goma client in depot_tools" > > This reverts commit 77780358. > > Reason for revert: AttributeError: 'GomaEnvPosix' object has no attribute 'RestartCompilerProxy' > > Original change's description: > > put goma client in depot_tools > > > > install goma client cipd package in depot_tools. > > > > should not use $MYPATH/goma_ctl in cipd_bin_setup > > since $MYPATH/goma_ctl uses cipd_bin_setup in itself, > > so causing recursive calls. > > invoke python to run .cipd/goma_ctl.py in cipd_bin_setup > > instead. > > > > Bug: b/77663154 > > Change-Id: I9f82c766a886a2acfb899e3594e5f05a7b7bc75a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1866350 > > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > > Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> > > TBR=sque@chromium.org,ukai@chromium.org,yyanagisawa@google.com,vadimsh@chromium.org,dpranke@chromium.org,tikuta@chromium.org,ehmaldonado@chromium.org,yekuang@google.com > > Change-Id: Ie050dfb524dd885634c31be829d733613e80aece > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: b/77663154 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1872129 > Reviewed-by: Fumitoshi Ukai <ukai@chromium.org> > Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> TBR=sque@chromium.org,ukai@chromium.org,yyanagisawa@google.com,vadimsh@chromium.org,dpranke@chromium.org,tikuta@chromium.org,ehmaldonado@chromium.org,yekuang@google.com Bug: b/77663154 Change-Id: I8bb51631e4418ff63953099814bdb464128eb279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1875982Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>
-
- 29 Oct, 2019 1 commit
-
-
Erik Chen authored
This CL adds more perf tracing to `git fetch` from bot_update.py and git_cache.py Change-Id: I9b69c60b6c81fc0c5f23f82fcc889b4d45a27556 Recipe-Nontrivial-Roll: build_limited_scripts_slave Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: infra Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1888433Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org>
-