Skip to content

C
Chromium_Depot_tools
Switch branch/tag
  1. 12 Aug, 2022 2 commits
    • Bruce Dawson's avatar
      Print which PRESUBMIT.py scripts run on Python 2 · 8d78bd1f
      Bruce Dawson authored 
      When running presubmits you can tell if Python 2 presubmits are running,
but it's subtle, and it isn't obvious which presubmits are running under
Python 2.

This makes it obvious by always printing the path to PRESUBMIT.py
scripts that are run under Python 2. This change also fixes a bug in the
--verbose logic - it would print that a script was running before
evaluating _ShouldRunPresubmit.

Bug: 1352347
Change-Id: I45213acdb3b37f7be0713e5caba775841704817c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3826917
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: 's avatarAravind Vasudevan <aravindvasudev@google.com>
      8d78bd1f
    • Bruce Dawson's avatar
      Revert "Update autoninja.bat to work with other shells." · a358defc
      Bruce Dawson authored 
      This reverts commit ba352e00.

Reason for revert: Unfortunately this breaks this command when run
from a normal cmd.exe prompt:
  autoninja ..\..\base\win\access_token.cc^^
The escaping of ^^ as it passes through batch files is very finicky, but important.

Original change's description:
> Update autoninja.bat to work with other shells.
>
> Other shells, such as TCC, have subtle differences in how batch files are processed. This will not break cmd.exe compatibility.
>
> Without the "call" command, running a nested batch file should, according to CMD.exe "rules", cancel the current batch file and run the new one. However, the 'FOR /f "usebackq"' command will call the batch file and return. One could argue for both approaches, however, adding the "call" command doesn't seem to affect cmd.exe and fixes the other shell.
>
> There is a similar issue with the "do" (in the FOR command) block and the use of the '&' separator. The '%a' variable isn't expanded, but adding the '()' block works in both instances.
>
> Bug: 1351817
> Change-Id: Idd685a64404ea950b71e1f3cc0f5d1e3bf13b8b6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3824199
> Commit-Queue: Allen Bauer <kylixrd@chromium.org>
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>

Bug: 1351817
Change-Id: I9d204a3369c468664c0cff247ed1a53065dfebfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3829729
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
      a358defc
  3. 11 Aug, 2022 1 commit
  5. 10 Aug, 2022 6 commits
  7. 09 Aug, 2022 1 commit
  9. 08 Aug, 2022 3 commits
  11. 06 Aug, 2022 1 commit
  13. 05 Aug, 2022 7 commits
  15. 04 Aug, 2022 2 commits
  17. 03 Aug, 2022 3 commits
  19. 02 Aug, 2022 2 commits
  21. 01 Aug, 2022 3 commits
  23. 29 Jul, 2022 1 commit
  25. 28 Jul, 2022 4 commits
  27. 27 Jul, 2022 2 commits
  29. 25 Jul, 2022 2 commits