1. 08 May, 2018 1 commit
    • Jamie Madill's avatar
      git cl: Do not set WIP when using no_squash. · 276da0b4
      Jamie Madill authored
      When using non-squashed uploads, there usually isn't an associated
      issue with a branch. Thus setting WIP when the issue tag wasn't
      present would continually set WIP even on trivial rebases. Not
      adding the WIP tag when uploading allows the user to set WIP manually,
      while not forcing the WIP flag after every new upload.
      
      Also updates the unit tests that use no-squash.
      
      Bug: 767439
      Change-Id: I990a82139fefe1a0c5c7b149d39045cf985539b7
      Reviewed-on: https://chromium-review.googlesource.com/1033187
      Commit-Queue: Jamie Madill <jmadill@chromium.org>
      Reviewed-by: 's avatarAaron Gable <agable@chromium.org>
      276da0b4
  2. 19 Apr, 2018 1 commit
  3. 13 Apr, 2018 1 commit
  4. 14 Mar, 2018 2 commits
  5. 06 Mar, 2018 1 commit
  6. 21 Feb, 2018 1 commit
  7. 09 Feb, 2018 1 commit
  8. 26 Jan, 2018 1 commit
  9. 16 Dec, 2017 1 commit
  10. 12 Dec, 2017 3 commits
    • Aaron Gable's avatar
      Reland "Use core.quotePath=false when git is listing files" · 7817f025
      Aaron Gable authored
      This is a reland of 9219d356
      
      The original was reverted due to a typo (core,quotePath instead
      of core.quotePath). This version is fixed.
      
      Original change's description:
      > Use core.quotePath=false when git is listing files
      >
      > This prevents git from putting quotes around some file names
      > (those that have astral-plane characters) and not around others.
      >
      > R=maruel
      >
      > Bug: 792302
      >
      > Change-Id: I3b6a6b36c4720116de811b40177b59aa25c263db
      > Reviewed-on: https://chromium-review.googlesource.com/815454
      > Commit-Queue: Aaron Gable <agable@chromium.org>
      > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
      
      Bug: 792302
      Recipe-Nontrivial-Roll: build
      Recipe-Nontrivial-Roll: build_limited_scripts_slave
      Change-Id: I28d2260948aaf63bd865888c2f60e4cdee9aea48
      Reviewed-on: https://chromium-review.googlesource.com/822990
      Commit-Queue: Aaron Gable <agable@chromium.org>
      Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
      7817f025
    • Quinten Yearsley's avatar
      Add more fields to try-results --json for WPT importer · a563d722
      Quinten Yearsley authored
      Context: The WPT importer consumes the JSON produced by
      git cl try-results is consumed and uses it to determine
      when the CQ has passed (whether all non-experimental cq
      jobs were successful) and where layout test results are
      stored.
      
      Added fields:
        created_ts: This could be used to sort builds by time.
        tags: Includes user_agent tag and experimental tag, as well as
        experimental: whether the job is experimental
      
      Bug: 792652
      Change-Id: Ic6099a21b21db668b88b1a8e54aefd84529a2a91
      Reviewed-on: https://chromium-review.googlesource.com/819573
      Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
      Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
      a563d722
    • Robbie Iannucci's avatar
      Revert "Use core.quotePath=false when git is listing files" · 6aaee306
      Robbie Iannucci authored
      This reverts commit 9219d356.
      
      Reason for revert: unfortunately this says "core,quotePath" and since it includes recipe changes, we need something that the roller can munch on :(
      
      Original change's description:
      > Use core.quotePath=false when git is listing files
      > 
      > This prevents git from putting quotes around some file names
      > (those that have astral-plane characters) and not around others.
      > 
      > R=​maruel
      > 
      > Bug: 792302
      > Recipe-Nontrivial-Roll: build
      > Recipe-Nontrivial-Roll: build_limited_scripts_slave
      > Change-Id: I3b6a6b36c4720116de811b40177b59aa25c263db
      > Reviewed-on: https://chromium-review.googlesource.com/815454
      > Commit-Queue: Aaron Gable <agable@chromium.org>
      > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
      
      TBR=maruel@chromium.org,agable@chromium.org
      
      Change-Id: I226388f19024403240a1443eb2b878b9293220e1
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: 792302
      Reviewed-on: https://chromium-review.googlesource.com/821671Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
      Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
      6aaee306
  11. 11 Dec, 2017 1 commit
  12. 20 Nov, 2017 1 commit
  13. 16 Nov, 2017 2 commits
  14. 07 Nov, 2017 1 commit
  15. 06 Nov, 2017 1 commit
  16. 17 Oct, 2017 1 commit
  17. 12 Oct, 2017 1 commit
  18. 04 Oct, 2017 1 commit
    • Aaron Gable's avatar
      Simplify git-cl-diff for Gerrit · a718c3eb
      Aaron Gable authored
      Previously, git-cl-diff went through a dance where it would create
      a new branch, download the uploaded patch onto that branch, and
      then diff against that. This had all sorts of problems: if you
      aborted the command, it might leave you on that branch; if you have
      local changes, they might get clobbered or the command would refuse
      to run.
      
      Now that we're in a Gerrit-only world, and patchsets are by definition
      equivalent to commits, we can simply diff against whatever local commit
      was last uploaded or, in a pinch, fetch the uploaded commit and diff
      against that.
      
      Bug: 759893
      Change-Id: Ia4b93dcfb9b8aba85817e62731f68d6450026e75
      Reviewed-on: https://chromium-review.googlesource.com/639915Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
      Commit-Queue: Aaron Gable <agable@chromium.org>
      a718c3eb
  19. 26 Sep, 2017 1 commit
  20. 13 Sep, 2017 1 commit
  21. 10 Aug, 2017 1 commit
  22. 20 Jul, 2017 1 commit
  23. 18 Jul, 2017 1 commit
  24. 14 Jul, 2017 1 commit
  25. 12 Jul, 2017 1 commit
    • Aaron Gable's avatar
      'git cl issue 0': Remove Change-Id · 400e989b
      Aaron Gable authored
      Although git-cl-upload warns when uploading a new patchset
      to a change owned by someone else, if the uploader has run
      'git cl issue 0', then git-cl believes they'll be uploading
      a new change, so it doesn't bother checking. However, once
      the upload begins, Gerrit notices the Change-Id in the commit
      message, and instead adds a new patchset to someone else's
      review (if the uploader is a committer).
      
      This change introduces some logic to git-cl-issue to also
      remove any Change-Id from the commit message when a user
      tries to clear the metadata about their branch.
      
      Bug: 741648
      Change-Id: I6c7c3b24a7fc09c68220c8200b732fbdf9cf1fd3
      Reviewed-on: https://chromium-review.googlesource.com/568267Reviewed-by: 's avatarRobbie Iannucci <iannucci@chromium.org>
      Commit-Queue: Aaron Gable <agable@chromium.org>
      400e989b
  26. 10 Jul, 2017 1 commit
  27. 06 Jul, 2017 1 commit
  28. 28 Jun, 2017 1 commit
  29. 27 Jun, 2017 2 commits
  30. 16 Jun, 2017 1 commit
  31. 09 Jun, 2017 3 commits
  32. 08 Jun, 2017 2 commits
    • Aaron Gable's avatar
      Make gerrit 'git cl patch' use hard reset by default · 9387b4f0
      Aaron Gable authored
      This CL changes the way that "git cl patch" behaves for Gerrit changes.
      
      Previously, git-cl-patch behaved just like it did for Rietveld:
      make sure you're on a branch, download the diff, apply it on top
      of your branch. However, this causes problems with Gerrit. Namely,
      when you upload a change to Gerrit, git-cl has to make sure that all
      parents of your local change have previously been uploaded as well,
      either as other changes or as commits already landed on the target
      branch. But the method for "applying a patch" from Gerrit was to
      cherry-pick it, and that changes the commit hash. So the resulting
      commit would *not* have been uploaded to Gerrit. Thus, the
      following routine didn't work with Gerrit:
      $ git checkout -t origin/master -b your-work
      $ git cl patch 123456
      $ git checkout -tb my-work
      $ #hack and commit
      $ git cl upload
      This would fail during the upload with a message saying that the
      contents of 'your-work' hadn't been uploaded.
      
      This CL fixes the situation by replacing the cherry-pick with
      a hard reset. This means that the contents of the 'your-work'
      branch will be *exactly* what was downloaded from Gerrit. Uploads
      based on top of that commit will work just fine.
      
      Finally, in a concession to some people who want 'git cl patch'
      to actually apply a patch instead of performing a hard reset, if
      the current branch contains local work, then rather than leaving
      that work behind with a hard reset, we fall back to the old
      cherry-pick behavior with a confirmation dialog and warning that
      uploading will be hard.
      
      Bug: 723787
      Change-Id: I3ad164f6d3078bff00139d446bb8ce97738a1344
      Reviewed-on: https://chromium-review.googlesource.com/527345
      Commit-Queue: Aaron Gable <agable@chromium.org>
      Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
      9387b4f0
    • Aaron Gable's avatar
      Use API to set TBR code-review · fd238086
      Aaron Gable authored
      This prevents TBR (self code-review) permissions from blocking
      the CL from being uploaded at all. Instead, it will fully
      upload, and then show a better error message after upload is
      complete.
      
      Bug: 729967
      Change-Id: I55e3e98e200143076afcaab858064d9f5c62f8ef
      Reviewed-on: https://chromium-review.googlesource.com/527325Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
      Commit-Queue: Aaron Gable <agable@chromium.org>
      fd238086