- 08 May, 2018 1 commit
-
-
Jamie Madill authored
When using non-squashed uploads, there usually isn't an associated issue with a branch. Thus setting WIP when the issue tag wasn't present would continually set WIP even on trivial rebases. Not adding the WIP tag when uploading allows the user to set WIP manually, while not forcing the WIP flag after every new upload. Also updates the unit tests that use no-squash. Bug: 767439 Change-Id: I990a82139fefe1a0c5c7b149d39045cf985539b7 Reviewed-on: https://chromium-review.googlesource.com/1033187 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org>
-
- 19 Apr, 2018 1 commit
-
-
Andrii Shyshkalov authored
Unfortunately, w/o rewrite of gerrit_util, one can't take advantage of existing auth.Authenticator (which also doesn't know about ~/.netrc or .gitcookies, but that's fixable). This rewrite, however, will likely cause issues for nasty scripts outside of depot_tools which use gerrit_util as a Python library. So, I followed outdated way of gerrit_util :( Also contains refactoring of auth library, which was kept backwards compatible for the same reasons as above. R=vadimsh@chromium.org Test-with: led tool Test-artifact: https://ci.chromium.org/swarming/task/3cf4687dfd26ca10?server=chromium-swarm.appspot.com Bug: 834536 Change-Id: I6b84b8b5732aee5d345e2b2ba44f47aaecc0f6c5 Reviewed-on: https://chromium-review.googlesource.com/1018488Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 13 Apr, 2018 1 commit
-
-
Olivier Robin authored
After https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/994241 RunHooks take a parallel parameter. This call was not fixed in initial CL. TBR=agable@chromium.org Change-Id: Ic2a076afbd8ef61e3bb12473f43e1e7eab273825 Reviewed-on: https://chromium-review.googlesource.com/1011613 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
- 14 Mar, 2018 2 commits
-
-
Robert Iannucci authored
R=agable@chromium.org, tandrii@chromium.org Change-Id: I2bfed54a9a1bde3335340e5949eac313c3fdda32 Reviewed-on: https://chromium-review.googlesource.com/961970 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
Robert Iannucci authored
R=agable@chromium.org, tandrii@chromium.org Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: infra Change-Id: I518335e7b8fdce316b5566caccd3c4c7c2ae741a Reviewed-on: https://chromium-review.googlesource.com/960161 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
- 06 Mar, 2018 1 commit
-
-
Aaron Gable authored
This allows people to configure their gitcookies file to be whereever they want. As long as it actually exists and has credentials in it, we'll accept it, just like git itself. Change-Id: I4aa4806ddca0e61b28b003b0d3bc486407c13ab4 Reviewed-on: https://chromium-review.googlesource.com/951917Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
- 21 Feb, 2018 1 commit
-
-
Nodir Turakulov authored
Remove code path. Update new code path to expect one bucket, instead of a list. Related: https://chromium-review.googlesource.com/c/infra/infra/+/927792 TBR=tandrii@chromium.org Bug: 800355 Change-Id: I60fbcf92dc242fc9b448760aaa5399320e257323 Reviewed-on: https://chromium-review.googlesource.com/928053 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org>
-
- 09 Feb, 2018 1 commit
-
-
Aaron Gable authored
The purpose of this CL is to remove confusion around whether or not git-cl support the similarity flags when talking to Gerrit. It does not. However, because Rietveld support has not been fully ripped out of git-cl, this change does modify some of the Rietveld-specific code to remove similarity support from everywhere. Bug: 800902 Change-Id: I8703ed60d6889c7a36400b8a9f8f26de4669020a Reviewed-on: https://chromium-review.googlesource.com/912389Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
- 26 Jan, 2018 1 commit
-
-
Aaron Gable authored
I don't know of any use-case where someone would want to use git-cl-patch to pull a (e.g.) chromium change into their (e.g.) v8 checkout. Bug: 803918 Change-Id: Id53f1cc3ab97e623d0098bb366a573b18b54e91a Reviewed-on: https://chromium-review.googlesource.com/876930Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
- 16 Dec, 2017 1 commit
-
-
Lei Zhang authored
Change-Id: Ic993758ea901d039c5fdac978e516ba20f95005d Reviewed-on: https://chromium-review.googlesource.com/830611Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org>
-
- 12 Dec, 2017 3 commits
-
-
Aaron Gable authored
This is a reland of 9219d356 The original was reverted due to a typo (core,quotePath instead of core.quotePath). This version is fixed. Original change's description: > Use core.quotePath=false when git is listing files > > This prevents git from putting quotes around some file names > (those that have astral-plane characters) and not around others. > > R=maruel > > Bug: 792302 > > Change-Id: I3b6a6b36c4720116de811b40177b59aa25c263db > Reviewed-on: https://chromium-review.googlesource.com/815454 > Commit-Queue: Aaron Gable <agable@chromium.org> > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Bug: 792302 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited_scripts_slave Change-Id: I28d2260948aaf63bd865888c2f60e4cdee9aea48 Reviewed-on: https://chromium-review.googlesource.com/822990 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
Quinten Yearsley authored
Context: The WPT importer consumes the JSON produced by git cl try-results is consumed and uses it to determine when the CQ has passed (whether all non-experimental cq jobs were successful) and where layout test results are stored. Added fields: created_ts: This could be used to sort builds by time. tags: Includes user_agent tag and experimental tag, as well as experimental: whether the job is experimental Bug: 792652 Change-Id: Ic6099a21b21db668b88b1a8e54aefd84529a2a91 Reviewed-on: https://chromium-review.googlesource.com/819573 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
Robbie Iannucci authored
This reverts commit 9219d356. Reason for revert: unfortunately this says "core,quotePath" and since it includes recipe changes, we need something that the roller can munch on :( Original change's description: > Use core.quotePath=false when git is listing files > > This prevents git from putting quotes around some file names > (those that have astral-plane characters) and not around others. > > R=maruel > > Bug: 792302 > Recipe-Nontrivial-Roll: build > Recipe-Nontrivial-Roll: build_limited_scripts_slave > Change-Id: I3b6a6b36c4720116de811b40177b59aa25c263db > Reviewed-on: https://chromium-review.googlesource.com/815454 > Commit-Queue: Aaron Gable <agable@chromium.org> > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> TBR=maruel@chromium.org,agable@chromium.org Change-Id: I226388f19024403240a1443eb2b878b9293220e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 792302 Reviewed-on: https://chromium-review.googlesource.com/821671Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 11 Dec, 2017 1 commit
-
-
Aaron Gable authored
This prevents git from putting quotes around some file names (those that have astral-plane characters) and not around others. R=maruel Bug: 792302 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited_scripts_slave Change-Id: I3b6a6b36c4720116de811b40177b59aa25c263db Reviewed-on: https://chromium-review.googlesource.com/815454 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org>
-
- 20 Nov, 2017 1 commit
-
-
Daniel Cheng authored
Bug: 786386 Change-Id: If29acf287355d150e0f89f45b2f7aa87a08dcc57 Reviewed-on: https://chromium-review.googlesource.com/776645Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org>
-
- 16 Nov, 2017 2 commits
-
-
Nodir Turakulov authored
Addressing comments in https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/764974 that were sent after the CL landed. Bug: Change-Id: I6e0a583999e1c22f86d0f6b905aa5fae62b194d5 Reviewed-on: https://chromium-review.googlesource.com/775453Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
-
Nodir Turakulov authored
If a commit subject contains [hashtags], include them in Gerrit CL. Replace consecutive non-alphanums with dash. Also add --hashtag flag for explicit hashtagging. Bug: Change-Id: I25aed286013043263f959ff340a5b5478faa0f27 Reviewed-on: https://chromium-review.googlesource.com/764974 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org>
-
- 07 Nov, 2017 1 commit
-
-
Nick Carter authored
Bug: 663787 Change-Id: Ie7e2fca42db0c840d713dc6edba5dc0c2b65223d Reviewed-on: https://chromium-review.googlesource.com/676086Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Nick Carter <nick@chromium.org>
-
- 06 Nov, 2017 1 commit
-
-
Aaron Gable authored
Bug: 780540 Change-Id: I85bf40d8faa482786589f9031e34f364342c06dd Reviewed-on: https://chromium-review.googlesource.com/754003Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
- 17 Oct, 2017 1 commit
-
-
Dirk Pranke authored
R=estaab@chromium.org Change-Id: I318a1897fa1d10fce4aaad2dd1f4a553d14aff47 Reviewed-on: https://chromium-review.googlesource.com/723999Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org>
-
- 12 Oct, 2017 1 commit
-
-
Stefan Zager authored
R=agable@chromium.org,tandrii@chromium.org Bug: Change-Id: I83c285c333a21f2ed0138723a1cd5347e65f41ae Reviewed-on: https://chromium-review.googlesource.com/710742 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org>
-
- 04 Oct, 2017 1 commit
-
-
Aaron Gable authored
Previously, git-cl-diff went through a dance where it would create a new branch, download the uploaded patch onto that branch, and then diff against that. This had all sorts of problems: if you aborted the command, it might leave you on that branch; if you have local changes, they might get clobbered or the command would refuse to run. Now that we're in a Gerrit-only world, and patchsets are by definition equivalent to commits, we can simply diff against whatever local commit was last uploaded or, in a pinch, fetch the uploaded commit and diff against that. Bug: 759893 Change-Id: Ia4b93dcfb9b8aba85817e62731f68d6450026e75 Reviewed-on: https://chromium-review.googlesource.com/639915Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
- 26 Sep, 2017 1 commit
-
-
Yoshisato Yanagisawa authored
Since git-cl TBR always sets +1, it does not allow auto-submit where using +2 score as approval. Let me make git-cl automatically adjust to proper score. Bug: 762425 Change-Id: I71fe1af1b8bf5e68d2509c60e8bf05024b6bdbb7 Reviewed-on: https://chromium-review.googlesource.com/680717Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
-
- 13 Sep, 2017 1 commit
-
-
Aaron Gable authored
Bug: 764848 Change-Id: I639451ad54eb50a405fe44b9a83b00d84ec76578 Reviewed-on: https://chromium-review.googlesource.com/665998Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
- 10 Aug, 2017 1 commit
-
-
Andrii Shyshkalov authored
R=phajdan.jr@chromium.org Change-Id: Ia1380bc0cfff50e82f9a26d3c54e9dc34a38c7b5 Reviewed-on: https://chromium-review.googlesource.com/574528 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 20 Jul, 2017 1 commit
-
-
Aaron Gable authored
Using self.GetDescription() uses the description from the web. Given that the user is purposefully disassociating their current branch from the review on the web, they may have already changed the commit message. We shouldn't set it back. Bug: 742730 Change-Id: I0545cb6288c332fd475d1de7fb302f71ee41a415 Reviewed-on: https://chromium-review.googlesource.com/578229Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
- 18 Jul, 2017 1 commit
-
-
Aaron Gable authored
Change-Id: I872658970c04cdadda2b0eaffd95e10717c09493 Reviewed-on: https://chromium-review.googlesource.com/575009Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
- 14 Jul, 2017 1 commit
-
-
Aaron Gable authored
In Rietveld, adding a comment to a change automatically published it no matter what. In Gerrit, we need to explicitly mark the change as Ready for Review. This CL adds a new parameter to the wrapper methods around the SetReview API so that they can mark changes as Ready. Bug: 740950 Change-Id: Icb2ad7c5beb03a4760657a761841745f0d75514e Reviewed-on: https://chromium-review.googlesource.com/572031Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
- 12 Jul, 2017 1 commit
-
-
Aaron Gable authored
Although git-cl-upload warns when uploading a new patchset to a change owned by someone else, if the uploader has run 'git cl issue 0', then git-cl believes they'll be uploading a new change, so it doesn't bother checking. However, once the upload begins, Gerrit notices the Change-Id in the commit message, and instead adds a new patchset to someone else's review (if the uploader is a committer). This change introduces some logic to git-cl-issue to also remove any Change-Id from the commit message when a user tries to clear the metadata about their branch. Bug: 741648 Change-Id: I6c7c3b24a7fc09c68220c8200b732fbdf9cf1fd3 Reviewed-on: https://chromium-review.googlesource.com/568267Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
- 10 Jul, 2017 1 commit
-
-
Andrii Shyshkalov authored
R=machenbach@chromium.org,agable@chromium.org Bug: N/A Change-Id: I831e9e72c8687c248022f49ea405e149538ef02a Reviewed-on: https://chromium-review.googlesource.com/563671Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 06 Jul, 2017 1 commit
-
-
Andrii Shyshkalov authored
Due to relaxation of when last paragraph of commit message is is consider as containing footers, `git cl land` started removing non-canonic footer lines from last paragraph if Git Numberer is enabled on a repo. This only manifests in manual lands of Rietveld CLs or bypassing code review entirely. R=agable@chromium.org Bug: 736852 Change-Id: I3972c590c3959974157ada9de9891a3c08bd385a Reviewed-on: https://chromium-review.googlesource.com/562278Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 28 Jun, 2017 1 commit
-
-
Aaron Gable authored
It seems like some folks are confused by additional patchsets after the first putting the change back into WIP mode. This confusion is honestly understandable. Maybe we try only setting it on the very first upload, and just controlling the notify parameter for future patchsets. Bug: 721836, 737675 Change-Id: If56e5c71e0c6b3b46c2e30ac0b6d80b878218181 Reviewed-on: https://chromium-review.googlesource.com/552779Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
smut <smut@google.com> Commit-Queue: Aaron Gable <agable@chromium.org>
-
- 27 Jun, 2017 2 commits
-
-
Aaron Gable authored
The previous CL forgot that the lack of '%wip' doesn't mark a change ready-to-review, you have to explicitly pass '%ready' in the refspec to do that. TBR=tandrii@chromium.org Bug: 721836 Change-Id: Iea82222d64edf1b73fefa9bca3feec4188e35ab3 Reviewed-on: https://chromium-review.googlesource.com/551005Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
Aaron Gable authored
Work-In-Progress is a new change flag that can be set on Gerrit changes. While a change is in WIP mode, certain things are different: * It doesn't send emails except to the change owner * The "Reply" button becomes "Start Review" * When a change is moved out of WIP, it sends a special "ready for review" message to any new reviewers This is much more similar to the Rietveld model, where users would "Publish" their changes for the reviewers to look at. Bug: 721836 Change-Id: I3b9697e311fa176cb679ecefbfead9bb32b6afaf Reviewed-on: https://chromium-review.googlesource.com/549015Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
- 16 Jun, 2017 1 commit
-
-
Aaron Gable authored
This is a partial revert of https://chromium-review.googlesource.com/c/527345/ Turns out more people were confused by the new behavior than expected, so we're returning to "cherry-pick" being the default, but supporting the collaboration workflow is important, so we're adding a warning message and support for "reset --hard" behind a pre-existing flag. Bug: 723787 Change-Id: Ib6038a42e3bdcc0db93c1f32d759e9ff0e91a065 Reviewed-on: https://chromium-review.googlesource.com/538137 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
- 09 Jun, 2017 3 commits
-
-
Aaron Gable authored
Bug: skia:6744 Change-Id: I0f84bd685bfacf692190f8636208122cf88d0b82 Reviewed-on: https://chromium-review.googlesource.com/529016Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
Aaron Gable authored
TBR=tandrii@chromium.org Bug: 723787 Change-Id: Ie5017747f2070116774cd12ba0dd2ea531b2d0aa Reviewed-on: https://chromium-review.googlesource.com/529547Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-
Andrii Shyshkalov authored
Follow up on https://chromium-review.googlesource.com/c/527325/ R=agable@chromium.org,rmistry@chromium.org Bug: chromium:729967 Bug: skia:6744 Change-Id: I7443298797a7c95c8ca01624e3cbf08c95e04855 Reviewed-on: https://chromium-review.googlesource.com/529246Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
-
- 08 Jun, 2017 2 commits
-
-
Aaron Gable authored
This CL changes the way that "git cl patch" behaves for Gerrit changes. Previously, git-cl-patch behaved just like it did for Rietveld: make sure you're on a branch, download the diff, apply it on top of your branch. However, this causes problems with Gerrit. Namely, when you upload a change to Gerrit, git-cl has to make sure that all parents of your local change have previously been uploaded as well, either as other changes or as commits already landed on the target branch. But the method for "applying a patch" from Gerrit was to cherry-pick it, and that changes the commit hash. So the resulting commit would *not* have been uploaded to Gerrit. Thus, the following routine didn't work with Gerrit: $ git checkout -t origin/master -b your-work $ git cl patch 123456 $ git checkout -tb my-work $ #hack and commit $ git cl upload This would fail during the upload with a message saying that the contents of 'your-work' hadn't been uploaded. This CL fixes the situation by replacing the cherry-pick with a hard reset. This means that the contents of the 'your-work' branch will be *exactly* what was downloaded from Gerrit. Uploads based on top of that commit will work just fine. Finally, in a concession to some people who want 'git cl patch' to actually apply a patch instead of performing a hard reset, if the current branch contains local work, then rather than leaving that work behind with a hard reset, we fall back to the old cherry-pick behavior with a confirmation dialog and warning that uploading will be hard. Bug: 723787 Change-Id: I3ad164f6d3078bff00139d446bb8ce97738a1344 Reviewed-on: https://chromium-review.googlesource.com/527345 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
Aaron Gable authored
This prevents TBR (self code-review) permissions from blocking the CL from being uploaded at all. Instead, it will fully upload, and then show a better error message after upload is complete. Bug: 729967 Change-Id: I55e3e98e200143076afcaab858064d9f5c62f8ef Reviewed-on: https://chromium-review.googlesource.com/527325Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org>
-