- 10 Jan, 2019 1 commit
-
-
Takuto Ikuta authored
I got launch approval. http://shortn/_dyJK6ME7C0 Detailed document of this log upload is in https://chromium.googlesource.com/chromium/tools/depot_tools/+/HEAD/ninjalog.README.md Bug: 900161 Change-Id: Iad2f954040d40caa5b7cc1f1eb39c1088f7f316e Reviewed-on: https://chromium-review.googlesource.com/c/1401919Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
-
- 09 Jan, 2019 9 commits
-
-
Jared Saul authored
The change around line 29-30 in https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1368409/2/metrics_utils.py inadvertently removed an extra space. As a result, the metrics collection dialog looks like this: https://screenshot.googleplex.com/3aGtquydCXM.png Change-Id: I7c9c08949b0df248e6de4f59ec9cfd573ff40901 Reviewed-on: https://chromium-review.googlesource.com/c/1403577Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com>
-
Avi Drissman authored
da90c53e was incorrect; the size() functions take almost anything, not just word characters, and std::extent() uses brackets. BUG=837308 Change-Id: I6ee75a5da7a021758bbfb0996aeaef81f2003cd9 Reviewed-on: https://chromium-review.googlesource.com/c/1401581Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/3535e529c7b925fb486cfaccc1f89e739402d54b [buildbucket] Populate ref from branch property (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I02ff1f10339bf828d57fe372e19fa794f766102d Reviewed-on: https://chromium-review.googlesource.com/c/1402104Reviewed-by:
Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Takuto Ikuta authored
We cannot send PII data. This CL tried to remove following data, * build config that can contain build directory path * build directory path * hostname * cwd I use per build uuid instead of per user uuid. Bug: 900161 Change-Id: Id533762749806ad8616b7dc07f21b27dfe632c9a Reviewed-on: https://chromium-review.googlesource.com/c/1369473Reviewed-by:
Fumitoshi Ukai <ukai@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/7d75cc6e379d1603027cb39420541ceaa8fd6a2c [swarming] enforce to set server if server is referred (tikuta@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I72e8a523c2dd431b75c52a49b7bdb556683f7097 Reviewed-on: https://chromium-review.googlesource.com/c/1402101Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/7e610e4cc8e12bf654b0ecfc1872cc50e1ceed8d Restore old user guide for now. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ic8df1bbf114667e9f1012611f4569b4f7ab93681 Reviewed-on: https://chromium-review.googlesource.com/c/1401599Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/08b7a23ec10abc078fd0f7594dd1331c76ae30e4 Revert "Remove use_result_proto flag" (martiniss@chromium.org) TBR=iannucci@chromium.org NOPRESUBMIT=true NOTRY=true Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ibe04b68b36fd509c22656e3a6cbd6403edf14818 Reviewed-on: https://chromium-review.googlesource.com/c/1401589 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/5e16623c2af04706ed78dec9aa25fcf367a2f0bc Remove use_result_proto flag (martiniss@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I6655221dfa31991e53bcb2142abd1a92bcbee308 Reviewed-on: https://chromium-review.googlesource.com/c/1401585Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/d44c26c543da894ac048a1a5f129790c2bb9923f [isolated] enforce to set server if server is referred (tikuta@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I4dcc257d7303380f148abaae14febc33da632b61 Reviewed-on: https://chromium-review.googlesource.com/c/1401583Reviewed-by:
-
- 08 Jan, 2019 1 commit
-
-
Avi Drissman authored
Using base/std::size and std::extent does not result in the creation of a VLA; cpplint should not warn on their use. BUG=837308 Change-Id: Ie133b2144b6c1c9f4f5e406144f28b333a212197 Reviewed-on: https://chromium-review.googlesource.com/c/1399961Reviewed-by:
-
- 07 Jan, 2019 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/1f61472de5efab2217261a2912af7682f0e5c62e [isolated] Allow ability to isolate a given root directory. (joshuaseaton@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ie2bef3cefb24a9df75ba14608337897addd3d71d Reviewed-on: https://chromium-review.googlesource.com/c/1398623Reviewed-by:
-
- 04 Jan, 2019 3 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/c1b615b6808b8aa8001b5e4e1d5d234233ad8266 [buildbucket] Add set_output_gitiles_commit (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ia34028e3fe28469bf8202948ccaafdf38e15b9eb Reviewed-on: https://chromium-review.googlesource.com/c/1396583Reviewed-by:
-
Nodir Turakulov authored
This bug caused https://logs.chromium.org/logs/infra-internal/buildbucket/cr-buildbucket.appspot.com/8925230260185002096/+/steps/presubmit/0/stdout Tested locally R=vadimsh@chromium.org Change-Id: I9c42b7d7e9a1366e00fe40ca8a9f18ff0629663a Reviewed-on: https://chromium-review.googlesource.com/c/1396527 Auto-Submit: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/be3df181ebe1e4a67251ef904e4396553b959506 [buildbucket] Parse created_ts from string (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Idfeb2ea0aca20da3dfba0398057404c6c20adf26 Reviewed-on: https://chromium-review.googlesource.com/c/1396099Reviewed-by:
-
- 03 Jan, 2019 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/77f5f049d615d9086198660ebe9539ce7abbf7ff [buildbucket] Parse created_ts (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I1f7a27a53b534b50f7c21b2c99b50530de07f3c6 Reviewed-on: https://chromium-review.googlesource.com/c/1394816Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/1e2a5440207a57b828e58d3998501b2a45679ada [isolated] Roll the isolated CLI tool version (nmulcahey@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I3f89db3268f1ae2790628695d2a91b8f0925cba2 Reviewed-on: https://chromium-review.googlesource.com/c/1394805Reviewed-by:
-
- 21 Dec, 2018 1 commit
-
-
Edward Lemur authored
Fix CheckOwnersFormat so that it checks the new OWNERS files instead of the original ones. Change-Id: I4abb1cfc847bd28f45b9948fe7775c10dcc8a420 Reviewed-on: https://chromium-review.googlesource.com/c/1382946Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 20 Dec, 2018 7 commits
-
-
Mike Frysinger authored
This rolls a few changes from upstream noticed by early testing. Bug: 900461 Change-Id: Iea568be41e3149a667fba655576bdd591b353079 Reviewed-on: https://chromium-review.googlesource.com/c/1387706Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/354bb02e9c0b74eea43faa883ac1aa134c435e3c [swarming] Add support for environment variables. (joshuaseaton@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Iacd8293734181d6d5cdfb8af38c1824ab9cfe586 Reviewed-on: https://chromium-review.googlesource.com/c/1387704Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/19c28875c9f1519cac7156e07dbb8e59ff40f7c1 [isolated] Add download method (joshuaseaton@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I62be38022b84c35c5c17d4b18fd411af2ce176ad Reviewed-on: https://chromium-review.googlesource.com/c/1387567Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/1236ebd26cbcfae759c3857b26bd9bd1cf3547d2 [file] Introduce SymlinkTree (joshuaseaton@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I5ff1123b7289e134a765e20a6c4e9dc2f8e6c142 Reviewed-on: https://chromium-review.googlesource.com/c/1387566Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/0fad0863959ecf172fb460a7008eeabf8c8f078d [swarming] Minor clean-up and typo fixes. (joshuaseaton@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Id98f511e9d4344f8625ff5d3732d792e669e4850 Reviewed-on: https://chromium-review.googlesource.com/c/1387565Reviewed-by:
-
Clemens Hammacher authored
This also allows digits in class decorators, to also match macros like V8_EXPORT_PRIVATE. Note: I uploaded a pull request for the (previous) upstream at https://github.com/google/styleguide/pull/422, but then was told that that repository is not maintained any more. R=jochen@chromium.org Bug: chromium:916550 Change-Id: I24cd1829b794b296be8e0c2829271c746751ee1c Reviewed-on: https://chromium-review.googlesource.com/c/1383472 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/c3fbb33835795d43242ef673522148ade63a3cf0 [swarming,isolated] Add `on_path` methods. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I150752f2f6e26edb7c86969e93ae95a925fe2c8b Reviewed-on: https://chromium-review.googlesource.com/c/1385506Reviewed-by:
-
- 19 Dec, 2018 2 commits
-
-
Takuto Ikuta authored
I added document explaining ninjalog collection. This document explains what type of data is collected and how the data will be used. Bug: 900161, b/120645342 Change-Id: If47517aaa7a5510e4a634b5ccc0e4127d014dcb9 Reviewed-on: https://chromium-review.googlesource.com/c/1381912 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org>
-
Bruce Dawson authored
When non-Googlers try to build Chromium for the first time they get an error saying: Please follow the instructions at https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_instructions.md However those instructions are quite long and it's not obvious to some users which part of the instructions they have forgotten. The most likely is that they didn't set DEPOT_TOOLS_WIN_TOOLCHAIN=0, so this changes the error message to suggest that directly. Auto-detecting the correct state for DEPOT_TOOLS_WIN_TOOLCHAIN was tried in crrev.com/c/1374833 but deemed impractical. Bug: 907300, angleproject:2712 Change-Id: I45a9f59babe90bbe2137d49c555884d7bbbcf170 Reviewed-on: https://chromium-review.googlesource.com/c/1382942Reviewed-by:
-
- 18 Dec, 2018 7 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM+CQ. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/3f3879c37865ac94e52e8d91a70399ca37ae4fb8 Make aggregated InfraFailures surface as exceptions. (joshuaseaton@google.com) R=iannucci@chromium.org, martiniss@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I1ce8de0ea0660d734f553d18a051ba0552d263e5 Reviewed-on: https://chromium-review.googlesource.com/c/1382977 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org>
-
Mike Frysinger authored
This syntax seems to be invalid, so remove it to unblock others. Bug: 900461 No-Presubmit: True Change-Id: I16569b8f8236a14b6dc879c973e4925a99649ac2 Reviewed-on: https://chromium-review.googlesource.com/c/1382975 Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by:
-
Mike Frysinger authored
Bug: 900461 Change-Id: I74bf2a048f766d95a8d11d74f5a97e67898299fe Reviewed-on: https://chromium-review.googlesource.com/c/1380591Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
-
Vadim Shtayura authored
This picks up the following changes: https://chromium.googlesource.com/infra/luci/luci-go/+log/d052999e151b..20acb618582d/cipd R=tandrii@chromium.org, iannucci@chromium.org BUG=915278 Change-Id: Ibaa9d20456dcb513d9bbdaf0bca970390254ee67 Reviewed-on: https://chromium-review.googlesource.com/c/1381773Reviewed-by:
-
Don Garrett authored
R=-owners Bug: None Change-Id: I9ff818b65b1c9a2a3a19f65932ffac4957dab0cc Reviewed-on: https://chromium-review.googlesource.com/c/1382934 Auto-Submit: Don Garrett <dgarrett@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This function extracts build target from command line. Bug: 900161 Change-Id: I38d37689a42437de76933ea3c9afb9def5a1253c Reviewed-on: https://chromium-review.googlesource.com/c/1381911 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/dc70d2e73b72e43934db0f7dd816a061aa6f428d Add post_process functions for checking the status of a step. (gbeaty@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I86b8b38db5dbbdec46efeeb929c937e193e489ea Reviewed-on: https://chromium-review.googlesource.com/c/1381274Reviewed-by:
-
- 17 Dec, 2018 3 commits
-
-
Takuto Ikuta authored
Use unittest module instead of doctest. Bug: 900161 Change-Id: I2e8265afb66345814c4c4b8e94618171b7aaaaf3 Reviewed-on: https://chromium-review.googlesource.com/c/1379441 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
-
Edward Lemur authored
Tbr: tandrii@chromium.org Bug: 914712 Change-Id: Iff8aecff346692ef36fd653f226b48270fefa304 Reviewed-on: https://chromium-review.googlesource.com/c/1380972Reviewed-by:
-
Edward Lemur authored
Bug: 914712 Change-Id: I13db57af519bb254389bc6bd1f1f81ad1d497e42 Reviewed-on: https://chromium-review.googlesource.com/c/1377295 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
- 15 Dec, 2018 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/0d040fde89eac5b4762eab44a97e9556de6cffb8 [path] Add additional info to the assert in mkdtemp/mkstemp. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Iedb912a8205792211f10f221518b94a53bc9fb34 Reviewed-on: https://chromium-review.googlesource.com/c/1378962Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/d3f6d71aea0086eb34ae3cbbe7fbfd729d16b29f Fix README generation from a66cf68621e2c514b7684e5404cd700a700f1aba (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I542f25dbea97c7a25b714ed41d005a26b6234f9e Reviewed-on: https://chromium-review.googlesource.com/c/1378958Reviewed-by:
-
- 14 Dec, 2018 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/a66cf68621e2c514b7684e5404cd700a700f1aba [swarming] Create minimal swarming module. (joshuaseaton@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ieeda3bddd24b2e839ce93a88bcfae45f6251e66e Reviewed-on: https://chromium-review.googlesource.com/c/1378956Reviewed-by:
-
