- 06 Jul, 2017 9 commits
-
-
Dan Jacques authored
It's currently possible for CIPD bootstraps that provision concurrently to: 1) On Linux, step on each other during download, and 2) On Windows, fail. Fix these respective scripts so that bootstraps are safe to use concurrently. On Linux and Mac, we download to a temporary file and use "mv" (atomic) to write it to the final destination. Concurrent initializations will perform parallel downloads, execute the "mv", and copy their downloaded file to the destination path. On Windows, we use filesystem locking to lock the operation and ensure that only one download can happen. BUG=chromium:739195 TEST=local - Ran in parallel on Windows, Linux, and Max. Change-Id: Ie050d37598da67389f21728e781bd58904ef9c17 Reviewed-on: https://chromium-review.googlesource.com/560521Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org>
-
Paweł Hajdan, Jr authored
Instead of passing around 6+ out-parameters, keep state inside the class. No intended behavior change. Bug: 570091 Change-Id: Ia15c1db2170680f0ec087b61f51af49e12fd7579 Reviewed-on: https://chromium-review.googlesource.com/561700 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
Paweł Hajdan, Jr authored
It turns out it most likely won't be needed. Instead, auto-pinning deps is useful mode. This removal helps simplify and restructure the flatten code. Bug: 570091 Change-Id: Ia70221c88a37f210cf1338a36d79168d2cfe96f6 Reviewed-on: https://chromium-review.googlesource.com/561717Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Michael Achenbach authored
This'll allow to query gerrit from recipes for e.g. current changes in CQ. Bug: 685318 Change-Id: I73d08d4b186b2e5fe044fd4d4fafd9db62e27066 Reviewed-on: https://chromium-review.googlesource.com/558939 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org>
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I4fac33ca683ff2011fa7307d5175592f3d9e258e Reviewed-on: https://chromium-review.googlesource.com/560171Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Paweł Hajdan, Jr authored
The main goal is to provide a migration path, where we can add conditional src-internal entry to src/DEPS, and have it still work on checkouts where .gclient pulls src-internal, provided the condition evaluates to False. The migration path is then to remove the .gclient entry, and at the same time flip the condition to True (e.g. by overriding a variable). Bug: 570091 Change-Id: I9b9850a644463ab0b1f368d65a5cd5f47cf7be97 Reviewed-on: https://chromium-review.googlesource.com/559150Reviewed-by:
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: Ib8009ae9ac77e50a09e3e2714cec7c67537b47a2 Reviewed-on: https://chromium-review.googlesource.com/558970Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/11d7598fa760017f168aec1c53a9ced74b2fc8a6 [file] Allow placeholders in file.copy (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I0c4b2d35f805aaeb647a574aa6d62fa5caeea1ef Reviewed-on: https://chromium-review.googlesource.com/560737Reviewed-by:
Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Dan Jacques authored
Make Linux/Mac CIPD wrapper fail if any step returns an error. Include the "-f" curl flag, which will cause it to error on non-200 status. BUG=chromium:739195 TEST=local R=iannucci@chromium.org Change-Id: I3efea3f38c1ee322cb9d63f29819472564107ddc Reviewed-on: https://chromium-review.googlesource.com/560723Reviewed-by:
-
- 05 Jul, 2017 3 commits
-
-
Vadim Shtayura authored
New version correctly handle LUCI_CONTEXT['local_auth'] environment. BUG=730878 R=dnj@chromium.org, smut@google.com Change-Id: I1ed9c48eb15010856502d35baf140c97d1dd566c Reviewed-on: https://chromium-review.googlesource.com/559954Reviewed-by:
Daniel Jacques <dnj@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/9419a0e2ea6ab618b33a1e962ce62b36664e5234 [doc] Put all external URLs in a single section. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I39a8a4934d27e1461379cf5be48f722cc571c103 Reviewed-on: https://chromium-review.googlesource.com/559511Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/4b6b21e529889fcb3f4b1128ddd0fb941210012a [doc] Fix randomization of DEPS link order, give DEPS links fully qualified names (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ifb23eec7d9298dc5cd75536860e5374936fdeae8 Reviewed-on: https://chromium-review.googlesource.com/560130Reviewed-by:
-
- 03 Jul, 2017 5 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/3ac778ec88ee4a878bd75ab8a89162c848b3d1db [recipe_autoroller] regen docs on trivial rolls too. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ia2ec717f995182adb820c0773c11d060405d2223 Reviewed-on: https://chromium-review.googlesource.com/558153Reviewed-by:
-
Robert Iannucci authored
Tbr: dnj@chromium.org Bug: Change-Id: Icc87cb23571341835e54cc80210fa23bc33fb1f0 Reviewed-on: https://chromium-review.googlesource.com/558382Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/c8d78bf15c065b5a35ccfc5798d1498d0899bb68 [doc] Automatically generate and update cross-indexed recipe markdown files. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I64f3ebdbf1565f7f8c08c6e21df516f87533ac7b Reviewed-on: https://chromium-review.googlesource.com/558392Reviewed-by:
-
Paweł Hajdan, Jr authored
The previous code did not distinguish between None and [] value for orig_deps. This could be triggered by not having any deps, but some entries in deps_os, in which case these deps_os entries would get added by mistake to deps. Bug: 570091 Change-Id: Id5b41e37ea717d5d00404694ad5bfce8df9da934 Reviewed-on: https://chromium-review.googlesource.com/558349Reviewed-by:
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I96417d462efb3b0476ee17d42ac5f19d8c4f99c3 Reviewed-on: https://chromium-review.googlesource.com/558352Reviewed-by:
-
- 30 Jun, 2017 2 commits
-
-
Dan Jacques authored
"bot_update" currently passes a full "gclient" specification as a command-line argument to "bot_update.py". This file contains all sorts of junk that clutters the command-line, and revealed a batch file escaping bug that seems to be present in the recipe engine. Change this so that "bot_update" passes the spec as file content instead of a command-line flag. Also, "bot_update" apparently called "--spec", which optparse kindly recognized as the real flag, "--specs". This has always(?) been a bug, and is no longer a problem. BUG=chromium:738348 TEST=expectations Change-Id: I5324b94dd5ef78503e7cfdc28b5fde8f434e4359 Reviewed-on: https://chromium-review.googlesource.com/558207Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/5873ef21cc9f2a9d9d6de868608c51976fdca20a Fix "env_prefixes" rendering. (dnj@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ib15645fe57cb10b05aca2bb57bba412b807005c1 Reviewed-on: https://chromium-review.googlesource.com/557659Reviewed-by:
-
- 29 Jun, 2017 7 commits
-
-
Dan Jacques authored
Prefix "depot_tools" to PATH instead of appending. This will ensure that "depot_tools" pulls resources from the recipe checkout as a preference, not as a last resort. Use "env_prefixes" instead of "env" to prefix PATH. Remove Git speed limit settings, which are taken care of by the Git wrapper now. BUG=chromium:738176 TEST=expectations R=hinoka@chromium.org, iannucci@chromium.org Change-Id: I2e509a331266e867be323bc70e3bc0f08f85246f Reviewed-on: https://chromium-review.googlesource.com/556287Reviewed-by:
-
Aaron Gable authored
R=avayvod Bug: 738116 Change-Id: Idd1ea46dfd876b800868bba9cc981a4093e1c809 Reviewed-on: https://chromium-review.googlesource.com/556302Reviewed-by:
Andrew Bonventre <andybons@chromium.org> Commit-Queue: Andrew Bonventre <andybons@chromium.org>
-
Aaron Gable authored
Using the remote url is much more useful than the hash of the first commit in the repo, since we can use it to track down repos, teams, and people still using Rietveld for review. Bug: 600469 Change-Id: I067594794ba77692c11daf63b5f5844d36209a08 Reviewed-on: https://chromium-review.googlesource.com/556301Reviewed-by:
-
Aaron Gable authored
Bug: 600469 Change-Id: I4ebc7b0f28204ae4a4649e51d6aac8fc2f43ed20 Reviewed-on: https://chromium-review.googlesource.com/556152Reviewed-by:
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: Ib1a86289f8219ead789e19896c2a873b8d59c179 Reviewed-on: https://chromium-review.googlesource.com/556035Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/49d884b8bf92c358eab83cf2da43ef9863a89bbb file: correctly pass --symlinks after the command name (phajdan.jr@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ic5ee3e2ff92fe373e8a746201ef2b1f2165059db Reviewed-on: https://chromium-review.googlesource.com/555332Reviewed-by:
-
Michael Moss authored
R=dpranke@chromium.org, phajdan.jr@chromium.org Bug: 570091 Change-Id: Ic2aa1a9fe18f3fe8d5aa6fa4c4e9269106b36092 Reviewed-on: https://chromium-review.googlesource.com/553719 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Di Mu <dimu@chromium.org> Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
- 28 Jun, 2017 3 commits
-
-
Aaron Gable authored
It seems like some folks are confused by additional patchsets after the first putting the change back into WIP mode. This confusion is honestly understandable. Maybe we try only setting it on the very first upload, and just controlling the notify parameter for future patchsets. Bug: 721836, 737675 Change-Id: If56e5c71e0c6b3b46c2e30ac0b6d80b878218181 Reviewed-on: https://chromium-review.googlesource.com/552779Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
smut <smut@google.com> Commit-Queue: Aaron Gable <agable@chromium.org>
-
Nico Weber authored
I added this when we were moving from gcc to clang on OS X many years ago. Now that gcc has been deprecated on mac for many years, this is safe to remove (clang errors on this pattern). This check took 0.6s during `git cl presubmit` on a recent change of mine, so it should speed presubmit up a bit. Bug: none Change-Id: Ia29b046807582e056115519fb5b34ee8a1b9ff91 Reviewed-on: https://chromium-review.googlesource.com/553238Reviewed-by:
-
Tobias Hilbrich authored
Powershell can try to read additional commands from stdin. The `< nul` makes sure it reads an EOF and properly returns. The motivation for this change was a hanging WebRTC build job on an automated build machine. R=iannucci@chromium.org, vadimsh@chromium.org Details: https://stackoverflow.com/questions/2041799/powershell-script-gets-stuck-doesnt-exit-when-called-from-batch-file Bug: Change-Id: I51df3927644ca3a7e212089e0c414e2e8eb0c02a Reviewed-on: https://chromium-review.googlesource.com/549317Reviewed-by:
-
- 27 Jun, 2017 5 commits
-
-
Aaron Gable authored
The previous CL forgot that the lack of '%wip' doesn't mark a change ready-to-review, you have to explicitly pass '%ready' in the refspec to do that. TBR=tandrii@chromium.org Bug: 721836 Change-Id: Iea82222d64edf1b73fefa9bca3feec4188e35ab3 Reviewed-on: https://chromium-review.googlesource.com/551005Reviewed-by:
-
Aaron Gable authored
Work-In-Progress is a new change flag that can be set on Gerrit changes. While a change is in WIP mode, certain things are different: * It doesn't send emails except to the change owner * The "Reply" button becomes "Start Review" * When a change is moved out of WIP, it sends a special "ready for review" message to any new reviewers This is much more similar to the Rietveld model, where users would "Publish" their changes for the reviewers to look at. Bug: 721836 Change-Id: I3b9697e311fa176cb679ecefbfead9bb32b6afaf Reviewed-on: https://chromium-review.googlesource.com/549015Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/097a0dbe9f6b8eae39e690de848aea5c3d8ea38b [test] minor refactoring. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I42c968970a1358a8ee3720d9b0cbba8c375e5212 Reviewed-on: https://chromium-review.googlesource.com/550636Reviewed-by:
-
Aaron Gable authored
Bug: 736816 Change-Id: I56d222a3aad684f51c8c47f302c8a298b7a0469a Reviewed-on: https://chromium-review.googlesource.com/549060 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: Ia7f81a81d7df75004c5f8b7560dfd50a14f4cddd Reviewed-on: https://chromium-review.googlesource.com/549355 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
-
- 26 Jun, 2017 3 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/8c0fd220f89fdee4865b016def85a4ad8d04fec5 Add experimental downstream trybots (phajdan.jr@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I6f2f673faa0d5037d15b20af79f786b32f728758 Reviewed-on: https://chromium-review.googlesource.com/549115Reviewed-by:
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: Iae9dad68a75d751ceac6379baac588f32c59aa06 Reviewed-on: https://chromium-review.googlesource.com/548935Reviewed-by:
-
Aaron Gable authored
https://gerrit-review.googlesource.com/c/110057/ has been deployed, so this change can now take advantage of that new API to make git-cl-description more reliable. Both the API to add content to a change edit and to publish a change edit return '204 No Content' on a successful call, but this API returns 200. It seems likely to me that one or the other will change, so this calling code accepts both codes for future-proofness. Bug: gerrit:5099 Change-Id: I14d5323f92c807036f8aa11b314d10706c51dbf5 Reviewed-on: https://chromium-review.googlesource.com/544118 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
-
- 23 Jun, 2017 2 commits
-
-
Stefan Zager authored
Change-Id: I2e7243f1b9243ec98df54bd9f78b98cba8743217 Reviewed-on: https://chromium-review.googlesource.com/544792Reviewed-by:
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I5a489f9f9cbc5384b720685264aa918573234cf5 Reviewed-on: https://chromium-review.googlesource.com/544965Reviewed-by:
-
- 22 Jun, 2017 1 commit
-
-
Bruce Dawson authored
Some build machines end up running vctip.exe for some reason and then it doesn't shut down in a timely manner, leaving locks on directories. This changes the packaging script so that vctip.exe is not packaged, and therefore won't be run. vctip.exe is the "Microsoft VC compiler and tools experience improvement data uploader" and it presumably runs automatically as part of running the compiler. It's not clear what triggers it to run, however omitting it should be safe. BUG=735226 Change-Id: Ie6af562def6214a5bb130ccc09c732efc1769bcd Reviewed-on: https://chromium-review.googlesource.com/544395 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org>
-
