Skip to content

C
Chromium_Depot_tools
Switch branch/tag
  1. 16 Oct, 2014 1 commit
  3. 13 Oct, 2014 3 commits
  5. 10 Oct, 2014 1 commit
  7. 09 Oct, 2014 1 commit
  9. 04 Oct, 2014 1 commit
  11. 02 Oct, 2014 1 commit
  13. 01 Oct, 2014 1 commit
  15. 26 Sep, 2014 1 commit
  17. 24 Sep, 2014 3 commits
  19. 23 Sep, 2014 4 commits
  21. 22 Sep, 2014 1 commit
  23. 19 Sep, 2014 1 commit
  25. 15 Sep, 2014 1 commit
  27. 11 Sep, 2014 2 commits
  29. 10 Sep, 2014 2 commits
  31. 09 Sep, 2014 6 commits
  33. 08 Sep, 2014 5 commits
  35. 06 Sep, 2014 1 commit
  37. 05 Sep, 2014 4 commits
    • thakis@chromium.org's avatar
      Grammar up. · 5f32a966
      thakis@chromium.org authored 
      BUG=
TBR=iannucci

Review URL: https://codereview.chromium.org/549613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291835 0039d316-1c4b-4281-b951-d872f2087c98
      5f32a966
    • thakis@chromium.org's avatar
      Make git cl format work on my Windows box. · bd2a9b97
      thakis@chromium.org authored 
      For me, PATH was a unicode instead of a str for some reason, so things
failed with

D:\src\chromefetch\src>git cl format
Traceback (most recent call last):
  File "d:\src\depot_tools\git_cl.py", line 2821, in <module>
    sys.exit(main(sys.argv[1:]))
  File "d:\src\depot_tools\git_cl.py", line 2807, in main
    return dispatcher.execute(OptionParser(), argv)
  File "d:\src\depot_tools\subcommand.py", line 245, in execute
    return command(parser, args[1:])
  File "d:\src\depot_tools\git_cl.py", line 2768, in CMDformat
    stdout = RunCommand(cmd, stdin=diff_output, cwd=top_dir, env=env)
  File "d:\src\depot_tools\git_cl.py", line 81, in RunCommand
    return subprocess2.check_output(args, shell=False, **kwargs)
  File "d:\src\depot_tools\subprocess2.py", line 515, in check_output
    return check_call_out(args, stdout=PIPE, **kwargs)[0]
  File "d:\src\depot_tools\subprocess2.py", line 475, in check_call_out
    out, returncode = communicate(args, **kwargs)
  File "d:\src\depot_tools\subprocess2.py", line 449, in communicate
    proc = Popen(args, **kwargs)
  File "d:\src\depot_tools\subprocess2.py", line 237, in __init__
    super(Popen, self).__init__(args, **kwargs)
  File "d:\src\depot_tools\python276_bin\lib\subprocess.py", line 709, in __init__
    errread, errwrite)
  File "d:\src\depot_tools\python276_bin\lib\subprocess.py", line 957, in _execute_child
    startupinfo)
TypeError: environment can only contain strings
Sending crash report ...
  args: ['d:\\src\\depot_tools\\git_cl.py', 'format']
  cwd: D:\src\chromefetch\src
  exception: environment can only contain strings
  host: THAKIS1-W.ad.corp.google.com
  stack:   File "d:\src\depot_tools\git_cl.py", line 2821,
  user: thakis
  version: 2.7.6 (default, Nov 10 2013, 19:24:18)

This fixes the glitch.

Review URL: https://codereview.chromium.org/545333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291825 0039d316-1c4b-4281-b951-d872f2087c98
      bd2a9b97
    • iannucci@chromium.org's avatar
      Return 1 from git_cl land when you Ctrl-C it in the middle. · bbe9cc5a
      iannucci@chromium.org authored 
      R=agable@chromium.org, mmoss@chromium.org
BUG=

Review URL: https://codereview.chromium.org/549513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291823 0039d316-1c4b-4281-b951-d872f2087c98
      bbe9cc5a
    • kjellander@chromium.org's avatar
      Make gn.py support root directories other than 'src'. · f7facfab
      kjellander@chromium.org authored 
      In https://codereview.chromium.org/341533006/ a change
was made so that gn.py is not looking for the .gn file
to identify the root of the checkout. This breaks
GN functionality for projects that uses gclient but
have a top directory named something else than 'src'.

This change adds support for arbitrarily named primary (the first)
solutions in the .gclient file.
It also adds a check for the generated GN path so a friendly
error message can be printed if the GN executable cannot be found.


BUG=389883
TESTED=Various cases of Chromium, WebRTC and custom checkouts
with .gclient containing empty solution list, solution missing the
'name' key and so on.

Review URL: https://codereview.chromium.org/538393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@291819 0039d316-1c4b-4281-b951-d872f2087c98
      f7facfab