Commits · 7400cf0f8448a3173b4e35de0aa00352c7e7ac82 · Linshizhi / Chromium_Depot_tools

21 Jun, 2016 3 commits

Bump git-cl version to 2.0, since we now support Gerrit. · 7400cf0f
tandrii authored Jun 21, 2016
```
R=andybons@chromium.org
BUG=618017

Review-Url: https://codereview.chromium.org/2077773003
```
7400cf0f

Refactor git_common config and die · 7aa2ddd8

agable authored Jun 21, 2016

R=iannucci@chromium.org
BUG=376099

Review-Url: https://codereview.chromium.org/2075603002

7aa2ddd8

Remove SVN code from update_depot_tools · a0e5cc40

Aaron Gable authored Jun 21, 2016

R=maruel@chromium.org
BUG=600446

Review URL: https://codereview.chromium.org/2088653003 .

a0e5cc40

20 Jun, 2016 4 commits

Roll recipe dependencies (trivial). · f0834e44

recipe-roller authored Jun 20, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/d6668158ac17d845f016c191258b733947169ad1 Add per step timeout (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2081783002

f0834e44

git cl test framework: improve debuggability of expected calls. · 9d206759
tandrii authored Jun 20, 2016
```
R=phajdan.jr@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2074233002
```
9d206759
Default to y(es) when asking user about archiving committed branches · 4a5ecbe6
sergiyb authored Jun 20, 2016
```
R=tandrii@chromium.org

Review-Url: https://codereview.chromium.org/2074723002
```
4a5ecbe6

Gerrit git cl upload: --squash is now default. · a60502f2

tandrii authored Jun 20, 2016

You can override it for all devs of repo by adding line to codereview.settings:
  GERRIT_SQUASH_UPLOADS: (True|False)

And even with that, individual devs can overide it for themselves with:
  git config [--global] --bool gerrit.override-squash-uploads (true|false)

BUG=611892

Review-Url: https://codereview.chromium.org/2072363002

a60502f2

17 Jun, 2016 7 commits

Roll recipe dependencies (trivial). · 95369051

recipe-roller authored Jun 17, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/3495f24ac7834058a1490b6253e413f78d6adb93 remove whitespace (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2073253002

95369051

cit: print to stderr to allow piping from cit log cat. · 56396af3

tandrii authored Jun 17, 2016

R=hinoka@chromium.org,stip@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2062053002

56396af3

Add SVN->Git migration warning to git cl dcommit users. · 3bb82ff1

tandrii authored Jun 17, 2016

R=mmoss@chromium.org,benhenry@chromium.org
BUG=600451,161849

Review-Url: https://codereview.chromium.org/2074883002

3bb82ff1

Remove git-tree-prune. · 461a222a

tandrii authored Jun 17, 2016

PSA [1] has been sent 3 weeks ago. Alternative git cl archive landed 1 week ago.
No comments have been received since then. Also, this tool is not even in
top-level depot_tools, hence outside of $PATH for most people, user impact
should be very limited.

[1] PSA link:
https://groups.google.com/a/chromium.org/d/msg/infra-dev/K2qwUQ-mRUM/nnYcTDD8AQAJ

BUG=616404
R=machenbach@chromium.org

Review-Url: https://codereview.chromium.org/2077943003

461a222a

Enforce GN formatting for *.typemap files. · 58edce2b

kylechar authored Jun 17, 2016

Ensure consistent formatting for Mojo typemap files that define the
build rules to generate StructTraits.

BUG=620799
TEST=Tested locally, both presubmit and git cl format work as expected.

Review-Url: https://codereview.chromium.org/2074793002

58edce2b

Roll recipe dependencies (trivial). · 7d44639e

recipe-roller authored Jun 17, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/d6f0e607c1bca05178f248b9f06619749a8c42d8 Introduce different repo types (git and gitiles) (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=chromium:459840

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2074073002

7d44639e

Simplify octal constants in Python code (e.g. 0o0700 -> 0o700). · 1dfe43ca
mgiuca authored Jun 17, 2016
```
Review-Url: https://codereview.chromium.org/2075923003
```
1dfe43ca

16 Jun, 2016 15 commits

Gerrit git cl upload: Remove --no-squash warning message. · edbf9a3e

tandrii authored Jun 16, 2016

First, it's wrong because of instruction in it is ineffective.
Second, it was also shown during --squash upload, which is completely wrong.

TBR=sergiyb@chromium.org
BUG=611892

Review-Url: https://codereview.chromium.org/2072923002

edbf9a3e

Revert of Gerrit git cl: allow overriding GERRIT_SQUASH_UPLOADS in git config.... · 8dd81ea2

tandrii authored Jun 16, 2016

Revert of Gerrit git cl: allow overriding GERRIT_SQUASH_UPLOADS in git config. (patchset #2 id:20001 of https://codereview.chromium.org/2070013002/ )

Reason for revert:
I suspect this broke squash setting setup.

Original issue's description:
> Gerrit git cl: allow overriding GERRIT_SQUASH_UPLOADS in git config.
>
> Previously, if GERRIT_SQUASH_UPLOADS was found in codereview.settings,
> a local repository value of gerrit.squash-uploads would be set.
>
> This CL changes that, so that gerrit.squash-uploads property is written
> with GERRIT_SQUASH_UPLOADS value ONLY IF the property wasn't set before.
>
> This allows individual users to choose their own way with
>   git config [--global] -bool gerrit.squash-uploads (true|false)
>
> BUG=611892
> R=andybons@chromium.org,sergiyb@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/768ec9a75560b5e5903d86654d4c1ab2afe17361

TBR=andybons@chromium.org,sergiyb@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=611892

Review-Url: https://codereview.chromium.org/2071963002

8dd81ea2

git cl upload: stop using deprecated except syntax · 2cc483c1

vapier authored Jun 16, 2016

The newer form works with python2 and python3.

Review-Url: https://codereview.chromium.org/2076643002

2cc483c1

Cleanup CQ config post SVN->Git migration. · 62d045ce
tandrii authored Jun 16, 2016
```
R=sergiyb@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2074823002
```
62d045ce

git cl upload: convert to print_function · c0943768

vapier authored Jun 16, 2016

This makes the code work both in python2 and python3.

Review-Url: https://codereview.chromium.org/2078553002

c0943768

use py3 compatible octal constants · 8057ac88
vapier authored Jun 16, 2016
```
Review-Url: https://codereview.chromium.org/2076613002
```
8057ac88
Add project-infra-tryjob-access to dry-runners of CQ. · 214df955
tandrii authored Jun 16, 2016
```
TBR=sergiyb@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2071703003
```
214df955

httplib2: update to 0.9.2 release · 45c2edf7

vapier authored Jun 16, 2016

This is in preparation for adding py3 support.

Review-Url: https://codereview.chromium.org/2073823002

45c2edf7

git_cl: convert to print_function · a7fbd5a9

vapier authored Jun 16, 2016

This makes the code work both in python2 and python3.

Review-Url: https://codereview.chromium.org/2066003002

a7fbd5a9

git_cl: stop using deprecated except syntax · fd77ac7c

vapier authored Jun 16, 2016

The newer form works with python2 and python3.

Review-Url: https://codereview.chromium.org/2061023003

fd77ac7c

Gerrit git cl: allow overriding GERRIT_SQUASH_UPLOADS in git config. · 768ec9a7

tandrii authored Jun 16, 2016

Previously, if GERRIT_SQUASH_UPLOADS was found in codereview.settings,
a local repository value of gerrit.squash-uploads would be set.

This CL changes that, so that gerrit.squash-uploads property is written
with GERRIT_SQUASH_UPLOADS value ONLY IF the property wasn't set before.

This allows individual users to choose their own way with
  git config [--global] -bool gerrit.squash-uploads (true|false)

BUG=611892
R=andybons@chromium.org,sergiyb@chromium.org

Review-Url: https://codereview.chromium.org/2070013002

768ec9a7

Expose fnmatch in presubmit's input_api. · 091b7db6
dcheng authored Jun 16, 2016
```
BUG=611905

Review-Url: https://codereview.chromium.org/2070493002
```
091b7db6

Roll recipe dependencies (trivial). · adf9f0db

recipe-roller authored Jun 16, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/a6baded1c8c7a15dd1e4020289fd19d985f58c25 add basic bootstrap for coverage (martiniss@google.com)

R=martiniss@google.com,iannucci@chromium.org,phajdan.jr@chromium.org
BUG=618709

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2075483002

adf9f0db

drover win: Use --stdin so update-index doesn't fail on long cmdline · 02056563

scottmg authored Jun 16, 2016

git update-index would fail on long command lines when setting up
a resolve. Instead of passing all the files names on the command line,
pass them through --stdin and a file handle.

BUG=598808

Review-Url: https://codereview.chromium.org/2067653002

02056563

Fix presubmit checkout test after git 2.9.0 · f3c688bf

scottmg authored Jun 16, 2016

Quoting https://github.com/blog/2188-git-2-9-has-been-released

"""Rename detection is now enabled by default for diffs..."

which broke this test.

R=tandrii@chromium.org, iannucci@chromium.org
BUG=619959

Review-Url: https://codereview.chromium.org/2073553003

f3c688bf

10 Jun, 2016 5 commits

Update message for Gerrit git cl --no-squash users. · 26f3e4ee
tandrii authored Jun 10, 2016
```
R=andybons@chromium.org
BUG=611892

Review-Url: https://codereview.chromium.org/2055233002
```
26f3e4ee
Mock stdout to avoid pollutting test runner stdout. · 1c67da67
tandrii authored Jun 10, 2016
```
TBR=kmarshall@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2055003003
```
1c67da67

Roll recipe dependencies (trivial). · ea46b886

recipe-roller authored Jun 10, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/d6fea3edecb31f2f87e8551f7ca4cdaafef731f8 convert recipe_engine/fetch to use requests HTTP library (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=none

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2059713002

ea46b886

Roll recipe dependencies (trivial). · 97e8e559

recipe-roller authored Jun 10, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/da26a351b7034d37e55acd468fa90c8ee3a1ada0 Fix --timestamps help (nodir@chromium.org)

R=nodir@chromium.org,martiniss@chromium.org
BUG=613584

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2059593002

97e8e559

Roll recipe dependencies (trivial). · d139d55f

recipe-roller authored Jun 10, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/02bd5642786bd00b6060404bf8c459e6cc146c4c Emit CURRENT_TIMESTAMP annotation (nodir@chromium.org)

R=iannucci@chromium.org,nodir@chromium.org,martiniss@chromium.org
BUG=613584

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2056113002

d139d55f

09 Jun, 2016 5 commits

git cl upload: commit subject is default patchset title · 7aafc3f4

nodir authored Jun 09, 2016

git cl upload asks the user to provide a patchset title.
If the user makes a commit per patchset, the subject of the commit may
be exactly what patchset title should be.

R=dnj@chromium.org, vadimsh@chromium.org
BUG=582419

Review-Url: https://codereview.chromium.org/1868313002

7aafc3f4

Use different exit code when desired dep roll is a no-op · 7036c4f0
smut authored Jun 09, 2016
```
BUG=609899

Review-Url: https://codereview.chromium.org/2047013005
```
7036c4f0

Reland: git_cache.py: Clobber git repos if the config is corrupt · dcd84048

hinoka authored Jun 09, 2016

Reland of: https://codereview.chromium.org/2049463003/

See https://build.chromium.org/p/tryserver.chromium.win/builders/win10_chromium_x64_rel_ng_exp/builds/1801/steps/bot_update/logs/stdio
[Mirror] https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2Fwin10_chromium_x64_rel_ng_exp%2F1801%2F%2B%2Frecipes%2Fsteps%2Fbot_update%2F0%2Fstdout

Sometimes repos become corrupt and bot_update fails spectacularly.  This usually happens due to the process being interrupted during a fetch. Git
cache should be able to recover from this by clobbering.

BUG=

Review-Url: https://codereview.chromium.org/2045243004

dcd84048

Roll recipe dependencies (trivial). · faa493b2

recipe-roller authored Jun 09, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/9bd80bed8e2c252d85333afeb15e4ae6446390c5 fix package help (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2057753003

faa493b2

Roll recipe dependencies (trivial). · 7bb9cf7c

recipe-roller authored Jun 09, 2016

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/e4cd3d7622993438df62de4b827d8900ee0b74e5 remote_run: resolve revision for consistent results from gitiles (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=chromium:459840

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2050613004

7bb9cf7c

08 Jun, 2016 1 commit

Add resource locking in gclient · 885e5b1e

hinoka authored Jun 08, 2016

There are entries in the DEPS file where two folders uses the same
git URL (ie. freetype2).  This doesn't work well with git caches because
each task will run on it's own and might try to clobber on top of each other.

This adds another field in a WorkItem which is a list of resources.  When the
work queue is flushed, it has to make sure that none of a newly added workitem
has any resource conflicts.

BUG=618124

Review-Url: https://codereview.chromium.org/2049583003

885e5b1e