Skip to content

C
Chromium_Depot_tools
Switch branch/tag
  1. 22 Feb, 2016 2 commits
    • thakis@chromium.org's avatar
      package_from_installed: Put env in json file behind "env" key. · 73aa9fb9
      thakis@chromium.org authored 
      Every time I write a json file, I end up wishing I put my toplevel items
into non-toplevel items down the line when I want to add more stuff to the
json file.  Address this now, while no toolchain with this json file has
been built yet.

Follow-up to https://codereview.chromium.org/1706423002/

BUG=495204

Review URL: https://codereview.chromium.org/1718083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298908 0039d316-1c4b-4281-b951-d872f2087c98
      73aa9fb9
    • mgiuca@chromium.org's avatar
      git hyper-blame: Added automatically ignoring revs from a file. · cd0a1cf3
      mgiuca@chromium.org authored 
      Added --ignore-file argument, so you can specify ignored commits in a
file rather than as raw command-line arguments. Also, automatically
searches for a file called .git-blame-ignore-revs, which is
automatically used as an ignore list by default.

Also, specifying an unknown revision (either on the command line or in a
file) now generates a warning, not an error.

Notes on some decisions:
- The file is called .git-blame-ignore-revs (not mentioning hyper-blame)
  because we may use the same list in tools other than hyper-blame in
  the future.
- We look at the *currently checked out* version of
  .git-blame-ignore-revs (not the version at the specified revision) for
  consistency with .git-ignore. Because we only expect revisions to be
  added (not deleted), it should be fine to use an ignore list from a
  newer version than the revision being blamed.
- We considered using git notes for the ignore list so that you could
  add a revision to the ignore list without needing a follow-up CL.
  However, there are some problems with this approach. git notes is not
  automatically synced with git clone/pull. Also the Chromium infra
  tools (Reitveld, CQ) are not set up to allow modification of git
  notes, nor are changes to git notes subject to OWNERS checks. Using a
  regular file ensures all users synced to a particular revision are
  using the same ignore list.

BUG=574290

Review URL: https://codereview.chromium.org/1697423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298897 0039d316-1c4b-4281-b951-d872f2087c98
      cd0a1cf3
  3. 18 Feb, 2016 6 commits
  5. 17 Feb, 2016 2 commits
  7. 16 Feb, 2016 1 commit
  9. 15 Feb, 2016 2 commits
  11. 13 Feb, 2016 1 commit
  13. 12 Feb, 2016 1 commit
  15. 11 Feb, 2016 4 commits
  17. 10 Feb, 2016 4 commits
  19. 09 Feb, 2016 4 commits
  21. 06 Feb, 2016 2 commits
  23. 05 Feb, 2016 5 commits
  25. 04 Feb, 2016 6 commits