Commits · 6c96e493a38edb413794d9135c40503fc988b312 · Linshizhi / Chromium_Depot_tools

18 Jan, 2011 1 commit

Second attempt to work around App Engine flakiness by retrying upon URLError · 6c96e493

kbr@chromium.org authored Jan 18, 2011

("Connection timed out"). This allowed me to successfully upload a CL I had
been stuck on for a couple of hours.

Manually tested by raising both HTTPError and URLError within this code block
and ensuring both are caught correctly.

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/6304006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@71702 0039d316-1c4b-4281-b951-d872f2087c98

6c96e493

17 Jan, 2011 2 commits

Add --ignore-externals to svn update and svn checkout invocations. · ce117f61

maruel@chromium.org authored Jan 17, 2011

svn:externals are slow to update and are unnecessary in a gclient environment.

TEST=none
BUG=55904

Review URL: http://codereview.chromium.org/3421013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@71604 0039d316-1c4b-4281-b951-d872f2087c98

ce117f61

Add more logging. Useful to understand `git try` slowness. · 3487f7f4

thakis@chromium.org authored Jan 17, 2011

Review URL: http://codereview.chromium.org/6247008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@71602 0039d316-1c4b-4281-b951-d872f2087c98

3487f7f4

15 Jan, 2011 1 commit

Revert http://codereview.chromium.org/6345001/ because it apparently · e0c16f9f

kbr@chromium.org authored Jan 15, 2011

introduced a bug which I didn't encounter during testing.

BUG=none
TEST=none
TBR=maruel

Review URL: http://codereview.chromium.org/6340006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@71520 0039d316-1c4b-4281-b951-d872f2087c98

e0c16f9f

14 Jan, 2011 1 commit

Work around App Engine flakiness by retrying upon URLError · 02a89f56

kbr@chromium.org authored Jan 14, 2011

("Connection timed out"). This allowed me to successfully upload a CL
I have been stuck on for a couple of hours.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6345001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@71513 0039d316-1c4b-4281-b951-d872f2087c98

02a89f56

12 Jan, 2011 1 commit

Improve parsing of committed hash to be more resilient. · df947ea8

maruel@chromium.org authored Jan 12, 2011

TEST=Verified that if this code breaks, the presubmit checks fail.
BUG=none

Review URL: http://codereview.chromium.org/6079003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@71229 0039d316-1c4b-4281-b951-d872f2087c98

df947ea8

11 Jan, 2011 2 commits

Update the repo wrapper · 2c64b712

msb@chromium.org authored Jan 11, 2011

BUG=
TEST=

Review URL: http://codereview.chromium.org/6179004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@71101 0039d316-1c4b-4281-b951-d872f2087c98

2c64b712

Add support for post-dcommit/post-push hooks. · 0ba7f967

maruel@chromium.org authored Jan 11, 2011

Patch contributed by sadrul@chromium.org

Review URL: http://codereview.chromium.org/5972005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@71097 0039d316-1c4b-4281-b951-d872f2087c98

0ba7f967

10 Jan, 2011 1 commit

Update the index in SendUpstream before tree check. · c76e675f

chase@chromium.org authored Jan 10, 2011

BUG=none
TEST=git cl dcommit/push performs an index update before
checking if the tree is dirty
Review URL: http://codereview.chromium.org/6172003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@70908 0039d316-1c4b-4281-b951-d872f2087c98

c76e675f

03 Jan, 2011 1 commit

Fix path filtering to be on the relative path and no on the absolute path. · 5d0dc43e

maruel@chromium.org authored Jan 03, 2011

Add logging to presubmit_support.py.

BUG=
TEST=

Review URL: http://codereview.chromium.org/6004006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@70378 0039d316-1c4b-4281-b951-d872f2087c98

5d0dc43e

23 Dec, 2010 2 commits

Import from git_cl instead of git_cl_repo. · b9a98324

chase@chromium.org authored Dec 23, 2010

Also update the PRESUBMIT check to exclude git_cl/.

BUG=none
TEST=git-cl hooks run
TBR=maruel@chromium.org
Review URL: http://codereview.chromium.org/5998008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@70108 0039d316-1c4b-4281-b951-d872f2087c98

b9a98324

Move git-cl into depot_tools. · cc51cd03

chase@chromium.org authored Dec 23, 2010

BUG=none
TEST=git-cl works after move
Review URL: http://codereview.chromium.org/5012006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@70011 0039d316-1c4b-4281-b951-d872f2087c98

cc51cd03

21 Dec, 2010 4 commits

patch from issue 5575008 · dcd1522a

evan@chromium.org authored Dec 21, 2010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@69888 0039d316-1c4b-4281-b951-d872f2087c98

dcd1522a

Silence pylint warnings. · 4c6f18ca

maruel@chromium.org authored Dec 21, 2010

TBR=dpranke
BUG=
TEST=

Review URL: http://codereview.chromium.org/6051004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@69848 0039d316-1c4b-4281-b951-d872f2087c98

4c6f18ca

Split FakeRepos class in two so it can be reused for commti-queue unit tests. · e0f81697

maruel@chromium.org authored Dec 21, 2010

FakeRepos is useful for offline SCM tests but it was hardcoded for depot_tools
requirements. Luckily, it was already modular enought that it merely required to
shuffle code around to split it in two classes to be able to reuse the code
as-is.

BUG=
TEST=

Review URL: http://codereview.chromium.org/6029004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@69845 0039d316-1c4b-4281-b951-d872f2087c98

e0f81697

Workaround the fact that pylint calls sys.exit(). · fca53394

maruel@chromium.org authored Dec 21, 2010

Otherwise the following presubmit checks where never called.

TBR=nsylvain
BUG=
TEST=fixes unit tests

Review URL: http://codereview.chromium.org/5995003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@69844 0039d316-1c4b-4281-b951-d872f2087c98

fca53394

15 Dec, 2010 1 commit

Add support for an --upstream_branch argument to make diffing against · 2e9ba2ac

dpranke@google.com authored Dec 15, 2010

things other than trunk easier.

    BUG=none
    R=maruel@chromium.org
    TEST=none

Review URL: http://codereview.chromium.org/5680006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@69307 0039d316-1c4b-4281-b951-d872f2087c98

2e9ba2ac

14 Dec, 2010 1 commit

Enhance RunPylint to use white_list and black_list arguments. · bf38a7ed

maruel@chromium.org authored Dec 14, 2010

Change RunPylint to parse all .py files when one is modified.

Make all depot_tools/tests pass on pylint. That mostly meant fixing some
builtins aliasing, wrong alignment and turning off most remaining warnings.

BUG=none
TEST=unit tests

Review URL: http://codereview.chromium.org/5695007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@69159 0039d316-1c4b-4281-b951-d872f2087c98

bf38a7ed

13 Dec, 2010 1 commit

Add RunPylint as a canned presubmit check. · e94aedc2

maruel@chromium.org authored Dec 13, 2010

Adding it as I figured out how to make it run correctly on ubuntu 10.4 and it's
used in enough places it warrants a canned check.

BUG=none
TEST=it self tests itself.

Review URL: http://codereview.chromium.org/5682011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@69051 0039d316-1c4b-4281-b951-d872f2087c98

e94aedc2

02 Dec, 2010 1 commit

Make max len parametrable so it can be modified for users. · f31294b4

maruel@chromium.org authored Dec 02, 2010

Mostly useful for commit-queue as I want to both send the trace and be able to
read it locally.

TBR=jam

Review URL: http://codereview.chromium.org/5608001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@68055 0039d316-1c4b-4281-b951-d872f2087c98

f31294b4

25 Nov, 2010 2 commits

Increment tries so it doesn't loop forever. · b7d3b24d

maruel@chromium.org authored Nov 25, 2010

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/5257002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@67359 0039d316-1c4b-4281-b951-d872f2087c98

b7d3b24d

Propagate host to _GetAuthToken() to make it coherent. · d528cb88

maruel@chromium.org authored Nov 25, 2010

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/5342001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@67358 0039d316-1c4b-4281-b951-d872f2087c98

d528cb88

24 Nov, 2010 3 commits

Add python's version in breakpad stack traces · a7a1a83b

maruel@chromium.org authored Nov 24, 2010

BUG=
TEST=

Review URL: http://codereview.chromium.org/5131005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@67314 0039d316-1c4b-4281-b951-d872f2087c98

a7a1a83b

Add more exception information to breakpad. · 1bd1ed3c

maruel@chromium.org authored Nov 24, 2010

When an HTTP exception information is logged, no information is sent by
default. Add an helper function to manually extract interesting information
to append it to the exception type.

Also disable another pylint warning.

TEST=manual test
BUG=none

Review URL: http://codereview.chromium.org/5303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@67306 0039d316-1c4b-4281-b951-d872f2087c98

1bd1ed3c

Add a regexp to verify the host parameter. · cbf1f6b7

maruel@chromium.org authored Nov 24, 2010

If the host parameter is invalid, like having a trailing backslash, it will
result on HTTP 400 later which is much harder to diagnose.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/5339001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@67295 0039d316-1c4b-4281-b951-d872f2087c98

cbf1f6b7

20 Nov, 2010 3 commits

Add an alert for python < 2.5. · c3a15a23

maruel@chromium.org authored Nov 20, 2010

Don't block execution.

Python 2.4 has been untested for a while and may break unexpectedly.

TEST=manual testing
BUG=none

Review URL: http://codereview.chromium.org/5110009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@66870 0039d316-1c4b-4281-b951-d872f2087c98

c3a15a23

Revert r66865 "revert upload.py changes from previous commit since its throwing exceptions" · ea4d91e0

maruel@chromium.org authored Nov 20, 2010

This issue is only on python 2.4.

BUG=
TEST=

Review URL: http://codereview.chromium.org/5216004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@66867 0039d316-1c4b-4281-b951-d872f2087c98

ea4d91e0

revert upload.py changes from previous commit since its throwing exceptions · c04db91d
jam@chromium.org authored Nov 20, 2010
```
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@66865 0039d316-1c4b-4281-b951-d872f2087c98
```
c04db91d

19 Nov, 2010 2 commits

Apply directly http://codereview.appspot.com/3227041 to add support for HTTP 301 · f6d0de19

maruel@chromium.org authored Nov 19, 2010

We need this now for an imminent rietveld instance move.

TEST=worked with manual testing
BUG=none

Review URL: http://codereview.chromium.org/5138007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@66810 0039d316-1c4b-4281-b951-d872f2087c98

f6d0de19

Update upload.py to r590. · 9ad0cf62

maruel@chromium.org authored Nov 19, 2010

TBR=jam
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5172007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@66776 0039d316-1c4b-4281-b951-d872f2087c98

9ad0cf62

17 Nov, 2010 2 commits

Fix XSRF token in gcl so we don't need to hack rietveld anymore. · 41db6ef3

maruel@chromium.org authored Nov 17, 2010

Improve SendToRietveld to hardcode less function arguments.

TEST=manually tested that gcl works on both chromium and non-chromium rietveld instances
BUG=none

Review URL: http://codereview.chromium.org/5015005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@66499 0039d316-1c4b-4281-b951-d872f2087c98

41db6ef3

Update cpplint.py to r62. · 35589e67

erg@google.com authored Nov 17, 2010

Review URL: http://codereview.chromium.org/5186001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@66483 0039d316-1c4b-4281-b951-d872f2087c98

35589e67

15 Nov, 2010 1 commit

Change shebangs to allow the tools to be used out of the box without modification · 3bb0d6fa

maruel@chromium.org authored Nov 15, 2010

on system that don't hard code bash's path.

For example, BSD's bash lives in /usr/local/bin on freebsd & openbsd.

Patch contributed by Sevan Janiyan (venture37 at gmail)

TEST=didn't break ubuntu users
BUG=none

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@66124 0039d316-1c4b-4281-b951-d872f2087c98

3bb0d6fa

11 Nov, 2010 1 commit

Improve help to be clearer about what --delete_unversioned_trees does. · 28d14bd1

maruel@chromium.org authored Nov 11, 2010

Make -D -f combination more effective by deleting directories even if there is
modified files.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/4803001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@65845 0039d316-1c4b-4281-b951-d872f2087c98

28d14bd1

10 Nov, 2010 1 commit

Do not check the safesync_url at all if one or more --revision flags are · 792ea881

joi@chromium.org authored Nov 10, 2010

specified.

BUG=49625
TEST=tests\gclient_smoketest.py runs successfully


Review URL: http://codereview.chromium.org/4698006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@65620 0039d316-1c4b-4281-b951-d872f2087c98

792ea881

04 Nov, 2010 1 commit

Reduce the chances for gclient to throw an exception in subprocess module. · 0661727b

maruel@chromium.org authored Nov 04, 2010

Python standard library is not thread safe. Work around it by leaking a bit.
The problem is particularly visible on python 2.4.

TEST=none
BUG=60623

Review URL: http://codereview.chromium.org/4465001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@65048 0039d316-1c4b-4281-b951-d872f2087c98

0661727b

03 Nov, 2010 4 commits

Disable the remaining pylint warnings locally and enable pylint warnings in PRESUBMIT. · b17b55be

maruel@chromium.org authored Nov 03, 2010

This causes some code clutter.

TEST=Increased pylint warning level
BUG=none

Review URL: http://codereview.chromium.org/4321006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64913 0039d316-1c4b-4281-b951-d872f2087c98

b17b55be

Largely reduce the number of pylint warnings and fix one typo. · cb2985fb

maruel@chromium.org authored Nov 03, 2010

Most of them are style issues or variable aliasing.

TEST=Can almost enable pylint warnings
BUG=none

Review URL: http://codereview.chromium.org/4360002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64908 0039d316-1c4b-4281-b951-d872f2087c98

cb2985fb

Make CheckLicense() to not trigger on empty files. · 71626858

maruel@chromium.org authored Nov 03, 2010

This is especially annoying on empty __init__.py files.

TEST=new unit test
BUG=none

Review URL: http://codereview.chromium.org/4310001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64904 0039d316-1c4b-4281-b951-d872f2087c98

71626858

Improve PRESUBMIT.py error messages. · 488d0431

maruel@chromium.org authored Nov 03, 2010

TEST=presubmit.py
BUG=none

Review URL: http://codereview.chromium.org/4279002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64903 0039d316-1c4b-4281-b951-d872f2087c98

488d0431