TBR=pgervais@chromium.org,sergeyberezin@chromium.org
BUG=537417

Review URL: https://codereview.chromium.org/1383723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297020 0039d316-1c4b-4281-b951-d872f2087c98

R=brucedawson@chromium.org
BUG=491424

Review URL: https://codereview.chromium.org/1382873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297019 0039d316-1c4b-4281-b951-d872f2087c98

R=pgervais@chromium.org
BUG=537417

Review URL: https://codereview.chromium.org/1372133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297015 0039d316-1c4b-4281-b951-d872f2087c98

BUG=537417
R=sergiyb@chromium.org,phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/1373363006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297012 0039d316-1c4b-4281-b951-d872f2087c98

This will make explanation provided by Rietveld visible to the user, e.g.
"Request to https://codereview.chromium.org/1386443003/edit_flags failed: Cannot
set commit on an issue that does not have a commit queue".

R=phajdan.jr@chromium.org
BUG=529339

Review URL: https://codereview.chromium.org/1387833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297009 0039d316-1c4b-4281-b951-d872f2087c98

R=sergeyberezin@chromium.org
BUG=537417

Review URL: https://codereview.chromium.org/1388463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296995 0039d316-1c4b-4281-b951-d872f2087c98

R=iannucci@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1375343005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296990 0039d316-1c4b-4281-b951-d872f2087c98

R=sergiyb@chromium.org,phajdan.jr@chromium.org
BUG=537417

Review URL: https://codereview.chromium.org/1385653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296986 0039d316-1c4b-4281-b951-d872f2087c98

R=jochen@chromium.org

Review URL: https://codereview.chromium.org/1384693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296985 0039d316-1c4b-4281-b951-d872f2087c98

This would allow bot_update to differentiate between patch download and
aplication failures.

R=phajdan.jr@chromium.org,sergiyb@chromium.org
BUG=537417

Review URL: https://codereview.chromium.org/1380093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296983 0039d316-1c4b-4281-b951-d872f2087c98

R=erikcorry@google.com, iannucci@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1317833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296978 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Temporary fix for codereview cert issue. (patchset #3 id:2 of https://codereview.chromium.org/1376333002/ )

Reason for revert:
Outage is now over

Original issue's description:
> Temporary fix for codereview cert issue.
> 
> BUG=537763
> R=stip@chromium.org
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296959

TBR=tandrii@google.com,tandrii@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=537763

Review URL: https://codereview.chromium.org/1374223004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296964 0039d316-1c4b-4281-b951-d872f2087c98

BUG=537763
R=stip@chromium.org

Review URL: https://codereview.chromium.org/1376333002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296959 0039d316-1c4b-4281-b951-d872f2087c98

It's incorrect - the checkout it creates is unusable for pdfium
development.

Correct instructions are here:
https://code.google.com/p/pdfium/wiki/Build

BUG=510419
R=phajdan.jr@chromium.org

Review URL: https://codereview.chromium.org/1382543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296946 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:532318
TEST=None

Review URL: https://codereview.chromium.org/1350673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296930 0039d316-1c4b-4281-b951-d872f2087c98

- Create logs URL for both gitiles and github.
- Include the number of commits being rolled in in the commit subject, which is
  always useful.
- Make the log inclusion conditional on the repository being rolled in and the
  number of commits.
- Checkout the new commit when using this script, otherwise this is surprising
  to users.
- Add flags to support more use cases.
- Use --quiet when calling git to reduce noise in the output.

R=spang@chromium.org,jochen@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1366493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296924 0039d316-1c4b-4281-b951-d872f2087c98

This uses the same trick as git-new-workdir to reuse an existing git
checkout without interfering with it. However, this makes it only usable
on platforms where os.symlink exists.

BUG=404755

Review URL: https://codereview.chromium.org/1342383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296920 0039d316-1c4b-4281-b951-d872f2087c98

This CL allows passing the Rietveld URL to git cl patch along with the
CL number or patch URL.

Review URL: https://codereview.chromium.org/1363043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296889 0039d316-1c4b-4281-b951-d872f2087c98

BUG=532220

Review URL: https://codereview.chromium.org/1344183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296885 0039d316-1c4b-4281-b951-d872f2087c98

BUG=504452

Review URL: https://codereview.chromium.org/1223793008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296882 0039d316-1c4b-4281-b951-d872f2087c98

Devs should use fetch chromium instead

R=phajdan.jr@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1367473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296860 0039d316-1c4b-4281-b951-d872f2087c98

Revert of roll_dep: Avoid large commit messages by providing the log as a link (patchset #1 id:1 of https://codereview.chromium.org/1257233006/ )

Reason for revert:
Blink merge is done, blink people won't have to use it anymore.

Original issue's description:
> roll_dep: Avoid large commit messages by providing the log as a link
> 
> The majority of chromium projects are on googlesource.com, which can
> display a range of commits on the web. Use this feature instead of
> dumping logs into the commit message.
> 
> Particularly, this avoids creating large commit messages as these logs
> sometimes contain upwards of 50 commits.
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296184

TBR=jochen@chromium.org,spang@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1364763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296840 0039d316-1c4b-4281-b951-d872f2087c98

With this change, 'git cache fetch' will automatically re-bootstrap
a repo from google storage if the local cache has too many pack
files.  The behavior can be disabled with the --no-bootstrap flag.

BUG=

Review URL: https://codereview.chromium.org/1320383004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296829 0039d316-1c4b-4281-b951-d872f2087c98

For example:

[5165c48...]d:\src\crashpad\crashpad>git cl checkout https://codereview.chromium.org/1355503005
Previous HEAD position was 5165c48... Use argument escaping function in util/win/process_info_test.cc
Switched to branch 'crashpad-info-cross-bitness'

[crashpad-info-cross-bitness]d:\src\crashpad\crashpad>git cl checkout 818433002
Multiple branches match issue 818433002:
0: file_io_open
1: file_io_open-2
2: file_io_open-3
Choose by index: 1
Switched to branch 'file_io_open-2'


R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1357213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296823 0039d316-1c4b-4281-b951-d872f2087c98

The revision property must be a part of `changes`, per
https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/master/buildbucket/README.md

R=tandrii@chromium.org
BUG=534315

Review URL: https://codereview.chromium.org/1349343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296790 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/1360493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296782 0039d316-1c4b-4281-b951-d872f2087c98

- Update "gsutil.py" to be cooperatively safe when invoked
  multiple times simultaneously.
- Allow the cache directory to be overridden by the
  DEPOT_TOOLS_GSUTIL_BIN_DIR environment variable.
- Add a "--clean" flag to force "gsutil.py" to do a clean download.

BUG=chromium:452497
TEST=local
  - for i in `seq 1 50`; do ./gsutil.py --clean -- version&; done

Review URL: https://codereview.chromium.org/1346213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296772 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/1352043004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296750 0039d316-1c4b-4281-b951-d872f2087c98

This prevents `git rebase-update` from losing work when using a hook like
pre-commit-go.

R=dnj@chromium.org, vadimsh@chromium.org, maruel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1350043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296737 0039d316-1c4b-4281-b951-d872f2087c98

BUG=529169

Review URL: https://codereview.chromium.org/1342003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296691 0039d316-1c4b-4281-b951-d872f2087c98

There's a race condition in python's subprocess module, and gclient uses
it heavily while multithreaded. Avoid the race by locking around calls
to subprocess.Popen's constructor. Detailed explanation in the bug.

BUG=531561

Review URL: https://codereview.chromium.org/1343783004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296685 0039d316-1c4b-4281-b951-d872f2087c98

This allows calling 'git cl try' with properties. Each
property is set with the option -p key=value, where value
will be treated as json if possible or as string.

Examples for -p and pitfalls:

key=string -> 'string'
key=1 -> 1
key=[1,2,3] -> [1,2,3]
key=["one","two","three"] -> '[one,two,three]'
'key=["one","two","three"]' -> ['one','two','three']

BUG=488235

Review URL: https://codereview.chromium.org/1339073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296683 0039d316-1c4b-4281-b951-d872f2087c98

With this change, and running 'git auto-svn' whenever starting work on a
new upstream branch, much git-svn confusion and mayhem can be avoided.
For example:

$ git checkout -b drover_2403 branch-heads/2403
$ git svn info --url
  svn://svn.chromium.org/chrome-internal/trunk/tools/build
  # git-svn still thinks it's dealing with trunk.
$ git auto-svn
...
$ git svn info --url
  svn://svn.chromium.org/chrome-internal/branches/2403/tools/build
  # That's better.

R=agable@chromium.org, amineer@chromium.org

Review URL: https://codereview.chromium.org/1340733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296667 0039d316-1c4b-4281-b951-d872f2087c98

Without this I get prompted if I really want to remote the file.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1332303003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296651 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/1331263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296639 0039d316-1c4b-4281-b951-d872f2087c98

Several Chromium OS projects were moved to AOSP so now the development
is in that gerrit instance. This patch includes it to the list.

BUG=None
TEST=`my_activity.py` shows changes in the AOSP gerrit instance.

Review URL: https://codereview.chromium.org/1332723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296634 0039d316-1c4b-4281-b951-d872f2087c98

At the moment, this doesn't work too well for something that was just merged to
45.

[(b912ace...)]scottmg@scottmg:/work/cr/src$ git find-releases 55b4c95889d6a72e52bc72702580a62f04f35777
commit 55b4c95889d6a72e52bc72702580a62f04f35777 was:
  initially in 47.0.2501.0
  merged to undefined (as de54b58d404a0cdf01639ae7260ef10bbb843ed9)
  merged to 46.0.2490.19 (as b4ba1071baaabc92cb5a2ca89e238c478eca0075)

("undefined" being the problem). This is because:

[(b912ace...)]scottmg@scottmg:/work/cr/src$ git name-rev --tags de54b58d404a0cdf01639ae7260ef10bbb843ed9
de54b58d404a0cdf01639ae7260ef10bbb843ed9 undefined

But,

[(b912ace...)]scottmg@scottmg:/work/cr/src$ cat .git/refs/remotes/branch-heads/2454
de54b58d404a0cdf01639ae7260ef10bbb843ed9

So, if name-rev --tags says it's not yet tagged, rather than just printing
'undefined', at least say which branch it was merged to. As in:

[(b912ace...)]scottmg@scottmg:/work/cr/src$ git find-releases 55b4c95889d6a72e52bc72702580a62f04f35777
commit 55b4c95889d6a72e52bc72702580a62f04f35777 was:
  initially in 47.0.2501.0
  merged to branch-heads/2454 [untagged] (as de54b58d404a0cdf01639ae7260ef10bbb843ed9)
  merged to 46.0.2490.19 (as b4ba1071baaabc92cb5a2ca89e238c478eca0075)


R=dpranke@chromium.org,primiano@chromium.org

Review URL: https://codereview.chromium.org/1325233005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296621 0039d316-1c4b-4281-b951-d872f2087c98

Finds the release(s) for a given change.

Relies on using "git cherry-pick -x" per
http://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/git-drover.html
so that the merge commit message contains the original commit.

Example:

d:\src\cr3\src>git show -s 53cc88da9a258bc4a34c4bff50025ee044c2e64d
commit 53cc88da9a258bc4a34c4bff50025ee044c2e64d
Author: grt <grt@chromium.org>
Date:   Tue Jun 2 10:33:09 2015 -0700

    Beacons for tracking default browser status.

    BUG=488247
    R=gab@chromium.org,wfh@chromium.org

    Review URL: https://codereview.chromium.org/1146843003

    Cr-Commit-Position: refs/heads/master@{#332423}


"Now, where did that ship?"


d:\src\cr3\src>git find-releases 53cc88da9a258bc4a34c4bff50025ee044c2e64d
commit 53cc88da9a258bc4a34c4bff50025ee044c2e64d was:
  initially in 45.0.2421.0
  merged to 43.0.2357.126 (as 8a5ccc0e0ad6b2237b2fcfffcb0ab24fe97bc77b)
  merged to 44.0.2403.39 (as d5d165943a88e51a64fd9e2fbcc781e4aaee270f)

Review URL: https://codereview.chromium.org/1332473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296604 0039d316-1c4b-4281-b951-d872f2087c98

This reverts https://codereview.chromium.org/1008143002
since WebRTC has now moved over to Chromium's Rietveld instance.

BUG=webrtc:3884

Review URL: https://codereview.chromium.org/1188523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296585 0039d316-1c4b-4281-b951-d872f2087c98

R=pgervais@chromium.org, rmistry@chromium.org

Review URL: https://codereview.chromium.org/1309393004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296530 0039d316-1c4b-4281-b951-d872f2087c98