Commits · 6898897529c0860b11b86856a93208c51a1f8c2f · Linshizhi / Chromium_Depot_tools

20 Sep, 2011 2 commits

Continue conversion to more properties. · 68988975

maruel@chromium.org authored Sep 20, 2011

Make Dependency.file_list a tuple so it can't be modified.
Move the guesswork of file_list at the right place.
Remove tree() since it's unnecessary.

R=dpranke@chromium.org
BUG=
TEST=all smoke tests still pass


Review URL: http://codereview.chromium.org/7922011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101951 0039d316-1c4b-4281-b951-d872f2087c98

68988975

Use properties for more members that do not change · d6db3d53

maruel@chromium.org authored Sep 20, 2011

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7889047

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101950 0039d316-1c4b-4281-b951-d872f2087c98

d6db3d53

19 Sep, 2011 3 commits

Fix gcl sometimes stripping the new line characters when changing the issue... · f1c2f43c

jam@chromium.org authored Sep 19, 2011

Fix gcl sometimes stripping the new line characters when changing the issue description on the server. This change replaces \n with \r\n before giving the description to the editor on Windows (not through cygwin though), and then replaces \r\n with \n when saving it locally or sending it to reitveld.

BUG=95618
Review URL: http://codereview.chromium.org/7875004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101863 0039d316-1c4b-4281-b951-d872f2087c98

f1c2f43c

Retry "Initial step into making Dependency thread safe"" · 6ca8bf80

maruel@chromium.org authored Sep 19, 2011

I had forgot one access to _requirements. Now that tests are run, this change is
safer to commit.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7909012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101856 0039d316-1c4b-4281-b951-d872f2087c98

6ca8bf80

GTTF: Make gclient try harder when doing svn cleanup. · 8a312c56

phajdan.jr@chromium.org authored Sep 19, 2011

BUG=96775

Review URL: http://codereview.chromium.org/7922018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101771 0039d316-1c4b-4281-b951-d872f2087c98

8a312c56

15 Sep, 2011 3 commits

Allow a trailing slash in the rietveld url. · 0e863f90

craig.schlenter@chromium.org authored Sep 15, 2011

Review URL: http://codereview.chromium.org/7894003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101356 0039d316-1c4b-4281-b951-d872f2087c98

0e863f90

Fix member lookup to be more stable. · 3c74bc9d

maruel@chromium.org authored Sep 15, 2011

Add regression test.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7891061

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101351 0039d316-1c4b-4281-b951-d872f2087c98

3c74bc9d

Fix a typo that resulted in no tests to be run in depot_tools. :( · fae707be

maruel@chromium.org authored Sep 15, 2011

Add a warning when RunUnitTestsInDirectory() finds no test to run to
catch this kind of regression.

Fix all the regressions that where introduced in the meantime...

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7906009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101347 0039d316-1c4b-4281-b951-d872f2087c98

fae707be

14 Sep, 2011 9 commits

Revert "Initial step into making Dependency thread safe" · adcf5b70

maruel@chromium.org authored Sep 14, 2011

Broke the tree. :(

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101136 0039d316-1c4b-4281-b951-d872f2087c98

adcf5b70

Initial step into making Dependency thread safe · 89d51c24

maruel@chromium.org authored Sep 14, 2011

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7892034

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101135 0039d316-1c4b-4281-b951-d872f2087c98

89d51c24

Print diagnosis message when a task is Ctrl-C'ed out · 109cb9d3

maruel@chromium.org authored Sep 14, 2011

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7891058

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101133 0039d316-1c4b-4281-b951-d872f2087c98

109cb9d3

Add diagnostics if an item is run multiple times · f36c0ee5

maruel@chromium.org authored Sep 14, 2011

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7885032

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101117 0039d316-1c4b-4281-b951-d872f2087c98

f36c0ee5

Revert to --jobs 1 again. · 8fbb7761

maruel@chromium.org authored Sep 14, 2011

I need to add real thread locking to some Dependency methods. That was long
needed anyway.

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7891053

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101100 0039d316-1c4b-4281-b951-d872f2087c98

8fbb7761

Replace check_output() call site into check_call(). Would throw otherwise. · 91def9be

maruel@chromium.org authored Sep 14, 2011

subprocess2.check_ouput() doesn't accept stdout argument to correctly mimic
subprocess implementation in python 2.7.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7888042

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101085 0039d316-1c4b-4281-b951-d872f2087c98

91def9be

Sets --jobs 8 as the default. · 8b36594b

maruel@chromium.org authored Sep 14, 2011

I've fixed the From() issue that was causing it to hangs. We'll see if anything
pops up again.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7885028

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101084 0039d316-1c4b-4281-b951-d872f2087c98

8b36594b

Retry r100190 "Change git_cl.py to use subprocess2"" · 32f9f5ed

maruel@chromium.org authored Sep 14, 2011

Now with more fixes and take in account subprocess2.check_output() correctness
w.r.t. stderr.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7866007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101072 0039d316-1c4b-4281-b951-d872f2087c98

32f9f5ed

Fix the case where a dep not processed could be set as a requirement. · 485dcab6

maruel@chromium.org authored Sep 14, 2011

This would result in a hang during gclient sync.

Includes regression test.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7885008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@101070 0039d316-1c4b-4281-b951-d872f2087c98

485dcab6

09 Sep, 2011 7 commits

subprocess2.check_output() doesn't allow stdout, like python2.7's version. · 69bc538f

maruel@chromium.org authored Sep 09, 2011

Don't bother, but redirect stderr.

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7865005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100464 0039d316-1c4b-4281-b951-d872f2087c98

69bc538f

Use check_call(), not check_output() · 6a051695

maruel@chromium.org authored Sep 09, 2011

There is user interaction when the svn credential isn't cached. (Duh)

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7864007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100462 0039d316-1c4b-4281-b951-d872f2087c98

6a051695

Update subprocess2.check_output() to behave like subprocess.check_output(). · 87e6d331

maruel@chromium.org authored Sep 09, 2011

stderr is not redirected by default. stdout is not allowed.
Both were oversight.
Do not override stdin=None in case the user would response to stderr output for
example.

Increase test coverage.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7860041

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100456 0039d316-1c4b-4281-b951-d872f2087c98

87e6d331

Fix check_output usage in trychange.py · e3606abc

maruel@chromium.org authored Sep 09, 2011

Update the command for subprocess.CalledProcessError

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7860047

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100410 0039d316-1c4b-4281-b951-d872f2087c98

e3606abc

Now that CheckCallAndFilter() throws subprocess2.CalledProcessError, use e.returncode. · 2a5b6a2a

maruel@chromium.org authored Sep 09, 2011

deferring e.args[0] would throw an error.

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7859032

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100402 0039d316-1c4b-4281-b951-d872f2087c98

2a5b6a2a

Some callers expect e.stderr to be filled on exception · 73c87e94

maruel@chromium.org authored Sep 09, 2011

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7860038

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100393 0039d316-1c4b-4281-b951-d872f2087c98

73c87e94

Revert r100190 "Change git_cl.py to use subprocess2" · d4b4e113

maruel@chromium.org authored Sep 09, 2011

Revert r100267 "git cl assumes no shell is used."

It's causing exceptions, r100190 still need some work.

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7858029

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100390 0039d316-1c4b-4281-b951-d872f2087c98

d4b4e113

08 Sep, 2011 16 commits

SVN.GenerateDiff assumes SVN.Capture captures stderr. · 904af089

maruel@chromium.org authored Sep 08, 2011

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7787008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100270 0039d316-1c4b-4281-b951-d872f2087c98

904af089

git cl assumes no shell is used. · b10e1c75

maruel@chromium.org authored Sep 08, 2011

This is necessary for msysgit usage on windows.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7858008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100267 0039d316-1c4b-4281-b951-d872f2087c98

b10e1c75

GIT.Capture doesn't throw gclient_utils.Error anymore. · 0112bfb5

maruel@chromium.org authored Sep 08, 2011

Fix case where git-try fails for branch not still uploaded to rietveld.

TBR=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7860004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100244 0039d316-1c4b-4281-b951-d872f2087c98

0112bfb5

Make the rietveld client code ignore file status more often. · 087066c5

maruel@chromium.org authored Sep 08, 2011

It's proved to be unreliable.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7857006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100236 0039d316-1c4b-4281-b951-d872f2087c98

087066c5

Update docstrings w.r.t. subprocess2. · 57bf78d8

maruel@chromium.org authored Sep 08, 2011

No code change.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7858001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100212 0039d316-1c4b-4281-b951-d872f2087c98

57bf78d8

Fix support when 2 properties are modified. · e2335ae8

maruel@chromium.org authored Sep 08, 2011

Add regression test.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7754020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100209 0039d316-1c4b-4281-b951-d872f2087c98

e2335ae8

Fix rietveld when status is only one char · 75547c3f

maruel@chromium.org authored Sep 08, 2011

Update unit test accordingly.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7754016

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100207 0039d316-1c4b-4281-b951-d872f2087c98

75547c3f

Make rietveld_test.py use patches_data.py · 77f47793

maruel@chromium.org authored Sep 08, 2011

Also verify source_filename properly.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7849015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100205 0039d316-1c4b-4281-b951-d872f2087c98

77f47793

Remove CheckCall, CheckCallError and Popen from gclient_utils. · a82a8ee4

maruel@chromium.org authored Sep 08, 2011

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7846003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100203 0039d316-1c4b-4281-b951-d872f2087c98

a82a8ee4

Move sample patches to its own file so it can be reused by rietveld_test.py · fd19a303

maruel@chromium.org authored Sep 08, 2011

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7847021

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100201 0039d316-1c4b-4281-b951-d872f2087c98

fd19a303

Move fail tests into a separate class. · c73a5303

maruel@chromium.org authored Sep 08, 2011

Makes the code clearer by separating good and bad use cases.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7850018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100198 0039d316-1c4b-4281-b951-d872f2087c98

c73a5303

Change git_cl.py to use subprocess2 · eafd7ae7

maruel@chromium.org authored Sep 08, 2011

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7848003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100190 0039d316-1c4b-4281-b951-d872f2087c98

eafd7ae7

Remove gclient_utils.CheckCall() from gclient_scm.py · bffad37d

maruel@chromium.org authored Sep 08, 2011

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7847004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100185 0039d316-1c4b-4281-b951-d872f2087c98

bffad37d

Remove gclient_utils.CheckCall() usage from scm.py · da64d639

maruel@chromium.org authored Sep 08, 2011

Remove reference to shutil while at it.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7851001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100182 0039d316-1c4b-4281-b951-d872f2087c98

da64d639

Make gclient_utils.CheckCallError inherit from subprocess2.CalledProcessError. · ca0f8398

maruel@chromium.org authored Sep 08, 2011

This will simply the transition

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7839038

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100174 0039d316-1c4b-4281-b951-d872f2087c98

ca0f8398

Remove gclient_utils.Popen() usage from gclient.py · 1ba646fc

maruel@chromium.org authored Sep 08, 2011

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7795061

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100173 0039d316-1c4b-4281-b951-d872f2087c98

1ba646fc