BUG=None
TBR=laforge@chromium.org, kerz

Review URL: https://codereview.chromium.org/16557009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@204668 0039d316-1c4b-4281-b951-d872f2087c98

Suppress alt_urls when a drover.properties file is present (otherwise it breaks branch reverts for Blink, etc...)

TBR=kerz

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@204545 0039d316-1c4b-4281-b951-d872f2087c98

                                                                                 
See the bug for how these were built.                                            
                                                                                 
The linux binaries were built by thestig@chromium.org.                           
The windows binary was built by scottmg@chromium.org.                            
The mac binary was built by thakis@chromium.org                                  
                                                                                 
This contains fixes for http://crbug.com/245034 and http://crbug.com/242397      
                                                                                 
BUG=242397,245034,246734
TBR=scottmg



git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@204049 0039d316-1c4b-4281-b951-d872f2087c98

When a developer runs download_from_google_storage, and they don't have a .boto
file, the tool automatically runs "gsutil config" to create one for them.
Unfortunately, a side consequence is that if a bot runs the script, and it has
a boto file that 403's, then it would run "gsutil config" which moves the .boto
to .boto.bak, and creates an empty .boto file.  This should not be the intended
action.

This CL changes so that "gsutil config" is not called, but instead just fails
with a message telling the dev to run that command.

TBR=maruel@chromium.org

Review URL: https://codereview.chromium.org/16072023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@203824 0039d316-1c4b-4281-b951-d872f2087c98

.search() may return results in unexpected order. Manually sort the entries
otherwise first_day and last_day could be inversed, leading to negative number
of days.

R=iannucci@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/16003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@203792 0039d316-1c4b-4281-b951-d872f2087c98

If ~/.gitconfig contains:
	[diff]
		renames = "true"
then git diff --name-status will produce output that confuses the parsing
in svm.GIT.CaptureStatus and git diff will produce output that confuses the
patch command on trybots.  Passing --no-renames explicitly counteracts this.

Review URL: https://chromiumcodereview.appspot.com/16057018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@203778 0039d316-1c4b-4281-b951-d872f2087c98

76 columns is fine for most patches but reverts will eat another
4 spaces in indentation. For the sake of revert clarity this reference
line is reduced to 72 columns.

Review URL: https://chromiumcodereview.appspot.com/16152005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@203530 0039d316-1c4b-4281-b951-d872f2087c98

BUG=237388

Review URL: https://chromiumcodereview.appspot.com/14583004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@203384 0039d316-1c4b-4281-b951-d872f2087c98

Adds an extra line to the default text description to help judge whether the
76 character recommended limit is being passed.

Review URL: https://chromiumcodereview.appspot.com/15670012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@203314 0039d316-1c4b-4281-b951-d872f2087c98

This is ninja at 4df15104d532ad91b7a9d3c54985180a6c2f2533.

Changes since 1.3.3 include that affect this Windows build:
- fixing '-t msvc' to stop lowercasing paths from /showIncludes output
- fix a crash in tool target suggestions
- error checking on -j.

This version is newer than 1.3.3 but --version will say 1.3.0git. Other
platforms are staying at 1.3.3. All platforms will re-converge at 1.4.0.

R=thakis@chromium.org
BUG=242397

Review URL: https://codereview.chromium.org/16232002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@203165 0039d316-1c4b-4281-b951-d872f2087c98

R=digit@chromium.org, maruel@chromium.org
BUG=244602

Review URL: https://chromiumcodereview.appspot.com/16007008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@202879 0039d316-1c4b-4281-b951-d872f2087c98

TEST=tests/git_cl_test.py

Review URL: https://chromiumcodereview.appspot.com/15650014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@202865 0039d316-1c4b-4281-b951-d872f2087c98

git_cl.py script.  See http://goo.gl/JGg0Z for details.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/14793006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@202864 0039d316-1c4b-4281-b951-d872f2087c98

Also adds msg to assertions to print current size of data written to stdout.

Review URL: https://chromiumcodereview.appspot.com/16058007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@202863 0039d316-1c4b-4281-b951-d872f2087c98

BUG=235289
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/15792004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@202236 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242220

Review URL: https://codereview.chromium.org/15367008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@201859 0039d316-1c4b-4281-b951-d872f2087c98

TBR=cmp@chromium.org
BUG=239665

Review URL: https://chromiumcodereview.appspot.com/15665002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@201438 0039d316-1c4b-4281-b951-d872f2087c98

._Capture throws exception on non-zero status, switch to
subprocess2 capture method. Switch magic value to dontswitchurl.

BUG=241907
R=dpranke@chromium.org, maruel@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15325003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@201397 0039d316-1c4b-4281-b951-d872f2087c98

As noticed in the TODO, raw_input (used by ask_for_data) works badly
on background threads. On my Windows it doesn't even print the prompt which
makes it hard to interact with it.

Better to just abort and tell the user of gclient how to proceed.

BUG=

Review URL: https://chromiumcodereview.appspot.com/15421005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@201295 0039d316-1c4b-4281-b951-d872f2087c98

cflags and ldflags.



git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@201145 0039d316-1c4b-4281-b951-d872f2087c98

On mac, I ran: 
git checkout v1.3.3 
./bootstrap.py 
CXX=path/to/chromiums/clang++ ./configure --with-gtest=path/to/gtest 
./ninja ninja_test 
./ninja_test # all passed 
strip ninja 

Empty build perf is ~7% slower (https://github.com/martine/ninja/issues/544), 
but this allows us to enable deps mode by default which will make empty builds 
twice as fast. 

Mac binary size grew by ~16kB. 

The linux binaries were built by thestig@chromium.org. 
The windows binary was built by scottmg@chromium.org. 

New stuff since 1.1: 
- NINJA_STATUS now allows %e, for elapsed time. 
- "pool" feature 
- "compdb" tool for writing clang compilation databases 
- faster deps mode (needs to be explicitly enabled in gyp, not done yet) 

BUG=241628
Review URL: https://codereview.chromium.org/15490003



git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@201143 0039d316-1c4b-4281-b951-d872f2087c98

R=maruel@chromium.org

Review URL: https://codereview.chromium.org/15302014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@201094 0039d316-1c4b-4281-b951-d872f2087c98

Regular map is preferred when parallization does
not speed presubmit tests.  It makes stacktraces more
understandable and facilitates debugging.  Only use
parallel pool when tests > 1.

R=maruel@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15385002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@200940 0039d316-1c4b-4281-b951-d872f2087c98

Windows bots are having trouble calling download_from_google_storage.py from the
DEPS hooks.  This should allow it to be called as just "download_from_google_storage".

BUG=
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/15395002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@200939 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes the implementation as follows:

  1/ Fix '--full' option to check for all changes in the
     current branch relative to upstream. The old code only
     considered currently modified files, which made little
     sense.

  2/ Fix '--full' option to apply Chromium style too.

  3/ Use a proper source file filter. The original code used
     ".*.cc .*.cpp .*.h" as the filter, which didn't catch anything !?

  4/ Add --no-ext-diff to make it work with custom "git diff" handlers.

R=agable@chromium.org, maruel@chromium.org, pliard@chromium.org
BUG=NONE

Review URL: https://chromiumcodereview.appspot.com/14942012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@200832 0039d316-1c4b-4281-b951-d872f2087c98

Until r200514 is merged into every active branches on Windows, python can't be
upgraded to 2.7.x.

TBR=iannucci@chromium.org,joi@chromium.org
BUG=241769

Review URL: https://codereview.chromium.org/15294005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@200800 0039d316-1c4b-4281-b951-d872f2087c98

TBR=joi@chromium.org
BUG=

Review URL: https://codereview.chromium.org/14972010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@200799 0039d316-1c4b-4281-b951-d872f2087c98

Some PRESUBMIT files dynamically generate test list
and so may pass an empty list to RunTests.  There
appears to be a bug in multiprocessing.Pool that
causes a stall in map_async with an empty list.

TBR=maruel

Review URL: https://chromiumcodereview.appspot.com/14962011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@200613 0039d316-1c4b-4281-b951-d872f2087c98

R=maruel@chromium.org, iannucci@chromium.org
BUG=239665

Review URL: https://chromiumcodereview.appspot.com/14876024

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@200358 0039d316-1c4b-4281-b951-d872f2087c98

Allow users to set a git config entry which stops
gclient from messing with remote.origin.url. Useful
for using experimental repos.

Review URL: https://chromiumcodereview.appspot.com/14731015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@199532 0039d316-1c4b-4281-b951-d872f2087c98

assertEquals is deprecated.

R=iannucci@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/14602008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@199316 0039d316-1c4b-4281-b951-d872f2087c98

This makes the commit description cleaner.

R=iannucci@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/14061008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@199275 0039d316-1c4b-4281-b951-d872f2087c98

[1] *scm_test.py are deeply broken, svnadmin is missing for svn_bin\.
And the git test are failing at shutdown.

Also Fix SvnCheckout.testMove flakiness.

TBR=ilevy@chromium.org,szager@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/14729012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@198900 0039d316-1c4b-4281-b951-d872f2087c98

Make upload.py treat images as binaries, so they upload correctly and display in Reitveld.

BUG=227346

Review URL: https://chromiumcodereview.appspot.com/14820015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@198833 0039d316-1c4b-4281-b951-d872f2087c98

Helps scanning faster. colorma is already slightly used by gclient but wasn't
by git-cl yet.

Update a unit test to be stricter, it was caught in the cross fire as colorma
hooks sys.stdout and stderr.

R=iannucci@chromium.org
BUG=

Review URL: https://chromiumcodereview.appspot.com/15025003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@198689 0039d316-1c4b-4281-b951-d872f2087c98

BUG=238390

Review URL: https://chromiumcodereview.appspot.com/15018003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@198572 0039d316-1c4b-4281-b951-d872f2087c98

As per the discussion in
https://groups.google.com/a/chromium.org/forum/?fromgroups=#!topic/chromium-dev/Hl2QPNQ9E5o,
this CL adds a 'git cl format' command. Users may use it at their own
discretion. By default, it generates a diff against the local tracking
(upstream) branch and runs clang-format-diff on that diff.  When given the
'--full' flag, it instead identifies all .cc, .cpp, and .h files in the diff and
runs clang-format on the entirety of each of those files.

Review URL: https://chromiumcodereview.appspot.com/14629012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@198477 0039d316-1c4b-4281-b951-d872f2087c98

Chanot branch[0].isdigit()nging --milestone to use JSON source and adding prompt for branch mismatch.

Sample output:

$ drover --merge 196360 --milestone 27

Not all platforms have same branch number for M27.

Here's a list of platforms on each branch:
-(1453): win, ios, cf, mac, linux, android
-(1460): cros
Which branch? ('q' to cancel) 1453

Review URL: https://chromiumcodereview.appspot.com/14544004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@198282 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/14746006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@198266 0039d316-1c4b-4281-b951-d872f2087c98

Follow-up to ilevy's comments in https://chromiumcodereview.appspot.com/14759006/

Review URL: https://chromiumcodereview.appspot.com/14874005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@198236 0039d316-1c4b-4281-b951-d872f2087c98