Skip to content

C
Chromium_Depot_tools
Switch branch/tag
  1. 01 Jul, 2022 5 commits
  3. 30 Jun, 2022 3 commits
  5. 29 Jun, 2022 4 commits
  7. 28 Jun, 2022 2 commits
  9. 27 Jun, 2022 3 commits
  11. 24 Jun, 2022 2 commits
  13. 23 Jun, 2022 3 commits
  15. 22 Jun, 2022 3 commits
  17. 21 Jun, 2022 1 commit
  19. 17 Jun, 2022 2 commits
    • dan sinclair's avatar
      Add some c++17 headers to the list of known headers. · 9a3c4bc6
      dan sinclair authored 
      This CL updates cpplint.py to add some of the c++17 header files to the
list of known c++ headers. We're specifically using optional and variant
in the Tint project and would like to remove the NOLINT lines necessary
to keep the linter happy.

Bug: dawn:1379
Change-Id: I41cacd21e0742f992cdd6913b7f4def556b543c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3709241
Auto-Submit: Dan Sinclair <dsinclair@chromium.org>
Reviewed-by: 's avatarJosip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
      9a3c4bc6
    • Bruce Dawson's avatar
      Mitigate Python 3 multiprocessing bug on Windows · 8254f06b
      Bruce Dawson authored 
      The multiprocessing module on Windows has a bug where if you ask for
more than 60 child processes then it will hang. This is related to the
MAXIMUM_WAIT_OBJECTS (64) limit of WaitForMultipleObjects. Other sources
have listed the multiprocessing limit as being 61, or have said that the
the maximum number of objects that can be waited on is actually 63, but
those details don't really matter.

The original fix for this class of issues was crrev.com/c/2785844. This
change extends those fixes to depot_tools, which was missed last year.
This change also updates how PyLint is called by further limiting the
number of jobs to the number of files being processed divided by 10.
This is because there is a significant cost to creating PyLint
subprocesses - each takes about 0.5 s on my test machine. So there needs
to be enough parallelism to justify this.

Patches for PyLint and a bug for cpython are planned.

This will stop PyLint from hanging during presubmits on many-core
machines. The command used to reproduce the hangs and validate the fix
was:

  git cl presubmit -v --force --files "chrome/test/mini_installer/*.py"

Prior to this change this command would use (on my many-core test
machine) 96 processes and would hang. How it uses just two processes
because there are only 16 files to analyze.

Output before:
  Pylint (16 files using ['--disable=cyclic-import'] on 96 cores)
Output after:
  Pylint (16 files using ['--disable=cyclic-import'] on 2 processes)

This is actually not quite true because the hang would prevent the
old message from being displayed.

Bug: 1190269, 1336854
Change-Id: Ie82baf91df4364a92eb664a00cf9daf167e0a548
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3711282Reviewed-by: 's avatarGavin Mak <gavinmak@google.com>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
      8254f06b
  21. 16 Jun, 2022 6 commits
  23. 15 Jun, 2022 3 commits
  25. 14 Jun, 2022 2 commits
  27. 13 Jun, 2022 1 commit