- 01 Mar, 2014 1 commit
-
-
machenbach@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/178223016 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@254321 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 Feb, 2014 4 commits
-
-
hinoka@google.com authored
We don't want to run it in the DEPS directory, which is apperently what the default behavior is. BUG=339171 Review URL: https://codereview.chromium.org/184793003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@254266 0039d316-1c4b-4281-b951-d872f2087c98
-
hinoka@google.com authored
Instead of having custom logic for dealing with cache directories, use git_cache.py to populate caches. Also fixes a bug in git_cache.py where it was looking for lockfiles in cwd rather than the cache dir. Other changes: * _Run now returns output. * Always print to stdout in CheckCallAndFilterOutput, even if it gets a carriage return. This is done because git progress report are carriage returns and not newlines and we don't want everything on the same line and not strip out the CRs. * Removed members changed tests, its not very useful to know a new import is added. BUG=339171 Review URL: https://codereview.chromium.org/180243006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@254248 0039d316-1c4b-4281-b951-d872f2087c98
-
tnagel@chromium.org authored
It's not true (anymore?) that the number of SCM jobs for gclient sync equals the number of cores, thus the new text is less specific. BUG=none Review URL: https://codereview.chromium.org/184733007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@254242 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
TBR=pkasting@chromium.org BUG=323300 Review URL: https://codereview.chromium.org/178193008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@254042 0039d316-1c4b-4281-b951-d872f2087c98
-
- 27 Feb, 2014 3 commits
-
-
hinoka@chromium.org authored
For some reason "--tags" wasn't working on some versions of git (pre-1.9) BUG=339171 Review URL: https://codereview.chromium.org/183813004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253929 0039d316-1c4b-4281-b951-d872f2087c98
-
agable@chromium.org authored
R=hinoka@chromium.org BUG=339171 Review URL: https://codereview.chromium.org/183643002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253887 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
git sometimes blocks asking for a password. On a random machine that didn't know anything about google/chromium, it failed immediately with "fatal: could not read Username for 'https://chrome-internal.googlesource.com': No such file or directory" but on my real machine w/o _netrc it blocks and wants this: Username for 'https://chrome-internal.googlesource.com': Password for 'https://chrome-internal.googlesource.com': There's no --non-interactive unfortunately, it's supposed to magically decide if it's connected to a tty and behave appropriately. It does not, perhaps because of being wrapped in depot_tools .bat files, perhaps an msysgit-port bug, perhaps being called from python. Anyway https://github.com/bower/bower/issues/1009 had a magic incantation that works for this case: 'true' is available in the msys distribution. R=iannucci@chromium.org BUG=323300 Review URL: https://codereview.chromium.org/182553004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253844 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Feb, 2014 4 commits
-
-
szager@chromium.org authored
This reverts commit 6ff54485. 'fetch --nohooks chromium' is broken with this change. BUG= Review URL: https://codereview.chromium.org/177003023 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253640 0039d316-1c4b-4281-b951-d872f2087c98
-
borenet@google.com authored
Review URL: https://codereview.chromium.org/164053003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253616 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
Shell PATH was growing quite long in some cases. R=gab@chromium.org, iannucci@chromium.org, johnw@chromium.org, maruel@chromium.org Review URL: https://codereview.chromium.org/180303003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253347 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyberezin@chromium.org authored
ssl.SSLError does NOT have 'reason' attribute. Use str() to get a reliable string. Fixed the silly bug in another CL: https://codereview.chromium.org/180273003/ The ssl.SSLError does NOT have attribute 'reason', and must use the generic 'strerror' instead. This is what happens when I submit a CL too fast... BUG=346845 R=stip@chromium.org,maruel@chromium.org Review URL: https://codereview.chromium.org/180723002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253317 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Feb, 2014 2 commits
-
-
nick@chromium.org authored
clang-format: Allow .proto files to be formatted (supported by an upcoming binary/script; this change is safe if you are running an older binary); remove warnings. BUG=344916 Review URL: https://codereview.chromium.org/177213013 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253295 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyberezin@chromium.org authored
BUG=346845 R=maruel@chromium.org Review URL: https://codereview.chromium.org/180273003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253271 0039d316-1c4b-4281-b951-d872f2087c98
-
- 24 Feb, 2014 2 commits
-
-
agable@chromium.org authored
The git cache command is a central place to manage a machine's git cache. It provides two subcommands: * populate -- creates or updates the cache of a given repository * exists -- prints the path to the cache of a repo, if it exists Gclient, deps2git, bot_update, and any other tools that touch the cache will be able to use this command to make sure that everyone is interacting with the cache in the same way. R=hinoka@chromium.org, iannucci@chromium.org BUG=339168 Review URL: https://codereview.chromium.org/164823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253007 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
If user is unauthenticated, svn ls would just hang waiting at "Password for 'User':", now it'll correctly fail with "svn: Can't get password". R=iannucci@chromium.org BUG=323300,346472 Review URL: https://codereview.chromium.org/178763003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253004 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Feb, 2014 5 commits
-
-
scottmg@chromium.org authored
TBR=iannucci@chromium.org BUG=345993 Review URL: https://codereview.chromium.org/169053008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252757 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
TBR=iannucci@chromium.org BUG=323300 Review URL: https://codereview.chromium.org/173523005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252737 0039d316-1c4b-4281-b951-d872f2087c98
-
hinoka@google.com authored
BUG=339171 Review URL: https://codereview.chromium.org/169433008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252729 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
Moves the update functionality out of update_depot_tools into src/ in https://codereview.chromium.org/175573004 . get_toolchain_if_required.py now expects a list of hashes on the command line, and makes sure that it gets one of those. toolchain2013.py saves a .json which contains information relevant to the interests of the caller, so that it can set up the parent environment. This is returned via the --output-json command line argument to get_...py R=iannucci@chromium.org BUG=323300 Review URL: https://codereview.chromium.org/168603004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252725 0039d316-1c4b-4281-b951-d872f2087c98
-
hinoka@google.com authored
This is to tackle the issue that slaves don't have global git vars set up. BUG=339171 Review URL: https://codereview.chromium.org/175543006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252705 0039d316-1c4b-4281-b951-d872f2087c98
-
- 21 Feb, 2014 6 commits
-
-
scottmg@chromium.org authored
> Switch to opt-out for toolchain > > R=maruel@chromium.org > BUG=323300 > > Review URL: https://codereview.chromium.org/174663005 TBR=scottmg@chromium.org Review URL: https://codereview.chromium.org/175743002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252634 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
R=maruel@chromium.org BUG=323300 Review URL: https://codereview.chromium.org/174663005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252633 0039d316-1c4b-4281-b951-d872f2087c98
-
mmoss@chromium.org authored
The git path is based on the git version, so it might change whenever git is updated. Run git.bat instead, since that's updated with new git installs and should always point to the right path. The mingw logic is based on similar handling of python.bat in git-cl. Review URL: https://codereview.chromium.org/166273024 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252584 0039d316-1c4b-4281-b951-d872f2087c98
-
agable@chromium.org authored
R=iannucci@chromium.org, maurel@chromium.org Review URL: https://codereview.chromium.org/169323004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252474 0039d316-1c4b-4281-b951-d872f2087c98
-
hinoka@google.com authored
This add --force to ignore the flag file. This also passes --base_ref so we can specify which ref we're basing off of so that it does not incorrectly assert that it is basing off origin/master BUG=339171 Review URL: https://codereview.chromium.org/171763003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252464 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyberezin@chromium.org authored
BUG=345117 Review URL: https://codereview.chromium.org/174313002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252452 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Feb, 2014 3 commits
-
-
mmoss@chromium.org authored
The git path is based on the git version, so it might change whenever git is updated. Run git.bat instead, since that's updated with new git installs and should always point to the right path. Review URL: https://codereview.chromium.org/173393002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252299 0039d316-1c4b-4281-b951-d872f2087c98
-
mmoss@chromium.org authored
R=maruel@chromium.org Review URL: https://codereview.chromium.org/172003003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252297 0039d316-1c4b-4281-b951-d872f2087c98
-
iannucci@chromium.org authored
One line for the fix, 30 lines for the test :) R=kbr@chromium.org, mmoss@chromium.org, stip@chromium.org, szager@chromium.org BUG=345073 Review URL: https://codereview.chromium.org/165443004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252138 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 Feb, 2014 2 commits
-
-
davidjames@chromium.org authored
This reverts commit cdd96909, which broke gerrit_unittest.py within the chroot, which has Java 6. Original-Review URL: https://codereview.chromium.org/164023005 TBR=szager BUG=344786 TEST=Run the unit tests before and after. Confirm this CL fixes them. Review URL: https://codereview.chromium.org/170423003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@251976 0039d316-1c4b-4281-b951-d872f2087c98
-
dborowitz@google.com authored
These may be named git-snapshot-VERSION.war, where VERSION is the long format defined in git-describe(1). In particular, this may include a number of commits after the given tag name; treat more commits since the tag as a higher version number. This is arguably not always strictly correct due to non-linear history, but the maintainers expect the total number of such snapshot versions to be low, and can remove old snapshot versions that don't sort correctly. Slightly de-obfuscate some of the variable names and logic while we're at it. R=szager@chromium.org BUG= Review URL: https://codereview.chromium.org/164023005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@251888 0039d316-1c4b-4281-b951-d872f2087c98
-
- 13 Feb, 2014 5 commits
-
-
scottmg@chromium.org authored
The goal of this change is to include the DIA SDK (and strip out a bit extra that was unnecessary). Unfortunately, the msi that includes the DIA SDK includes a file with an extraordinarily long path, 241 characters long. When prepended with "C:\Program Files (x86)\" it extracts OK, however, when we extract to %TEMP% it's not hard for it to exceed _MAX_PATH and have the msi tool fail. So, when extracting MSIs, also do the equivalent of "subst X: temp_dir" and use X:\ as the path given to msiexec. (sigh) R=maruel@chromium.org BUG=323300 Review URL: https://codereview.chromium.org/150333005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@251085 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
It's somewhat annoying to have the script delete your toolchain directory (at least during testing) and it necessitates downloading 3-4G to restore, so add a short timeout before doing so. Also, hide the output of taskkill'ing mspdbsrv so that the first message isn't '''ERROR: The process "..." not found.'''. R=maruel@chromium.org BUG=323300 Review URL: https://codereview.chromium.org/146583012 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@251084 0039d316-1c4b-4281-b951-d872f2087c98
-
zty@chromium.org authored
BUG=336460 Review URL: https://codereview.chromium.org/150003010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250904 0039d316-1c4b-4281-b951-d872f2087c98
-
mmoss@chromium.org authored
> Re-reland r245404 ("If the destination directory doesn't contain the desired repo, delete it") > > BUG= > > Review URL: https://codereview.chromium.org/133073015 TBR=borenet@google.com Review URL: https://codereview.chromium.org/146583013 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250878 0039d316-1c4b-4281-b951-d872f2087c98
-
mmoss@chromium.org authored
> gclient: Use the correct bot hostnames to enable experimental deletion behavior > > BUG=skia:1638 > > Review URL: https://codereview.chromium.org/132313017 TBR=borenet@google.com Review URL: https://codereview.chromium.org/143183008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250877 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 Feb, 2014 2 commits
-
-
wtc@chromium.org authored
This typo was introduced in https://codereview.chromium.org/106403003. Rename options.dryrun to options.dry_run. R=agable@chromium.org,dpranke@chromium.org BUG=none TEST=none Review URL: https://codereview.chromium.org/138623008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250802 0039d316-1c4b-4281-b951-d872f2087c98
-
mmoss@chromium.org authored
To force revert to the old git, and uninstall the new one, set: DEPOT_TOOLS_GIT_1852=0 BUG=341967 R=maruel@chromium.org Review URL: https://codereview.chromium.org/156713005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250622 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Feb, 2014 1 commit
-
-
hinoka@google.com authored
BUG=339168 Review URL: https://codereview.chromium.org/140553007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@250547 0039d316-1c4b-4281-b951-d872f2087c98
-