- 19 Dec, 2018 2 commits
-
-
Takuto Ikuta authored
I added document explaining ninjalog collection. This document explains what type of data is collected and how the data will be used. Bug: 900161, b/120645342 Change-Id: If47517aaa7a5510e4a634b5ccc0e4127d014dcb9 Reviewed-on: https://chromium-review.googlesource.com/c/1381912 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
-
Bruce Dawson authored
When non-Googlers try to build Chromium for the first time they get an error saying: Please follow the instructions at https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_instructions.md However those instructions are quite long and it's not obvious to some users which part of the instructions they have forgotten. The most likely is that they didn't set DEPOT_TOOLS_WIN_TOOLCHAIN=0, so this changes the error message to suggest that directly. Auto-detecting the correct state for DEPOT_TOOLS_WIN_TOOLCHAIN was tried in crrev.com/c/1374833 but deemed impractical. Bug: 907300, angleproject:2712 Change-Id: I45a9f59babe90bbe2137d49c555884d7bbbcf170 Reviewed-on: https://chromium-review.googlesource.com/c/1382942Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
- 18 Dec, 2018 7 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM+CQ. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/3f3879c37865ac94e52e8d91a70399ca37ae4fb8 Make aggregated InfraFailures surface as exceptions. (joshuaseaton@google.com) R=iannucci@chromium.org, martiniss@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I1ce8de0ea0660d734f553d18a051ba0552d263e5 Reviewed-on: https://chromium-review.googlesource.com/c/1382977 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
-
Mike Frysinger authored
This syntax seems to be invalid, so remove it to unblock others. Bug: 900461 No-Presubmit: True Change-Id: I16569b8f8236a14b6dc879c973e4925a99649ac2 Reviewed-on: https://chromium-review.googlesource.com/c/1382975 Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
Mike Frysinger authored
Bug: 900461 Change-Id: I74bf2a048f766d95a8d11d74f5a97e67898299fe Reviewed-on: https://chromium-review.googlesource.com/c/1380591Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org>
-
Vadim Shtayura authored
This picks up the following changes: https://chromium.googlesource.com/infra/luci/luci-go/+log/d052999e151b..20acb618582d/cipd R=tandrii@chromium.org, iannucci@chromium.org BUG=915278 Change-Id: Ibaa9d20456dcb513d9bbdaf0bca970390254ee67 Reviewed-on: https://chromium-review.googlesource.com/c/1381773Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
Don Garrett authored
R=-owners Bug: None Change-Id: I9ff818b65b1c9a2a3a19f65932ffac4957dab0cc Reviewed-on: https://chromium-review.googlesource.com/c/1382934 Auto-Submit: Don Garrett <dgarrett@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Don Garrett <dgarrett@chromium.org>
-
Takuto Ikuta authored
This function extracts build target from command line. Bug: 900161 Change-Id: I38d37689a42437de76933ea3c9afb9def5a1253c Reviewed-on: https://chromium-review.googlesource.com/c/1381911 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/dc70d2e73b72e43934db0f7dd816a061aa6f428d Add post_process functions for checking the status of a step. (gbeaty@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I86b8b38db5dbbdec46efeeb929c937e193e489ea Reviewed-on: https://chromium-review.googlesource.com/c/1381274Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
- 17 Dec, 2018 3 commits
-
-
Takuto Ikuta authored
Use unittest module instead of doctest. Bug: 900161 Change-Id: I2e8265afb66345814c4c4b8e94618171b7aaaaf3 Reviewed-on: https://chromium-review.googlesource.com/c/1379441 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
-
Edward Lemur authored
Tbr: tandrii@chromium.org Bug: 914712 Change-Id: Iff8aecff346692ef36fd653f226b48270fefa304 Reviewed-on: https://chromium-review.googlesource.com/c/1380972Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lemur authored
Bug: 914712 Change-Id: I13db57af519bb254389bc6bd1f1f81ad1d497e42 Reviewed-on: https://chromium-review.googlesource.com/c/1377295 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
-
- 15 Dec, 2018 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/0d040fde89eac5b4762eab44a97e9556de6cffb8 [path] Add additional info to the assert in mkdtemp/mkstemp. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Iedb912a8205792211f10f221518b94a53bc9fb34 Reviewed-on: https://chromium-review.googlesource.com/c/1378962Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/d3f6d71aea0086eb34ae3cbbe7fbfd729d16b29f Fix README generation from a66cf68621e2c514b7684e5404cd700a700f1aba (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I542f25dbea97c7a25b714ed41d005a26b6234f9e Reviewed-on: https://chromium-review.googlesource.com/c/1378958Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
- 14 Dec, 2018 5 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/a66cf68621e2c514b7684e5404cd700a700f1aba [swarming] Create minimal swarming module. (joshuaseaton@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ieeda3bddd24b2e839ce93a88bcfae45f6251e66e Reviewed-on: https://chromium-review.googlesource.com/c/1378956Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/a42e8c4de53e8dd05042bac03f24a86e87abe4a3 [depend_on] Remove "depend_on" functionality. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I7b45506ea2a466d1773323a1d9e04471a10f3058 Reviewed-on: https://chromium-review.googlesource.com/c/1378955Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/f1230fc4dd13e325a540bd70afba35674e605100 [stream_logdog] Remove old unused annotations.proto support. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Id20b679d186819a4452271e4aa338892753fee00 Reviewed-on: https://chromium-review.googlesource.com/c/1378953Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/0cbbe4a2a8b0a309f08b5a5459292885e8e1ce07 [manual_roll] Add new manual_roll command. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I7997ef3d51a412830ebbb97962445c90d7040c25 Reviewed-on: https://chromium-review.googlesource.com/c/1378926Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/4e2a492ca556e8dc991b52f0a3b683619af809a4 [protobuf] Update to protobuf 3.6.0. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I2387dc2437bd0576850b73c20ef423cbed7e3fa5 Reviewed-on: https://chromium-review.googlesource.com/c/1378925Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
- 13 Dec, 2018 8 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/17552e0276fe41580387b0d2a720298ed497010a Reland "Remove old run code" (martiniss@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ie183466497539d00c1272d4ef7429cad289873ab Reviewed-on: https://chromium-review.googlesource.com/c/1377269Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
Bryce Thomas authored
Commit a185e2e3 removed the Rietveld code review implementation, albeit hasn't expunged all references to Rietveld. This leads to an assertion error when running |git cl format| on a non-Gerrit change. There appears to have been a recent attempt to articulate this error better in a185e2e3, albeit not fix the underlying issue. This change addresses the immediate issue by defaulting the code review implementation to Gerrit rather than Reitveld. R=joenotcharles@google.com, tandrii@chromium.org Bug: 914150 Change-Id: I64d33e5a172cc43339ec417f7f0a7820e0337772 Reviewed-on: https://chromium-review.googlesource.com/c/1372928Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Bryce Thomas <bryct@amazon.com>
-
Robert Iannucci authored
This removes the '-mode' flag from the emitted job descriptions. TBR=nodir@chromium.org Bug: 914196,914926 Change-Id: I94ab67f0969b198164fa3fc3ef64a649dcf941bd Reviewed-on: https://chromium-review.googlesource.com/c/1376657Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
Sergiy Belozorov authored
Change-Id: I00f1d6716ca5ece647d7ac15471ded25c1f164b2 Reviewed-on: https://chromium-review.googlesource.com/c/1370125Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org>
-
Clemens Hammacher authored
Include verbose output of `git map-branches` to make visible what the state of the different branches is. R=iannucci@chromium.org Change-Id: I4af03ef15b39e4ba84a41c01d1ec801e7bb4bbd6 Reviewed-on: https://chromium-review.googlesource.com/c/1360711Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
-
Clemens Hammacher authored
Document the -v and --no-color options. R=iannucci@chromium.org Change-Id: I07624403f591b23cc5701aa8201124fdfdb65781 Reviewed-on: https://chromium-review.googlesource.com/c/1360710Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM+CQ. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/5e53d73e9bcec42830e10b835bc328eb75c9423f [path] Use 'cleanup' dir in mkdtemp and mkstemp (sergeyberezin@google.com) R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9a721c027e369ecd797e9fb1bfe707dfba15ed62 Reviewed-on: https://chromium-review.googlesource.com/c/1374435Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org> Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
Joey Scarr authored
Bug: 902400 Change-Id: I816dc06bfaabffac549d25ced60ddc61499fc38d Reviewed-on: https://chromium-review.googlesource.com/c/1343628 Commit-Queue: Joey Scarr <jsca@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
-
- 12 Dec, 2018 2 commits
-
-
Mrunal Kapade authored
This reverts commit dd0c341b. As it seems to be breaking the "git cl upload". Reverting the change as per suggestion from original author. BUG=891505 Change-Id: Ica3f9aaa78d33cee6935ffcff789417ce098905e Reviewed-on: https://chromium-review.googlesource.com/c/1260043Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Mrunal Kapade <mrunal.kapade@intel.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/84b31ee25882e7f1b190dbed036fa6c3da0b53fc [isolated] Update default properties (joshuaseaton@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: If746e956beb91814a4f228b0fdedab2a73115239 Reviewed-on: https://chromium-review.googlesource.com/c/1372929Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
- 11 Dec, 2018 2 commits
-
-
Jonas Termansen authored
gsutil.py is cumbersome to use on Windows, unlike on Linux and Mac. This change adds a batch file like the ones for gclient and other tools. Bug: https://github.com/dart-lang/sdk/issues/35367 Change-Id: Ib33dc27573de5485ae93b525002f5fbcb3a5f4d1 Reviewed-on: https://chromium-review.googlesource.com/c/1370124 Commit-Queue: Jonas Termansen <sortie@google.com> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
-
Bruce Dawson authored
Recent versions of the 10.0.17763 SDK have rearranged the redist directory. This change adjusts the packaging so that we can package the SDK with and without this change. The script looks first in the versioned directory and if that doesn't exist then it falls back to the unversioned directory. See also http://crrev.com/c/1371017 for the build\vs_toolchain.py version of this change. Change-Id: I835bf45f613a0aebb56eb1e8e63e6ffa5252edf0 Reviewed-on: https://chromium-review.googlesource.com/c/1370609Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
- 10 Dec, 2018 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/95a3eec6ae5226c402ca15514f2ccc39d5b367c9 [random] Add new "random" module. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Iae9b444ca39b1bb0622b2b43a9c8a218c8aef7eb Reviewed-on: https://chromium-review.googlesource.com/c/1370684Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
John Budorick authored
Bug: 912391 Change-Id: I8302918397977e03fe7c10179f854ce385ad92e4 Reviewed-on: https://chromium-review.googlesource.com/c/1368884Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Nodir Turakulov <nodir@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
- 08 Dec, 2018 2 commits
-
-
Robert Iannucci authored
This commit changes the layout of recipe_engine a bit which breaks the autoroller. R=jchinlee@chromium.org, martiniss@chromium.org, tandrii@chromium.org Bug: 913102 Change-Id: I207e6e5a13980e3819c2b4deb3c01c38c28ed876 Recipe-Manual-Change: infra Recipe-Manual-Change: build Recipe-Manual-Change: skia Recipe-Manual-Change: skiabuildbot Recipe-Manual-Change: build_limited_scripts_slave Recipe-Manual-Change: release_scripts Reviewed-on: https://chromium-review.googlesource.com/c/1368410 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Auto-Submit: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
-
Elliott Friedman authored
┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┓ ┃ METRICS COLLECTION IS TAKING PLACE ┃ ┃ ┃ ┃ To suppress this message opt in or out using: ┃ ┃ $ gclient metrics [--opt-in] [--opt-out] ┃ ┃ For more information please see metrics.README.md ┃ ┃ in your depot_tools checkout or visit ┃ ┃ https://goo.gl/yNpRDV. ┃ ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛ R=ehmaldonado, mmoss, tandrii Change-Id: Iab3a5a18aa57e603c8f253f3fcbbf7f96727e003 Reviewed-on: https://chromium-review.googlesource.com/c/1368409Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Elliott Friedman <friedman@chromium.org>
-
- 07 Dec, 2018 1 commit
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/7bf15aaea60841beb1973a1b0ec19f3be3ec53b2 [remote] Remove remote subcommand. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ie1f3ce3988abe2292f2cb9b1c42c0ad2b4746c2c Reviewed-on: https://chromium-review.googlesource.com/c/1368924Reviewed-by: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
- 06 Dec, 2018 2 commits
-
-
Takuto Ikuta authored
TBR=dpranke@chromium.org Bug: 900161 Change-Id: I5e481f04f281fddb08724fd27630a3fb926c5d1b Reviewed-on: https://chromium-review.googlesource.com/c/1365196Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
-
Vadim Shtayura authored
This picks up the following changes: https://chromium.googlesource.com/infra/luci/luci-go/+log/233800ef6928..d052999e151b/cipd R=iannucci@google.com, tandrii@google.com BUG=911229 Change-Id: I3dbe7fc2db1cae876d0acdd3f8e4299e96af9d37 Reviewed-on: https://chromium-review.googlesource.com/c/1363879Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
- 05 Dec, 2018 2 commits
-
-
John Budorick authored
This is a speculative fix for subprocess being unable to find string-escape later in execution; the theory being that something (unclear what) is interfering w/ codecs' lookup logic and that calling lookup earlier would allow string-escape to be cached before any such interference. See crbug.com/912292#c2 for more. Bug: 912292 Change-Id: I0abdd394253c9a4984db7c6c81d044087edc68fd Reviewed-on: https://chromium-review.googlesource.com/c/1363753Reviewed-by: Robbie Iannucci <iannucci@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
Clemens Hammacher authored
This reverts commit ba83229a. Reason for revert: After mail discussion we came to the conclusion that the old behavior makes more sense. Original change's description: > Fix semantics of git new-branch --upstream > > Currently, the "--upstream A" option for new-branch behaves totally > different than "--upstream_current". While "--upstream A" checks out > branch A and then creates a new branch which tracks A, > "--upstream_current" creates a new branch for the current HEAD and sets > the upstream to the previously checked out branch. > > As the documentation does not mention that any of the options changes > the currently-checked-out commit (HEAD), this CL changes the semantics > of "git new-branch --upstream A B" to be identical to "git checkout -b B > && git branch --set-upstream-to A". > > It also slightly extends the documentation to mention that in any case > the new branch is based on HEAD. > > R=iannucci@chromium.org > > Change-Id: Ic335d2caf27cb6afca1b8bc5a008424c0e880fca > Reviewed-on: https://chromium-review.googlesource.com/c/1350748 > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Auto-Submit: Clemens Hammacher <clemensh@chromium.org> TBR=iannucci@chromium.org,tandrii@chromium.org,clemensh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I7463935af172f0801c7da94d2de106a02fc4c42e Reviewed-on: https://chromium-review.googlesource.com/c/1362972Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
-