- 20 Aug, 2019 3 commits
-
-
Mike Frysinger authored
This allows people to pin a specific version of pylint when running it. The default behavior is unchanged: we run pylint-1.5.6 still as we've created a vpython wheel in cipd for it. But for projects that want to move to a newer version, they can pick any of the new 1.x wrappers. Having the full set of versions here allows projects to incrementally move to newer versions as the lint delta between 1.5 & 1.6 tends to be much smaller than 1.5 & 1.9. We don't include support for the newer 2.x series as those only support Python 3 which the codebase isn't ready for. Bug: 866772 Test: `./pylint ...` still works & shows pylint-1.5 Test: `./pylint-1.5 ...` runs the v1.5 version Test: `./pylint-1.8 ...` runs the v1.8 version Change-Id: I7c47187493564db81e3eb28c6dbd09e6309ead46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1752507Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org>
-
Raul Tambre authored
Windows 10 has support for native ANSI control codes. This means we don't have to wrap stdout/stderr with Colorama, which uses old CMD APIs to handle these sequences. This change inadvertently also works around an issue on Python 3 where Colorama errors when bytes are output by gclient_utils.CheckCallAndFilter due to not wrapping sys.stdout.buffer. Bug: 942522 Change-Id: Ic7dde620b01bd94eb50de353bfc0276cad045a45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1735566 Commit-Queue: Raul Tambre <raul@tambre.ee> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee>
-
Edward Lemur authored
Change-Id: Id24a1dc88ed9766b15a5145cdb29145d0c436514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1759277 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
- 19 Aug, 2019 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/2822336a446f5f6fc68e50e1e5c5419548979030 [led] Create LedTestApi (olivernewman@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I0afc6492e9a84eac1e63461d27dfd7d415712451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1760144Reviewed-by:
Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/560ef89d75ade5e9f6cdb8bc75991239a4c1b0dd [swarming] Support unicode arguments in all functions (garymm@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I805743842c7109a437867ae94c96dde1ea44c914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1760538Reviewed-by:
-
- 16 Aug, 2019 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM+CQ. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/74065d30431d49f380cba90ac7bb751df5aab235 [recipe_api] Update AggregatedStepFailure.contains_infra_failure when adding infra failure. (ihuh@google.com) R=recipe-roller@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I0b40f8c3047407ece2621b0e3fdbf29c32d827ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1757447 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
-
John Budorick authored
Bug: 803846, 856278 Change-Id: I60d28dc5d1cc2d697f5faa559d704bc80eec3114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1754634Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
- 15 Aug, 2019 8 commits
-
-
Edward Lemur authored
Bug: 984182 Change-Id: Iaacb10dfc5ce7c624ac52edb76a9a74c6e2fd1cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1757122 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/54c9a286d41d9f711837dd4c002fc7fbc9bfde83 [buildbucket] Fix timeout in collect_builds (nodir@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9bd486fed5d6b5492a34cec20a1f04f55101de05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1757116Reviewed-by:
-
Edward Lemur authored
Bug: 984182 Change-Id: I9fd81f758c16099b3cb021035a57c35fe363c8ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1755302Reviewed-by:
-
Edward Lemur authored
This will make it easier to get rid of super_mox.py Bug: 984182 Change-Id: Ic6c9646b8a96ef05ac59293a62f68ad7db7dc2d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1754977 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
-
Edward Lemur authored
Bug: 984182 Change-Id: Ie29f06c817824c009656cf81d93a605abebe948a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1754976Reviewed-by:
-
Edward Lemur authored
Bug: 984182 Change-Id: Idc38678acbfca9cc6b89d77db28fdc24784f2b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1753742 Commit-Queue: Edward Lemur <ehmaldonado@google.com> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/5ad4574eb507b14945b29450e6aa378fac0ea120 [analyze] Improve module path detection logic. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I67993ee25f91a007dc64f4f13653ddaab20090ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1756293Reviewed-by:
-
Daniel Bratell authored
Not everyone builds Chromium for arm so then it's practical to be able to use a smaller SDK package without arm support included. This also removes some samples that should not be needed. Recipe-Nontrivial-Roll: chromiumos Change-Id: I10f64d8907600fe79d3051083d100a7562d3a797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1752202 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org>
-
- 14 Aug, 2019 7 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/9739dd145b64ef8a9e33d0a4a5e25e8c516d83d4 Make set_worse_status not crash on None status (engeg@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I5731702cbe41cde465da4411e99405d4abdc25a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1754637Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/dbc1acf1456ba2041808ab5ac96d2bbe5ebdbf49 Improve the exception for missing config. (gbeaty@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I6403bd33f203a49d29aa39504aaf7fd17e73288c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1754635Reviewed-by:
-
Mike Frysinger authored
We can have --no-squash update the --squash state directly so we don't have to constantly check two different knobs. This means opts.squash is now a tristate: None means load config settings while True/False means the user has specified a command line option. This also means we don't have to detect multiple --squash/--no-squash flags as the argparse module will take care of coalescing. Bug: 993518 Test: `git cl upload` uses my ~/.gitconfig Test: `git cl upload --squash` squashes Test: `git cl upload --no-squash` doesn't squash Change-Id: Ib2577db11d3af03c93cb47d8b78b341213720a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1754234Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org>
-
George Engelbrecht authored
In support of the signing rework we're going to want to have the signers keep track of the calculated hash to ensure that we don't have a TOCTOU type issue. This commit adds the stat command to the gsutil module so that we can ask gs a files hash. Change-Id: Ib35d1541292a18fbfc26fab50f594c682ba4109d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1754262Reviewed-by:
-
Nodir Turakulov authored
R=iannucci@chromium.org Bug: iannucci@chromium.org Change-Id: I54feea6646d7f983795cc67e79008587ce3a74f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1754235 Commit-Queue: Nodir Turakulov <nodir@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Auto-Submit: Nodir Turakulov <nodir@chromium.org> Reviewed-by:
-
John Budorick authored
Mirroring crrev.com/c/1717663. bot_update runs that take more than an hour are typically hung in irrecoverable ways. Recipe-Nontrivial-Roll: build Change-Id: Ic0afc48db7e0ac3464888e7715621a04f55443ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1754263Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org>
-
John Budorick authored
Useful in cases like the green presubmit runs on crrev.com/i/1434617/2 Bug: 925774 Change-Id: I37ce2be843d76ace0615cd3313e5c8421504a1ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1687122Reviewed-by:
-
- 13 Aug, 2019 6 commits
-
-
Edward Lemur authored
Bug: 984182 Change-Id: I6165cf889ebd4e074f1f72b29e8d1216337fb04f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1752480 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
-
Edward Lemur authored
Bug: 984182 Change-Id: Ib9c5d2762546f29eaca5eae89b0428431067da4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1753029 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/83800d1aff85a6bfa6b5202485c8a26b44701ff5 Regenerate README from 3fd5281 (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I924af5959cae02f189dcc34b99b166a18739eda1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1752690Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM+CQ. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/e7fec5ccb9e70bf17b7878e63052a874afa06856 Change is_luci default to True. (mmoss@google.com) R=recipe-roller@chromium.org, tandrii@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9eb8913a8f65b8f107e5856c46aceda10e14c00c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1752476 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
Michael Moss authored
This is needed to change the api.runtime default to is_luci=True in https://crrev.com/c/1750109. R=iannucci@google.com, tandrii@google.com Bug: 993137 Change-Id: Id52e0a12b9121d590fcb61e275eda8ca903372d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1751815Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/6043003d0d744b4c03c880d3d260a4b5c52430b1 Rename run_build references to luciexe. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I5883f5aed52d1314bc3dacdc5feaad51005d87ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1751808Reviewed-by:
-
- 12 Aug, 2019 7 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/3fd5281a1aa2b954fad2303857e8abf9a037c9e2 [led] Accept and expose isolate/cipd info (olivernewman@google.com) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I1323814b2e10b606d163689bc0b695750971fc03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1749214Reviewed-by:
-
Edward Lesmes authored
This reverts commit d6186f99. Reason for revert: <INSERT REASONING HERE> Original change's description: > depot_tools: Run Python scripts using vpython (Part 1) > > Tbr: iannucci@chromium.org > Bug: 984182 > Change-Id: If36722e190d305f89d63dce91d0a600ddc34ebe3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1748589 > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> TBR=iannucci@chromium.org,ehmaldonado@chromium.org Change-Id: I7686985852608d0703bcbbab137df1ce82b29723 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 984182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1749853Reviewed-by:
-
Edward Lesmes authored
This reverts commit 3c814957. Reason for revert: <INSERT REASONING HERE> Original change's description: > depot_tools: Run Python scripts using vpython (Part 2) > > Tbr: iannucci@chromium.org > Bug: 984182 > Change-Id: I2e8469f8ee0acd6a54109697d5a6b76faf24fa42 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1748590 > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> TBR=iannucci@chromium.org,ehmaldonado@chromium.org Change-Id: Ic683543a04b45f733b48d6c43453fc8dff511d09 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 984182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1749852Reviewed-by:
-
Edward Lesmes authored
This reverts commit 1222ecd5. Reason for revert: recipes should never run any of the shims which fetch cipd packages in depot_tools Original change's description: > depot_tools: Include vpython in cipd bundle. > > Tbr: iannucci@chromium.org > Bug: 984182 > Change-Id: I01b0e12179d2314c48c00d74550ceea1e32b355d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1749844 > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> TBR=iannucci@chromium.org,ehmaldonado@chromium.org Change-Id: Iadf11b480c03e0bd57ba2c4210d39bdc6cb27b3d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 984182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1749851Reviewed-by:
-
Edward Lemur authored
Tbr: iannucci@chromium.org Bug: 984182 Change-Id: I01b0e12179d2314c48c00d74550ceea1e32b355d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1749844Reviewed-by:
-
Edward Lemur authored
Tbr: iannucci@chromium.org Bug: 984182 Change-Id: I2e8469f8ee0acd6a54109697d5a6b76faf24fa42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1748590Reviewed-by:
-
Edward Lemur authored
Tbr: iannucci@chromium.org Bug: 984182 Change-Id: If36722e190d305f89d63dce91d0a600ddc34ebe3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1748589Reviewed-by:
-
- 09 Aug, 2019 5 commits
-
-
Edward Lemur authored
Also replace mox with mock and move the test script to a different file. Bug: 984182 Change-Id: I9005a523c2abd82c38a7c61501c7cbfd4201a5b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1745412Reviewed-by:
-
Yaakov Shaul authored
BUG=chromium:973247 Change-Id: Ibbc10cbefb85b5c9ab7a8092d1ac8d4a16af9e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1745892Reviewed-by:
-
Yaakov Shaul authored
BUG=chromium:973247 Change-Id: Ia0c0625446845ff1c590e0ae455b099ecab958ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1746747 Commit-Queue: Yaakov Shaul <yshaul@chromium.org> Reviewed-by:
-
Yaakov Shaul authored
BUG=chromium:973247 Change-Id: I8be6386fc3ab9ce6e8d9558862dfd0a7c74a5e6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1743018 Commit-Queue: Yaakov Shaul <yshaul@chromium.org> Reviewed-by:
-
Edward Lemur authored
Remove support for unused features: - timeout - nag_timer and nag_max - Popen start property - callback functions for stdout and stderr Bug: 984182 Change-Id: Ib2327119508a89d1e60f4a42c64b78d050f48092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1745406Reviewed-by:
-
