Skip to content

C
Chromium_Depot_tools
Switch branch/tag
  1. 22 Mar, 2018 3 commits
    • Robert Iannucci's avatar
      [presubmit_support] Prevent depot_tools' virtualenv from leaking into other repos. · 5025893c
      Robert Iannucci authored 
      Currently in LUCI `git cl` is invoked on chromium_presubmit using vpython. This
means that it operates under the depot_tools .vpython environment (which is
blank).

Some features in presubmit_support allow invocation of python subprocesses, and
previously they would use `sys.executable` (especially on windows, but
occasionally on non-windows as well).

In non-vpython environments, this just picks up the system python and whatever
modules happen to be installed there. Some python unittests work around this on
non-windows systems by having a shebang line which explicitly invokes vpython.

This CL changes presubmit_support so that invocations of 'python', or executions
of '.py' scripts will always end up invoking vpython. In the best case, this will
pick up the invoked scripts' vpython environment. In the worst case, this will
invoke the script under an empty vpython environment (aka "stock python").

R=dpranke@chromium.org, jbudorick@chromium.org, tandrii@chromium.org, tikuta@chromium.org

Bug: 821669
Change-Id: I5d2d5dfd0364022d56833c2c8af4983553a29c7a
Reviewed-on: https://chromium-review.googlesource.com/961865Reviewed-by: 's avatarDirk Pranke <dpranke@chromium.org>
Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
      5025893c
    • Edward Lesmes's avatar
      gclient sync: Add support to apply gerrit refs. · c621b21a
      Edward Lesmes authored 
      Mimics bot_update's functionality to apply gerrit refs in gclient
via --gerrit-ref flags.
When the patch fails to apply, gclient sync will return exit code 2.

The idea is to move this logic from bot_update to gclient sync to
deal when patches for projects like ANGLE are tried on Chromium bots.
This way the patch is applied before recursively parsing and syncing
ANGLE’s DEPS.chromium file, which doesn't currently happen.

Bug: 643346

Change-Id: I7e2018b3c393a5ac9852b8c3611f906977eeeb18
Reviewed-on: https://chromium-review.googlesource.com/961605Reviewed-by: 's avatarAaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
      c621b21a
    • Lei Zhang's avatar
      Revert "Add debugging info when gclient deletes an old DEPS entry." · 869a2857
      Lei Zhang authored 
      This reverts commit 33bf4953.

Reason for revert: Done debugging.

Original change's description:
> Add debugging info when gclient deletes an old DEPS entry.
> 
> To help figure out why it decided to do so.
> 
> BUG=823586
> 
> Change-Id: I93d7c9f7af6145ee0ebd9f5ad4483f27925e84d6
> Reviewed-on: https://chromium-review.googlesource.com/970082
> Commit-Queue: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Aaron Gable <agable@chromium.org>

TBR=thestig@chromium.org,agable@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 823586
Change-Id: I476cbe423b849582f8684426653f0c08062e89e9
Reviewed-on: https://chromium-review.googlesource.com/974458Reviewed-by: 's avatarLei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
      869a2857
  3. 21 Mar, 2018 5 commits
  5. 20 Mar, 2018 4 commits
  7. 19 Mar, 2018 2 commits
  9. 16 Mar, 2018 1 commit
  11. 14 Mar, 2018 4 commits
  13. 13 Mar, 2018 2 commits
  15. 12 Mar, 2018 2 commits
  17. 08 Mar, 2018 1 commit
  19. 07 Mar, 2018 2 commits
  21. 06 Mar, 2018 4 commits
  23. 03 Mar, 2018 1 commit
  25. 28 Feb, 2018 1 commit
  27. 27 Feb, 2018 3 commits
  29. 26 Feb, 2018 1 commit
  31. 23 Feb, 2018 1 commit
  33. 22 Feb, 2018 3 commits