- 10 Mar, 2022 3 commits
-
-
Louis Romero authored
Prior to this CL, we have: ``` Running Python 2 presubmit upload checks ... Python 2 presubmit checks passed. Running Python 3 presubmit upload checks ... Presubmit checks took 10.2s to calculate. Python 3 presubmit checks passed. ios/chrome/browser/... | 20 +++++++++----------- ... ``` The first two checks are harder to parse with the newlines. This CL removes them: ``` Running Python 2 presubmit upload checks ... Python 2 presubmit checks passed. Running Python 3 presubmit upload checks ... Presubmit checks took 10.2s to calculate. Python 3 presubmit checks passed. ios/chrome/browser/... | 20 +++++++++----------- ... ``` Change-Id: Iaf7ac4b203c401f60d74884fd9bdd3ba4ee12c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3512873Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Louis Romero <lpromero@chromium.org>
-
Gavin Mak authored
This reverts commit 8edc960e. Reason for revert: potentially breaking chromeos builders Original change's description: > Update gsutil to use gsutil version 4.68 > > We can't yet upgrade to version 5.x since it's only py3 compatbile and > some builders still rely on running gsutil with py2. > > R=gavinmak@google.com > > Bug: 1184108 > Change-Id: I002cc3625a2184ab42383b88a014c0631d1a33ee > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3508516 > Reviewed-by: Gavin Mak <gavinmak@google.com> > Commit-Queue: Josip Sokcevic <sokcevic@google.com> Bug: 1184108 Change-Id: I40ce645ebd928c63116012353c632026c787b154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3514508 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Gavin Mak <gavinmak@google.com>
-
Yulan Lin authored
Bug:1094754 Change-Id: Ib644df8f2979f7059925d42f183c3df0b55d6b43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3500693Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Yulan Lin <yulanlin@google.com>
-
- 09 Mar, 2022 2 commits
-
-
Chris Blume authored
Currently, GetVSPath() is called twice. The result if that call is used locally in both situations. This commit makes only one call, passing the result to where it is needed. Change-Id: I186bd7f0387091ad16c2791de99d1de8a89f266c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3510528 Auto-Submit: Chris Blume <cblume@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
Darshan Sen authored
I ran into this error coming from the gclient.py script when I was trying to run it on a Cygwin setup on Windows: ... ________ running 'vpython.bat -vpython-spec src/.vpython -vpython-tool install' in '/c/Users/circleci/project' Hook 'vpython.bat -vpython-spec src/.vpython -vpython-tool install' took 34.10 secs ________ running 'vpython3 -vpython-spec src/.vpython3 -vpython-tool install' in '/c/Users/circleci/project' [E2022-02-17T07:07:56.374746Z 10204 0 annotate.go:273] goroutine 1: #0 go.chromium.org/luci/vpython/venv/config.go:309 - venv.(*Config).resolvePythonInterpreter() reason: none of [C:/Users/circleci/project/vendor/depot_tools/bootstrap-2@3_8_10_chromium_23_binpython3bin/python3] matched specification 3.8.0 #1 go.chromium.org/luci/vpython/venv/config.go:153 - venv.(*Config).resolveRuntime() reason: failed to resolve system Python interpreter #2 go.chromium.org/luci/vpython/venv/venv.go:143 - venv.With() reason: failed to resolve python runtime #3 go.chromium.org/luci/vpython/application/subcommand_install.go:61 - application.(*installCommandRun).Run.func1() reason: failed to setup the environment ... Similar to the Windows-only "vpython" -> "vpython.bat" modification, I added the necessary code to do it for vpython3 too, i.e., "vpython3" -> "vpython3.bat", and it fixed the problem for me. Signed-off-by:
Darshan Sen <raisinten@gmail.com> Change-Id: Iac167ffe61b04a2836b03e620b98ee97b56965e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3513473Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
- 08 Mar, 2022 3 commits
-
-
Josip Sokcevic authored
We can't yet upgrade to version 5.x since it's only py3 compatbile and some builders still rely on running gsutil with py2. R=gavinmak@google.com Bug: 1184108 Change-Id: I002cc3625a2184ab42383b88a014c0631d1a33ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3508516Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
Brian Ryner authored
Change-Id: I3fa03e91d64f8caa2ed0c339cc8245ba0e71ae2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3505444Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Brian Ryner <bryner@google.com>
-
Fumitoshi Ukai authored
Bug: b/219613977 Change-Id: I9ea3c999ea783eebba149bfdd047a5e2b063570c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3507574Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@google.com>
-
- 05 Mar, 2022 1 commit
-
-
Bruce Dawson authored
This reverts commit 36d41cef. Reason for revert: Script references VS_VERSION variable that was renamed in the prior change, so it doesn't work. Original change's description: > Support multiple VS installations > > Currently, package_from_installed.py assumes only one version of VS is > installed. It takes the path of the first installation. > > This could be incorrect in several ways: > - Maybe both 2017 and 2019 (the supported versions) are installed and > although the user specified using 2019, the 2017 path comes first. > - Maybe 2019 and 2022 are installed, and the 2022 path is used even > though it isn't supported. > > This CL fixes that issue by parsing the vswhere.exe output to confirm > the VS version matches what the user specified, using its corresponding > path. > > Change-Id: I2029a4f7126d0a45b5370ad58ab257df55571b3b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3458722 > Reviewed-by: Gavin Mak <gavinmak@google.com> > Reviewed-by: Chris Blume <cblume@chromium.org> > Commit-Queue: Chris Blume <cblume@chromium.org> > Auto-Submit: Chris Blume <cblume@chromium.org> Change-Id: I3d9147a7786f7f54f861087d16967b75d4afe2c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3504193 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
- 04 Mar, 2022 6 commits
-
-
Garrett Beaty authored
This reverts commit d1d7b0a4. Reason for revert: This seems likely the cause of infra failures for perf builders. Original change's description: > Reland "Update gsutil to use gsutil version 5.6, python3" > > This is a reland of commit c0af61c8 > > Original change's description: > > Update gsutil to use gsutil version 5.6, python3 > > > > R=gavinmak@google.com > > > > Bug: 1184108 > > Change-Id: I933c07132006b731a97153080ebe86ed756fbdb2 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3497998 > > Reviewed-by: Gavin Mak <gavinmak@google.com> > > Commit-Queue: Josip Sokcevic <sokcevic@google.com> > > Bug: 1184108 > Change-Id: I72c5b967f52e8b4531c238b20444596c549a5726 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3502172 > Reviewed-by: Gavin Mak <gavinmak@google.com> > Commit-Queue: Josip Sokcevic <sokcevic@google.com> Bug: 1184108 Change-Id: Iad314a3b6147f460e2f301481b03c5d3d7d601db No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3503959 Auto-Submit: Garrett Beaty <gbeaty@google.com> Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
Xinan Lin authored
Thus downstream recipes could run "train" without explicit mock data everywhere. BUG=1293270 TEST=train Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Change-Id: I09f6a27097f400dabd990f6ef61e301a75a39691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3502768Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Xinan Lin <linxinan@chromium.org>
-
Josip Sokcevic authored
This is a reland of commit c0af61c8 Original change's description: > Update gsutil to use gsutil version 5.6, python3 > > R=gavinmak@google.com > > Bug: 1184108 > Change-Id: I933c07132006b731a97153080ebe86ed756fbdb2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3497998 > Reviewed-by: Gavin Mak <gavinmak@google.com> > Commit-Queue: Josip Sokcevic <sokcevic@google.com> Bug: 1184108 Change-Id: I72c5b967f52e8b4531c238b20444596c549a5726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3502172Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
Josip Sokcevic authored
R=gavinmak@google.com Change-Id: I4bee5d9e4d5857d359d9f0663a4fbeea1194f838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3502623Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8820652096618423585 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/52ef3060ed5a4f75ef6e4056fb36aaf7274bc291 52ef306 (iannucci@chromium.org) [recipe_engine] Implicit CANCELED final build status. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I5f2da0be6bf371cdd46ba8ecc42e75b930056368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3500227 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8820658387597657393 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/f588cc00b94738c55b9311da1b41cef2f3842375 f588cc0 (chromium-autoroll@skia-public.iam.gserviceaccount.com) Roll CAS Client from 595e0f7a2869 to cb424e70e751 More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: Ieb77a38dd02db7554c40c42786f6b9fec7738fa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3500226 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 03 Mar, 2022 2 commits
-
-
Aravind Vasudevan authored
Manual Recipe Change: https://crrev.com/c/3460620 Recipe-Manual-Change: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Bug: 1289280 Change-Id: Ibdadf1eee3d2d5f385f520340a4f4bd8844f7bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3440919Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
-
Chan Li authored
Bug: 1099143, 1302087 Change-Id: I7f927b9cb880774c8ec493f3f184b6d3f22b4619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3499334 Auto-Submit: Chan Li <chanli@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 02 Mar, 2022 4 commits
-
-
Josip Sokcevic authored
This reverts commit c0af61c8. Reason for revert: blocked on https://crrev.com/c/3440919 Original change's description: > Update gsutil to use gsutil version 5.6, python3 > > R=gavinmak@google.com > > Bug: 1184108 > Change-Id: I933c07132006b731a97153080ebe86ed756fbdb2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3497998 > Reviewed-by: Gavin Mak <gavinmak@google.com> > Commit-Queue: Josip Sokcevic <sokcevic@google.com> Bug: 1184108 Change-Id: Ifd553d12fcc25230de5ba9e6c32c8e5190cf01a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3500910Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
Peter Wen authored
Chrome on Android is going to use android_static_analysis to control how static analysis runs (values can be: on, off, or build_server). This arg matters a great deal for build performance. Bug: 1202732 Change-Id: I0f7437452605f59c9bd01ff75aba56274f115a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3427859 Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
-
Josip Sokcevic authored
R=gavinmak@google.com Bug: 1184108 Change-Id: I933c07132006b731a97153080ebe86ed756fbdb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3497998Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8820831401628335073 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/7b42800366a15f34b28e62f6bcb1cddcb2206db0 7b42800 (chromium-autoroll@skia-public.iam.gserviceaccount.com) Roll CAS Client from 9274082f771a to be2264bd5c01 More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I6cfff0dffecfc1c0fac21c3076a42bbd19a94537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3499872 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 01 Mar, 2022 2 commits
-
-
Suma Kasa authored
Bug: 1294079 Change-Id: I23552a6e5f3bc60a8007df3cc6611fe0bdf45f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3475651Reviewed-by:
Yulan Lin <yulanlin@google.com> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Suma Kasa <sumakasa@google.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8820930807246912801 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/701c7805dd0669778ce5cd34c195dfeea2a95de6 701c780 (chromium-autoroll@skia-public.iam.gserviceaccount.com) Roll CAS Client from 11415c119300 to a1616e207f0d More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I0fc0a4702748dc0a5eb30941999392f484137c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3495641 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 28 Feb, 2022 5 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8820947794305645857 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/e13ab64b39f65711496bfcae73c6a7c10c9b977a e13ab64 (yiwzhang@google.com) cv: populate new reusability field More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I931d948c8a13b3ad4839fdfb514b157555b62034 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3495874 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8820949050774962417 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/26c1cf8a623d5cf10f3bafeb2820e401c302d005 26c1cf8 (yiwzhang@google.com) update.py: add back cv/api/v0 and common/bq/pb More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I67d1335b196934006f0d308bef9fde24ab3b1001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3495873 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8820960375580647601 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/51fe0724fb1565a0449c32e5081d58d6152a0b0d 51fe072 (yiwzhang@google.com) roll go.chromium.org proto to the latest More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I2b5bae533440bf5a2f140e1e9639e617dd748f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3495862 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8820963522322370369 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/55716175cf920994bbcaea30fc782f3780442409 5571617 (yiwzhang@google.com) fix update.py that imports proto More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: Ia0c5a17df516c0333fe134dc4ce051cea0cc3b29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3495563 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Ravi Mistry authored
This is a reland of fc9a40e3 Hopefully the cause of the 2nd revert was fixed in https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3489327 Original change's description: > Reland "Add support for Gerrit topics in gclient syncs" > > This is a reland of 0f13273f > > Hopefully the cause of the original revert was fixed in https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3480835 > > Original change's description: > > Add support for Gerrit topics in gclient syncs > > > > > > If the new flag "--download-topics" is specified with a "--patch-ref" then: > > * Finds the topic of the Gerrit change. > > * Finds all open changes in the same repo as the Gerrit change. > > * Cherrypicks all changes locally. > > > > This functionality can be used by developers and bots to apply all changes with the same topic in the checkout to be tested at the same time (similar to how Android's TreeHugger handles topics). > > > > > > Tested by: > > > > * Running the new unit test with `python gclient_scm_test.py GerritChangesTest.testDownloadsTopics` from the `tests/` directory. > > > > * Running an end-to-end test with `DEPOT_TOOLS_UPDATE=0 gclient sync --patch-ref "skia@d831da5b8ac2d257c5b0cf2ec6645a148f05e662:refs/changes/17/505217/2" --download-topics` in a skia checkout. > > > > > > Bug: chromium:1298922 > > Change-Id: Ieace5e27fbc9c5d0ea90a037bf80a95062c1b164 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3444003 > > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > > Commit-Queue: Ravi Mistry <rmistry@chromium.org> > > Bug: chromium:1298922 > Change-Id: I80747d797234bba06c17ef5c5e85b310281922c4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3484976 > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Commit-Queue: Ravi Mistry <rmistry@chromium.org> Bug: chromium:1298922 Change-Id: I21d7251bafff808b1144d6e522fa9f384f4541bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3490488Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Ravi Mistry <rmistry@chromium.org>
-
- 24 Feb, 2022 7 commits
-
-
Ravi Mistry authored
For context see comments 5 and 6 here: https://bugs.chromium.org/p/chromium/issues/detail?id=1298922#c6 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Bug: chromium:1298922 Change-Id: I23eaec3c104c7b52653732b6fd9d58d175d78069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3489327Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Ravi Mistry <rmistry@chromium.org>
-
Josip Sokcevic authored
git cl presubmit has --all option which marks all files as modified. However, that doesn't work well with SCM diff. That is, git diff may not contain affected file. Instead of throwing an exception in such case, just return no diff. R=gavinmak@google.com Fixed: 808346 Change-Id: Ie1d534b8eebc84bc5206eba7db8057829390fbec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3485501 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com>
-
Josip Sokcevic authored
This reverts commit fc9a40e3. Reason for revert: at least one tryjob if failing: Gerrit Plugins Tester Original change's description: > Reland "Add support for Gerrit topics in gclient syncs" > > This is a reland of 0f13273f > > Hopefully the cause of the original revert was fixed in https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3480835 > > Original change's description: > > Add support for Gerrit topics in gclient syncs > > > > > > If the new flag "--download-topics" is specified with a "--patch-ref" then: > > * Finds the topic of the Gerrit change. > > * Finds all open changes in the same repo as the Gerrit change. > > * Cherrypicks all changes locally. > > > > This functionality can be used by developers and bots to apply all changes with the same topic in the checkout to be tested at the same time (similar to how Android's TreeHugger handles topics). > > > > > > Tested by: > > > > * Running the new unit test with `python gclient_scm_test.py GerritChangesTest.testDownloadsTopics` from the `tests/` directory. > > > > * Running an end-to-end test with `DEPOT_TOOLS_UPDATE=0 gclient sync --patch-ref "skia@d831da5b8ac2d257c5b0cf2ec6645a148f05e662:refs/changes/17/505217/2" --download-topics` in a skia checkout. > > > > > > Bug: chromium:1298922 > > Change-Id: Ieace5e27fbc9c5d0ea90a037bf80a95062c1b164 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3444003 > > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > > Commit-Queue: Ravi Mistry <rmistry@chromium.org> > > Bug: chromium:1298922 > Change-Id: I80747d797234bba06c17ef5c5e85b310281922c4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3484976 > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Commit-Queue: Ravi Mistry <rmistry@chromium.org> Bug: chromium:1298922 Change-Id: I845321941157ab55d026488b7ce59787ba5e57f2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3488245 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
Ravi Mistry authored
This is a reland of 0f13273f Hopefully the cause of the original revert was fixed in https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3480835 Original change's description: > Add support for Gerrit topics in gclient syncs > > > If the new flag "--download-topics" is specified with a "--patch-ref" then: > * Finds the topic of the Gerrit change. > * Finds all open changes in the same repo as the Gerrit change. > * Cherrypicks all changes locally. > > This functionality can be used by developers and bots to apply all changes with the same topic in the checkout to be tested at the same time (similar to how Android's TreeHugger handles topics). > > > Tested by: > > * Running the new unit test with `python gclient_scm_test.py GerritChangesTest.testDownloadsTopics` from the `tests/` directory. > > * Running an end-to-end test with `DEPOT_TOOLS_UPDATE=0 gclient sync --patch-ref "skia@d831da5b8ac2d257c5b0cf2ec6645a148f05e662:refs/changes/17/505217/2" --download-topics` in a skia checkout. > > > Bug: chromium:1298922 > Change-Id: Ieace5e27fbc9c5d0ea90a037bf80a95062c1b164 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3444003 > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Commit-Queue: Ravi Mistry <rmistry@chromium.org> Bug: chromium:1298922 Change-Id: I80747d797234bba06c17ef5c5e85b310281922c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3484976Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Ravi Mistry <rmistry@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8821375613269346385 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/b81a11283cb14ace0699e8f1dea768b8f5304f7c b81a112 (bryner@google.com) Bump versions of wheels affected by crbug/1297798. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I864a9747ce5a3abb6c9a4e50c21c390d9c33160e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3486524 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8821386937728323985 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/7460e9239c140f8d426c9e99401031af3d65fdf1 7460e92 (chanli@chromium.org) [buildbucket module] return the canceled step failure if recipe... More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: Id569e6092484f6a46fdc3a90d70fd8b4b9fb236a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3486517 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Chris Blume authored
Currently, package_from_installed.py assumes only one version of VS is installed. It takes the path of the first installation. This could be incorrect in several ways: - Maybe both 2017 and 2019 (the supported versions) are installed and although the user specified using 2019, the 2017 path comes first. - Maybe 2019 and 2022 are installed, and the 2022 path is used even though it isn't supported. This CL fixes that issue by parsing the vswhere.exe output to confirm the VS version matches what the user specified, using its corresponding path. Change-Id: I2029a4f7126d0a45b5370ad58ab257df55571b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3458722Reviewed-by:
Gavin Mak <gavinmak@google.com> Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Auto-Submit: Chris Blume <cblume@chromium.org>
-
- 23 Feb, 2022 3 commits
-
-
David Benjamin authored
Change-Id: I7271280deb09c9675567f3dd255e809da19619b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3484977 Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
Josip Sokcevic authored
R=calamity@chromium.org Change-Id: Iee4634462c598685032c8a5ffcfd3b9766726958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3482664 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Christopher Lam <calamity@chromium.org> Commit-Queue: Christopher Lam <calamity@chromium.org>
-
Alexander Schulze authored
This file is used by a few dependent projects. Highlighting py3 compatiblity eases the migration process for those projects. This CL additionally adds executation permissions to the file and includes the script in the docs. Bug: 1298903 Change-Id: I5838fedcef181ee5e3eb84a1fa16b649250460ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3479854 Auto-Submit: Alexander Schulze <alexschulze@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
- 22 Feb, 2022 1 commit
-
-
Ravi Mistry authored
For context see comments 5 and 6 here: https://bugs.chromium.org/p/chromium/issues/detail?id=1298922#c6 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Bug: chromium:1298922 Change-Id: Id424cec27ca64ac0c2e746d54edf044820915cd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3480835Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Ravi Mistry <rmistry@chromium.org>
-
- 21 Feb, 2022 1 commit
-
-
Brian Ryner authored
The previous version was built against a different MSVC runtime than the Python interpreter on Windows, which is unsafe on Python 2.7. Note that this will now use a pure-Python implementation of crcmod on Windows, since there is no packaged wheel available (only an msi, which we don't currently support repackaging). Bug: 1297798 Change-Id: I91e4f58cf2b994280c1620fec86dd8638d8a78ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3474820 Auto-Submit: Brian Ryner <bryner@google.com> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-