Skip to content

C
Chromium_Depot_tools
Switch branch/tag
  1. 31 Jan, 2020 2 commits
    • Sylvain Defresne's avatar
      [roll] Fix the command in the commit message · 4ada8ab4
      Sylvain Defresne authored 
      The CL https://crrev.com/c/chromium/tools/depot_tools/+/2031104 used
the full hash when calling "git log" to fix the roll on some bot. It
however resulted in the full hash visible in the commit message.

Fix the command included in the commit message while still using the
full hash in the command invoked.

Bug: none
Change-Id: I454e600fc34e554c1186ae9488ea4b0f7e7df310
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2031105
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: 's avatarAaron Gable <agable@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
      4ada8ab4
    • Sylvain Defresne's avatar
      Tentative fix for roll-dep.py failing in generate commit message · ae2b962c
      Sylvain Defresne authored 
      Some bots run roll-dep.py and fail while generating the commit message
with the following error:

  src/ios/third_party/material_components_ios/src: Rolling from 54fd1dac39 to 5aaf54801f
  fatal: ambiguous argument '54fd1dac3..5aaf54801': unknown revision or path not in the working tree.
  Use '--' to separate paths from revisions, like this:
  'git <command> [<revision>...] -- [<file>...]'

As "Rolling from 54fd1dac39 to 5aaf54801f" is printed, this mean that
the bot was able to resolve both HEAD and roll_to before invoking this
function, thus the corresponding hashes exists in the repository.

It is unlikely that shortening the hash to just the first nine chars
results in a collision, but there is no reason to use a short hash
when invoking git anyway, so use a separate variable to construct the
header of the commit with short hashes while invoking git with the
full hashes.

Also pass '--' after all the parameters to force git to interpret the
hash range as a range and not as a path.

This is a speculative fix.

Change-Id: Iaa2888610dcf8e20f9edc115a719791d573b83ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2031104Reviewed-by: 's avatarAaron Gable <agable@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
      ae2b962c
  3. 30 Jan, 2020 4 commits
  5. 29 Jan, 2020 1 commit
  7. 28 Jan, 2020 2 commits
  9. 27 Jan, 2020 3 commits
  11. 25 Jan, 2020 1 commit
  13. 24 Jan, 2020 2 commits
  15. 23 Jan, 2020 2 commits
  17. 22 Jan, 2020 2 commits
  19. 21 Jan, 2020 2 commits
  21. 17 Jan, 2020 3 commits
  23. 16 Jan, 2020 1 commit
  25. 15 Jan, 2020 1 commit
    • Raul Tambre's avatar
      subprocess2: Ensure environment keys and values are strings on Python 3 · e9730d75
      Raul Tambre authored 
      Example error during "git cl upload":
Traceback (most recent call last):
  File "C:\Google\depot_tools\presubmit_support.py", line 220, in CallCommand
    returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
  File "C:\Google\depot_tools\presubmit_support.py", line 204, in _RunWithTimeout
    p = subprocess.Popen(cmd, **kwargs)
  File "C:\Google\depot_tools\subprocess2.py", line 143, in __init__
    super(Popen, self).__init__(args, **kwargs)
  File "C:\Google\depot_tools\bootstrap-3_8_0b1_chromium_1_bin\python\bin\Lib\subprocess.py", line 390, in __init__
    errread, errwrite)
  File "C:\Google\depot_tools\bootstrap-3_8_0b1_chromium_1_bin\python\bin\Lib\subprocess.py", line 640, in _execute_child
    startupinfo)
TypeError: environment can only contain strings

Bug: 984182
Change-Id: Id996d73a80845aaeaa061107ed123627091cb600
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1815872
Commit-Queue: Raul Tambre <raul@tambre.ee>
Reviewed-by: 's avatarEdward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>
      e9730d75
  27. 14 Jan, 2020 4 commits
  29. 13 Jan, 2020 4 commits
  31. 11 Jan, 2020 1 commit
  33. 10 Jan, 2020 5 commits