- 03 Jun, 2021 4 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/ac7e7183a25bd2085ab205a93d47e68fedac65a7 ac7e718 (olivernewman@google.com) [file] Catch IOErrors More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I70e76d7105174e7e9b04c7c4a98f8111f81fcdf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2937308 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Josip Sokcevic authored
Depot tools git cl presubmit supports py2 and py3. However, presumbit recipe only runs py2. This patch adds support for running py3 presubmit checks too. Bug: 1214829 Recipe-Nontrivial-Roll: build Change-Id: I089460eaf65d4b6f1238eea13eb087fadb21cad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2934371Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
Dirk Pranke authored
When presubmit checks create warnings that should raise a prompt whether or not to continue, the output wasn't being flushed properly under python3. Bug: 1213316 Change-Id: Ibb4b4d965d49f0cd65ccc0737282e5f5b5f58004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2921323Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com>
-
Marco Georgaklis authored
The endpoint documentation can be found here: https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#get-related-changes This involved adding support for the command in gerrit_client and gerrit_util and then incorporating functionality and testing into the gerrit recipe module. The reasoning for this is to be able to identify chained builds for improved accuracy of the new test identification for the FLake Endorser project. Bug:1204163 Change-Id: Ic60c733540a9afd7ff159408b0ea9ad7aac078e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2928016 Commit-Queue: Marco Georgaklis <mgeorgaklis@google.com> Reviewed-by:
Josip Sokcevic <sokcevic@google.com>
-
- 02 Jun, 2021 2 commits
-
-
Edward Lesmes authored
Change-Id: I5340fa9b989cccda61e7a14b4cd30749e2f2c017 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2935003Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Nicolas Boichat authored
my_activity can definitely be useful outside of Chromium, and the gerrit instances are sometimes private. This allows users to carry an additional list of instances in a json file (and possibly monorail projects, but that seems like likely to be useful). Change-Id: Ic0fec3bd4f815200f27cc0a8530cfd88f4328269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2925677 Commit-Queue: Nicolas Boichat <drinkcat@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com>
-
- 01 Jun, 2021 2 commits
-
-
Greg Thompson authored
Commit 6fc394f9 added some diagnostics, but it didn't quite work out the way it was planned. Bug: 1210746 Change-Id: Ia4f30606e87d3f8b1362441bd74bb7ed0f5ca886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2928771 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com>
-
Brian Ryner authored
There should be no functional changes for depot_tools. However, this version contains a fix for building Python wheels, and we're trying to standardize on this version everywhere. Change-Id: Ibb8259028f0c7aa39f03a75ffdedbbb5349b4fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2927689 Auto-Submit: Brian Ryner <bryner@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com>
-
- 27 May, 2021 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/d21e9df67973aae34d960eb10da3dd65272268de d21e9df (mgeorgaklis@google.com) Added option to not log builds in presentation for buildbucket... More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I62a226159c98f0ae2b693cb50be77bb936fc6f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2922983 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/fdd7ffd886e6077f80633fb7237401c2edd7c8e3 fdd7ffd (mgeorgaklis@google.com) Created function for GetTestResultHistory rpc call in resultdb... More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I33e406a81bb3db1fb797887c6626a2e06c7e4359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2922982 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 26 May, 2021 4 commits
-
-
Dirk Pranke authored
If a presubmit happened to generate a crash, the logic we have for reporting the presubmit check times would call `six.reraise()` incorrectly, leading to a second crash. This CL fixes the invocation of the second crash, and also adds an error message to help users tripping over one possible source of the first crash (reading a binary file as text). Bug: 1210746 Change-Id: Ic46f38901b6acf2055b3feb7272dc751dc69037c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2921322Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com>
-
Edward Lesmes authored
This is a reland of 856ccef0 Use a tempfile instead of stdout for gclient revinfo output Original change's description: > bot_update: Don't use gclient sync output and rely on gclient revinfo. > > In preparation for skipping gclient sync if there are no DEPS changes. > > Bug: 1199853 > Change-Id: Ib9b4ab803bc574a384c661765cee5e4c1de5baae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2912259 > Reviewed-by: Anthony Polito <apolito@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Bug: 1199853 Change-Id: Ib50c4e943cbb51e4a2463beee9b7d1dee824ad29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2910950Reviewed-by:
Gavin Mak <gavinmak@google.com> Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Zhaoyang Li authored
The roll in depot_tools enables new features of uploading iOS runtimes to separate packages, etc, for human users using the tool to upload Xcode. Bug: 1191260 Change-Id: Id6334afd599c9345f05c7fefbd8407f3bc3f8124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2918693Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
-
Brian Ryner authored
Bug: 1208146 Change-Id: I9347a6f95454cfab58eecc08a636957a5fcdb35a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2916176Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Brian Ryner <bryner@google.com>
-
- 25 May, 2021 3 commits
-
-
Gavin Mak authored
Recipe-Manual-Change: infra Bug: 1201483 Change-Id: Id57c2e93e028baad101416bfecbf41ce136ad5b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2904102Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Gavin Mak <gavinmak@google.com>
-
Josip Sokcevic authored
This reverts commit 1cf97004. Reason for revert: roll fails https://crrev.com/c/2915655 Error: dirmd failed. Original change's description: > [dirmd] Roll dirmd > > Earlier git-ls-files-based optimizations was reverted > https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2911692. > Since then the root cause was fixed > https://chromium-review.googlesource.com/c/chromium/tools/build/+/2911979 > and this CL relands the optimization. > > This CL also picks up "mixins" feature which enables reducing duplication of metadata. > See https://chromium-review.googlesource.com/c/chromium/src/+/2897943 > > Bug: 1179786, 1201822 > Change-Id: I9697bae9342f6cdc947abe025bebce22b09b530e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2912261 > Reviewed-by: Prakhar Asthana <pasthana@google.com> > Commit-Queue: Nodir Turakulov <nodir@chromium.org> Bug: 1179786 Bug: 1201822 Change-Id: Iea5aad69382da9cfd3e32c74db10721f37aee930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2909617 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
Brian Ryner authored
Bug: 1208146 Change-Id: Ifb27636063a3fbe02f605f42af3f04b2dbda1529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2914233Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Brian Ryner <bryner@google.com>
-
- 24 May, 2021 3 commits
-
-
Stephen Martinis authored
This reverts commit 856ccef0. Reason for revert: Probably broke chrome os waterfall Original change's description: > bot_update: Don't use gclient sync output and rely on gclient revinfo. > > In preparation for skipping gclient sync if there are no DEPS changes. > > Bug: 1199853 > Change-Id: Ib9b4ab803bc574a384c661765cee5e4c1de5baae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2912259 > Reviewed-by: Anthony Polito <apolito@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Bug: 1199853 Change-Id: Ib893704dffc68b02dfa7f977e751e236003b7e0b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2910949 Auto-Submit: Stephen Martinis <martiniss@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Owners-Override: Avi Drissman <avi@chromium.org>
-
Edward Lesmes authored
In preparation for skipping gclient sync if there are no DEPS changes. Bug: 1199853 Change-Id: Ib9b4ab803bc574a384c661765cee5e4c1de5baae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2912259Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Fumitoshi Ukai authored
Bug: b/187774798 Change-Id: I4746b764b1201fe6a92b90da50186078a1e3f6b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2913018Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@google.com>
-
- 21 May, 2021 8 commits
-
-
Nodir Turakulov authored
Earlier git-ls-files-based optimizations was reverted https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2911692. Since then the root cause was fixed https://chromium-review.googlesource.com/c/chromium/tools/build/+/2911979 and this CL relands the optimization. This CL also picks up "mixins" feature which enables reducing duplication of metadata. See https://chromium-review.googlesource.com/c/chromium/src/+/2897943 Bug: 1179786, 1201822 Change-Id: I9697bae9342f6cdc947abe025bebce22b09b530e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2912261Reviewed-by:
Prakhar Asthana <pasthana@google.com> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
-
Edward Lesmes authored
Change-Id: I00b32eb109cdff7e138ef5d9497eda77c33188f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2912295 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Gavin Mak <gavinmak@google.com> Reviewed-by:
Gavin Mak <gavinmak@google.com>
-
Bruce Dawson authored
Presubmits when uploading occasionally take a very long time - over a minute - and after the fact there is no easy way to know why. This makes fixes to slow presubmits take longer. This change builds on crrev.com/c/2532895 to print a message when any individual presubmit function takes longer than ten seconds. During normal usage this is a NOP but it will presumably find the long poles when presubmits are running particularly slowly. This is similar to gclient runhooks where any hooks that take longer than ten seconds have their run time printed. Change-Id: If57ed35d7a7d221f6380e9b97cf72af56f75e441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2911594Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
Bruce Dawson authored
CheckForWindowsLineEndings is a Chromium presubmit to make sure that \r\n line endings (Windows line endings) don't get committed. Among other things these line endings mess up the license checks, leading to cryptic errors. The problem is that ChangedContents() was stripping line endings, making any checking for them futile. This change adds an option to preserve line endings, to be used by Chromium's CheckForWindowsLineEndings. It's not clear how long this has been broken. See also crrev.com/c/2911914 which must land after this. Bug: 801033 Change-Id: I7cdb9b3581788624f9eca081da43bb070ee412a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2910488Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
Bruce Dawson authored
The CheckLicense presubmit is supposed to check for correct licenses, not for correct line endings. By reading the input file in binary mode it implictly does both, leading to confusing error messages. This is exacerbated by bugs in the line ending checks which are being addressed separately. This change will avoid false positives on files that have Windows line endings. Change-Id: I2ff8632f273ec4896cb4918c386e0d1c12e72935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2910486Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
Edward Lesmes authored
Change-Id: I4a6811f4dd3c5330eed821acd2dc4855aabcf483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2911202Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Prakhar Asthana authored
This reverts commit 170ef527. Reason for revert: This is breaking coverage builds(https://bugs.chromium.org/p/chromium/issues/detail?id=1210693) Original change's description: > [dirmd] Roll dirmd > > To pickup https://chromium-review.googlesource.com/c/infra/infra/+/2891608 > > R=dpranke@chromium.org > > Bug: 1179786 > Change-Id: I023e85e96660ee3acef8eaca345e5e89d3bf03e3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2894371 > Commit-Queue: Nodir Turakulov <nodir@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@google.com> > Auto-Submit: Nodir Turakulov <nodir@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> Bug: 1179786 Change-Id: I5f9a985080c04f52d2c554763c1a42cd95caecd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2911692 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Prakhar Asthana <pasthana@google.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/f53df171aca3367df3b5bf4534b746667aedce40 f53df17 (yiwzhang@google.com) luciexe: don't clear tag in initial build when invoking sub-luc... More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Id9010b0da15d5ac9703abf3576e728b3abeaa164 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2911023 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 20 May, 2021 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/e6c4e528a2562a14f28acc75d52f1f11b4595899 e6c4e52 (mgeorgaklis@google.com) Added -merge flag functionality to resultdb query method. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I2d952e5b82784cbdcb3274c11bbbf143420cb13d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2911020 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Dirk Pranke authored
This reverts commit 3e9eda17. Reason for revert: Trying again with a fix. Original change's description: > Revert "Try again to fix UnicodeDecodeError in CheckAuthorizedAuthor." > > This reverts commit dd007670. > > Reason for revert: Change wasn't correct. > > Original change's description: > > Try again to fix UnicodeDecodeError in CheckAuthorizedAuthor. > > > > This will attempt to do so in a Python2-compatible way. > > > > Bug: 1210746 > > Change-Id: I09edc21a5c47106803c0ac5ca449e0f8732efb24 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2906501 > > Auto-Submit: Dirk Pranke <dpranke@google.com> > > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > > Bug: 1210746 > Change-Id: Ia101d73857abe3d65ba48e05e7a0bc98efb2fd37 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2908152 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Dirk Pranke <dpranke@google.com> Bug: 1210746 Change-Id: I6b7b2a24dd5565740a0561c8eeb860d62375d4bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2908153Reviewed-by:
Alan Screen <awscreen@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com>
-
- 19 May, 2021 7 commits
-
-
Dirk Pranke authored
This reverts commit dd007670. Reason for revert: Change wasn't correct. Original change's description: > Try again to fix UnicodeDecodeError in CheckAuthorizedAuthor. > > This will attempt to do so in a Python2-compatible way. > > Bug: 1210746 > Change-Id: I09edc21a5c47106803c0ac5ca449e0f8732efb24 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2906501 > Auto-Submit: Dirk Pranke <dpranke@google.com> > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Bug: 1210746 Change-Id: Ia101d73857abe3d65ba48e05e7a0bc98efb2fd37 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2908152 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Dirk Pranke <dpranke@google.com>
-
Matt Kotsenas authored
To pick up https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/2906656 The new version uses os.Rename on Windows for faster file moves. Change-Id: I4149ad9968d3f2404517ece91b04fcd53e06dbf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2906502Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
Dirk Pranke authored
This will attempt to do so in a Python2-compatible way. Bug: 1210746 Change-Id: I09edc21a5c47106803c0ac5ca449e0f8732efb24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2906501 Auto-Submit: Dirk Pranke <dpranke@google.com> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Dirk Pranke authored
This reverts commit 68324eff. Reason for revert: I think we need to revert this, because if someone tries to upload a CL from a revision older than when we switched to Python3, this'll run under Python2, where that parameter isn't accepted. Sorry, I didn't think that part through. Original change's description: > Specify encoding for AUTHORS file > > Needed to resolve "UnicodeDecodeError" for Python 3 presubmit checks. > > Bug: 1210746 > Change-Id: If55190ffc9f99c671a84fe9b3539317e464639cc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2904927 > Commit-Queue: Dirk Pranke <dpranke@google.com> > Auto-Submit: Alan Screen <awscreen@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> Bug: 1210746 Change-Id: I4e5a58869baa897066f4e84c2e18b673c25bcc34 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2906499 Auto-Submit: Dirk Pranke <dpranke@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
-
Edward Lesmes authored
Bug: 861786 Change-Id: I378ff8f5871e61cce77d4888432462a33a974ee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2906495 Commit-Queue: Gavin Mak <gavinmak@google.com> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Gavin Mak <gavinmak@google.com>
-
Dirk Pranke authored
This reverts commit f059ec93. Reason for revert: Reverting because we probably need to be using vpython and a compiled crcmod instead. See, e.g.,. b/188591640. Original change's description: > Update gsutil to use gsutil version 4.61, python3. > > This CL updates the gsutil.py wrapper to download and use > v4.61 of GCP's gsutil, which is Python3-compatible. > > v4.61 appears to be fully self-contained and have all of the > packages it needs vendored into it. So, there's no reason to > use vpython anymore, and this CL removes that. > > Also, this CL removes the 'fallback' option to gsutil and > the ability to force a version switch, as this should no > longer be necessary (it was added for a migration back in 2014 > but apparently this code was never removed afterwards). > > This CL also updates download_from_google_storage.py and > upload_to_google_storage.py to similarly not have the version flags > and to just use regular python3, not vpython3. > > Bug: 1184108 > Change-Id: I0d1a8351dba2d3ad1f927afa333fb10959f19443 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2898439 > Reviewed-by: Mike Frysinger <vapier@chromium.org> > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@google.com> Bug: 1184108 Change-Id: I8e21a9a40d81e4e185642f866855b6838f80f1c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2905904 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Dirk Pranke <dpranke@google.com>
-
Alan Screen authored
Needed to resolve "UnicodeDecodeError" for Python 3 presubmit checks. Bug: 1210746 Change-Id: If55190ffc9f99c671a84fe9b3539317e464639cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2904927 Commit-Queue: Dirk Pranke <dpranke@google.com> Auto-Submit: Alan Screen <awscreen@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com>
-
- 18 May, 2021 3 commits
-
-
Gavin Mak authored
Patch failures in bot_update return exit code 87 and 88, which are ignored by ensure_checkout. This causes the bot_update step in recipes to be successful despite a patch failure. This change removes these exit codes from the accepted return codes for this step. Bug: 1207685 Change-Id: I7bd71732a99184c96196659c6953e4d4b610c9b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2893686Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Gavin Mak <gavinmak@google.com>
-
Vadim Shtayura authored
To pick up `-use-id-token` and `-audience` flags. BUG=1204034 R=iannucci@chromium.org, tandrii@chromium.org CC=sdefresne@chromium.org Change-Id: I1a70115d9833d10224516edd6042fb9c022fd38b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2904101Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
Edward Lesmes authored
Bug: 1199853 Change-Id: I0616f90a0cd7e4478f40ac7eaf5dbccca788d517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2898001Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-