- 08 Jun, 2017 8 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM+CQ. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/154ef7e5d8f964ef30b1250dd33751582705f6f2 [path] Add concept of a "cleanup" directory. (dnj@chromium.org) R=dnj@chromium.org, martiniss@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I31787615cfaa6f33deae6c1c0c3d7b748c222d05 Reviewed-on: https://chromium-review.googlesource.com/527503 Commit-Queue: Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by:
Daniel Jacques <dnj@chromium.org>
-
Robert Iannucci authored
R=dnj@chromium.org Bug: Change-Id: I69d2e75a7a6784a611f6e0128f1ba5617f009af2 Reviewed-on: https://chromium-review.googlesource.com/528320Reviewed-by:
-
Ryan Tseng authored
This picks up about 2 years worth of changes. Bug:723733 TEST=Ran gclient sync on src.git checkout, worked. Change-Id: I7021ac62be560bb3ba7b523f0758d56bceeef12a Reviewed-on: https://chromium-review.googlesource.com/527262Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org>
-
Aaron Gable authored
This CL changes the way that "git cl patch" behaves for Gerrit changes. Previously, git-cl-patch behaved just like it did for Rietveld: make sure you're on a branch, download the diff, apply it on top of your branch. However, this causes problems with Gerrit. Namely, when you upload a change to Gerrit, git-cl has to make sure that all parents of your local change have previously been uploaded as well, either as other changes or as commits already landed on the target branch. But the method for "applying a patch" from Gerrit was to cherry-pick it, and that changes the commit hash. So the resulting commit would *not* have been uploaded to Gerrit. Thus, the following routine didn't work with Gerrit: $ git checkout -t origin/master -b your-work $ git cl patch 123456 $ git checkout -tb my-work $ #hack and commit $ git cl upload This would fail during the upload with a message saying that the contents of 'your-work' hadn't been uploaded. This CL fixes the situation by replacing the cherry-pick with a hard reset. This means that the contents of the 'your-work' branch will be *exactly* what was downloaded from Gerrit. Uploads based on top of that commit will work just fine. Finally, in a concession to some people who want 'git cl patch' to actually apply a patch instead of performing a hard reset, if the current branch contains local work, then rather than leaving that work behind with a hard reset, we fall back to the old cherry-pick behavior with a confirmation dialog and warning that uploading will be hard. Bug: 723787 Change-Id: I3ad164f6d3078bff00139d446bb8ce97738a1344 Reviewed-on: https://chromium-review.googlesource.com/527345 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org>
-
Aaron Gable authored
The logic for handling --title, --message, and the commit message of the most recent commit was accidentally doing this differently from how Rietveld had done them. Bug: 728391 Change-Id: I70a46ccb470d790103f5d6bb745902595be28eee Reviewed-on: https://chromium-review.googlesource.com/527339 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
-
Aaron Gable authored
This prevents TBR (self code-review) permissions from blocking the CL from being uploaded at all. Instead, it will fully upload, and then show a better error message after upload is complete. Bug: 729967 Change-Id: I55e3e98e200143076afcaab858064d9f5c62f8ef Reviewed-on: https://chromium-review.googlesource.com/527325Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/c916898b8189866a0bf43fe15c800e4fe6d4a19e [context] fix treatment of None in env. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I96a7fb05593c4e946faa581a67bcc5f2ecdcace4 Reviewed-on: https://chromium-review.googlesource.com/527913Reviewed-by:
Recipe Roller <recipe-roller@chromium.org> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/c40412cbc4e1b8ee1e6eba2e88328ca71c6ec1e4 [context] Add path prefix/suffix manipulation. (dnj@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I10613e30e3a58c208346243fb221cf9ed9d6b274 Reviewed-on: https://chromium-review.googlesource.com/527403Reviewed-by:
-
- 07 Jun, 2017 4 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/db920908bf51fcdb0e30f686a528b25cd4876ca7 Update vpython and spec to new text protobuf. (dnj@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Idc9ee786cc2f54eb69cbd5034fb5f58370d5663a Reviewed-on: https://chromium-review.googlesource.com/527497Reviewed-by:
-
Jeremy Roman authored
This causes review links to be shown using crrev.com/c/ or crrev.com/i/, which are the ones recommended at https://polygerrit.appspot.com/. This gerrit server is no longer used only by CrOS. Change-Id: Ie6b856390ec465f9d35a5035547f7b779392b24c Reviewed-on: https://chromium-review.googlesource.com/526612Reviewed-by:
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I5c7cf00722c47a2063a8635822c0bb270a26b524 Reviewed-on: https://chromium-review.googlesource.com/527632 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
-
Aaron Gable authored
TBR=iannucci@chromium.org Change-Id: I07668787e4f26bc4809ea3c3a5331a259655d2da Reviewed-on: https://chromium-review.googlesource.com/527295Reviewed-by:
-
- 06 Jun, 2017 3 commits
-
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: Ib2b966b5bc967de11a295b1636c1901faabea55f Reviewed-on: https://chromium-review.googlesource.com/525540 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: Id95be31767d302c5eb9f7de96d31e32cc4dec1a4 Reviewed-on: https://chromium-review.googlesource.com/524492Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/267b9221c5fbd2712527852550d86f9e2e3874ff [file] Derive user-facing error from StepFailure and set FAILURE status on step. (iannucci@chromium.org) https://crrev.com/1ec7ad4df3efbdd7224f249179390aab4a66c562 [file] add log listings to file.listdir and file.glob_paths. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I45cd3ad3d3282e80d1b13b4873b77865c62bbcd1 Reviewed-on: https://chromium-review.googlesource.com/525853Reviewed-by:
-
- 05 Jun, 2017 3 commits
-
-
Aaron Gable authored
This brings the gerrit version of "git cl comments" into line with the Rietveld implementation by including file- and line-level comments as well as top-level review comments. It requires an extra API call to do so, so this may result in some slow-down, but the result is worth it. It formats the comments to match the formatting used in the PolyGerrit UI, with the addition of visible URLs linking to the comment since we can't hyperlink text in the terminal. This CL also causes it to ignore messages and comments with the 'autogenerated' tag, which are generally less interesting and clutter the output. Bug: 726514 Change-Id: I1fd939d90259b43886ddc209c0e727eab36cc9c9 Reviewed-on: https://chromium-review.googlesource.com/520722 Commit-Queue: Aaron Gable <agable@chromium.org> Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/ddd199058ea23f965a1a6b276d76cf5c3723baaf [bundle] switch implimentation to use git 2.13 attr pathspec. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I14490bf186639eff4d6c0b0735b623e4343e5e1f Reviewed-on: https://chromium-review.googlesource.com/524007Reviewed-by:
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: I72326ee6ddd907a97b5c497a8b2cc7fb744cf422 Reviewed-on: https://chromium-review.googlesource.com/523142Reviewed-by:
-
- 02 Jun, 2017 7 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/a64a4d4ad8e4844cb81868a2b24df4d836d5caca [file] No error in remove if file does not exist (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ie865339d6d6b8495a0ab737905f3236e006603b9 Reviewed-on: https://chromium-review.googlesource.com/523183Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
gclient-new-workdir.py should work on systems not supporting reflink now. Bug: 728903, 721585 Change-Id: I1385c4281bbf61d4ccae64c3595a39972fbe9d9e Reviewed-on: https://chromium-review.googlesource.com/522232 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
Wiktor Garbacz authored
Using --no-squash resulted in an exception being thrown, because issue number is not set in that case. Change-Id: Iaf0d7eb05851eba0d5231640c077b845bca486ee Reviewed-on: https://chromium-review.googlesource.com/505509Reviewed-by:
-
Paweł Hajdan, Jr authored
This way we can get e.g. ordered dict as needed for conditions. Only the new logic does it, not the regular python exec logic. Bug: 570091 Change-Id: Ia5554e5b018085b3b9bd876b7f28a9f8e54a7984 Reviewed-on: https://chromium-review.googlesource.com/522564Reviewed-by:
-
Paweł Hajdan, Jr authored
It's still used in some places like CDM. This fixes the bug below. Bug: 728343 Change-Id: I0f9e2bbd0339838ee6d1d240c584858947cf36d2 Reviewed-on: https://chromium-review.googlesource.com/522682 Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Emma Soederberg <emso@google.com>
-
Dan Jacques authored
Bump to: c6dbc470acfd836494db899bc6aebe0f3d2df593 BUG=None TEST=None R=iannucci@chromium.org Change-Id: I02a62665c9d7c95b4dc8dc93e45028cf9ff99aae Reviewed-on: https://chromium-review.googlesource.com/522422Reviewed-by:
-
Dan Jacques authored
Currently, the Windows toolchain is installed in a subdirectory under "depot_tools". Allow this installation destination to be overridden, either by flag (useful for testing) or via environment variable (to be used in Chromium recipe). BUG=chromium:727917 TEST=local - Ran explicitly w/ flag, seems to work. - Ran via Chromium's "vs_toolchain" with and without environment variable override, seems to install correctly. Change-Id: I6b33832d7f099796e23da0548949073c70a17788 Reviewed-on: https://chromium-review.googlesource.com/521663Reviewed-by:Scott Graham <scottmg@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
- 01 Jun, 2017 14 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/e7ce42597641397a594380f0d5edd6fd7ade1037 [test] only clean up expectations if training was otherwise successful. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I42380f37fe4bfdc80a0c8910528fa56ab3ed9dce Reviewed-on: https://chromium-review.googlesource.com/522003Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/09efd6f1bfd7040872c894fa6f70294a9575036a Remove all mentions of example.py (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Id46193eb7842600cead91a00d210febd1148511b Reviewed-on: https://chromium-review.googlesource.com/521943Reviewed-by:
-
Dan Jacques authored
Enable a sentinel file to enable/disable "depot_tools" auto-updating. This file, if present, indicates that automatic updating should not occur. Add a simple control script to enable/disable automatic updating. BUG=chromium:727917 TEST=local - Ran locally, --enable, --disable. R=iannucci@chromium.org, maruel@chromium.org, nodir@chromium.org Change-Id: Id30a17586248228849d046f79d7e0bc445d97f97 Reviewed-on: https://chromium-review.googlesource.com/521884 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org>
-
Dave Tu authored
Pinpoint needs to request builds at specific revisions, e.g. clank@0123 + chromium/src@4567 + v8@89ab. It's not aware of the path of the repositories in the src tree, so it makes more sense to pass in the repository URLs instead. Bug: https://github.com/catapult-project/catapult/issues/3394 Change-Id: Ib9fb9a7bf5d918c18f37c3b2b36418537512b235 Reviewed-on: https://chromium-review.googlesource.com/520569 Commit-Queue: David Tu <dtu@chromium.org> Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
Dan Jacques authored
Second attempt at landing. Fix quotes around python in "gclient.bat". Currently, all ".bat" entry points use "~dp0python" to ensure that the Python that is used to execute the tool is the one in depot_tools. This prevents any sort of system override. Remove this override so that PATH solely determines which Python is used. To accommodate users who invoked these tools without Python on the PATH, we still still add "depot_tools" as a catch-all PATH suffix. Some tools were also not using DOS-style line endings. This CL fixes this. BUG=chromium:714293, chromium:724902 TEST=None Change-Id: I0fceb99c8adb96e72dac706819be032d400aad37 Reviewed-on: https://chromium-review.googlesource.com/521704 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org>
-
Daniel Jacques authored
This reverts commit 2f5f0b7a. Reason for revert: <INSERT REASONING HERE> Original change's description: > [.bat] Remove "depot_tools" override. > > Currently, all ".bat" entry points use "~dp0python" to ensure that the > Python that is used to execute the tool is the one in depot_tools. This > prevents any sort of system override. > > Remove this override so that PATH solely determines which Python is > used. To accommodate users who invoked these tools without Python on the > PATH, we still still add "depot_tools" as a catch-all PATH suffix. > > Some tools were also not using DOS-style line endings. This CL fixes > this. > > BUG=chromium:714293, chromium:724902 > TEST=None > > Change-Id: I06e9583a668c767196a2a335547aded868f2a2b5 > Reviewed-on: https://chromium-review.googlesource.com/517236 > Commit-Queue: Daniel Jacques <dnj@chromium.org> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> > TBR=maruel@chromium.org,iannucci@chromium.org,vadimsh@chromium.org,dnj@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=chromium:714293, chromium:724902 Change-Id: I822abdd4e02abd32d2f4789fb16d5a7f78fdd02d Reviewed-on: https://chromium-review.googlesource.com/521867Reviewed-by:
-
Dave Tu authored
`parsed_root.path` already contains the leading slash in the the URL, so adding an additional slash gives an incorrect URL. Change-Id: I84f04179356bb132a31531232a5c30c7808f7c1b Reviewed-on: https://chromium-review.googlesource.com/520724Reviewed-by:
-
Dan Jacques authored
Currently, all ".bat" entry points use "~dp0python" to ensure that the Python that is used to execute the tool is the one in depot_tools. This prevents any sort of system override. Remove this override so that PATH solely determines which Python is used. To accommodate users who invoked these tools without Python on the PATH, we still still add "depot_tools" as a catch-all PATH suffix. Some tools were also not using DOS-style line endings. This CL fixes this. BUG=chromium:714293, chromium:724902 TEST=None Change-Id: I06e9583a668c767196a2a335547aded868f2a2b5 Reviewed-on: https://chromium-review.googlesource.com/517236 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by:
-
Robert Iannucci authored
R=dnj@chromium.org, nodir@chromium.org, phajdan.jr@chromium.org Bug: Change-Id: I47d8f9311b6ee71583fb989888a1e4d28b5495df Reviewed-on: https://chromium-review.googlesource.com/520731 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
-
Paweł Hajdan, Jr authored
Bug: 570091 Change-Id: Icb15bcd354c9b524674c6b4496f430c26cf7b89e Reviewed-on: https://chromium-review.googlesource.com/521482Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
-
John Budorick authored
Bug: 728618 Change-Id: I0706f9c0b6d17e82a77cad95a9264038f594b80d Reviewed-on: https://chromium-review.googlesource.com/521222Reviewed-by:
-
Paweł Hajdan, Jr authored
This is a step towards implementing conditions. Bug: 570091 Change-Id: I99467033082d96021854c23dcff3fc2b56f995b4 Reviewed-on: https://chromium-review.googlesource.com/517107Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/d878bba594c81c7ba4cc16b8bf078097b00a102d [recipe_modules/file] add real file module to engine. (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I0f11eb017b42f090cc49c0c4a325205a2e92e504 Reviewed-on: https://chromium-review.googlesource.com/520644Reviewed-by:
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. recipe_engine: https://crrev.com/8ff178b2ec0c099d49ecb1df1c411f487c6bc657 [context] simplify step context implementation (iannucci@chromium.org) TBR=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9f963c1cdfee1e9ee0a4ecf00a4cd7d9e45dc0d9 Reviewed-on: https://chromium-review.googlesource.com/520783Reviewed-by:
-
- 31 May, 2017 1 commit
-
-
Bruce Dawson authored
On recent SDKs the size of the toolchain package grew. This change filters out some unneeded directories in order to minimize this growth. This change also fixes the bin paths for the 10.0.15063.0 SDK. Starting with this SDK version the SDK version is part of the path. The script does *not* handle packaging older SDKs anymore - older versions of the script can be used for that purpose. The 10.0.15063.0 SDK will be needed eventually in order to support Windows 10 Creators Update. Test builds are running on crrev.com/2913873003 (VS 2017) and crrev.com/2914643003 (VS 2015). Bug: 683729,682416 Change-Id: Ia89e3253869a45dd10c923a2edee53aaf086e12c Reviewed-on: https://chromium-review.googlesource.com/519982 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
-
