BUG=none
TEST=none

Review URL: http://codereview.chromium.org/4112010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64443 0039d316-1c4b-4281-b951-d872f2087c98

Doing static analysis on the script greatly easy refactoring since it reduces
the chances of leaving a typo in rarely executed & untested & untested code.

This is in preparation to refactor changelist on-disk format to use json.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/4184008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64427 0039d316-1c4b-4281-b951-d872f2087c98

Previously, solution's properties would be ignored if there was no DEPS file in
source control. Change the behavior to evaluate the properties anyway.

TEST=new smoke test
BUG=none

Review URL: http://codereview.chromium.org/4154004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64232 0039d316-1c4b-4281-b951-d872f2087c98

To make sure to regression is added while looking into the code more deeply.

BUG=none
TEST=new smoke test

Review URL: http://codereview.chromium.org/4215001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64230 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/4176004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@64049 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/4157002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@63886 0039d316-1c4b-4281-b951-d872f2087c98

Lowers the noise

TBR=jochen
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/4151001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@63885 0039d316-1c4b-4281-b951-d872f2087c98

Contributed by Torsten Becker <torsten.becker@gmail.com>

BUG=
TEST=gclient config 'ssh://user-name@asd.com/~/asd.git' && gclient sync  # fails in SplitUrlRevision

Review URL: http://codereview.chromium.org/4144002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@63877 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jochen
BUG=
TEST=

Review URL: http://codereview.chromium.org/4132002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@63832 0039d316-1c4b-4281-b951-d872f2087c98

Create an update_depot_tools.bat file to use for updated when on cygwin, and
properly call it from the update_depot_tools shell script and gclient batch
files.

BUG=none
TEST=gclient sync and git cl work again on cygwin.  Can also turn echo on in update_depot_tools.bat to verify updating working correctly.

Review URL: http://codereview.chromium.org/3856006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@63234 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3853003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@63047 0039d316-1c4b-4281-b951-d872f2087c98

Also, modify git-cl to also update depot_tools. Otherwise, the git-cl
script never gets updated for folks that only use git-cl but
not gclient. This fixes a bug ChromiumOS developers are currently seeing
where there git-cl checkout is still pointing to src.chromium.org
and not git.chromium.org.

BUG=none
TEST=Verified that git-cl help and gclient help work.

Review URL: http://codereview.chromium.org/3817011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@62948 0039d316-1c4b-4281-b951-d872f2087c98

This is nicer than an error message.

TEST=manually tested the url was overwritten
BUG=none

Review URL: http://codereview.chromium.org/3796010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@62923 0039d316-1c4b-4281-b951-d872f2087c98

It's better than throwing an exception.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3779010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@62921 0039d316-1c4b-4281-b951-d872f2087c98

Prints a meaningful message instead of throwing an exception.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3828010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@62920 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=git-cl works
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/3757006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@62916 0039d316-1c4b-4281-b951-d872f2087c98

It happens when a user uses --diff foo.diff so the list of file is not defined.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3763004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@62547 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3797002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@62541 0039d316-1c4b-4281-b951-d872f2087c98

This occurs when gclient compares the cached deps in .gclient_entries
to the new DEPS and tries to construct an SCM for any cached entries
which no longer exist. In this situation gclient doesn't account for
the case where previous entries may have been ignored by setting their
url to None via the custom_deps section in .gclient.

Contributed by Jay Soffian.

Review URL: http://codereview.chromium.org/3769002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@62540 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=cd ../tempdir && ../depot_tools/drover <some args>

Review URL: http://codereview.chromium.org/3811001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@62497 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3737001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@62400 0039d316-1c4b-4281-b951-d872f2087c98

This is part 2 of a 2-part change which fixes a bug where git-cl
hangs if ~/.codereview_upload_cookies does not exist. It is
actually waiting on user input for email/password (but you don't see the
prompt because it's happening in a subprocess).

This is a do-over of http://codereview.chromium.org/3622002.

Much thanks to Lei Zhang for fixing the bugs in the original CL. His
fixup CL was http://codereview.chromium.org/3541019.

BUG=none
TEST=Verified that the hang is fixed.

Wrote a quick pre-submit to test that issue and patchset are ints:
    http://codereview.chromium.org/3533020

Output:

** Presubmit Warnings **
Patchset is 1

Issue is 3533020

Review URL: http://codereview.chromium.org/3591017

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61957 0039d316-1c4b-4281-b951-d872f2087c98

TBR=maruel
BUG=none
TEST=none

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61883 0039d316-1c4b-4281-b951-d872f2087c98

This is part 2 of a 2-part change which fixes a bug where git-cl
hangs if ~/.codereview_upload_cookies does not exist. It is
actually waiting on user input for email/password (but you don't see the
prompt because it's happening in a subprocess).

BUG=none
TEST=Verified that the hang is fixed.

Review URL: http://codereview.chromium.org/3622002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61822 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise, git try breaks for some users.

Also, make testUpdateCheckout pass if the path to the temp directory contains a symlink (like on Mac OS X).

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/3620011

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61786 0039d316-1c4b-4281-b951-d872f2087c98

smarter about finding the most appropriate settings file.

Before this change, I inadvertently did a [gcl try] on a chrome-internal
change (it was a trivial change and not really secret, so no harm done).
After this change, that won't be possible.

Also, change breakpad to not upload the exception that is thrown when 
the user fails to provide correct log-on credentials.

TEST=none
BUG=none


Review URL: http://codereview.chromium.org/3390013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61738 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61734 0039d316-1c4b-4281-b951-d872f2087c98

Patch contributed by Anton Staaf.

BUG=None
TEST=run "gclient config ...; gclient sync chromium"

Review URL: http://codereview.chromium.org/3497013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61733 0039d316-1c4b-4281-b951-d872f2087c98

python does not seem to be able to import for a dir with dashes in it.

BUG=none
TEST=Ran git-cl help and verified it worked and new dir was created.

Review URL: http://codereview.chromium.org/3530012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61694 0039d316-1c4b-4281-b951-d872f2087c98

sys.stdout.isatty() is True even on buildbot.
Otherwise, logs can't be untangled when using --jobs.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3596006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61552 0039d316-1c4b-4281-b951-d872f2087c98

Added a unit test to verify .hg detection.
Also refactor the test a bit to reduce the amount of reduncdant code.

TEST=fixed unit tests
BUG=none

Review URL: http://codereview.chromium.org/3516015

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61551 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise the scripts make it looks like they are hung when the presubmit checks
are slow.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3613007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61506 0039d316-1c4b-4281-b951-d872f2087c98

BUG=57783
TEST=none
Review URL: http://codereview.chromium.org/3601007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61459 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=29953

Review URL: http://codereview.chromium.org/3609007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61371 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3521006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@61277 0039d316-1c4b-4281-b951-d872f2087c98

looking for non-standard-named depot_tools directory
in git cl hooks python script.  Otherwise, python
ignores the path.

Patch contributed by James Jones @ nvidia.

BUG=chromium-os:7007

Review URL: http://codereview.chromium.org/3467013

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@60499 0039d316-1c4b-4281-b951-d872f2087c98

The user will get an idea of what data is sent.

Getting the current working directory is useful to know what checkout was used.

the repr(last_tb) call was stripping off a lot of useful information for
debugging.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3384020

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@60339 0039d316-1c4b-4281-b951-d872f2087c98

That's so pythonic. Use str() instead.

TBR=bradnelson
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3415019

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@60211 0039d316-1c4b-4281-b951-d872f2087c98

It doesn't give me useful information.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3493005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@60209 0039d316-1c4b-4281-b951-d872f2087c98

This makes the code saner to understand.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3420014

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@60050 0039d316-1c4b-4281-b951-d872f2087c98