- 03 Jul, 2013 3 commits
-
-
iannucci@chromium.org authored
This enables significant time savings, especially since file_list only exists to enable file-specific hooks (which, AFAIK, nothing actually uses). On a z620 (linux) using the cached git repos, a first-time `gclient sync --nohooks` takes: * (with) 131.06s user 14.10s system 117% cpu 2:03.89 total * (without) 482.13s user 189.35s system 144% cpu 7:45.63 total This change makes nohooks cause file_list to be None if we don't need to accumulate it, and updates GitWrapper and SvnWrapper appropriately. R=szager@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/18541006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@210026 0039d316-1c4b-4281-b951-d872f2087c98
-
iannucci@chromium.org authored
Instead of cloning straight into place, clones are made to a global cache dir, and then local (using --shared) clones are made from the cache to the final resting place. This means the 'final' clones are full repos with no shenanigans, meaning that branches, commits, etc. all work, which should allow the rest of the gclient ecosystem to work without change as well. The primary benefit is, of course, reduced network IO, and a much lower cost for 'clobber' operations (assuming we don't clobber the cache). It also means that a given bot can have a greater number of checkouts, since the entire git history will only be stored once per machine, instead of once per checkout. R=dpranke@chromium.org, szager@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/18328003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@210024 0039d316-1c4b-4281-b951-d872f2087c98
-
ilevy@chromium.org authored
- Use config --local for properties that should be local. - Remove git fetch retry logic, it should not be necessary with the googlesource hosts. - Include .strip() in GIT.Capture, simplifying other calls. - Safer testing of whether dep revision is a sha. - Fix refs/remotes/ DEPS branch detection Review URL: https://chromiumcodereview.appspot.com/18262002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@209825 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Jul, 2013 1 commit
-
-
iannucci@chromium.org authored
R=dpranke@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/18269002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@209483 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 Jun, 2013 3 commits
-
-
petermayo@chromium.org authored
Able to pull internal tools, but distinct from the source that those tools may eventually build. TBR=cmp@chromium.org BUG=252226 TEST=local buildslave Review URL: https://chromiumcodereview.appspot.com/17351008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@209166 0039d316-1c4b-4281-b951-d872f2087c98
-
iannucci@chromium.org authored
This will be used on the bots when calling apply_patch, which commits to git repos. R=dpranke@chromium.org,szager@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/18006002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@209040 0039d316-1c4b-4281-b951-d872f2087c98
-
ukai@chromium.org authored
R=hinoka@chromium.org,maruel@chromium.org BUG=254817 Review URL: https://chromiumcodereview.appspot.com/17992005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@209037 0039d316-1c4b-4281-b951-d872f2087c98
-
- 27 Jun, 2013 1 commit
-
-
iannucci@chromium.org authored
Previously if one or both of these values were unset, the tests would simply fail because `git config` returns 1. R=dpranke@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/18053009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@208966 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Jun, 2013 4 commits
-
-
hinoka@chromium.org authored
In order to support both developer workflow and not breaking bots, if the script fails on a 403 in a bucket, it'll print a message asking developers to run "download_from_google_storage --config" in order to create a new boto file. This is not done automatically because it would break bots (Imagine hitting a 403, and then gsutil wiping the .boto file, waiting for input, then dying). BUG=231699,176331 Review URL: https://chromiumcodereview.appspot.com/17590010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@208806 0039d316-1c4b-4281-b951-d872f2087c98
-
iannucci@chromium.org authored
This reverts commit 012dc07c. Revert "Partially revert r208574 to get the CQ working again (hopefully)." This reverts commit 74105cd2. Pull the --no-commit change out completely. TBR=dpranke@chromium.org BUG=254556 Review URL: https://codereview.chromium.org/17944002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@208801 0039d316-1c4b-4281-b951-d872f2087c98
-
hinoka@google.com authored
basic.sh expects "work: None", but "work: " is printed instead, which breaks presubmit. This fixes it. BUG= R=dpranke@chromium.org Review URL: https://codereview.chromium.org/17763004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@208799 0039d316-1c4b-4281-b951-d872f2087c98
-
dpranke@chromium.org authored
TBR=iannucci@chromium.org, cmp@chromium.org BUG=254556 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@208782 0039d316-1c4b-4281-b951-d872f2087c98
-
- 25 Jun, 2013 1 commit
-
-
iannucci@chromium.org authored
R=dpranke@chromium.org BUG= Review URL: https://codereview.chromium.org/17644004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@208574 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Jun, 2013 2 commits
-
-
petermayo@chromium.org authored
It appears to be parsed and ignored, seems like a bug to me. BUG=None TEST=local/manual. Review URL: https://chromiumcodereview.appspot.com/17265012 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@207404 0039d316-1c4b-4281-b951-d872f2087c98
-
ilevy@chromium.org authored
This will speed up main waterfall sync. We can remove this hack tomorrow if svn load is still OK. TBR=cmp Review URL: https://chromiumcodereview.appspot.com/17468009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@207277 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 Jun, 2013 1 commit
-
-
cmp@chromium.org authored
TBR=iannucci@chromium.org Review URL: https://chromiumcodereview.appspot.com/17274009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@207253 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Jun, 2013 1 commit
-
-
dbeam@chromium.org authored
R=maruel@chromium.org BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/17379008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@207048 0039d316-1c4b-4281-b951-d872f2087c98
-
- 17 Jun, 2013 2 commits
-
-
maruel@chromium.org authored
Look for either a unique prefix or for an approximation of the shortest Levenshtein distance. So all of these will resolve to 'git cl upload': git cl upl git cl uplaod These won't resolve: git cl up # it shares prefix with 'upstream' git cl uplao # not similar enough Also align help against longest command instead of hard coded '10'. The help page was distorded. R=iannucci@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/17272002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@206820 0039d316-1c4b-4281-b951-d872f2087c98
-
iannucci@chromium.org authored
This pulls r1084 from the chromium on upstream rietveld. R=jparent@chromium.org, maruel@chromium.org BUG=247791 Review URL: https://chromiumcodereview.appspot.com/16744006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@206743 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 Jun, 2013 1 commit
-
-
xusydoc@chromium.org authored
BUG=248384 Review URL: https://chromiumcodereview.appspot.com/16763004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@205692 0039d316-1c4b-4281-b951-d872f2087c98
-
- 11 Jun, 2013 1 commit
-
-
danakj@chromium.org authored
src/base/hash_tables.h has moved to src/base/containers/hash_tables.h in r205241. R=maruel@chromium.org Review URL: https://chromiumcodereview.appspot.com/16787005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@205662 0039d316-1c4b-4281-b951-d872f2087c98
-
- 10 Jun, 2013 3 commits
-
-
brettw@chromium.org authored
I have a large rename change and it's impossible to upload because the size of the CC field is above the maximum 2000 characters in Reitveld. Review URL: https://chromiumcodereview.appspot.com/16366008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@205323 0039d316-1c4b-4281-b951-d872f2087c98
-
enne@chromium.org authored
If (hypothetically) you pointed your WebKit repo environment variable to Blink and not WebKit, then the change_re will not find anything in the log and the script will explode on changes[0] because changes=[]. Fix this by being robust to not being able to parse anything out of the log in process_git_commits. R=szager@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/16258010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@205290 0039d316-1c4b-4281-b951-d872f2087c98
-
nick@chromium.org authored
presubmit_support: Call git once per change, to get a diff for all files. Parse this result to generate per-file diffs, which go into a cache that's shared between the AffectedFile instances. Greatly improves presubmit performance on Blink where there may be rule violations (my test case went from 50s to 5s). BUG=236206 TEST=new test in presubmit_unittest.py; manual performance test on Mac and Windows after touching hundreds of files in webkit; testing included add/move/edit/delete on both binary and text files. Review URL: https://chromiumcodereview.appspot.com/15898005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@205275 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 Jun, 2013 4 commits
-
-
tapted@chromium.org authored
> Default to using --3way when using `git cl patch`. > > Resolving conflicts is much more fun this way. > > BUG=None > TEST=Ran `git cl patch <issue>` with both clean and unclean patches, also checked behaviour of --reject is preserved. > R=maruel@chromium.org > > Review URL: https://codereview.chromium.org/16211005 TBR=tapted@chromium.org Review URL: https://codereview.chromium.org/15786008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@204978 0039d316-1c4b-4281-b951-d872f2087c98
-
mazda@chromium.org authored
Review URL: https://chromiumcodereview.appspot.com/15864011 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@204686 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
Resolving conflicts is much more fun this way. BUG=None TEST=Ran `git cl patch <issue>` with both clean and unclean patches, also checked behaviour of --reject is preserved. R=maruel@chromium.org Review URL: https://codereview.chromium.org/16211005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@204671 0039d316-1c4b-4281-b951-d872f2087c98
-
tapted@chromium.org authored
BUG=None TBR=laforge@chromium.org, kerz Review URL: https://codereview.chromium.org/16557009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@204668 0039d316-1c4b-4281-b951-d872f2087c98
-
- 06 Jun, 2013 1 commit
-
-
laforge@chromium.org authored
Suppress alt_urls when a drover.properties file is present (otherwise it breaks branch reverts for Blink, etc...) TBR=kerz git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@204545 0039d316-1c4b-4281-b951-d872f2087c98
-
- 04 Jun, 2013 2 commits
-
-
thakis@chromium.org authored
See the bug for how these were built. The linux binaries were built by thestig@chromium.org. The windows binary was built by scottmg@chromium.org. The mac binary was built by thakis@chromium.org This contains fixes for http://crbug.com/245034 and http://crbug.com/242397 BUG=242397,245034,246734 TBR=scottmg git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@204049 0039d316-1c4b-4281-b951-d872f2087c98
-
hinoka@google.com authored
When a developer runs download_from_google_storage, and they don't have a .boto file, the tool automatically runs "gsutil config" to create one for them. Unfortunately, a side consequence is that if a bot runs the script, and it has a boto file that 403's, then it would run "gsutil config" which moves the .boto to .boto.bak, and creates an empty .boto file. This should not be the intended action. This CL changes so that "gsutil config" is not called, but instead just fails with a message telling the dev to run that command. TBR=maruel@chromium.org Review URL: https://codereview.chromium.org/16072023 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@203824 0039d316-1c4b-4281-b951-d872f2087c98
-
- 03 Jun, 2013 2 commits
-
-
maruel@chromium.org authored
.search() may return results in unexpected order. Manually sort the entries otherwise first_day and last_day could be inversed, leading to negative number of days. R=iannucci@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/16003003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@203792 0039d316-1c4b-4281-b951-d872f2087c98
-
mcgrathr@chromium.org authored
If ~/.gitconfig contains: [diff] renames = "true" then git diff --name-status will produce output that confuses the parsing in svm.GIT.CaptureStatus and git diff will produce output that confuses the patch command on trybots. Passing --no-renames explicitly counteracts this. Review URL: https://chromiumcodereview.appspot.com/16057018 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@203778 0039d316-1c4b-4281-b951-d872f2087c98
-
- 01 Jun, 2013 1 commit
-
-
alancutter@chromium.org authored
76 columns is fine for most patches but reverts will eat another 4 spaces in indentation. For the sake of revert clarity this reference line is reduced to 72 columns. Review URL: https://chromiumcodereview.appspot.com/16152005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@203530 0039d316-1c4b-4281-b951-d872f2087c98
-
- 31 May, 2013 2 commits
-
-
xusydoc@chromium.org authored
BUG=237388 Review URL: https://chromiumcodereview.appspot.com/14583004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@203384 0039d316-1c4b-4281-b951-d872f2087c98
-
alancutter@chromium.org authored
Adds an extra line to the default text description to help judge whether the 76 character recommended limit is being passed. Review URL: https://chromiumcodereview.appspot.com/15670012 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@203314 0039d316-1c4b-4281-b951-d872f2087c98
-
- 30 May, 2013 1 commit
-
-
scottmg@chromium.org authored
This is ninja at 4df15104d532ad91b7a9d3c54985180a6c2f2533. Changes since 1.3.3 include that affect this Windows build: - fixing '-t msvc' to stop lowercasing paths from /showIncludes output - fix a crash in tool target suggestions - error checking on -j. This version is newer than 1.3.3 but --version will say 1.3.0git. Other platforms are staying at 1.3.3. All platforms will re-converge at 1.4.0. R=thakis@chromium.org BUG=242397 Review URL: https://codereview.chromium.org/16232002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@203165 0039d316-1c4b-4281-b951-d872f2087c98
-
- 29 May, 2013 3 commits
-
-
enne@chromium.org authored
R=digit@chromium.org, maruel@chromium.org BUG=244602 Review URL: https://chromiumcodereview.appspot.com/16007008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@202879 0039d316-1c4b-4281-b951-d872f2087c98
-
tyoshino@chromium.org authored
TEST=tests/git_cl_test.py Review URL: https://chromiumcodereview.appspot.com/15650014 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@202865 0039d316-1c4b-4281-b951-d872f2087c98
-
rogerta@chromium.org authored
git_cl.py script. See http://goo.gl/JGg0Z for details. BUG=None Review URL: https://chromiumcodereview.appspot.com/14793006 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@202864 0039d316-1c4b-4281-b951-d872f2087c98
-