- 27 Apr, 2022 9 commits
-
-
Takuto Ikuta authored
This is to prevent revert like https://crrev.com/c/3607513 Bug: 1317620 Change-Id: I6ab7aba5f92719bd573d22d90358f58e48aeb10c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3607514Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
-
Bruce Dawson authored
The files_to_skip lists in chrome/android/java/src/PRESUBMIT.py were not working on Windows because they didn't use the verbose [\\\/] construct for path separators. Fixing this in FilterSourceFile means that multiple failures may be fixed simultaneously. The only failures that this is known to fix are a set of AlertDialog.Builder errors that were showing up only on Windows. This addresses the issues that were going to be incorrectly fixed in crrev.com/c/3606128 (now abandoned). Bug: 1309977 Change-Id: I7a10483448e00df55e2cbf8bff8bad7a5d8db124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3609117Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8815691911578901441 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/ce1d3684033cc90518019714ed6387a3cbeadc94 ce1d368 (iannucci@chromium.org) [warnings] Omit warnings which are attributed to other recipe r... More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I8e378c342be9b9a9e046e0f87e40563a1824163c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3611408 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Joanna Wang authored
Test: Merged: https://chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/3600858 Created new CL in same branch: https://chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/3609588 Bug: 1312511 Change-Id: I20ccfc978fd84c4c68f71007cf636fc1ee8e3d4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3609115Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Joanna Wang <jojwang@chromium.org>
-
Aravind Vasudevan authored
This is a reland of commit 5e49eda5 Original change's description: > Break make_encoded_file into two functions > > The python3 fallback for `make_encoded_file()` produces different results on py2 and py3 when bytes are passed. This CL makes it clear breaking it into two methods, one for text and another for bytes. This CL also adds a fallback in `download_file` for py3 to return bytes when it cannot decode the downloaded file into utf-8. > > Recipe-Manual-Change: chromiumos > Change-Id: I3d313e430c852e179825bc24bf4a58ce84440b2a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3595026 > Reviewed-by: Gavin Mak <gavinmak@google.com> > Reviewed-by: Greg Edelston <gredelston@google.com> > Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com> Recipe-Manual-Change: chromiumos Change-Id: I2de85eca71cc45f503c25888297ba881a5c662a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3610973Reviewed-by:
Aravind Vasudevan <aravindvasudev@google.com> Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Greg Edelston <gredelston@google.com>
-
Junji Watanabe authored
linux32 is not supported now. Bug: 931218 Change-Id: I753c8e1b0de5126e944d71cd7725e0ed8a4df5d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3609948 Auto-Submit: Junji Watanabe <jwata@google.com> Commit-Queue: Junji Watanabe <jwata@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org>
-
Takuto Ikuta authored
This reverts commit 06b18e4b. Reason for revert: platform is not imported Original change's description: > autoninja: increase parallelism for non-HT cpu > > M1 mac seems to have capacity to build with higher parallelism. > This also remove limit in macOS. > > Bug: 1317620 > Change-Id: I4460915c405cbb27ed977dcee631adb8753f2335 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3596361 > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Junji Watanabe <jwata@google.com> > Reviewed-by: Fumitoshi Ukai <ukai@google.com> > Reviewed-by: Philipp Wollermann <philwo@google.com> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Bug: 1317620 Change-Id: I325d0be8feca28e2f89a9191cfdb01de1f367d86 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3607513 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Owners-Override: Takuto Ikuta <tikuta@chromium.org>
-
Bruce Dawson authored
Bug: 1309977 Change-Id: Ifca6e60c1fb2ff76f6a8dee9129d4d661ba196a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3606733Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
Takuto Ikuta authored
M1 mac seems to have capacity to build with higher parallelism. This also remove limit in macOS. Bug: 1317620 Change-Id: I4460915c405cbb27ed977dcee631adb8753f2335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3596361 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Junji Watanabe <jwata@google.com> Reviewed-by:
Fumitoshi Ukai <ukai@google.com> Reviewed-by:
Philipp Wollermann <philwo@google.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
- 26 Apr, 2022 3 commits
-
-
Takuto Ikuta authored
This is to make the script work even when config file is broken. Change-Id: I6c2a090b01026b5747137bcc9fdec0bd5c03f75e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3607373 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Fumitoshi Ukai <ukai@google.com> Commit-Queue: Fumitoshi Ukai <ukai@google.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8815794460453950289 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/e174a863c115a0f0b292acdaabc2dc817531c14c e174a86 (martiniss@google.com) Add exponential_backoff to the time module. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: Ibf9037526aba87200f64f6ee3229a8c658bdcc87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3608835 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8815795716575896193 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/357b1cd333959e0d6a7670ff92481afe8fbc3b1a 357b1cd (martiniss@google.com) Add timing information option to the test command More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: If433fa0a8a8fab3a20b355c8c8e8c67b3683fee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3608833 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 25 Apr, 2022 3 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8815872476725262353 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/36be9467fd4479eea43fc5bc8ae4043c984cf575 36be946 (iannucci@chromium.org) [python] Deprecate api.python.__call__ More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I5832314968fba170d20fe9219e8eaf354968c070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3606940 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8815879397770455089 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/6345fb20c97d488a7578d0fb58edd9b3a462448a 6345fb2 (chromium-autoroll@skia-public.iam.gserviceaccount.com) Roll CAS Client from 4f40f26f3102 to 2aa3d7e5e866 More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: Ib13f2ec77c610ddbce3fa240012afcf1bb307087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3605846 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Ravi Mistry authored
Tested by: * `python recipes.py test run` * Tested end-to-end by patching in this unsubmitted change in Skia's recipes with https://skia-review.googlesource.com/c/skia/+/532768 Bug: chromium:1319415 Change-Id: Ia1c9c495ef6482b3fdb494e1c1c9320541bcd0c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3602901Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Ravi Mistry <rmistry@chromium.org>
-
- 22 Apr, 2022 3 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8816140493369992641 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/dc013a866f2fd28bccdc390f259995e1004dcdf1 dc013a8 (iannucci@chromium.org) [python] Mark python.inline with a warning More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I432e2d1c10b2a6cabeebe9873e8a09caa9548fe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3603076 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8816144897986979425 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/efaa1e2e3e663d5342ed58bd3fdfc8cde25b6cee efaa1e2 (iannucci@chromium.org) [json] Stop using python.inline. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I3ec21b65013fc137e124da47961b976941833dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3603074 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Aravind Vasudevan authored
This reverts commit 5e49eda5. Reason for revert: chromiumos rollout fails Original change's description: > Break make_encoded_file into two functions > > The python3 fallback for `make_encoded_file()` produces different results on py2 and py3 when bytes are passed. This CL makes it clear breaking it into two methods, one for text and another for bytes. This CL also adds a fallback in `download_file` for py3 to return bytes when it cannot decode the downloaded file into utf-8. > > Recipe-Manual-Change: chromiumos > Change-Id: I3d313e430c852e179825bc24bf4a58ce84440b2a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3595026 > Reviewed-by: Gavin Mak <gavinmak@google.com> > Reviewed-by: Greg Edelston <gredelston@google.com> > Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com> Change-Id: Ibfb51614f9e19b575b99704aa4ca33c5525ab294 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3602168 Auto-Submit: Aravind Vasudevan <aravindvasudev@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
-
- 21 Apr, 2022 1 commit
-
-
Aravind Vasudevan authored
The python3 fallback for `make_encoded_file()` produces different results on py2 and py3 when bytes are passed. This CL makes it clear breaking it into two methods, one for text and another for bytes. This CL also adds a fallback in `download_file` for py3 to return bytes when it cannot decode the downloaded file into utf-8. Recipe-Manual-Change: chromiumos Change-Id: I3d313e430c852e179825bc24bf4a58ce84440b2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3595026Reviewed-by:
Gavin Mak <gavinmak@google.com> Reviewed-by:
Greg Edelston <gredelston@google.com> Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
-
- 19 Apr, 2022 5 commits
-
-
Bruce Dawson authored
Header guards are checked by CheckForIncludeGuards which has broader coverage than cpplint.py and should therefore be preferred. Having two include-guard checkers that cover different sets of files and use different tags to silence warnings is just confusing. Bug: 1309977 Change-Id: Ic0d1ad610cf9c34d6777d852da2e2e22b8686552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3587725Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
Bruce Dawson authored
When running "git cl presubmit --all" some of the presubmit messages were ending up double-spaced if the output is sent to a file and then loaded into notepad or Visual Studio. Visual Studio would complain about inconsistent line endings, and it turns out that this was all caused by some lines having \r\r\n line endings - notepad and Visual Studio interpret that as two line endings. The problem is that the stream that WinUnicodeOutput writes to does \n to \r\n translation. If the text being printed already has \r\n line endings then we get doubled-up \r characters. The fix is to replace all \r\n sequences with \n before calling write. This reduces the line count of the output by almost 2300 lines (more than 25% of the total) and makes it much more readable. Bug: 1309977 Change-Id: Ie5475087badc3d3146e4f2ba41d30c9817dd375a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3589498Reviewed-by:
Aravind Vasudevan <aravindvasudev@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
Ryan Heise authored
Bug:1067587 Change-Id: I3f79af6a83a8c3622a450e4526438777223a64e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3594241Reviewed-by:
Joanna Wang <jojwang@chromium.org> Reviewed-by:
Aravind Vasudevan <aravindvasudev@google.com> Commit-Queue: Ryan Heise <heiserya@google.com>
-
Bruce Dawson authored
I feel like a PRESUBMIT owner now and this makes it official. Bug: 1309977 Change-Id: I38356bc52c8d03d93c4ec42e4952b5872b31a79a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3589901Reviewed-by:
Aravind Vasudevan <aravindvasudev@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
Bruce Dawson authored
presubmit --all tells the presubmit system that all files are 'modified' but ChangedContents still goes off to see what changes are present. If most files were unchanged this was all handled perfectly, but if _all_ files were unchanged then _GitDiffCache would interpret the empty dictionary of changes as a reason to ask git for diffs, millions of times. This made some checks take more than 100x as long. The overall effect on presubmit --all time is not known because I was never willing to wait the multiple days for them to terminate. That is, this would take many days to run: git checkout -b empty -t origin/main git cl presubmit --all whereas a single-character change to any file would let this run in about two hours. After three weeks of working on presubmits I only hit this twice which is why it took me so long to realize what the problem was. Bug: 1309977 Change-Id: Ib280ea386107843b9174d835b0895316a5ed240c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3589900Reviewed-by:
Aravind Vasudevan <aravindvasudev@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
- 18 Apr, 2022 1 commit
-
-
David Dorwin authored
depot_tools version of https://crrev.com/c/3526975. Change-Id: I9c46525322ebfa36ebde67bb5fe00249cdf51fca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3591072Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Aravind Vasudevan <aravindvasudev@google.com>
-
- 15 Apr, 2022 1 commit
-
-
Bruce Dawson authored
When CheckLongLines finds problems it prints the first five, but this gives no indication as to whether there are just five, or hundreds. This change prints the number of long lines found. The snapshot function in PanProjectChecks prints the elapsed time for long checks, however it has two issues that make it inconvenient. One is that it prints the time in ms which sounds great until you get a warning that one of the checks is taking 2041373 ms (not kidding, although now fixed) which is tricky to read. The other problem is that it was actually measuring CPU time, not wall-clock time. This changes it to print the time in seconds (to 0.1 seconds) and to measure elapsed time. Bug: 1309977 Change-Id: I7564a8cdf7bb3349b10ebbddbfe179188d4bf309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3587726Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
- 14 Apr, 2022 5 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8816874699072805217 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/22391916f2fa18a9e24df64968c6f3133f42238c 2239191 (gbeaty@chromium.org) Prevent spurious GitFetchErrors in CommitList.from_backend. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I1f252e93fa21eff467a07dea0a74ed20458a41ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3587404 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8816875963485349249 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/e783f88f68a7c91a776a24729b942979727c825d e783f88 (chanli@chromium.org) [recipe-py] (2 attempt) buildbucket: set `luci.buildbucket.pare... More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I277b6a32a528dc3d1fd8fe8237f6ada9c61c8f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3587403 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8816888547939077841 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/d63eb67ccf0e759735a9993af3e6a0e88dfe9282 d63eb67 (chanli@chromium.org) Revert "[recipe-py] buildbucket: set `luci.buildbucket.parent_t... More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: If35beef29b7264610b3414c8c3af7afc77b5ba62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3587286 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Fumitoshi Ukai authored
Bug: b/227978974 Change-Id: Ic339add74c112798322e0b9682c19aa2fa91e938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3581947Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@google.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8816954607693384897 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/048f6f2fbb02fee8e69db6d41269c1f3b037403f 048f6f2 (chanli@chromium.org) [recipe-py] buildbucket: set `luci.buildbucket.parent_tracking`... More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I8cdd9dda8c4160dfb399b59b3d41b12d216bc8be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3581205 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 13 Apr, 2022 1 commit
-
-
Bruce Dawson authored
After optimizing CheckForIncludeGuards the CheckLicense presubmit was the second slowest presubmit, taking about 35 minutes when run as part of "git cl presubmit --all". The cause of its slowness was initially non-obvious because it runs quite quickly on most files, however analysis showed that it could take 50+ seconds on some files. The files that it is slow on are those that lack a good license header, meaning that the regex match has to painstakingly scan the entire file. The optimization in this change is to recognize that there is a simple non-regex line that appears in all valid license headers, regardless of variants. If that line is absent then there is, necessarily, no valid license header, and searching for a line of text is something that Python can do extremely quickly. This change drops the CheckLicense time from about 35 minutes to about 32 seconds. Trivia: _CommonChecks in third_party/blink/PRESUBMIT.py passes .* as the license, so I added an early-out for that to avoid pointlessly scanning those files. Bug: 1309977 Change-Id: Ic2e56079675c2c5a2643d20dd492b1cc52e4ead2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3584882Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
- 12 Apr, 2022 1 commit
-
-
Garrett Beaty authored
This is a reland of commit 05381726 The change was not related to the errors that it was reverted for, so no changes are necessary. Original change's description: > Set a default got_revision property in the bot_update json output. > > The bot_update.py script sets a got_revision property by default even if > it is not present in the reverse revision mapping. This results in an > uncaught exception when set_output_commit is set to True if got_revision > isn't present in the reverse revision mapping, but it isn't caught until > production because the test API doesn't match that behavior. This change > updates the test API method to match the behavior of the script. > > Recipe-Nontrivial-Roll: build > Recipe-Nontrivial-Roll: build_limited > Recipe-Nontrivial-Roll: chromiumos > Recipe-Nontrivial-Roll: infra > Change-Id: Ideefa9d77d2a816ae66a2bb52737264ed3f5bcee > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3575361 > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Commit-Queue: Garrett Beaty <gbeaty@google.com> > Auto-Submit: Garrett Beaty <gbeaty@google.com> Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: I80efeee8a2b951df43b00d89bb596dc2cf2fcec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3582182Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@google.com>
-
- 11 Apr, 2022 1 commit
-
-
Eduardo Yap authored
Bug: chromium:1314669 Change-Id: Id411b66bf3f1a8d3c23cb2827525dd1f21aa296a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3582180 Auto-Submit: Eduardo Yap <eduardoyap@google.com> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
-
- 08 Apr, 2022 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. The build that created this CL was https://ci.chromium.org/b/8817421433491348977 recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/0f5f374af06ce6c30708b36fd2545668dff22ad7 0f5f374 (alexschulze@chromium.org) [cipd] Fix `instances` command with limit = 0 More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Ignore-Freeze: Autoroller Bugdroid-Send-Email: False Change-Id: I091805fddb573d78b830f1e33c31e344e5225863 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3579841 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Josip Sokcevic authored
This reverts commit 05381726. Reason for revert: we reverted got_revision change, and this change itself may be causing some other failues. Original change's description: > Set a default got_revision property in the bot_update json output. > > The bot_update.py script sets a got_revision property by default even if > it is not present in the reverse revision mapping. This results in an > uncaught exception when set_output_commit is set to True if got_revision > isn't present in the reverse revision mapping, but it isn't caught until > production because the test API doesn't match that behavior. This change > updates the test API method to match the behavior of the script. > > Recipe-Nontrivial-Roll: build > Recipe-Nontrivial-Roll: build_limited > Recipe-Nontrivial-Roll: chromiumos > Recipe-Nontrivial-Roll: infra > Change-Id: Ideefa9d77d2a816ae66a2bb52737264ed3f5bcee > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3575361 > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Commit-Queue: Garrett Beaty <gbeaty@google.com> > Auto-Submit: Garrett Beaty <gbeaty@google.com> Change-Id: Ie975dfe39e7b8997336761e12f53f3046359d825 Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3578820 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
-
- 07 Apr, 2022 4 commits
-
-
Josip Sokcevic authored
If a user has git for x64, `git cl` results in downloading x64 cipd packages. Other operations, such as gclient or git-cl will result in downloading arm64. This flip-flopping between architectures causes unexpected behavior: (1) slows down commands since packages are wiped and new ones are downloaded. (2) long running processes, such as goma may crash. This change adds additional check for all macs running on x86 to check if is running under Rosetta and sets ARCH=arm64 if true. R=bryner@google.com, masonf@chromium.org Bug: 1311733 Change-Id: I65b127467d5c47d5bf07952d2ecdcb93630c7c87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3573068Reviewed-by:
Brian Ryner <bryner@google.com> Reviewed-by:
Mason Freed <masonf@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
-
Garrett Beaty authored
The bot_update.py script sets a got_revision property by default even if it is not present in the reverse revision mapping. This results in an uncaught exception when set_output_commit is set to True if got_revision isn't present in the reverse revision mapping, but it isn't caught until production because the test API doesn't match that behavior. This change updates the test API method to match the behavior of the script. Recipe-Nontrivial-Roll: build Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: chromiumos Recipe-Nontrivial-Roll: infra Change-Id: Ideefa9d77d2a816ae66a2bb52737264ed3f5bcee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3575361Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Garrett Beaty <gbeaty@google.com> Auto-Submit: Garrett Beaty <gbeaty@google.com>
-
Jack Neus authored
This reverts commit ffeef900. Reason for revert: Breaks ChromeOS builders, e.g. go/bbid/8817528282713702353 Original change's description: > bot_update: change set_output_commit to True by default > > This is for https://crbug.com/1310066#c7 > > Bug: 1310066 > Change-Id: I874e1a4c2ca53a7da04d6c24533429d7508088a8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3565259 > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Reviewed-by: Josip Sokcevic <sokcevic@google.com> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Recipe-Nontrivial-Roll: infra Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: build Bug: 1310066 Change-Id: Id6b32f71ba8824ad3e748d0b52603ea1548096e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3575359 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@google.com> Owners-Override: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
-
Yannic Bonenberger authored
Follow-up on https://crrev.com/c/3569027 Change-Id: I4b7830c83939d8a75cde7cae9001e89cf68f0d79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3575946Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Yannic Bonenberger <yannic.bonenberger@gmail.com>
-