Skip to content

C
Chromium_Depot_tools
Switch branch/tag
  1. 14 Mar, 2018 2 commits
  3. 13 Mar, 2018 2 commits
  5. 12 Mar, 2018 2 commits
  7. 08 Mar, 2018 1 commit
  9. 07 Mar, 2018 2 commits
  11. 06 Mar, 2018 4 commits
  13. 03 Mar, 2018 1 commit
  15. 28 Feb, 2018 1 commit
  17. 27 Feb, 2018 3 commits
  19. 26 Feb, 2018 1 commit
  21. 23 Feb, 2018 1 commit
  23. 22 Feb, 2018 3 commits
  25. 21 Feb, 2018 3 commits
  27. 20 Feb, 2018 2 commits
  29. 16 Feb, 2018 1 commit
    • Alexander Alekseev's avatar
      Override temporary directory before spawning subprocess. · 3ade6e12
      Alexander Alekseev authored 
      Python multiprocessing is using sockets to communicate. UNIX socket names are
bound by PATH_MAX which includes temporary directory name.

gsutil uses multiprocessing, which creates file sockets in the tmpdir.
On some testing configurations, the tmpdir is set to a very long path, which
causes gsutil to fail with AF_UNIX path too long errors.

To prevent multiprocess failures, this CL overrides temporary directory
dictated by the environment to /tmp.

Bug: 812581
Change-Id: Idcd99d13b2e20b3095111fa26ec4e242848c8848
Reviewed-on: https://chromium-review.googlesource.com/923170Reviewed-by: 's avatarRyan Tseng <hinoka@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
      3ade6e12
  31. 13 Feb, 2018 3 commits
    • Bruce Dawson's avatar
      Fix autoninja && chrome on failed builds · 46541b49
      Bruce Dawson authored 
      A handy usage pattern for autoninja.bat that I was not aware of is to go

    autoninja -C out\Default chrome && chrome

This will build chrome and then run it, but only run it if the build
succeeds. The addition of post_build_ninja_summary.py broke this by
losing the error code. This change fixes it by using black magic to
set an error code in the failure case.

Bug: chromium:787983
Change-Id: Ib87fd1799816e19d56de76e08e0f9688be903d80
Reviewed-on: https://chromium-review.googlesource.com/916705Reviewed-by: 's avatarDirk Pranke <dpranke@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
      46541b49
    • Bruce Dawson's avatar
      Update post_build_ninja_summary.py for Linux · e186e50d
      Bruce Dawson authored 
      post_build_ninja_summary.py gives a summary of a ninja build. It can be
run standalone or it can be run automatically by autoninja. This CL
updates the Python script and the autoninja bash script to make this
work on Linux. This includes removing a zero-value assert, and ensuring
that .so files get categorized as such.

Change-Id: I2d59ab129f5ce70117beeb119719f8432bfbab7c
Reviewed-on: https://chromium-review.googlesource.com/915053Reviewed-by: 's avatarDirk Pranke <dpranke@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
      e186e50d
    • Aaron Gable's avatar
      gclient: diff against hash in DEPS · 1853f66e
      Aaron Gable authored 
      When someone runs "gclient diff", they expect to be diffing their
local state against the state of a clean gclient checkout.

Up until now, "gclient diff" has been doing... not that. It's been
assuming that the sha1 in DEPS is approximately the head of the
remote's master branch, finding the merge-base between the local
content and that remote master, and diffing against that merge-base.
This makes basically no sense in the context of gclient. With
gclient, we already know exactly what should be checked out: it's
whatever is in DEPS.

This CL updates the behavior of "gclient diff" to do the right thing.

Bug: 731701
Change-Id: I23a43cbc0d6bc7772495097ff615d4d070f5ad19
Reviewed-on: https://chromium-review.googlesource.com/914717Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
      1853f66e
  33. 12 Feb, 2018 4 commits
  35. 09 Feb, 2018 3 commits
    • Aaron Gable's avatar
      Remove similarity support from git-cl · 13101a6e
      Aaron Gable authored 
      The purpose of this CL is to remove confusion around whether or
not git-cl support the similarity flags when talking to Gerrit.
It does not. However, because Rietveld support has not been
fully ripped out of git-cl, this change does modify some of the
Rietveld-specific code to remove similarity support from everywhere.

Bug: 800902
Change-Id: I8703ed60d6889c7a36400b8a9f8f26de4669020a
Reviewed-on: https://chromium-review.googlesource.com/912389Reviewed-by: 's avatarAndrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
      13101a6e
    • Bruce Dawson's avatar
      Script to summarize performance of ninja builds · ffc0c7c6
      Bruce Dawson authored 
      post_build_ninja_summary.py analyzes the .ninja_log file in an output
directory to summarize build performance. It lists the most expensive
build steps, and build-step types, printing both their elapsed time and,
more importantly, their "weighted" time which is a measure of their
contribution to the total build time.

For each time segment within the build the running build steps
accumulate weighted time that is proportional to the elapsed time
divided by the number of tasks running. If a thousand compilation steps
are running in parallel then they will each be "charged" for 1/1,000th
of the elapsed time. If a single link step is running alone then it is
charged with all of the elapsed time.

Bug: chromium:787983
Change-Id: Id5aea715f798a16415dd0365a27f0051202668e5
Reviewed-on: https://chromium-review.googlesource.com/871988Reviewed-by: 's avatarDirk Pranke <dpranke@chromium.org>
Reviewed-by: 's avatarErik Staab <estaab@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
      ffc0c7c6
    • Torne (Richard Coles)'s avatar
      Don't fetch tags when using --no-history. · 08ca04b2
      Torne (Richard Coles) authored 
      After the initial gclient sync, "fetch --no-history" was adding a
fetchspec to the config for the main repository that causes all tags to
be downloaded in future. This means that after fetching a repository
with no history, the very next git pull (or other remote update
operation) will download all the tags, including all the history
referred to by those tags, leaving you with an almost-complete checkout
of the top-level repository that takes up much more space.

Fix this by skipping the "git config" command that requests the tags
when using no-history.

Change-Id: Ia31baa6a90df014ebc1e8c2ed6e05de3ad27d415
Reviewed-on: https://chromium-review.googlesource.com/909653Reviewed-by: 's avatarAaron Gable <agable@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
      08ca04b2
  37. 08 Feb, 2018 1 commit