- 03 Mar, 2021 2 commits
-
-
Dirk Pranke authored
The python_bin_reldir.txt path to find the python2 binary will contain backslashes instead of forward slashes on Windows, so this tweaks the wrapper in //python2-bin/python2 to handle that and start working under msys. Bug: 1168365 Change-Id: If0876054f0a73c9a53a1eb23ea03c60c1e756c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2729410 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Josip Sokcevic <sokcevic@google.com>
-
Josip Sokcevic authored
Change-Id: I89fe5184e13040ced6e016433db42093223be0a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2730056 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
- 02 Mar, 2021 10 commits
-
-
Josip Sokcevic authored
This updates local reference to origin/HEAD, which is necessary for new-branch to work as expected. R=ehmaldonado@google.com Change-Id: Ia620b3b01c0ad23bb4e969f9026fa6bcfdd88b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2730051 Commit-Queue: Josip Sokcevic <sokcevic@google.com> Auto-Submit: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
Edward Lesmes authored
code-owners plugins wants a git ref in Gerrit (e.g. refs/heads/master) while Depot Tools wants a local git ref (e.g. refs/remotes/origin/main, or a git hash). Add an upstream parameters to be used by Depot Tools, separate from a Gerrit ref expected by owners_client. Change-Id: Ieed97a186e3140b3f82830efa189dbe3e4d8c806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2730049 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Josip Sokcevic <sokcevic@google.com>
-
Bruce Dawson authored
If autoninja.py detects that goma is not running when it should be then it prints 'cmd /c exit 1' as the command to be run. This ensures that errorlevel will be set so that the failure will be detected. Unfortunately this doesn't work when running autoninja from git bash. Instead of launching a cmd.exe instance which immediately exits, it launches a cmd.exe instance which the user must manually exit. This change adds quotes so that this works from git bash (which invokes the shell script) as well as from cmd.exe (invoking the batch file). Bug: 868590 Change-Id: I482f22830f9bd4f7b70c51de9647a70d946ec145 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2726085Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Owners-Override: Bruce Dawson <brucedawson@chromium.org> Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com>
-
Josip Sokcevic authored
This reverts commit 2cf835a9. Reason for revert: doesn't work with depot_tools error 404 Not found: tools (with applied patch from 2729404) Bug: 1183975 Original change's description: > presubmit: Skip owners checks if code-owners plugin is enabled. > > If code-owners plugin is enable for the repo, skip owners check on > commit, and skip checking owners format, as that will be done by > the plugin. > > Change-Id: I1663baef4f0f27b00423071343fe740f6da50ce7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2727131 > Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Gavin Mak <gavinmak@google.com> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Change-Id: Id4d560701e4b0144e0aafc5263e09ed6927f6222 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2729409 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
-
Josip Sokcevic authored
This reverts commit 70405c2f. Reason for revert: doesn't work with depot_tools error 404 Not found: tools Bug: 1183975 Original change's description: > presubmit: Fix checking if code-owners enabled for repo. > > Change-Id: I22e6a9d4405d92d26dfbfba64735b6e9ce92674c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2729404 > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > Commit-Queue: Josip Sokcevic <sokcevic@google.com> > Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Josip Sokcevic <sokcevic@google.com> Change-Id: Ib358f31e7c4c6fc07f98db4758004097234eaa87 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2729408 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
-
Dirk Pranke authored
The python3_bin_reldir.txt path to find the python binary will contain backslashes instead of forward slashes on windows, so this tweaks the wrapper in //python-bin/python3 to handle that and start working under msys. Bug: 1168365 Change-Id: I0c83f36f48f229276803c2e5d73ec86ecb55ada1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2721367Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com>
-
Edward Lesmes authored
Change-Id: I22e6a9d4405d92d26dfbfba64735b6e9ce92674c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2729404 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Josip Sokcevic <sokcevic@google.com>
-
Edward Lesmes authored
If code-owners plugin is enable for the repo, skip owners check on commit, and skip checking owners format, as that will be done by the plugin. Change-Id: I1663baef4f0f27b00423071343fe740f6da50ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2727131 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/dbdb4601a494804eaf83d06b6bb18c94e5f776c9 dbdb460 (gbeaty@chromium.org) Update the version of attrs used in recipe engine. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I5f580b2ef32f53a2cda447c02d48a3b7ae48db62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2729401 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Edward Lesmes authored
We have to use refs/remotes/origin/foo instead of refs/heads/foo, as refs/heads/foo might not be defined. https://logs.chromium.org/logs/infra-internal/buildbucket/cr-buildbucket.appspot.com/8853851694141987488/+/u/build/git_cl_upload/stdout Change-Id: Ic729510d7beca63c25ea84394758cb62f76c572f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2729615 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Josip Sokcevic <sokcevic@google.com>
-
- 01 Mar, 2021 7 commits
-
-
Edward Lesmes authored
Change-Id: Iaca829ed8af6d040bbd588aeb1ec9a021594d705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2728130 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
Edward Lesmes authored
Bug: 1183447 Change-Id: I11c67b13ace08eb5bafb90756bd45af6ff39f12f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2727569 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/653da17a19d3fd054c7811afc9a83a4cfc7a6c58 653da17 (iannucci@chromium.org) [engine] Improve recipe engine behavior in cancelation/timeout... More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I9a9e715fa2e8046221cf290f201a665c84b8deb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2727014 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
John Budorick authored
Matching chromium. (I'm sure this is asking for trouble.) Bug: chromium:1007101 Change-Id: Iba3200bd093697f41551c99f58a9c5261c958436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2726729Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: John Budorick <jbudorick@chromium.org>
-
Edward Lesmes authored
Will be used in a follow-up CL to initialize code-owners client. Recipe-Nontrivial-Roll: build Change-Id: Iefe9176320b4d1ae7715e88a8db132e815be76ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2717979 Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Gavin Mak <gavinmak@google.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/c5b9437ca18dd89b247ab4115e0a1d5530f1b7ac c5b9437 (tikuta@chromium.org) runtime: fix comment of experiments field usage More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I10475fdc3be031fd646feebaaf813466a13c5b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2727568 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Mike Frysinger authored
Debian is deleting /usr/bin/python by default, so re-use the existing python3 interp that our wrapper was invoked with. Bug: 1182059 Test: `./repo` still works w/out /usr/bin/python Change-Id: I1806f2ae2f8c6fe8b5f5a95fd2e50735d6e3196a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2715994Reviewed-by:
Michael Mortensen <mmortensen@google.com> Commit-Queue: Mike Frysinger <vapier@chromium.org>
-
- 27 Feb, 2021 1 commit
-
-
Bruce Dawson authored
This reverts commit 428143ee. Reason for revert: Fixing the issues revealed by the original change by avoiding python3 and by checking for the existence of gomacc[.exe] before running it. This also relands 2241db8a - "Avoid capture_output to support Python 3.6", to simplify relanding and any possible reverts. Original change's description: > Revert "Check whether goma is running when it is enabled" > > This reverts commit b7ddc5a0. > > Reason for revert: > This broke the builder where depot_tools is not in PATH. > https://logs.chromium.org/logs/infra-internal/buildbucket/cr-buildbucket.appspot.com/8858077852309878080/+/u/build/stdout > > Original change's description: > > Check whether goma is running when it is enabled > > > > One of the mistakes one can make when running ninja is having goma > > enabled (use_goma=true in args.gn) but not having goma running. This can > > lead to ~1,000 failed compile steps, which is messy. > > > > This change teaches autoninja.py to check whether goma is running. If > > not then it tells autoninja to just print a warning message. The > > check costs roughly 30 ms which seems reasonable. > > > > In fact, because this change also switches away from vpython (necessary > > to use python3 to use subprocess.run) it actually runs about 600 ms > > _faster_ than before this change. > > > > If build acceleration is requested through use_rbe then no checking for > > whether the service is running is done. That could be added in the > > future. > > > > autoninja.py could auto-start goma but that is error prone and has > > limited additional value. > > > > This was tested on Linux, OSX, and Windows. > > > > Bug: 868590, b/174673874 > > Change-Id: Ie773e574878471e5136b9b82d52f86af3d848318 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2627014 > > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> > > TBR=yyanagisawa@google.com,dpranke@google.com,brucedawson@chromium.org,sanfin@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com > > Change-Id: I57a6c73ea853259f3d1ec7ad0ce51e495acc96db > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 868590 > Bug: b/174673874 > Bug: 1167064 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2632018 > Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> > Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> TBR=yyanagisawa@google.com,dpranke@google.com,brucedawson@chromium.org,sanfin@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because this is a reland. Bug: 868590 Bug: b/174673874 Bug: 1167064 Change-Id: I8aa6830259bc18f8e7926cd0bf5c62e671c74a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2634201Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Fumitoshi Ukai <ukai@google.com> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
-
- 26 Feb, 2021 2 commits
-
-
Takuto Ikuta authored
This is for python3 compatibility. Bug: b/177465438 Change-Id: I4770136ea702bcaf7a8b644ef842db2f1a7d1200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2717272Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Chris Hall <chrishall@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/a5ac18a9966dab7f09069ede9ec3128547535882 a5ac18a (iannucci@chromium.org) [StepPresentation] Replace spaces in urls with %20. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I13c8ffc26838f3c1b2ed8c6eb619dadf341a012e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2720710 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 25 Feb, 2021 2 commits
-
-
Gavin Mak authored
Bug: 1180316 Change-Id: I8390f72d8a6cd1044ce10b7cbd4573a004a9730c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2705614Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Gavin Mak <gavinmak@google.com>
-
Stephen Martinis authored
This reverts commit 7a67bca6. Reason for revert: Probably broke chromium presubmit, see https://ci.chromium.org/ui/p/chromium/builders/try/chromium_presubmit/1152280/overview Original change's description: > Use GetCodeOwnersClient in presubmit_support > > This change also adds a target_ref flag to presubmit_support.py. > > Recipe-Nontrivial-Roll: build > Change-Id: I6de6bb87fc1482b88d9fbebe5e4ad1dbd8ce9748 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2702792 > Commit-Queue: Gavin Mak <gavinmak@google.com> > Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org> > Reviewed-by: Josip Sokcevic <sokcevic@google.com> Change-Id: I2cca469f14194f65306baab7928ddddd48033a3b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2718691 Auto-Submit: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
-
- 24 Feb, 2021 5 commits
-
-
Gavin Mak authored
This change also adds a target_ref flag to presubmit_support.py. Recipe-Nontrivial-Roll: build Change-Id: I6de6bb87fc1482b88d9fbebe5e4ad1dbd8ce9748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2702792 Commit-Queue: Gavin Mak <gavinmak@google.com> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Josip Sokcevic <sokcevic@google.com>
-
Vadim Shtayura authored
To switch a depot_tools installation to use mac-arm64 binaries, run: $ cd depot_tools $ echo "mac-arm64" > .cipd_client_platform $ ./cipd help $ <observe "infra/tools/cipd/mac-arm64" in the version string> Deleting .cipd_client_platform file restores the original logic (which is currently to use mac-amd64 binaries even on arm64 host). R=iannucci@chromium.org, tandrii@chromium.org CC=thakis@chromium.org BUG=1102967 Change-Id: I0248fd913eb3d71f2a228f74a601dc4b12fc8824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2699692 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Robbie Iannucci <iannucci@chromium.org>
-
Vadim Shtayura authored
All packages except mac-amd64 ones are built with go1.16. mac-amd64 are built with go1.15, to preserve OSX 10.10/10.11 compatibility. Note that we still use mac-amd64 even on arm64 OSX, since the bootstrap script still installs mac-amd64 version of CIPD. R=iannucci@chromium.org, tandrii@chromium.org BUG=1102967 Change-Id: I8fdb27397fbbf238fe39e81305d4642a0500ab33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2699690 Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com>
-
Dean Michael Berris authored
This is an early version of the `pinpoint` client for starting Telemetry A/B experiments. R=nodir@chromium.org Change-Id: Iff11f8a16f93172cf71d9f76b02c27bd3b659111 Bug: chromium:1175615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2703000 Auto-Submit: Dean Berris <dberris@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/36be9321286d722ffe115419dd42227c65e1a894 36be932 (iannucci@chromium.org) [recipe_engine] Supress CryptographyDeprecationWarning on proce... More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org, jessiciahmendez7@gmail.com, kwalsh0413@gmail.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: I0242b0f4b3acb4784ac64e34ff98287b3462e3b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2716780 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
- 23 Feb, 2021 4 commits
-
-
Bruce Dawson authored
I rely on VsChromium for code search in Chromium and in depot_tools, so it is appropriate to ignore its configuration file in both places. Change-Id: I4481d565e2271d86f69ceb98037b9ace908bdf44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2715832 Commit-Queue: Gavin Mak <gavinmak@google.com> Auto-Submit: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Gavin Mak <gavinmak@google.com>
-
Owen Rodley authored
While I'm here, change to a more concise way of spelling the platform string. Bug: 1179513 Change-Id: Ibb9bd69fb00e66332f8af73154f4615c20efb2b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2703228 Auto-Submit: Owen Rodley <orodley@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Edward Lesmes <ehmaldonado@chromium.org>
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/f9ea671f521a63386be7e57a91d4d59ff6d42bac f9ea671 (orodley@chromium.org) Upgrade the cryptography wheel for recipes-py. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=iannucci@chromium.org, jdiez@google.com, linax.c.wang@intel.corp-partner.google.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: If444f46cb7f5928f68a930b46b13ef60303f72fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2716086 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Michael Moss authored
In the current pylint handling, the only way to use an alternative config is to explicitly pass it with the "--rcfile" flag, which is confusingly inconsistent with normal pylint config file resolution. This change allows local pylintrc files or PYLINTRC env var to override the default depot_tools config, which is often desirable to enforce different style guidelines for different projects. For reference, the config file search order[1] is: 1) File specified by the "--rcfile" flag 2) pylintrc in the CWD 3) .pylintrc in the CWD 4) first pylintrc found up the python module hierarchy, if CWD is in a module hierarchy 5) $PYLINTRC env var 6) $HOME/.pylintrc 7) $HOME/.config/pylintrc 8) /etc/pylintrc (or equivalent on other platforms) - 1-5 will take precedence over the new depot_tools default. - If there is no match for 1-5 and there is no PYLINTRC env var, depot_tools will set PYLINTRC to its default and that will be used. - If there is no match for 1-5 and the PYLINTRC env var is empty, then it will fall through to 6-8. [1] Newer pylints have additional options, but these are the options, and the order, common to all versions of depot_tools pylint. Change-Id: Ib725b15bb639dc9c7cb9009fd3b504124e0c1f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2708749Reviewed-by:
Mike Frysinger <vapier@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Michael Moss <mmoss@chromium.org>
-
- 22 Feb, 2021 1 commit
-
-
Jacob Kopczynski authored
Includes all footers used by the recipe. Other footers used only by presubmit hooks not included. Bug: chromium:1079219 Change-Id: I9c351bda158bc7c1e64a8254feb7055dc31fb6db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2707709 Auto-Submit: Jacob Kopczynski <jkop@chromium.org> Commit-Queue: Jacob Kopczynski <jkop@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com>
-
- 19 Feb, 2021 2 commits
-
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (recipe_engine) into this repository. recipe_engine: https://chromium.googlesource.com/infra/luci/recipes-py.git/+/7df78d5270944a9c191c5939d61e41cb06183638 7df78d5 (tandrii@google.com) Update luci-go protos. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug. R=gatchun85@gmail.com, iannucci@chromium.org, raytarquainanderson@gmail.com Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Change-Id: Ic21d5a83ea1a0a65963c0fcb66c762a063f59638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2707703 Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
-
Edward Lesmes authored
Change-Id: I94d7b3cdc17651a6fe5dafa261c58f46f37b8439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2693919 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
- 18 Feb, 2021 2 commits
-
-
Bruce Dawson authored
When using "git cl patch -b branch_name issue_number" to resolve merge conflicts in an uploaded CL the cherry-pick stage will probably fail due to the expected merge conflicts. If you resolve the conflict and then upload the now-merged CL you will actually create a new CL. This happens because the SetIssue step is skipped when the cherry-pick fails. This change sets the issue whenever a new branch is created. This is safe (the new branch is not being used for anything else) and will improve the situation in many cases. crrev.com/c/2636593 is an example of a CL that was accidentally uploaded as new when it was just supposed to be a resolving of merge conflicts on an existing CL. This change was manually tested with crrev.com/c/2107132. Change-Id: Icb5b8e38feb6f0fa4a007d3924c4d69d2ee4937c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2638979 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Gavin Mak <gavinmak@google.com>
-
Antonio Sartori authored
This change makes git map-branches a little bit faster by avoiding fetching the revision list of each branch if git map-branches will not show the tracking info anyway. Change-Id: I47458871f904004f910aadd7d774bea5193c979e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2695393Reviewed-by:
Anthony Polito <apolito@google.com> Commit-Queue: Antonio Sartori <antoniosartori@chromium.org>
-
- 17 Feb, 2021 2 commits
-
-
Edward Lesmes authored
Change-Id: I6a74971878e5a1abaf6d8f5db20d0387c1abf308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2701392 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Reviewed-by:
Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Gavin Mak <gavinmak@google.com> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
-
Chan Li authored
To include change https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/2701154 Bug: 1179373 Change-Id: I1d028053c642eeb445aa1b8f205a6dabb66d1373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2702531 Auto-Submit: Chan Li <chanli@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
-