Commits · 2acf4957984643d8ac1a856afed0730c4449e190 · Linshizhi / Chromium_Depot_tools

26 Apr, 2018 1 commit

Revert "bot_update: Patch on gclient by default." · 2acf4957

Edward Lesmes authored Apr 26, 2018

This reverts commit 355b11a3.

Reason for revert:
Easier to do this another way that doesn't cause expectation changes,
so it doesn't require non-trivial rolls.

Original change's description:
> bot_update: Patch on gclient by default.
> 
> See [4] for the design doc for this change.
> 
> We're moving the patching logic from bot_update to gclient.
> This way we can test patches of dependencies that modify their DEPS
> files as well, for example when ANGLE uploads a patch that modifies
> DEPS files to be tested by a Chromium trybot.
> 
> Chromium Linux CQ and Angle trybots are already running this way
> (see [1] and [2]) and a PSA has already been sent [3]
> 
> [1] https://chromium.googlesource.com/chromium/src/+/master/infra/config/global/cr-buildbucket.cfg#214
> [2] https://chromium.googlesource.com/angle/angle/+/infra/config/cr-buildbucket.cfg#105
> [3] https://groups.google.com/a/google.com/forum/#!topic/chrome-infra/FVHN2kdUX4I
> [4] https://docs.google.com/document/d/1GSTw4ysm5AYjNR6vMA7NJUxLK2VN9IpOEp_v0u-wyOE/edit?ts=5ad78165#
> 
> Bug: 643346
> Change-Id: Ic9a9dcfae86aca730d35fbb26c26b21135e05bf3
> Recipe-Nontrivial-Roll: skia
> Recipe-Nontrivial-Roll: infra
> Recipe-Nontrivial-Roll: build_limited_scripts_slave
> Recipe-Nontrivial-Roll: skiabuildbot
> Recipe-Nontrivial-Roll: build
> Recipe-Nontrivial-Roll: release_scripts
> Reviewed-on: https://chromium-review.googlesource.com/1014356
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Aaron Gable <agable@chromium.org>

TBR=agable@chromium.org,ehmaldonado@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 643346
Change-Id: I0e694b0e398770b8bd2e5a3170e158a7e54c5a61
Reviewed-on: https://chromium-review.googlesource.com/1029310Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

2acf4957

25 Apr, 2018 2 commits

Roll recipe dependencies (trivial). · 2f2142ef

recipe-roller authored Apr 25, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/e315ab3c7742e21b293911eb61e0c0a2e877acab cq: switch to 100% LUCI. (tandrii@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I571d840178dfd2e9b737abaf59b01648c1062fac
Reviewed-on: https://chromium-review.googlesource.com/1027150
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>

2f2142ef

CQ: switch to 100% LUCI builders. · cab00ccf

Andrii Shyshkalov authored Apr 24, 2018

R=jchinlee@chromium.org

Bug: 830992
Change-Id: Ic18a6bc309661581be55dd39510d5223cefefc40
Reviewed-on: https://chromium-review.googlesource.com/1026631Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

cab00ccf

24 Apr, 2018 3 commits

bot_update: Patch on gclient by default. · 355b11a3

Edward Lesmes authored Apr 16, 2018

See [4] for the design doc for this change.

We're moving the patching logic from bot_update to gclient.
This way we can test patches of dependencies that modify their DEPS
files as well, for example when ANGLE uploads a patch that modifies
DEPS files to be tested by a Chromium trybot.

Chromium Linux CQ and Angle trybots are already running this way
(see [1] and [2]) and a PSA has already been sent [3]

[1] https://chromium.googlesource.com/chromium/src/+/master/infra/config/global/cr-buildbucket.cfg#214
[2] https://chromium.googlesource.com/angle/angle/+/infra/config/cr-buildbucket.cfg#105
[3] https://groups.google.com/a/google.com/forum/#!topic/chrome-infra/FVHN2kdUX4I
[4] https://docs.google.com/document/d/1GSTw4ysm5AYjNR6vMA7NJUxLK2VN9IpOEp_v0u-wyOE/edit?ts=5ad78165#

Bug: 643346
Change-Id: Ic9a9dcfae86aca730d35fbb26c26b21135e05bf3
Recipe-Nontrivial-Roll: skia
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: skiabuildbot
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: release_scripts
Reviewed-on: https://chromium-review.googlesource.com/1014356
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

355b11a3

Roll recipe dependencies (trivial). · 2c9a0460

recipe-roller authored Apr 24, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/480046798daeca78c14e4514b25da0c50cf2b680 cq: start using LUCI downstream recipe rollers as an experiment. (tandrii@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I565f90c1e6b79ab11710b5dd5a5fe2e75b1f0e5f
Reviewed-on: https://chromium-review.googlesource.com/1024815
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>

2c9a0460

cq: start using LUCI downstream testers as an experiment. · 4d0f2a33

Andrii Shyshkalov authored Apr 24, 2018

R=hinoka

Bug: 830992
Change-Id: Ibb0a269c10d2939505e4286e3278efb650d82636
Reviewed-on: https://chromium-review.googlesource.com/1024869Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

4d0f2a33

20 Apr, 2018 2 commits

Check format of OWNERS files in PRESUBMIT and PanProjectChecks. · cb62e48b

Edward Lesmes authored Apr 19, 2018

Bug: 789773
Change-Id: Iaa721c9971d1834dd796a9cd28a28a83b6482e05
Reviewed-on: https://chromium-review.googlesource.com/1019975Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

cb62e48b

[auth] Fix typo introduced in https://crrev.com/c/1018488/13/auth.py#514 · 94580ab0

Andrii Shyshkalov authored Apr 20, 2018

TBR=vadimsh@google.com

Change-Id: I96c4039d12ba3570d828b24009a2446fba44c14d
Reviewed-on: https://chromium-review.googlesource.com/1020539
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

94580ab0

19 Apr, 2018 6 commits

Add support for checking that OWNERS files are correctly formatted. · 067ef5d8

Edward Lesmes authored Apr 19, 2018

Bug: 789773
Change-Id: I4c6c676a821fad33a34ef6c46468af95cdf6c0ec
Reviewed-on: https://chromium-review.googlesource.com/1020073
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

067ef5d8

[auth] cleanup old code.google.com oauth scope usage. · 741afe8c

Andrii Shyshkalov authored Apr 19, 2018

R=vadimsh@chromium.org

Change-Id: Iab38f0cf29594e20883e62e1ed113bc36a884ea4
Reviewed-on: https://chromium-review.googlesource.com/1020298
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>

741afe8c

[auth] cache LUCI_CONTEXT local_auth parameters. · b3c4441c

Andrii Shyshkalov authored Apr 19, 2018

R=vadimsh@chromium.org

Bug: 834536
Change-Id: I84d27c2d962e94cfe7befebfb374b17949bba7e5
Reviewed-on: https://chromium-review.googlesource.com/1020296Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

b3c4441c

[gerrit_util] learn about and use LUCI_CONTEXT when available. · 733d4ec8

Andrii Shyshkalov authored Apr 19, 2018

Unfortunately, w/o rewrite of gerrit_util, one can't take advantage
of existing auth.Authenticator (which also doesn't know about ~/.netrc
or .gitcookies, but that's fixable). This rewrite, however, will likely
cause issues for nasty scripts outside of depot_tools which use
gerrit_util as a Python library. So, I followed outdated way of
gerrit_util :(

Also contains refactoring of auth library, which was kept backwards
compatible for the same reasons as above.

R=vadimsh@chromium.org

Test-with: led tool
Test-artifact: https://ci.chromium.org/swarming/task/3cf4687dfd26ca10?server=chromium-swarm.appspot.com
Bug: 834536
Change-Id: I6b84b8b5732aee5d345e2b2ba44f47aaecc0f6c5
Reviewed-on: https://chromium-review.googlesource.com/1018488Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

733d4ec8

owners: Add support for comments at the end of the line. · 5c62ed59

Edward Lesmes authored Apr 19, 2018

Bug: 789773
Change-Id: Ic6fff7e4eba5e86dc77cf2b8e213228ec394dccf
Reviewed-on: https://chromium-review.googlesource.com/1019612
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

5c62ed59

[git-cl] make more informative error message. · 98824231

Andrii Shyshkalov authored Apr 19, 2018

R=vadimsh@chromium.org

Change-Id: Ib0891581b7eb5cd49667e7ec07e73232cd4874cd
Reviewed-on: https://chromium-review.googlesource.com/1020067Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

98824231

18 Apr, 2018 3 commits

presubmit: don't attempt to verify nonexistent vpython specs. · 16162377

John Budorick authored Apr 18, 2018

Bug: 834180
Change-Id: I431431e4fdf99c16c5fc3dbc7ed999b0c8da24bc
Reviewed-on: https://chromium-review.googlesource.com/1016690Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

16162377

bot_update: Ensure create_manifest ignores repos with explicit None urls. · 9ccad568

John Budorick authored Apr 18, 2018

Bug: 830306
Change-Id: Id87a6f2053c7e3cd489647d1cbbc8a83f2e585db
Reviewed-on: https://chromium-review.googlesource.com/1003326Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>

9ccad568

Teach autoninja.py to support GOMA_DISABLED env var · 85c75025

Bruce Dawson authored Apr 18, 2018

When GOMA_DISABLED is set goma will use the local compiler. Autoninja
needs to understand this in order to avoid requesting too much
parallelism.

Change-Id: Ic124893dd583a401d0d9ad7fbd27ee9b6715fcfe
Reviewed-on: https://chromium-review.googlesource.com/1015402
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

85c75025

13 Apr, 2018 7 commits

Remove tandrii@ from watching git cl changes. · adc953f9

Andrii Shyshkalov authored Apr 13, 2018

TBR=ehmaldonado@chromium.org

Change-Id: I25569c255acd7cb39364354b55dcb55bba0a9dd3
Reviewed-on: https://chromium-review.googlesource.com/1013081Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>

adc953f9

git-cl: Add parallel option to git-cl land. · 67b3faa8

Edward Lesmes authored Apr 13, 2018

It is used by CMDland but it was not declared and is causing failures.

TBR=agable@chromium.org

Bug: 832566
Change-Id: Ia8ba5df458f9a39e415b7a9495dc338def0b16a5
Reviewed-on: https://chromium-review.googlesource.com/1013056
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>

67b3faa8

Poke depot_tools recipe roller for git-cl fixes. · b8f33bef

Michael Moss authored Apr 13, 2018

TBR=agable@google.com

Change-Id: I680ab9441acffc91fae7500eb369e85d989f7443
Reviewed-on: https://chromium-review.googlesource.com/1012929Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Michael Moss <mmoss@chromium.org>

b8f33bef

Fix call to RunHook in CMDLand · 75ee7258

Olivier Robin authored Apr 13, 2018

After https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/994241
RunHooks take a parallel parameter.
This call was not fixed in initial CL.

TBR=agable@chromium.org

Change-Id: Ic2a076afbd8ef61e3bb12473f43e1e7eab273825
Reviewed-on: https://chromium-review.googlesource.com/1011613
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

75ee7258

roll-dep: Use gclient_eval.GetRevision to get current revision. · 58330b0d

Edward Lesmes authored Apr 06, 2018

R=agable@chromium.org

Bug: 760633
Change-Id: Iebabb417b5b1bd5a987de2707e84a0329e1ebe66
Reviewed-on: https://chromium-review.googlesource.com/1000758Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

58330b0d

Add support for downloading Windows VS toolchain from a HTTP URL · 54a81e45

Kimmo Kinnunen authored Apr 12, 2018

Add support for downloading Windows VS toolchain from a HTTP URL.
This is useful for developers that do not have access to the
Chrome toolchain.

If the developer specifies DEPOT_TOOLS_WIN_TOOLCHAIN_HTTP_BASE_URL
environment variable, the toolchain will be downloaded from that
url.

Bug: 830569
Change-Id: I41d815a4460085c3b028f56f2e01adc68d8410fe
Reviewed-on: https://chromium-review.googlesource.com/1002892
Commit-Queue: Kimmo Kinnunen FI <kkinnunen@nvidia.com>
Reviewed-by: Scott Graham <scottmg@chromium.org>

54a81e45

Add a '--inject-current' option to 'git new-branch' · 53a115e6

Asanka Herath authored Apr 12, 2018

This option creates a new branch that sets itself as the upstream for
the current branch and adopts the current branch's upstream as its own.

What does it do?
----------------

Imagine we have the following set of branches (as `git map-branches -vv`
would show it):

  origin/master  00001111  [ ahead 1 ]
    foo          00002222  [ ahead 1 ]
      baz *      00003333  [ ahead 1 ]

'baz' is the current branch. If one were to issue the following command:

  $ git new-branch --inject-current bar

... then the branch layout will now look like this:

  origin/master  00001111  [ ahead 1 ]
    foo          00002222  [ ahead 1 ]
      bar *      00002222
        baz      00003333  [ ahead 1 ]

Why would you need this?
------------------------

When working on a single change or a sequence of changes organized into
dependent branches, this option lets you quickly create a new branch
with the correct upstreams so that you can peel off smaller cleanups and
potentially unrelated changes out of your main feature branch into
separate branches. These can then be uploaded as dependent CLs.

R=petermayo@chromium.org,iannucci@chromium.org

Change-Id: Id912f8e5c17e267fc52d74bdfac7bbcf87a50908
Reviewed-on: https://chromium-review.googlesource.com/987529
Commit-Queue: Asanka Herath <asanka@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

53a115e6

12 Apr, 2018 5 commits

Remove petermayo from OWNERS · 3297f1a0

Peter Mayo authored Apr 12, 2018

I think the statute of limitations has run out on me.
I'm no longer on the infra list so OWNERS doesn't make much sense.

Change-Id: I3b3815d5f93980574c319d74438e0a3732a25680
Reviewed-on: https://chromium-review.googlesource.com/1011461Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>

3297f1a0

Reland "presubmit support: Run all tests in parallel." · 8e282797

Edward Lesmes authored Apr 03, 2018

Currently all tests in a PRESUBMIT.py file are run in parallel, but not
all tests across PRESUBMIT.py files.

This introduces a flag that will allow presubmit to run all tests across
PRESUBMIT files in parallel.

Bug: 819774
Change-Id: Idd3046cb3c85e9c28932a9789ba7b207a01d9f99
Reviewed-on: https://chromium-review.googlesource.com/994241Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

8e282797

gclient: Don't parse DEPS files that we won't recurse into. · 5d6cde39

Edward Lesmes authored Apr 12, 2018

Bug: 830306
Change-Id: I419f16583dc2bf4bd2a66a41eb73fff4802686a8
Reviewed-on: https://chromium-review.googlesource.com/1011391
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

5d6cde39

Roll recipe dependencies (trivial). · 7662307e

recipe-roller authored Apr 12, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/45938bc375fc0610b9c331b9089d6d42d2fe2d90 Add CIPD recipe module (phosek@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If81375858619c689fec326b1c45b8b41623569db
Reviewed-on: https://chromium-review.googlesource.com/1011364Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

7662307e

presubmit_unittest.py: use LUCI for the optional GPU tests on Windows · b1c21a5a

Corentin Wallez authored Apr 11, 2018

BUG=chromium:815092

Change-Id: Iecbbdf41a00a637e07dfb137d7956f110138b5f6
Reviewed-on: https://chromium-review.googlesource.com/1008302Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

b1c21a5a

11 Apr, 2018 1 commit

Roll recipe dependencies (trivial). · 7e9e2c82

recipe-roller authored Apr 11, 2018

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c56929b29c60fcaba3ee5d89da10c5e35ef03884 [raw_io] Add UNC magic prefix on win32 to handle long paths. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8c4e8c997d534d4ba0298cadc90531c43b8ecabf
Reviewed-on: https://chromium-review.googlesource.com/1008543Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>

7e9e2c82

09 Apr, 2018 1 commit

roll-dep: Run gclient.py rather than gclient · 5888d6f6

Eric Boren authored Apr 09, 2018

gclient calls into update_depot_tools, where gclient.py does not.

Change-Id: Idabf0fd613ee241460fbeb6b897a79b084bbc4e2
Reviewed-on: https://chromium-review.googlesource.com/1000786Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Eric Boren <borenet@chromium.org>

5888d6f6

08 Apr, 2018 1 commit

Apply parent vars to recursedeps. · da55cdc0

Michael Moss authored Apr 07, 2018

This fixes an issue where cumulative conditions would fail to evaluate
if the recursed DEP (or custom_var overrides) didn't happen to redeclare
all the variables used by the parent conditions.

TBR=dpranke@google.com, ehmaldonado@google.com

Bug: 825063
Change-Id: Icb53f04928f914dfacc2c3035d01be103d9f8247
Reviewed-on: https://chromium-review.googlesource.com/1000836
Commit-Queue: Michael Moss <mmoss@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>

da55cdc0

06 Apr, 2018 3 commits

roll-dep: Add support for gclient root various levels above. · 3f277fc7

Edward Lesmes authored Apr 06, 2018

In some cases, gclient root is not the parent directory, it might be two
levels above.

This fixes it by asking gclient for the real root directory.

Bug: 760633
Change-Id: I82d754f1c53259a111a74628f784d1bc461c18ef
Reviewed-on: https://chromium-review.googlesource.com/999971Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

3f277fc7

gclient: Add a command to get revision/variable information. · 411041f9

Edward Lesmes authored Apr 06, 2018

Introduce a getdep command to get revision/version/variable value information
as a counterpart for gclient setdep.

It will be useful for autorollers.

Bug: 760633
Change-Id: Iabeae0e78c6fbdcb1a3a79cfb380ac2d83f256d5
Reviewed-on: https://chromium-review.googlesource.com/999171Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

411041f9

Move path to depot to the front of PATH in the tutorial. · 5e79d078

Simon Zünd authored Apr 06, 2018

Adding it to the end caused issues since a cpplint.py version comes
preinstalled on the system at /usr/bin/cpplint.py, that is actually a symlink to
a bash script.
When the presubmit script is run, it uses python to run this bash script, causing it to fail.

Change-Id: Ib12cbdf20265c14e7252f30c268b5b4a9ce32193
Reviewed-on: https://chromium-review.googlesource.com/999595
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>

5e79d078

05 Apr, 2018 5 commits

gclient_eval: Support unpinned dependencies in SetRevision. · 1118a219

Edward Lesmes authored Apr 05, 2018

If a dependency was unpinned, support adding a revision to it.

R=agable@chromium.org

Bug: 760633
Change-Id: Id2c9fe5174458acaea334726176b88558425ef5a
Reviewed-on: https://chromium-review.googlesource.com/998735Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

1118a219

gclient_eval: Add more support when adding new variables. · 8d626576

Edward Lesmes authored Apr 05, 2018

Now we respect comments before the first variable.

Bug: 760633
Change-Id: Ibe60d719429c033415bfb1c99942c9d04601d967
Reviewed-on: https://chromium-review.googlesource.com/998683
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

8d626576

gclient setdep: Command line interface nits. · 0ecf6d6a

Edward Lesmes authored Apr 05, 2018

'setdep' now shows as a command when typing 'gclient help'.
We now use parser errors to indicate invalid formatting of flags, and
raise an error when there are unused arguments.

R=agable@chromium.org

Bug: 760633
Change-Id: I37fa65ef0c2cff9de1234efcf22bcd888a5e9589
Reviewed-on: https://chromium-review.googlesource.com/998741
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

0ecf6d6a

presubmit_unittest: Remove redundant tests. · dbd6476c

Edward Lesmes authored Apr 05, 2018

Bug: 829134
Change-Id: I3a29b67d96e04162425148a401dfb384efd5cef3
Reviewed-on: https://chromium-review.googlesource.com/998629
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>

dbd6476c

Roll mac_toolchain to 496a91484 · 9d3a7a9e

Sergey Berezin authored Apr 05, 2018

Relevant change:
  496a91484 mac_toolchain: preserve u+w and mtime for Xcode

Bug: 797051
Change-Id: Iae5b34ff31e110ce827a1d94dcee86049c5d7bc4
TBR=iannucci@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/998624Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>

9d3a7a9e