- 30 Apr, 2011 1 commit
-
-
maruel@chromium.org authored
Otherwise it's hard to know what's generated from automated testing. R=chase@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6902153 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83673 0039d316-1c4b-4281-b951-d872f2087c98
-
- 29 Apr, 2011 2 commits
-
-
rsesek@chromium.org authored
BUG=80589 TEST=Merge a CL using drover and when prompted to upload, check that the original CL description still has its linebreaks. Review URL: http://codereview.chromium.org/6893095 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83561 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
BUG= TEST= Review URL: http://codereview.chromium.org/6904055 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83507 0039d316-1c4b-4281-b951-d872f2087c98
-
- 28 Apr, 2011 1 commit
-
-
floitsch@google.com authored
When specifying a revision (with -r) propagates the date of the revision to its children. Review URL: http://codereview.chromium.org/6873110 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83313 0039d316-1c4b-4281-b951-d872f2087c98
-
- 27 Apr, 2011 1 commit
-
-
nick@chromium.org authored
Review URL: http://codereview.chromium.org/6897005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83228 0039d316-1c4b-4281-b951-d872f2087c98
-
- 26 Apr, 2011 2 commits
-
-
maruel@chromium.org authored
Rename check_call to check_call_out. It's a quite specific need when stderr is needed or when the user doesn't want the default arguments of check_output. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6882127 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83023 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
When the tree is not versionned, svn can return <info></info>. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6899052 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@83020 0039d316-1c4b-4281-b951-d872f2087c98
-
- 23 Apr, 2011 2 commits
-
-
maruel@chromium.org authored
R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6897034 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82763 0039d316-1c4b-4281-b951-d872f2087c98
-
nick@chromium.org authored
seems to take an inordinate amount of time. The idea is to lint whole files, and only try to compute deltas if the file contains at least one error. For my environment, the three affected presubmit rules took 2000ms each for a 4-file changelist. With this change, all my rules run in about a second, and none take anything close to 500ms. Also, since there seem to be environment-dependent factors at work here, I'm proposing putting timer warnings that print a message if any check takes longer than 500ms. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82559 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=82568 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82607 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=82653 Review URL: http://codereview.chromium.org/6883050 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82762 0039d316-1c4b-4281-b951-d872f2087c98
-
- 22 Apr, 2011 3 commits
-
-
nick@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82653 0039d316-1c4b-4281-b951-d872f2087c98
-
nick@chromium.org authored
seems to take an inordinate amount of time. The idea is to lint whole files, and only try to compute deltas if the file contains at least one error. For my environment, the three affected presubmit rules took 2000ms each for a 4-file changelist. With this change, all my rules run in about a second, and none take anything close to 500ms. Also, since there seem to be environment-dependent factors at work here, I'm proposing putting timer warnings that print a message if any check takes longer than 500ms. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=82559 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=82568 Review URL: http://codereview.chromium.org/6883050 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82607 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
This enables doing late modifications like updating the copyright notice or fixing line endings. Also silence the checkout operations a bit more when VOID=subprocess2.VOID. Add corresponding unit tests. Review URL: http://codereview.chromium.org/6891003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82587 0039d316-1c4b-4281-b951-d872f2087c98
-
- 21 Apr, 2011 5 commits
-
-
nick@chromium.org authored
Review URL: http://codereview.chromium.org/6896004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82568 0039d316-1c4b-4281-b951-d872f2087c98
-
nick@chromium.org authored
seems to take an inordinate amount of time. The idea is to lint whole files, and only try to compute deltas if the file contains at least one error. For my environment, the three affected presubmit rules took 2000ms each for a 4-file changelist. With this change, all my rules run in about a second, and none take anything close to 500ms. Also, since there seem to be environment-dependent factors at work here, I'm proposing putting timer warnings that print a message if any check takes longer than 500ms. Review URL: http://codereview.chromium.org/6883050 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82559 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6889002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82495 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
BUG= TEST= Review URL: http://codereview.chromium.org/6877055 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82414 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6878069 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82410 0039d316-1c4b-4281-b951-d872f2087c98
-
- 20 Apr, 2011 2 commits
-
-
maruel@chromium.org authored
R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6877038 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82406 0039d316-1c4b-4281-b951-d872f2087c98
-
bauerb@chromium.org authored
BUG=79953 TEST=see bug Review URL: http://codereview.chromium.org/6883085 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82290 0039d316-1c4b-4281-b951-d872f2087c98
-
- 19 Apr, 2011 1 commit
-
-
mark@chromium.org authored
updated; show the real last-change revision and not the current HEAD revision. BUG=none TEST=none Review URL: http://codereview.chromium.org/6881049 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@82124 0039d316-1c4b-4281-b951-d872f2087c98
-
- 18 Apr, 2011 5 commits
-
-
maruel@chromium.org authored
Renamed the previous subprocess2.call() to subprocess2.communicate(). R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6877005 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81976 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
getSVNInfo() is expected to fail in some use case. Make this behavior explicit. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6881008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81970 0039d316-1c4b-4281-b951-d872f2087c98
-
bauerb@chromium.org authored
BUG=none TEST=watchlists work again. Review URL: http://codereview.chromium.org/6871015 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81950 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
This would case a failure when: - a .py file is moved - *.pyc is in svn:ignore, causing the .pyc to not be deleted. - the new .py modifies its API. - another .py imports the old .py and uses the new API. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6854022 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81942 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6840053 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81941 0039d316-1c4b-4281-b951-d872f2087c98
-
- 14 Apr, 2011 2 commits
-
-
maruel@chromium.org authored
Looks like we had forgot gcl. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6838028 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81654 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
TBR=dpranke@chromium.org BUG= TEST= git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81579 0039d316-1c4b-4281-b951-d872f2087c98
-
- 12 Apr, 2011 6 commits
-
-
maruel@chromium.org authored
It's mostly to be used with the commit queue. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6820076 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81326 0039d316-1c4b-4281-b951-d872f2087c98
-
scottbyer@chromium.org authored
svn info doesn't like it when handed a symlink - you get an 'is not a working copy' error message. Unfortunately, the Mac uses BSD readlink, and doesn't have -f, so the subshell CD/PWD idiom must be used. BUG=none TEST=Create a symlink to depot_tools, put it early in your path, and do update_depot_tools. You should not get any 'not a working copy' error messages. Review URL: http://codereview.chromium.org/6838001 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81323 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6821083 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81322 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
At the moment it just fetches the patch. It's still useful to debug rietveld issues. Improve resiliency to invalid patches. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6825085 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81305 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Since no output is user visible anyway, causing a hang with no clue about what to type in. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6823091 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81302 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
It could result in failed tests so I'll revert if it ever becomes problematic. It ran fine with my limited testing. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6813114 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81279 0039d316-1c4b-4281-b951-d872f2087c98
-
- 09 Apr, 2011 2 commits
-
-
maruel@chromium.org authored
Exposes InputApi.rietveld and deprecate host_url. This is useful since it places authentication at a single place. BUG= TEST= Review URL: http://codereview.chromium.org/6825008 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81019 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Add better code to handle diff header, especially add more patch verification code. Add a lot of tests. Add mangling of \ to /. R=dpranke@chromium.org BUG=78561 TEST= Review URL: http://codereview.chromium.org/6802021 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81017 0039d316-1c4b-4281-b951-d872f2087c98
-
- 07 Apr, 2011 5 commits
-
-
maruel@chromium.org authored
Add propagation of verbose flag from git cl to presubmit_support Rename NotImplementedException to standard NotImplementError. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6810012 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80798 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Reapply r80770 "Switch from xml.dom.minidom to xml.etree". TBR=dpranke@chromium.org BUG= TEST= git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80785 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6806009 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80775 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Throws exceptions on mac. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6811020 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80771 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
The reason of this change (beside deleting 30 lines) is to fix pylint on Mac. For an unknown reason, it was dying here trying to process the minidom import. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6799021 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@80770 0039d316-1c4b-4281-b951-d872f2087c98
-